When display orientation is not the same as device orientation, aiai won't work for select mode highlight. So we should only show the select button in task menu for in-place landscape when the display rotation is the same as the device rotation which is portrait.
Screenshot would be in the task menu for in-place landscape all the time.
Test: demo video: https://drive.google.com/file/d/1OQrjww2lFTTsthz4dB3BSa-jw943KLWp/view?usp=sharing
Change-Id: I58b6f6da234ea36eef0af5bb966c33ebda3625b8
When nav mode state changes, launcher gets
re-instantiated, which means the listener for
nav mode changes often gets destroyed before it
even gets fired. Rely on the initial setup to
set the correct nav mode.
The other bug with relying
on the initial value was that we were initially
getting the old nav mode when initFlags was called
from the ctor, but then the correct updated nav
mode when called from initListeners(). The first
call would enable rotation but then the second
call wasn't disabling it. Now we toggled based on
nav mode each time.
Another bug fix in RecentsView was not calling
update when launcher rotation is enabled. That was
added when previously we were using HOME_ROTATED
and PORTRAIT as different PagedViewHandlers to
differentiate when launcher rotation was enabled.
HOME_ROTATED is now removed, so we no longer need
to change the internal state of RecentsOrientedState.
Fixes: 159176222
Change-Id: I2a37880ce3cf835ca5b9b165ce3840537facee6c
If a view does not handle its long press and return true, View.java calls getParent().showContextMenuForChild(this). However, in Hybrid hotseat case, predicted icons are removed from the hotseat when user long presses an icon. This will result in getParent() returning null.
Bug: 159064799
Change-Id: I80d8f27cbc20b94b0381e767584a1f6854d17e2c
When it is select mode, disabling swiping on the parent container for a11y to avoid exiting select mode UI.
This will only disable swiping and talkback on other tasks and the cleanall button, but will keep the modal task container app info and content description, also keep the action buttons description working.
Test: local
Bug: 155947513
Change-Id: I6d513c7eb3e7deeaa233550749f8be0d95e56daf
It's a flake.
It was likely caused by enabling fallback tests, and we don't know
what's leaked and why.
Bug: 143488140
Change-Id: I0d0c88ac9b0de316861f16ba023a596c1f39cde4
Launcher defaults to sensor rotation when in split
screen instead of the fixed portrait orientation.
We were setting the multi window flag but never
updating RecentsOrientedState's internal state to
reflect it.
Fixes: 158537350
Change-Id: Ib0e1cf4c2e0674a5af41ac11c532a50db0a6f0fa
- AllAppsTransitionController should not animate alphas for atomic
components even when failing fast (we already had this check for
the normal flow where mProgress != targetProgress).
- Don't set state to NORMAL until both the workspace stagger anim
and overview peek anim are finished
Test: swipe up and hold from the nav bar on the home screen, then,
without lifting finger, fling upwards to return home; ensure qsb
springs in staggered formation with rest of workspace, and alpha
matches accordingly
Bug: 154637581
Change-Id: Iafeaeac50ee8bce05492628d443c3ca4ab3d26df
RecentsView
Bug: 151450844
Test: manual verification with following steps
1. launch a few apps
2. swipe up from bottom to bring up RecentsView
3. enable talkback
4. perform a scroll next a11y gesture (without lifting finger, swipe
right then left)
5. verify nothing happens (as opposed to pushing the page back a little)
Change-Id: I6dea2559592bdaa7227a2e12ce0565d6d7b7f4a1
We should only set it to true before the slop when continuing the
gesture, otherwise gestures to home could attach the adjacent
task view before the transition even starts.
Bug: 158855957
Change-Id: I86eba9bad9c85e05d5274d7396160762a28e5cf1
Resetting unloads visible task data and thus will leave recents
blank if overview state is enabled. Instead, unload and reload
visible task data to take new icon shape into account.
(The reason we're getting onIdpChanged() on nav bar mode change
is because the change in nav bar height causes the computed icon
size to change very slightly.)
Also fix InvariantDeviceProfile copy constructor by copying
iconBitmapSize.
Test:
- Change between 0 button and 3 button nav modes, verify recents
doesn't appear blank
- Change icon shape in Styles and Wallpapers and go to recents,
verify icon shape is reflected in task icons
Bug: 156354328
Change-Id: Ife29f51e85814ff483d055005fa2645135d5ec3d
1) When view system is already dispatching an event, proxy-dispatch is restricted
to gesture only and follow the gesture dispatching rule.
2) If a full-proxy-dispatch is going on, and view-dispatch comes in, view-dispatch
takes over and proxy-dispatch is cancelled.
3) During gesture-only proxy dispatch, if view-dispatch already started a gesture,
proxy dispatch is ignored. Otherwise view-dispatch is restricted to non-gesture
dispatching only (and proxy-dispatch is already restricted to gesture only).
Bug: 158130948
Change-Id: Ied351663e16beda5acf49a52bdefea881c18b9cf
In cases where onCreate does not get called before bindPredictedItems, mHotseatPredictionController will be null. This results in the hotseat remaining empty until AiAi sends predictions.
Bug: 158867468
Test: Manual
Change-Id: I4f3c3fc41f489e96a9f91dc9505202ae9ce9cce1
TreeHugger Robot
Sreyas
Becky Qiu
thiruram
vadimt
Vinit Nayak
Samuel Fufa
Tony Wickham
Miranda Kephart
Pinyao Ting
Sunny Goyal