Commit Graph

22914 Commits

Author SHA1 Message Date
Brian Isganitis ae80cbfed3 Refactor test dagger graph to stub PerDisplayRepository instances.
These are not being used yet in Taskbar, but they are hardcoding
DEFAULT_DISPLAY for the primary ID. In tests, we want the primary to be
considered the ID of the virtual display tests are running on.

This change also moves dagger classes to its own file for organization.

Flag: TEST_ONLY
Bug: 415326979
Test: Taskbar multivalent tests
Change-Id: Ibd0cdf46bc53dbd7a3dd5f34d7171d9a6cdebb38
2025-05-12 17:10:57 -04:00
Treehugger Robot d03c7e64e2 Merge "Start SurfaceFlinger early wakeup sooner for blur." into main 2025-05-09 17:37:52 -07:00
Treehugger Robot d506f0154b Merge "Adding support for generating a preview bitmap with an optional delay to allow widgets to be rendered" into main 2025-05-09 17:16:29 -07:00
Wen-chien Wang 495fb1e9b4 Merge "pin-shortcut: Check desktop state for the feature" into main 2025-05-09 17:06:48 -07:00
Treehugger Robot ae69c409bd Merge "Clean up taskLaunch and taskLaunchCancel runnables more consistently" into main 2025-05-09 16:44:52 -07:00
Liran Binyamin a0dcefc714 Mark a BubbleBarViewScreenshotTest test flaky
Bug: 416207075
Flag: EXEMPT test only
Test: treehugger
Change-Id: Ib3c5878e554be19aa0580450f46c63365c622771
2025-05-09 14:02:06 -07:00
Treehugger Robot c9eb3511d2 Merge "Separate blur/fallback styles for all apps and overview" into main 2025-05-09 13:34:51 -07:00
Alex Chau f472991f88 Merge "Revert "Add debug log for RecentsView touch down"" into main 2025-05-09 10:50:55 -07:00
Sunny Goyal 63fe0c779e Adding support for generating a preview bitmap with an optional delay to allow widgets to be rendered
> Adding a completionSignal when preview is generated so that callers can wait on it
> Also adding support for proving an optional screen-id for preview

Bug: 400403115
Test: atest GridPreviewTest
Flag: EXEMPT refactor and unused new API

Change-Id: I569e0ab318ad101e4f6dd808f2e1cfc39ba50bda
2025-05-09 10:42:39 -07:00
Alex Chau eefa935e5a Merge "Add temp logging to select task" into main 2025-05-09 09:46:48 -07:00
Uwais Ashraf 1ae9814920 Merge "Create separate worker threads for IO work and lighter BG work" into main 2025-05-09 09:45:40 -07:00
Treehugger Robot 71438c16d8 Merge "Use custom height for all apps for CD" into main 2025-05-09 09:27:34 -07:00
Treehugger Robot 2ad54144f0 Merge "Fix Select mode transalte in wrong direction in RTL" into main 2025-05-09 08:32:44 -07:00
Alex Chau 3db085d650 Revert "Add debug log for RecentsView touch down"
This reverts commit 45162f9cf0.

Reason for revert: bug is closed

Bug: 318590728
Change-Id: Id4c91298e90170ac49f948a8fe3aa197cd3dc88d
2025-05-09 08:14:00 -07:00
Treehugger Robot 0dddfe6aae Merge "Account for magnetic detach when dismissing tasks in TAPL tests." into main 2025-05-09 08:12:58 -07:00
Alex Chau 7ea16a5408 Add temp logging to select task
Bug: 407815700
Test: presubmit
Flag: EXEMPT logging
Change-Id: I8eec794763c4e1619c35ff1bf26d64c287a6bd27
2025-05-09 14:44:05 +01:00
Alex Chau 0595b9c38a Fix Select mode transalte in wrong direction in RTL
- It's simply missing a +/- flip when it's RTL

Fix: 406241212
Test: manual
Flag: EXEMPT bug fix
Change-Id: I0a82bf5dfbe7bd15cf1eacd27c330801bc585452
2025-05-09 14:08:55 +01:00
vinayjoglekar 3997f6ce4a Separate blur/fallback styles for all apps and overview
Fix: 415233763
Test: Manual. go to overview/all apps enable/disable battery saver mode.
Flag: com.android.launcher3.all_apps_blur
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I4fdb672feb34d4b4da74f430eb8ef9a86ec3adf2
2025-05-09 10:17:11 +01:00
Uwais Ashraf c1102750dd Create separate worker threads for IO work and lighter BG work
Documentation largely pulled from Kotlin coroutines docs.

Flag: com.android.launcher3.enable_coroutine_threading_improvements
Bug: 416206104
Test: Presubmits
Change-Id: I89b7222e31680619e311fa9e9986da5c12d80ed4
2025-05-09 06:49:48 +00:00
Yunfan Chen 71d8ca3896 Merge "Update Insets API call due to signature change" into main 2025-05-08 20:42:57 -07:00
Ajinkya Chalke 0c32760b3c Use custom height for all apps for CD
Bug: 416220478
Flag: com.android.window.flags.enable_taskbar_connected_displays
Test: m
Change-Id: I772c43cec98e5a2679324603bee128482c614e26
2025-05-09 01:14:15 +00:00
Wen-Chien Wang e6816545b6 pin-shortcut: Check desktop state for the feature
This feature aims to work only for desktop mode. Add a check to
the desktop state when checking the aconfig feature flag.

Bug: 375648361
Test: EXEMPT flag update
Flag: com.android.window.flags.enable_pinning_app_with_context_menu
Change-Id: I19eb17d756f17892637bd303464748b505c89190
2025-05-09 00:31:27 +00:00
Andy Wickham a1e2662bc8 Start SurfaceFlinger early wakeup sooner for blur.
Now early wakeup is controlled by BaseDepthController (with the
exception of Taskbar which uses TaskbarOverlayController). It does
all of the following:
 - Increase GPU clock
 - Increase CPU clock (notifyRendererOfExpensiveFrame)
 - Tell SurfaceFlinger to wake up early

By default these happen the first time we render a non-0 blur, but
in some cases we can proactively activate it even earlier:
 - Swipe up to All Apps begins
 - Home screen QSB is tapped

These early cases were already handled for CPU and GPU, but now SF
is also in the loop.

In addition, SF early wakeup is disabled when Launcher is no longer
in the foreground.

Bug: 410973453
Test: Log manually to see early wakeup start/end
Flag: com.android.launcher3.all_apps_blur

Change-Id: I39ac0baf8c706b20f0818d31dbc8165b798ea54a
2025-05-08 16:52:28 -07:00
Merissa Mitchell 7e206dfc24 Merge "[Pip2] Reload Recents when IPipAnimationListener#onExitPip" into main 2025-05-08 16:37:01 -07:00
Treehugger Robot fe0dcb9087 Merge "Handle AddDeskButton's visibility across reboot" into main 2025-05-08 13:35:11 -07:00
Treehugger Robot 4f030edec6 Merge "Store startAlignTaskbar in DisplayInfoSpec" into main 2025-05-08 12:47:28 -07:00
Jagrut Desai 5ae9e4ffd4 Merge "Fix Taskbar window size upon rotation" into main 2025-05-08 12:45:43 -07:00
Rob Mickle e18c02547a Merge "Suppress home transitions from non-primary taskbar." into main 2025-05-08 10:58:17 -07:00
Suhua Lei a6bd2abc12 Handle AddDeskButton's visibility across reboot
Currently, if we create 4 (upper limit) non-empty desks, reboot, and
enter Overview, the addDesktopButton shows up when it actully shouldn't.

This change fixes this edge case by checking if we can create a desk or
not when inflating addDesktopButton and update its visibility
accordingly.

Bug: 416052493
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Test: create desks and reboot
Change-Id: I7142c3aeb88cc1f06b99ddef753ea20c63b17297
2025-05-08 17:50:52 +00:00
Treehugger Robot a69fa34118 Merge "Don't use large tile in the overview after enabling overview in connected display" into main 2025-05-08 10:50:21 -07:00
Ajinkya Chalke f0ec71d325 Store startAlignTaskbar in DisplayInfoSpec
- CD grids should override startAlignTaskbar.
- The DP.toBuilder method should carry forward DisplayInfoSpec instead
  of always recalculating.

Fix: 416276424
Test: m
Flag: EXEMPT updating recently added logic
Change-Id: I7b1cb8eab5fedc09b29e96a765d1341655474e8a
2025-05-08 17:00:22 +00:00
Sergey Pinkevich ba7849663e Merge "Move exit DW latency tracking to new observer API" into main 2025-05-08 09:27:03 -07:00
Rob Mickle 827d125937 Suppress home transitions from non-primary taskbar.
Note: enableOverviewOnConnectedDisplays must be true to enable the
functionality (taskbar button --> home) in the first place

Bug: 378443899
Test: m
Flag: com.android.window.flags.enable_reject_home_transition

Change-Id: Icf5e5939c8e4f59a7d87c30df0d74a151bdbd1d5
2025-05-08 09:08:13 -07:00
Treehugger Robot 36e3a92b6f Merge "Set uiController only in RecentsWindowManager" into main 2025-05-08 09:08:07 -07:00
Tony Wickham c25acda96d Clean up taskLaunch and taskLaunchCancel runnables more consistently
- Set both to null instead of just one or the other
- Clean up in TaskbarUIController#onDestroy instead of only in
  FallbackTaskbarUIController

Test: presubmit + leak detection
Flag: EXEMPT bug fix
Fixes: 411767825
Change-Id: I1571f126e2df01009777359eac1973976a8bb661
2025-05-08 08:34:41 -07:00
Pat Manning 015f0005b9 Account for magnetic detach when dismissing tasks in TAPL tests.
When the dismiss length is short, like in fixed landscape, we must account for a minimum distance to ensure dismissal

Fix: 415773066
Test: TaplTestsQuickstep#testOverview
Flag: EXEMPT Bugfix.
Change-Id: I31a1a9e0bbd23145455df35937cf85ce8ac2c20f
2025-05-08 16:15:29 +01:00
Steven Ng 26bc9f873e Don't use large tile in the overview after enabling overview in connected display
Test: tested overview in a connected display with a full screen app. Verified the full screen app is shown in a small tile.
Flag: com.android.launcher3.enable_overview_on_connected_displays
Bug: 415030147
Change-Id: I3e9313a17e9a323ecada89ac6fac29ea126cc613
2025-05-08 15:08:47 +00:00
Sunny Goyal 29b86863f2 Merge "Making workspaceData immutable" into main 2025-05-08 08:06:06 -07:00
Sergey Pinkevich e3173b2162 Move exit DW latency tracking to new observer API
Bug: 406551739
Flag: EXEMPT adding latency logging
Test: manually, using Perfetto

Change-Id: Ibdced4fcca0b73c635cf4d98457a140e54d3c21e
2025-05-08 13:39:17 +00:00
Ajinkya Chalke 9086f88aeb Set uiController only in RecentsWindowManager
Fix: 414724376
Test: m
Flag: EXEMPT fixing a recently added logic
Change-Id: I5c489252dd5b8f917c2a278d217f68d8260e4fcc
2025-05-08 12:57:25 +00:00
Merissa Mitchell c4cc2a52f1 [Pip2] Reload Recents when IPipAnimationListener#onExitPip
is triggered instead of in RecentsView#onActivityUnpinned, so that
Recents is updated in sync with PiP transitions.

Bug: 416075099
Test: m
Test: Presubmits
Flag: com.android.wm.shell.enable_pip2

Change-Id: If593c2e7271e972e96b1ab21b4396af66b1e3ea4
2025-05-07 18:21:43 -07:00
Treehugger Robot 46cd197147 Merge "Don't start align connected display taskbar" into main 2025-05-07 18:05:00 -07:00
Sebastián Franco 78ddf0f37c Merge "Log which active controller is handling input in the BaseDragLayer" into main 2025-05-07 17:22:23 -07:00
Ajinkya Chalke 47dad33208 Merge "Use per-display shared state in TaskbarManager" into main 2025-05-07 17:18:43 -07:00
Andy Wickham 2b400db392 Fix back home animation blurring.
Particularly with predictive back in cases that the app doesn't
support peeking the home screen, there was a thrashing animation
due to a secondary blur animation being applied. So in some cases,
it would rapidly alternate between 0 blur and the correct animation
blur. This wasn't necessarily user-visible, but likely contributed
to some performance jank.

Also ensure the scaling workspace blur uses the correct starting
depth and duration.

Demo: https://drive.google.com/file/d/1AffSvzlXycg8Yl4ULpctKADO6IdvvO3m/view?usp=drive_link&resourcekey=0--zqQ341w7U3MhRBwSYrsyA

Bug: 407534544
Test: Manual (predictive back, back without predictive peek, home)
Flag: com.android.launcher3.predictive_back_to_home_blur
Flag: com.android.launcher3.all_apps_blur
Change-Id: I76ed59e99aaef5bd44e8f5b0290f01763a8d4b0f
2025-05-07 16:54:58 -07:00
Mykola Podolian c5aa1b101f Merge "Hide bubble bar stash handle on the keyboard open." into main 2025-05-07 16:42:07 -07:00
Treehugger Robot d90fc68749 Merge "Performance improvements for Launcher blurs." into main 2025-05-07 15:37:46 -07:00
Ajinkya Chalke 4f0ec0bf8b Don't start align connected display taskbar
Bug: 416276424
Test: m
Flag: com.android.window.flags.enable_taskbar_connected_displays
Change-Id: I25617ac2a011b4b42cb7d652ae8647d56bfc0bd9
2025-05-07 22:13:07 +00:00
Pat Manning 505814903b Merge "Refactor building chain of spring animations for task reflow." into main 2025-05-07 14:54:34 -07:00
Bill Yi 4023aef00b Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2025-05-07 14:49:23 -07:00