Commit Graph

9988 Commits

Author SHA1 Message Date
Jon Miranda a28e0f474a Fix NPE when closing folder.
There is a race condition where Folder is closing, it unbinds, and then
another call to AbstractFloatingView.closeAllOpenViews tries to close the
Folder again. But since the contents are unbound and removed from the folder,
it produces a NPE.

Bug: 153625271
Change-Id: Ia6c55f15cf7517e26af8f499bc0c1a4828737480
2020-04-17 15:03:33 -07:00
Tony Wickham c09e8fbe9d Merge "Remove mPendingCallback from ActivityTracker" into ub-launcher3-rvc-dev 2020-04-17 19:35:49 +00:00
TreeHugger Robot 2a14c83515 Merge "Prevent two overlapping long press actions." into ub-launcher3-rvc-dev 2020-04-16 22:25:34 +00:00
TreeHugger Robot 64abef8ca1 Merge "Choosing better points to output "start" events for TAPL" into ub-launcher3-rvc-dev 2020-04-16 21:58:47 +00:00
Jon Miranda a1567d50d0 Prevent two overlapping long press actions.
We add a check in CheckLongPressHelper to not trigger long press if the
view is already in the pressed state.

This fixes the bug where a stranded DragView is left in the DragLayer.

Repo's every 50 tries:
- Open folder
- Long click and slightly drag the same item over and over in slightly
  different directions.

Logs show that long click on folder item initiates the first long click,
and then later on CheckLongPressHelper triggers another long press before the
initial one is finished.

Bug: 151053858
Change-Id: Ifbb6919e4f0153aaef2904f704baa284e78f1e83
2020-04-16 14:00:50 -07:00
Jonathan Miranda a976a2212d Merge "Add AnimationFlag for SKIP_DEPTH_CONTROLLER." into ub-launcher3-rvc-dev 2020-04-16 20:10:05 +00:00
Hyunyoung Song 6dde528c82 Merge "Add AllAppsSearchPlugin Bug: 151089843" into ub-launcher3-rvc-dev 2020-04-16 19:45:26 +00:00
Hyunyoung Song 3f82135f06 Add AllAppsSearchPlugin
Bug: 151089843

Change-Id: I6d61fb9c7855bafee731f47147b3070a1b672071
2020-04-16 11:50:04 -07:00
Andy Wickham 4f66dc3bef Adds dummy HomeGestureTutorialFragment.
- Adds a new launch target in Dev options
 - Moves Back handling to the parent TutorialFragment
   (so all Tutorials can handle it as necessary)
 - Currently uses a dummy translating rectangle in
   place of a proper hand animation
 - No actual home gesture recognition is in place yet

Test: Manual
Bug: 148542211
Change-Id: Ic5a545eb9f5003914803272c8ffe367220d63336
2020-04-16 18:23:08 +00:00
jayaprakashs 86932724e7 Don't open the Folder and IME when Folder is created.
Bug: 153751859
Change-Id: I8169d0890a43b614b293ca29f504e19c532b90ee
(cherry picked from commit 09066ffeb2)
2020-04-16 02:43:36 +00:00
Tony Wickham 73ff6ddeac Remove mPendingCallback from ActivityTracker
Instead, all callers should use EXTRA_SCHEDULER_CALLBACK, set via
addToIntent(), to provide a callback for the next handleIntent().
The updated runCallbackWhenActivityExists() will do that for the
caller if the activity doesn't already exist (otherwise it will
run the callback synchronously as before).

Bug: 151389129
Change-Id: Idbec264354fd6de166ff3bae98249230078d5674
2020-04-15 18:48:39 -05:00
Jon Miranda dc186e68a1 Add AnimationFlag for SKIP_DEPTH_CONTROLLER.
We use this flag to prevent the depth from being immediately set to 0 when
preparing to animate home.

Bug: 152327671
Change-Id: I614c6ae08b9f9e56ecb94fb51748791a38504583
2020-04-15 15:19:49 -07:00
TreeHugger Robot 62d493d50b Merge "Removing tracing for a fixed bug" into ub-launcher3-rvc-dev 2020-04-15 21:57:31 +00:00
TreeHugger Robot 1fe0a4e080 Merge "Address race condition with drag from external window" into ub-launcher3-rvc-dev 2020-04-15 21:41:34 +00:00
Tony Wickham cfb803c42c Address race condition with drag from external window
When dragging from another window, e.g. when pinning an app shortcut,
there's a race condition as follows if launcher is killed:
- System drag starts
- Workspace loads and starts binding, canceling the drag

With this change, the drag will get onDragStart() again after this
case and allow completion of the drop.

Change-Id: I3f1c786ad1d451ecda9bbac5e9a9a3e0d8b66f73
2020-04-15 15:56:57 -05:00
vadimt f528fa6518 Removing tracing for a fixed bug
Bug: 138251824
Change-Id: Icd0d5001bfce0b1dabc102a2bbb0212a57d5839a
2020-04-15 13:51:47 -07:00
vadimt cf275c1bd7 Choosing better points to output "start" events for TAPL
Now doing this before branching points, thus avoiding flakes when the
execution can go to an unexpected branch and not produce an event.

Bug: 153824894
Change-Id: If117da0498eaf2d94c9610552724981be34c6569
2020-04-15 12:45:11 -07:00
TreeHugger Robot ce2d7134f6 Merge "Manually marking widgets recycler as non-scrollable of frozen" into ub-launcher3-rvc-dev 2020-04-15 18:12:13 +00:00
TreeHugger Robot c730304898 Merge "Revert "Use UiEvent for constants inside StatsLogManager"" into ub-launcher3-rvc-dev 2020-04-15 17:32:22 +00:00
vadimt 31fa653ef3 Manually marking widgets recycler as non-scrollable of frozen
There was hope that freezing automatically marks it as non-scrollable,
but this happened to be not true.

Sending accessibility event per pweaver@'s instructions.

Bug: 152354290
Change-Id: Idd04c69cef9e8e621775ef86112f35e3d9d9d2da
2020-04-15 10:21:14 -07:00
Hyunyoung Song 1505d2f2e6 Revert "Use UiEvent for constants inside StatsLogManager"
This reverts commit 6b99a7d397.

Reason for revert: Launcher3 AOSP cannot link to uieventloggerlib because it's private API

Change-Id: Id652b8a4cba54b97d1d8b8644c2939903cc0e88a
2020-04-15 16:52:19 +00:00
Sunny Goyal ae190ff807 Revert "Have consistent All Apps UI between grid size changes."
Revert submission 557031-1571265377317-631e3e5

Reason for revert: Breaks multiwindow and secondary display layout
Reverted Changes:
Idee087e31:Remove numAllAppsColumns, allAppsIconSize, allApps...
I6235862c9:Have consistent All Apps UI between grid size chan...

Change-Id: I64156123a8fbaba1a7d2b64cddd5376671123aa2
2020-04-14 17:19:47 -07:00
TreeHugger Robot 2fc1c88448 Merge "Revert "Show all apps app names in multi window landscape"" into ub-launcher3-rvc-dev 2020-04-15 00:12:21 +00:00
Hyunyoung Song a613217bd0 Merge "Use UiEvent for constants inside StatsLogManager" into ub-launcher3-rvc-dev 2020-04-15 00:09:13 +00:00
Sunny Goyal 604e7bd667 Revert "Show all apps app names in multi window landscape"
This reverts commit 1c3c3b1d6f.

Reason for revert: Broke multi-window rotation and secondary display

Change-Id: I907b21ca82cf2e25f8abe7a09eafd6dec817f81b
(cherry picked from commit 157e666058)
2020-04-14 23:24:02 +00:00
Jon Miranda f8df99fd0a Fix bug where view stays invisible due to view recycling before it gets reset.
Repo steps:
* Drag item out of folder into a space where it won't fit (ie. full workspace)
* Drop item before folder finishes closing

The issue is that the drop completes and we unbind the folder contents
before the postDelayed callback runs to set the view back to visible.

Bug: 153267452
Change-Id: I0bd4e41cc6dda8b908eed3c8789ced54da4ac38a
2020-04-14 14:39:08 -07:00
Hyunyoung Song 6b99a7d397 Use UiEvent for constants inside StatsLogManager
Bug: 137777105
Bug: 148533500
Change-Id: I8ebf1110e8d25ab28f7496add9734bd7386b272f
2020-04-14 13:59:31 -07:00
TreeHugger Robot eb916b560b Merge "Remove swipe support on WorkModeSwitch" into ub-launcher3-rvc-dev 2020-04-14 09:04:29 +00:00
TreeHugger Robot dafb4d10ae Merge "Resolve RTL Work tab highlight" into ub-launcher3-rvc-dev 2020-04-14 05:57:22 +00:00
Samuel Fufa b2b1a0b351 Remove swipe support on WorkModeSwitch
Bug: 153063698
Test: Manual
Change-Id: I0c59617772e1cedff364fd18413dcaec8031cd06
2020-04-13 21:54:58 -07:00
Samuel Fufa 73911d6545 Resolve RTL Work tab highlight
Bug: 153682566
Test: Manual
Change-Id: Ibe2160f10233bae3aa5e86942ac69a9a40fc13e3
2020-04-13 13:45:27 -07:00
Tony Wickham 047a54a21f Merge changes I01790ce5,I938e23af into ub-launcher3-rvc-dev
* changes:
  Remove all apps arrow after getting to all apps 5 times
  Refactor some onboarding-related shared prefs into a class
2020-04-13 18:59:57 +00:00
TreeHugger Robot 8f40d00a5d Merge "Resolve work switch drawable RTL issue" into ub-launcher3-rvc-dev 2020-04-13 18:03:12 +00:00
TreeHugger Robot 411a08665f Merge "Define a11y content description for work paused list" into ub-launcher3-rvc-dev 2020-04-13 01:28:34 +00:00
Samuel Fufa 6c00f16d67 Define a11y content description for work paused list
Bug: 151803591
Test: Manual
Change-Id: I2b592189d784010f09fcd54378f2b34bd2d6c6e3
2020-04-12 17:38:14 -07:00
Samuel Fufa 22557d7a8b Resolve work switch drawable RTL issue
Bug: 153680914
Test: Manual
Change-Id: I54f0240b8845c89f96bf61705fea0dff74c68668
2020-04-12 17:23:51 -07:00
Jon Miranda 57dab6fa29 Let spring take over the overscroll amount when swiping to first/last page.
Bug: 153747836
Change-Id: I8a883f648587b0cb4008df3b8176c9341162b8d1
2020-04-11 10:25:28 -07:00
Tony Wickham 6322000721 Remove all apps arrow after getting to all apps 5 times
- Instead of ScrimView implementing StateListener, added
  mAccessibilityLauncherStateListener.
- Added allAppsStateListener to determine whether we
  reached all apps 5 times.

Bug: 151768994
Change-Id: I01790ce577879eab2e4568fcda19d0245b256d13
2020-04-10 21:14:30 -07:00
Tony Wickham 133cd54474 Refactor some onboarding-related shared prefs into a class
Bug: 151768994
Change-Id: I938e23af8c1874714e02fe34d0f9f82bb21d00a2
2020-04-10 21:06:08 -07:00
TreeHugger Robot 0c0a9ae366 Merge "Fix bug where it is hard to swipe to work profile tab." into ub-launcher3-rvc-dev 2020-04-11 01:32:41 +00:00
Jon Miranda f52af437b2 Fix bug where it is hard to swipe to work profile tab.
Bug: 151739025
Change-Id: I1ba731b4c5ce3a8d88fb14cc4dea2e2410538e6f
2020-04-10 17:25:57 -07:00
TreeHugger Robot f84b31aaab Merge "Fix curve properties not applying when dismissing task" into ub-launcher3-rvc-dev 2020-04-11 00:13:15 +00:00
Tony Wickham a4734cb755 Merge "Dump notification dot counts" into ub-launcher3-rvc-dev 2020-04-10 21:55:27 +00:00
TreeHugger Robot 671173ef2e Merge "Add tooltip when long pressing system shortcut icon" into ub-launcher3-rvc-dev 2020-04-10 21:22:37 +00:00
TreeHugger Robot 9398772fb8 Merge "Removing tracing for fixed bug" into ub-launcher3-rvc-dev 2020-04-10 20:48:57 +00:00
Tony Wickham cf7552af3f Add tooltip when long pressing system shortcut icon
If we only show the icon view (rather than icon + label),
show the label on long press.

Bug: 148707493
Change-Id: I14ab45b43203375b573e5e5d937ad5ebfb016d83
2020-04-10 13:28:53 -07:00
Tony Wickham 646e4486be Dump notification dot counts
This could help us determine whether our data model or
UI is wrong if dots aren't appearing.

Bug: 152435463
Change-Id: I46065b130b6b1cbb3b2d1db471654b3959332ff5
2020-04-10 01:10:13 +00:00
Tony Wickham c101e1c5de Fix curve properties not applying when dismissing task
- ag/10936255 replaced getViewCenterPosition() with getChildStart(),
  meaning getTranslationX() was no longer included.
- This change goes back to using getViewCenterPosition() and renames
  it to getChildStartWithTranslation().
- Update typo with parameter in getCurveProperties being mInsets
  instead of insets.

Bug: 153574162
Change-Id: I9b46daecf3ee6dbefe0270e70fdc5e6d9d0b0c00
2020-04-10 00:44:28 +00:00
vadimt e206b031a6 Removing tracing for fixed bug
Bug: 152658211
Change-Id: Idc1643a879fca47a50bd58090bbb72a284fd8d59
2020-04-09 16:41:01 -07:00
Sunny Goyal e396abf502 Moving model data structures to a separate file
Change-Id: I77ad7a5219e72d2e0d6c1803de2ac3ed6a65a8f7
2020-04-09 13:20:39 -07:00