Commit Graph

14227 Commits

Author SHA1 Message Date
TreeHugger Robot 69c04c21c5 Merge "Explicit Nullbility in Launcher (Part 5)" into tm-qpr-dev 2022-09-19 17:12:40 +00:00
Luca Zuccarini 3fe8d2c9fa Merge "Fix issue with keyboard disappearing too late." into tm-qpr-dev 2022-09-19 15:36:59 +00:00
TreeHugger Robot 17c4741432 Merge "Updating the title of the Add to homescreen prompt to the requesting app instead of the Launcher name" into tm-qpr-dev 2022-09-17 01:47:48 +00:00
Holly Jiuyu Sun a6f9b4b76b Merge "Clear the staled mFocusedView when toast surface is closed." into tm-qpr-dev 2022-09-17 01:34:45 +00:00
Pinyao Ting 777c13eb00 Explicit Nullbility in Launcher (Part 5)
This CL addresses the nullbility in LauncherModel and update tasks.

Bug: 242895652
Test: manual
Change-Id: Ied635c944c3656f0d493b295f772aa0329b354b9
2022-09-16 17:17:16 -07:00
TreeHugger Robot 860657a5f2 Merge "Updating the scroll calculation from recyclerView to avoid view inflation" into tm-qpr-dev 2022-09-16 23:07:54 +00:00
Sunny Goyal bb5ebb7f2d Updating the title of the Add to homescreen prompt to the requesting app
instead of the Launcher name

Bug: 239055068
Test: Verified on device
Change-Id: I1494d911565ddf3a598f9fbf372b8d784a4276e4
2022-09-16 15:54:53 -07:00
Yein Jo dfaabbb499 Merge "Migrate Launcher to use the new OnBackInvokedCallback" into tm-qpr-dev 2022-09-16 21:44:49 +00:00
Holly Sun 98d6a4027a Clear the staled mFocusedView when toast surface is closed.
Test: manual
Bug: 224756660
Change-Id: Iadce94f9138ee375fa9b6e3ef8fb685847312045
2022-09-16 14:28:23 -07:00
Andy Wickham 455c942fd2 Merge "Pivot search results scale around top of view." into tm-qpr-dev 2022-09-16 21:17:26 +00:00
TreeHugger Robot af2fe7fd12 Merge "Turn off changing depth in wallpaper picker" into tm-qpr-dev 2022-09-16 16:50:04 +00:00
Alex Chau fa83199e62 Turn off changing depth in wallpaper picker
Fix: 246845529
Bug: 240580498
Test: manual
Change-Id: Ib8fd624c518fb4c26d2598137d056b196a0ddeb7
2022-09-16 16:39:47 +08:00
TreeHugger Robot 9fb4802a67 Merge "Moving ViewCapture to Quickstep level to use hidden apis." into tm-qpr-dev 2022-09-16 06:23:07 +00:00
Stefan Andonian 5df305fed6 Moving ViewCapture to Quickstep level to use hidden apis.
Bug: 242867462
Test: Compilation succeeded while using private flags.
Change-Id: I9b15967b594963c5573ea1a0000b60f7c705da95
2022-09-16 03:36:15 +00:00
Andy Wickham 889be463f7 Merge "Adds SearchRecyclerView as a notification dot listener." into tm-qpr-dev 2022-09-15 23:47:00 +00:00
Andy Wickham 2d5b049531 Pivot search results scale around top of view.
This way views scale in/out relative to the top of the view,
instead of the center. This is most noticeable on larger views,
like Search Edu card.

Before/after videos: https://drive.google.com/drive/folders/1aXMGD44AQBeu6cLyzpV1DcFeh1Q8Vvmk?resourcekey=0-ShsGtgCTcST5cjUPAGPfwg&usp=sharing

Bug: 234882587
Test: Manual with 10x animation duration.
Change-Id: Ifb02f9dcb14e69b9cf3f9dea55d03d155b720391
2022-09-15 16:41:25 -07:00
Andy Wickham 5429b8fd86 Adds SearchRecyclerView as a notification dot listener.
This way app dots get updated as notifications come in or get
dismissed.

Bug: 246962476
Test: Dismissed notification while Search active.
Change-Id: I41e1b44561fb5ccd43deff342afb722cc5107330
2022-09-15 11:21:04 -07:00
TreeHugger Robot e58e123bd7 Merge "Add metrics sources for split invocation" into tm-qpr-dev 2022-09-15 09:35:12 +00:00
Jeremy Sim 21a5b12b6f Update animations for TM-QPR: Overview > OverviewSplitSelect transition
This change updates the Overview > OverviewSplitSelect animation to the latest spec. This is a re-upload of a previous change, ag/19464657, but no longer will cause the b/241165022 issue.

Includes:
- New timings
- Task thumbnails slide in with an "overshoot" animation
- Icons fade out and fade in appropriately
- SplitInstructionsView has a new compound "unfold" animation

Bug: 236760307
Test: Manual on tablet. Made sure the b/241165022 issue is fixed.
Change-Id: Ia22f6b6d7b9474b782e693fae2320a34a2985b18
2022-09-14 18:06:05 -07:00
Pinyao Ting fc14807d7a Fix launcher crash related to widget updates
LauncherAppWidgetHost fails to cleanup deferred widget when launcher
started binding the widgets in workspace, which leads to a crash because
widgets that was previously attached to the workspace get re-attached to
the workspace.

Bug: 245016152
Test: manual
Change-Id: I4de261e08cfdcee74f210c39bcadf403b98887ab
2022-09-14 13:22:29 -07:00
Yein Jo dc1b3660fe Migrate Launcher to use the new OnBackInvokedCallback
Bug: b/238475344
Test: Tapl & manual
Change-Id: Ieab329873f82890d95136e490086cc2cffff7ba8
2022-09-14 19:45:41 +00:00
Vinit Nayak 7fb4f997c4 Add metrics sources for split invocation
* See design doc in bug description for
usage/details

Bug: 231369744
Change-Id: I0c0ec11e924e387c523b5ac5feb7cabf78eaa748
2022-09-14 11:58:03 -07:00
Becky Qiu 1c8e630381 Merge "[Toast] Switch to use a device config instead of feature flag for appSearch." into tm-qpr-dev 2022-09-14 06:53:49 +00:00
TreeHugger Robot 839297e232 Merge "Add error detection for aborting the recents scrolling during transition to home" into tm-qpr-dev 2022-09-13 19:49:44 +00:00
Becky Qiu cdac570298 [Toast] Switch to use a device config instead of feature flag for appSearch.
Bug: 241001264
Test: local
Change-Id: I47416b07a62379ab5c2c17b3b769c8bc8b2ef106
2022-09-13 12:26:42 -07:00
TreeHugger Robot 3ded296cee Merge "Change wallpaper depth in widget picker" into tm-qpr-dev 2022-09-13 18:46:53 +00:00
TreeHugger Robot 22af7c2e7e Merge "Removing UiThreadHelper and moving code to corresponding classes" into tm-qpr-dev 2022-09-13 17:57:44 +00:00
Alex Chau 3d2c062567 Change wallpaper depth in widget picker
- Also changed widget picker open/close duration, refactored the values into DeviceProfile
- Generalized MultiAdditivePropertyFactory to accept aggregator as parameter

Bug: 240580498
Test: manual
Change-Id: I6886ca514593e404b8d7b0e8ed44f20ec2b77c73
2022-09-13 12:20:56 +08:00
Becky Qiu a7be354913 Merge "[Toast] Add a debug log config for app search flow." into tm-qpr-dev 2022-09-13 00:33:26 +00:00
Sunny Goyal 42beb544e9 Removing UiThreadHelper and moving code to corresponding classes
This allows for better code organization based on the code logic

Bug: 246382466
Test: Presubmit
Change-Id: I6148143a60afdd917a11587e327f5e8a4d7def9e
2022-09-12 22:14:15 +00:00
Sunny Goyal 20bbe95ddb Updating the scroll calculation from recyclerView to avoid view inflation
> Updating the LayoutManager's scroll calculation instead of a separate
  implementation to better support recyclerView's calculations
> Caching the view sizes during layout to avoid view-inflation for
  unknown types
> Fixing scrollbar jump during scroll when widget list is expanded
> Fixing scrollbar never reaching end when onboarding card is displayed
  in work tab

Bug: 240343082
Test: Verified on device that new views are not inflated
Change-Id: Ied11ccf65b053691c5c126c4bf8de306ec24786d
2022-09-12 12:24:34 -07:00
TreeHugger Robot d581f40b30 Merge "Removing some unused code:" into tm-qpr-dev 2022-09-12 19:24:20 +00:00
Brandon Dayauon f17c581165 Merge "Work toggle button staying at the top when moving keyboard down" into tm-qpr-dev 2022-09-12 19:15:20 +00:00
Vinit Nayak f5e5c8e1ce Merge "Place TaskMenuView aligned with secondary split thumbnail" into tm-qpr-dev 2022-09-12 18:29:22 +00:00
Sunny Goyal 676d19c171 Merge "Removing back-button alpha animation code" into tm-qpr-dev 2022-09-12 16:04:34 +00:00
Luca Zuccarini ce03c9972b Fix issue with keyboard disappearing too late.
This seems to have been caused by a bad merge which removed the call
from outside the end listener. We reintroduce it for atomic animations
only, as for manual ones we want the keyboard to animate in sync with
All Apps (note that this is how it used to be, and doesn't depend on the
keyboard sync flag).

Fixes: 243632287
Fixes: 240116666
Test: manual
Change-Id: I9d226a4bd7cbde0692ae82b5a138b0d523fd5f25
2022-09-12 11:01:31 +00:00
TreeHugger Robot 69b9e736a8 Merge "Simplifying hideKeyboardAsync method" into tm-qpr-dev 2022-09-10 05:03:23 +00:00
Sunny Goyal 8958a7078a Simplifying hideKeyboardAsync method
Bug: 246000321
Test: Presubmit
Change-Id: I2851c49b61b662d4a5b7cd0a863f690fd74a8bd0
Merged-In: I2851c49b61b662d4a5b7cd0a863f690fd74a8bd0
2022-09-10 04:01:48 +00:00
TreeHugger Robot 1c22b7e57c Merge "Support for animating A-Z <-> Search." into tm-qpr-dev 2022-09-10 01:11:36 +00:00
Sunny Goyal 1eb1124d82 Removing back-button alpha animation code
Back button is only animation in 2-button UI which is not supported anymore

Bug: 246006580
Test: Presubmit
Change-Id: I7385b07272e44c1f9f0488c158e1b4ee67060120
2022-09-09 17:15:24 -07:00
Sunny Goyal eb018d8004 Removing some unused code:
> intrinsicIconScaleFactor is no longer read
> We no longer generatepreview outline for drag

Bug: 245997823
Test: Presubmit
Change-Id: I17ed25239d0affe89482da3406d529d323a426d9
2022-09-09 16:02:13 -07:00
Andy Wickham 94d5d3cb6c Support for animating A-Z <-> Search.
Demo videos (1/5 speed) and APK: https://drive.google.com/drive/folders/1qQNzcoibiFMzxYhvXc7UEHCaBhJg6SjN?resourcekey=0-OWD06iLXg3wf_eWce4rUPA&usp=sharing

Bug: 234882587
Bug: 243688989
Test: Manually tested a bunch of cases at 1/10 animation speed.
Such as work profile or not, suggested apps enabled/disabled,
typing during the animation, going back during the animation,
web results injected above apps, etc.

Change-Id: Id4f1a858d387bf3a7f9cf2d23564a276544abef1
2022-09-09 15:37:57 -07:00
Brandon Dayauon fa6011fcdf Work toggle button staying at the top when moving keyboard down
- Same fix from implementation when implementing extendedFAB. ag/19223926
- Essentiall remove isEnabled() check since it is not needed
bug: 235873194
test: Manual - before: https://drive.google.com/file/d/1JjDSudWS56fiDyMnP8Btvy0pWFyUIXND/view?usp=sharing
after: https://drive.google.com/file/d/1Ja-OVpXKK1yUrixpU_V6WsLV0Ryw152w/view?usp=sharing

Change-Id: Ibca405deccfcd61845dd4f5952ad196af1ab3fe2
2022-09-09 15:04:42 -07:00
Sebastián Franco b64894b095 Merge "Adding specific case for applications in getEntryMigrationId" into tm-qpr-dev 2022-09-09 21:50:52 +00:00
Becky Qiu 431aed846e [Toast] Add a debug log config for app search flow.
Bug: 241001264
Test: manual
Change-Id: Ifb102477278f41ebf51d736cf6f0114dadcb94ce
2022-09-09 13:19:21 -07:00
TreeHugger Robot d0aba60767 Merge "Introduce KeyboardStateManager to maintain keyboardstate as show or hide." into tm-qpr-dev 2022-09-09 20:10:37 +00:00
Vinit Nayak 2e4dcb16a7 Place TaskMenuView aligned with secondary split thumbnail
* Use consistent divider calculations in
different methods

Fixes: 245610772
Fixes: 218784487

Test: Open task menu view in split pair in landscape/
seascape/portrait, real and fake.

Change-Id: If1bbc7a0d4f1767584d0fc8cf549130f35b8e4a3
2022-09-09 11:25:08 -07:00
Winson Chung 607a976635 Merge "Fix missing call to super cancel method" into tm-qpr-dev 2022-09-09 16:16:09 +00:00
Aurélien Pomini 687c6e415c Merge "Hide keyboard when transitioning from all-apps state to overview state." into tm-qpr-dev 2022-09-09 14:25:16 +00:00
Winson Chung 82638f6ef1 Fix missing call to super cancel method
- Without the call, it's interpreted as a successful animation to the
  listener even though it was canceled

Bug: 245829938
Test: Swipe to previous task, immediately after settling touch the
      swipe area again
Change-Id: I531cbda0c2bc8168a312a14854a7a73fafd8f678
2022-09-09 05:58:27 +00:00