- Finish recents controller to app rather than to launcher, to ensure taskbar state uses in-app configuration
- Also fix an issue when a gesture completes before onLauncherStart, which happens in 3 button mode. The error I saw in the test was:
java.lang.AssertionError: http://go/tapl test failure: Failed to receive an event for the state change: expected [Overview], actual: [Background, Normal];
Context: want to switch from background to overview, clicking Recents button; now visible state is Background
(This also accurately describes what I saw on the device, where the LauncherState went to Normal but the task was still running in the live tile)
Test: testStressSwipeToOverview
Fixes: 203577620
Change-Id: I19616f7921c9821f1b45a90a3e4bec4fb3b8a9d3
Merged-In: I19616f7921c9821f1b45a90a3e4bec4fb3b8a9d3
(cherry picked from commit ce6bf7dd7f)
- Fix logic for canceling animation for continued quick switch, so that this case (starting a new gesture before onRecentsAnimationStart() of the previous gesture) instead goes to the STATE_FINISH_WITH_NO_END flow.
- Update the end target so that we go to that state instead of always overview state if swipe was past the halfway threshold when we call endLauncherTransitionController(). This is specifically so we don't use OverviewInputConsumer on the second gesture, given the first one was canceled and didn't actually go to overview.
- GestureState#isRecentsAnimationRunning() now checks for STATE_RECENTS_ANIMATION_STARTED rather than _INITIALIZED, to be consistent with its javadoc and TaskAnimationManager#isRecentsAnimationRunning(). This also ensures we can correctly calculate continued quick switch (see above).
- Call cleanUpRecentsAnimation() before creating a new one in TaskAnimationManager. This ensures that the previous listener doesn't immediately cleanup the new gesture when it gets onRecentsAnimationCanceled() due to the new recents animation starting.
Test: swipe to home twice from the app, locally ignoring the onRecentsAnimationStart() from the first one, and ensure the second one responds normally
Bug: 193851085
Change-Id: I76e27c96b54293805546c0d6c82e77f975c69d7a
Merged-In: I76e27c96b54293805546c0d6c82e77f975c69d7a
(cherry picked from commit 66ed0ff23e)
- Apply the same for all 3 setCurrentPage cases as they can all causes page jumping
Bug: 197493120
Test: manual
Change-Id: I5f7013ce3ce4d6fe84c67123618c3bebeeffc43a
Merged-In: I5f7013ce3ce4d6fe84c67123618c3bebeeffc43a
The transition from a widget to the splash screen icon feels
odd because of the difference in shapes. Disable for S and rework that
in T.
Test: Manually tested with clock and Calendar
Bug: 197504657
Change-Id: Ia375885af967d6ad282dcc7325ad905731c8734d
Until now the SurfaceControl transaction was being applied
asynchronously, which could lead to it being executed out of sync with
launcher drawing.
This became an issue at higher refresh rates, where frames are produced
at a much faster pace.
In order to fix this issue, we can use BLAST transactions, which are
annotated with a frame number.
Test: record video, go through it manually
Fixes: 194320152
Change-Id: I1636a1ded4f9dd84c54ba12239e3549b92ed7567
Merged-In: I1636a1ded4f9dd84c54ba12239e3549b92ed7567
The scrim visibility drives whether the launcher window is opaque or
not. We should track it and apply the flag instead of trying to catch it
through other Launcher life cycles.
Fixes: 195365607
Bug: 196403152
Test: tap on home button while launching app from overview
Change-Id: I2a00b86b602b5dd12c901433b92adcf0170be15e
(cherry picked from commit e4a9469156)
The All Apps scrim fades in early, covering part of the zoom animation.
We need to adjust the max zoom in order to make All Apps consistent with
Overview, -1, and Shade.
Test: pull up the all apps drawer
Fixes: 195992422
Change-Id: Ia7bbe17fe7f227dd0a16ba7d21b402cff57176f0
(cherry picked from commit f168bb7aaf)
- activity.hasBeenResumed is no longer an accurate indicator after live tile has been introduced, indeed it's always false
- Return recentsView regardless if there is a runningTask as well
Bug: 194286330
Test: In fallback Recents with 3 button, tap overview button from home screen, then tap overview button again. Try combination with back and home button
Change-Id: Ib2775a11f5466abc433763f24192e7bfdcf191a2
(cherry picked from commit 455718e842)
- Prediction row views were never updated when notification changes.
- FloatingIconView set the BubbleTextView to force hide dot, but never restored it.
BubbleTextView is instanceof IconLabelDotView, so its already handled in the end runnable
Bug: 183360736
Test: 1. swipe up to go home such that the closing app has a notification,
note that the notification dot is properly updated
2. have all apps open
make notification update for a predicted app
ensure dot is properly updated
Change-Id: I35dacf9b71a3d8b8a857be450690d65ea9199bf6
During the widget-activity transition, the widget foreground loses its
clipping radius, if the clipping is determined by a drawable. We remove
the drawable through the animation.
For widgets where there is content being clipped by the background's
corener radius, this results in the widget window appearing square
through the entire animation, then snapping in rounded corners on
animation-complete.
To solve this, we leave a transparent clone of the drawable in the
original drawable's place, for the balance of the animation, providing
the outline for clipping.
Manual testing against 20 Google widgets showed no regression in
behaviour in other cases.
Bug: 193665108
Test: manual
Change-Id: I3db31e4634c8dd6b22a513a976386d396445ebc2
Video: http://recall/-/aaaaaabFQoRHlzixHdtY/bpKcGg1eoOo5Jz5U6IwBYK
Bug: 191310680
Test: manual, auto-enter-pip from landscape with source rect hint being
turned on, see the video
Change-Id: Ic191fc73597132a5119522dda477a4319e35d1c8
Merged-In: Ic191fc73597132a5119522dda477a4319e35d1c8
TreeHugger Robot
Bill Yi
Tony Wickham
Alex Chau
Vadim Caen
Lucas Dupin
Tracy Zhou
Sunny Goyal
Jason Chang
Brian Isganitis
Jonathan Miranda
Winson Chung
Cyrus Boadway
Hongwei Wang
Schneider Victor-tulias