Commit Graph

17210 Commits

Author SHA1 Message Date
Wei Sheng Shih aa5b85628a Merge "Separate rotationHint as different object of WindowBounds" into main 2023-10-19 01:53:16 +00:00
wilsonshih ca129bc5ca Separate rotationHint as different object of WindowBounds
Some WindowBounds object with different rotation would be ignore in
DisplayController#supportedBounds due to there already exists an object
with the same bounds.

Bug: 304284870
Test: open app then rotate tablet device to 90 or 270, close app and
monitor the closing target flying back to the expected position.
Flag: N/A

Change-Id: I97f070cfaf7c6243ae3cd95cb728f7041a3736d1
2023-10-18 07:35:10 +00:00
Holly Jiuyu Sun 0fadf743cc Merge "[DMA] Add withFeature API in StatsLogManager." into main 2023-10-17 21:17:38 +00:00
Pat Manning 24cec69361 Revert "Revert "Combine icon app tests to allow overriding flag ..."
Revert submission 25032768-revert-25007147-tapl-flag-SBORVHYDTI

Reason for revert: Resubmitting for b/304470271

Reverted changes: /q/submissionid:25032768-revert-25007147-tapl-flag-SBORVHYDTI

Change-Id: Ib0bd13a5c2a366160b185a2c6409c607ed7525a1
2023-10-17 15:56:48 +00:00
Fengjiang Li c4f9dd2c04 Merge "Double pre-inflate counts if work profile is enabled" into main 2023-10-16 21:36:52 +00:00
Sebastián Franco 879efc7b2a Merge "Cleaning up some and removing unused calculations code in CellLayout" into main 2023-10-16 18:35:56 +00:00
Alex Chau 74e68c69e8 Merge "Use SandboxContext in AbstractDeviceProfileTest" into main 2023-10-16 09:41:59 +00:00
Sebastián Franco c3a2919fd1 Merge "Moving getPagesToBindSynchronously to ModelCallbacks" into main 2023-10-13 23:49:02 +00:00
Sebastian Franco 69fd742a60 Moving getPagesToBindSynchronously to ModelCallbacks
Changes are part of go/launcher_SoR .

Bug: 301108526
Test: This is a no-op change, compiling should be the test
Change-Id: I5e57b73edfa23e9f12ea94c0f9c5005e2d8fccd2
2023-10-13 11:34:23 -07:00
Sebastian Franco 0dd5db84e4 Cleaning up some and removing unused calculations code in CellLayout
Using cellToRect and removing some calculation that where unnecesary
because the variable are later overwritten.

Fix: 194414754
Bug: 294841331
Test: ImageTest
Change-Id: I31e0527cbbea463a32a36a172185a41985ed0d57
2023-10-13 18:24:41 +00:00
Ats Jenk a89365c2be Merge "Use desktop mode flag for split logic" into main 2023-10-13 18:00:53 +00:00
Fengjiang Li c83d96daea Merge "Trace unlock animation progress" into main 2023-10-13 15:35:11 +00:00
Jeremy Sim 20410d25f9 Merge "Migrate ENABLE_APP_PAIRS flag to aconfig" into main 2023-10-13 05:22:36 +00:00
Ats Jenk cd789874c3 Use desktop mode flag for split logic
Remove launcher specific split from desktop flag and use the desktop
windowing feature flag.

Bug: 305095670
Flag: persist.wm.debug.desktop_mode_2
Test: enable desktop mode flag, toggle split from a desktop task
Change-Id: I62b91de3deaa5bba3435faf3a268f5b58cda8276
2023-10-12 23:28:42 +00:00
Jeremy Sim 7dc3bdcd85 Migrate ENABLE_APP_PAIRS flag to aconfig
Fixes: 303323964
Flag: com.android.wm.shell.Flags.FLAG_ENABLE_APP_PAIRS
Test: Unit tests still run correctly
Change-Id: I617c699746492c9c0d131a28791d984afbbdda4d
2023-10-12 15:06:32 -07:00
Sunny Goyal c173c04422 Generalize userproperties to support for more user types in iconCache
Bug: 305062259
Flag: None
Test: Presubmit
Change-Id: I35cd20a03520ada233809930fcc56cdea1dabec6
2023-10-12 21:25:59 +00:00
Sunny Goyal 4588031286 Merge "Moving onboarding prefs to use LauncherPrefs" into main 2023-10-12 20:51:45 +00:00
Tyler Freeman 22781d97d9 Merge "Revert "Combine icon app tests to allow overriding flag for new ..."" into main 2023-10-12 20:06:56 +00:00
Fengjiang Li 25b1675d21 Trace unlock animation progress
The unlock animation is subject to interruption from sysui. Adding trace would help us find root cause easier in the future.

Bug: 301903832
Test: grab perfetto trace and verify the unlock progress is shown
Change-Id: Iab0ca483beb01752b1dd67bd28f401d3e2e9cef7
2023-10-12 11:22:57 -07:00
Tyler Freeman 1468467706 Revert "Combine icon app tests to allow overriding flag for new ..."
Revert submission 25007147-tapl-flag

Reason for revert: Breaks build: https://b.corp.google.com/issues/305033049

Reverted changes: /q/submissionid:25007147-tapl-flag

Change-Id: I99b5883e64ae25476394a4207c5d6a4d22fc27dc
2023-10-12 18:04:05 +00:00
Jagrut Desai a187ab0ec8 Merge "Adding test protocol support for getting num all apps columns" into main 2023-10-12 16:20:18 +00:00
Pat Manning 654c05837e Merge "Combine icon app tests to allow overriding flag for new icon app chip menu testing as well." into main 2023-10-12 15:59:17 +00:00
Pat Manning 236e738907 Combine icon app tests to allow overriding flag for new icon app chip menu testing as well.
Platinum exlude cl update: cl/572225659

Test: TaplOverviewAppIconMenuTest
Test: TaplAppIconAppChipMenuTest
Bug: 303329286
Bug: 303266562
Fix: 304470271
Change-Id: I4ca163401d6a42961e8955e06c164af0254b1231
2023-10-12 14:53:08 +01:00
Alex Chau 1ce67a6122 Use SandboxContext in AbstractDeviceProfileTest
- Added a initializeForTesting method to SandboxContext
- Also made SandboxContext non-abstract, so it can be used in tests to inject mock MainThreadInitializedObject into the SandboxContext, this should avoid mocked MainThreadInitializedObject bled into another test

Test: presubmit
Flag: None
Bug: 303328913
Change-Id: I37157d81b08b80f1e90eacca7dc2ce482cd08aa4
2023-10-12 11:43:37 +01:00
Stefan Andonian 3925bdfdf8 Merge "Remove some direct usage of getDevicePrefs()" into main 2023-10-11 23:09:26 +00:00
Stefan Andonian 2171d09fe6 Remove some direct usage of getDevicePrefs()
Bug: 261635315
Test: Manually did testing on device.
Change-Id: I47c88bdc031d330f6efa573411ab5dbf154ec8a2
2023-10-11 23:06:41 +00:00
Schneider Victor-tulias 276420a869 Merge "Fix janky Alt+Tab through overview animation" into main 2023-10-11 18:28:10 +00:00
Alex Chau 6ae2c4d77d Merge "Revert "Revert "Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig flag""" into main 2023-10-11 15:38:57 +00:00
Alex Chau 4989f4f36d Revert "Revert "Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig flag""
This reverts commit 7b5472f986.

Reason for revert: aconfig/SetFlagsRule actually works with TAPL tests (http://ag/c/platform/packages/apps/Launcher3/+/24991890/comment/8303a3c6_030ae00b/)
Bug: 270397206

Change-Id: I7529a64c3197e4c2b4d5fb1e46fb29bdea1e52e9
2023-10-11 14:08:22 +00:00
Hyunyoung Song e0a25fbd51 Merge "Add CUSTOM_LPNH_THRESHOLDS feature flag to customize LPNH" into main 2023-10-11 07:54:26 +00:00
Jagrut Desai 8e4077f8cd Adding test protocol support for getting num all apps columns
Test: Presubmit
Bug: 303257279
Flag: not needed
Change-Id: I9c6299fb3ff077bc42ca22609d2ff0232377a370
2023-10-10 16:07:51 -07:00
Jeremy Sim df55a762fe Merge "App Pairs: Implement app pairs icon" into main 2023-10-10 19:15:20 +00:00
Sunny Goyal cd44740567 Moving onboarding prefs to use LauncherPrefs
Bug: 301661768
Test: Presubmit
Flag: N/A
Change-Id: Iec8a5e739f394a152d5ffc57b01e0449e94b4084
2023-10-10 11:47:33 -07:00
Sunny Goyal b834d6eca8 Merge "Removing some usage of shared prefs" into main 2023-10-10 18:44:15 +00:00
Federico Baron e221945296 Merge "Add NullPointerException to try/catch since it's possible to have such an error" into main 2023-10-10 17:01:15 +00:00
Schneider Victor-tulias bdae57c157 Fix janky Alt+Tab through overview animation
Flag: not needed
Fixes: 282172884
Test: used alt+tab in overview; also launched overview through keyboard quick switch view
Change-Id: I3d1e54cda317ee8f8d2b2d698480cd3ca01dfc85
2023-10-10 11:20:15 -04:00
Alex Chau 09d8e2ca57 Merge "Revert "Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig flag"" into main 2023-10-10 12:26:21 +00:00
Alex Chau 7b5472f986 Revert "Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig flag"
This reverts commit 6f264a927b.

Reason for revert: Keeping old flag system so we can test in Tapl tests (b/283246928)
Bug: 270397206

Change-Id: I3e6364ebac8018facc3b22e510615735299a3dad
2023-10-10 10:38:04 +00:00
Vinit Nayak b95ee09a69 Merge "Dismiss split selection for workspace long-press" into main 2023-10-09 16:13:52 +00:00
fbaron 7e6107caaf Add NullPointerException to try/catch since it's possible to have such an error
getShortcutIconDrawable could return null "Method invocation 'getShortcutIconDrawable' may produce 'NullPointerException'" and it leads to the code crashing. Adding  NullPointerException as one of the exceptions in the try/catch would resolve this issue

Fix: 299525046
Test: verify after merging that the null pointer exception stops occurring
Flag: no flag
Change-Id: I52cfba9c7b08ea4e1b0f4506c461e79c3e91dc6c
2023-10-09 09:05:44 -07:00
Jeremy Sim 9d6dbd0a8d App Pairs: Implement app pairs icon
[App Pairs 5/?]

This patch implements the app pairs icon, which displays the two member apps and rotates with the device.

Flag: ENABLE_APP_PAIRS (set to false)
Bug: 274835596
Test: Manual
Change-Id: I07085339d1e2d28f004c1661f0948c59e605c76a
2023-10-06 18:57:09 -07:00
Vinit Nayak c6d6285cea Merge "Prevent workspace app icons/widgets from handling long click in split selection" into main 2023-10-07 00:21:08 +00:00
Vinit Nayak 4f850a42a0 Merge changes I9e56ddbe,I8767deea into main
* changes:
  Disallow taskbar long click when in split selection state
  Add method to determine if launcher is in split selection state
2023-10-07 00:20:24 +00:00
Vinit Nayak d0fc718a0a Dismiss split selection for workspace long-press
Bug: 295426148
Test: Enter split contextual from homescreen,
long-press on empty space, split gets dismissed
Flag: ENABLE_SPLIT_WORKSPACE_TO_WORKSPACE

Change-Id: I3a893bea7b22645fe60c65c4c5ab8c2087d769da
2023-10-06 16:05:54 -07:00
Vinit Nayak 3a3aa518f9 Prevent workspace app icons/widgets from handling long click in split selection
Bug: 295981634
Test: Enter split selection on workspace, long pressing on
app icon or widget does nothing
Flag: ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE

Change-Id: Ib439249477a7bb8bbbda9fd42e08ab02af7a831b
2023-10-06 15:13:06 -07:00
Andy Wickham 9fbc52f02d Add CUSTOM_LPNH_THRESHOLDS feature flag to customize LPNH
When this flag is enabled, new Developer Options appear which
allow you to customize the slop and timeout to invoke LPNH.

The slop is defined as a multiplier to the default edge slop
(which I discovered while looking into this - it appears to
be intended for touches along the device edge and is 50%
larger than the default touch slop; currently used by Back).

Timeout is defined in milliseconds, defaulting to 400, at least
on my device.

Bug: 301680992
Bug: 300955321
Flag: CUSTOM_LPNH_THRESHOLDS - should be no-op with default off
Test: Manual with flag on and adjusting sliders, and flag off
Change-Id: Iabc7b3706f4fdd6f0392c858b81a856e375ffd51
2023-10-06 15:06:13 -07:00
Vinit Nayak 1525cd7269 Add method to determine if launcher is in split selection state
* Available for both launcher and taskbar via
ActivityContext

Bug: 295981634
Change-Id: I8767deea0b2432da3047209037874c966b83c3b3
2023-10-06 14:40:49 -07:00
Sunny Goyal 576f7a5e80 Removing some usage of shared prefs
Bug: 301661768
Test: Presubmit
Flag: N/A
Change-Id: I158e9a5148d2c9404ea4d2e9e239696b29dbeb20
2023-10-06 14:35:56 -07:00
Federico Baron 0bd2c4ea75 Merge "Add smartspace removal option as a toggle" into main 2023-10-06 20:35:14 +00:00
Federico Baron 97789c9c5e Merge "Add flag for smartspace removal toggle" into main 2023-10-06 20:35:14 +00:00