Commit Graph

8728 Commits

Author SHA1 Message Date
Jon Miranda a97dc04478 Merge "Add taskbarIconSize to GridOption/DisplayOptions" into tm-qpr-dev am: 085c53869f am: 3cd39729dc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22228076

Change-Id: I3cb2d462cef1df514c87418ed70ac624899c21fd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 23:02:51 +00:00
Hyunyoung Song c5d4b109ee Merge "Revert "Revert "Hide the splash icon when launching with no view..."" into tm-qpr-dev am: e8abfee5e9 am: bb1237eb76
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22067827

Change-Id: I491a12f6d11c40c165b83f4bd61cf5d9f79d55c5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 23:00:41 +00:00
Jon Miranda 3cd39729dc Merge "Add taskbarIconSize to GridOption/DisplayOptions" into tm-qpr-dev am: 085c53869f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22228076

Change-Id: I687ea2a249e73036f8d4c4d187d999fd224b9f02
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 22:02:13 +00:00
Hyunyoung Song bb1237eb76 Merge "Revert "Revert "Hide the splash icon when launching with no view..."" into tm-qpr-dev am: e8abfee5e9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22067827

Change-Id: I1d5e7b401cfb874a0f801cfc0b5b76b53a608c64
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 22:00:27 +00:00
Jon Miranda 085c53869f Merge "Add taskbarIconSize to GridOption/DisplayOptions" into tm-qpr-dev 2023-03-24 21:51:42 +00:00
Hyunyoung Song e8abfee5e9 Merge "Revert "Revert "Hide the splash icon when launching with no view..."" into tm-qpr-dev 2023-03-24 21:41:04 +00:00
Jon Miranda 5dac395b9b Merge "Update transient taskbar shadow alpha for light/dark theme." into tm-qpr-dev am: d22b3af81c am: d914d88884
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22235599

Change-Id: Ie3657fd66dc88aec4bb2063b76202147ad3b2c3e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 19:56:41 +00:00
Jon Miranda d914d88884 Merge "Update transient taskbar shadow alpha for light/dark theme." into tm-qpr-dev am: d22b3af81c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22235599

Change-Id: Ie6b6229342e4c6d473d98ee4594d648095f5babc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 19:40:17 +00:00
Jon Miranda 9c478b6c29 Add taskbarIconSize to GridOption/DisplayOptions
- Renamed variables to make it more clear what they represent
- DeviceProfile will be source of truth for taskbar
  sizes

Bug: 265144213
Test: phone, multi-display, tablet
Change-Id: Id9c19d15a65894fd7645e0f876a4b6527b713c34
Flag: ENABLE_TRANSIENT_TASKBAR=true
2023-03-24 12:29:11 -07:00
Jon Miranda a8f03bbe13 Update transient taskbar shadow alpha for light/dark theme.
Bug: 259712417
Test: manual
Change-Id: If3b24efa7b619501e8ed07621d8673e68d2c903d
Flag: ENABLE_TRANSIENT_TASKBAR true
2023-03-24 17:22:39 +00:00
Riddle Hsu b828ba1386 Merge "Remove workaround of delaying remove task" into udc-dev 2023-03-24 15:43:19 +00:00
Mike Schneider bf513a44b1 Merge "Auto-stash taskbar when locking device" into tm-qpr-dev am: 1a09d4a2a2 am: d49c81775b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22196304

Change-Id: Iba29cb6b33b397ec817b1d88da799bf5d260c155
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 11:16:22 +00:00
Mike Schneider d49c81775b Merge "Auto-stash taskbar when locking device" into tm-qpr-dev am: 1a09d4a2a2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22196304

Change-Id: I3b35873bda6a7e65e4b0b290a25e278fd9c5efe9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 11:00:20 +00:00
Johannes Gallmann 1103621fbc Merge "Fix taskbar linger above notification shade" into tm-qpr-dev am: 96892011ff am: cea344515e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22162582

Change-Id: Idb6d573353381d7d7bb980beed5b8a660389da05
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 10:34:16 +00:00
Mike Schneider 1a09d4a2a2 Merge "Auto-stash taskbar when locking device" into tm-qpr-dev 2023-03-24 10:32:43 +00:00
Johannes Gallmann cea344515e Merge "Fix taskbar linger above notification shade" into tm-qpr-dev am: 96892011ff
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22162582

Change-Id: Iec6bfc729ea0c5b9c40cc3f491dd850427039349
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 10:05:08 +00:00
Johannes Gallmann 96892011ff Merge "Fix taskbar linger above notification shade" into tm-qpr-dev 2023-03-24 09:46:42 +00:00
Jagrut Desai 8e8017acf8 Merge "Make clear announcment for taskbar education." into tm-qpr-dev am: 601e0ff89c am: 9e4619e243
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22146024

Change-Id: I2c616ad0736f9345fc0d454bfbf7bbaa2b6cccbd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 00:56:17 +00:00
Jagrut Desai 9e4619e243 Merge "Make clear announcment for taskbar education." into tm-qpr-dev am: 601e0ff89c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22146024

Change-Id: I17dcffb5e72b672fedd2d54bbee6f09f99a395dc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 00:24:37 +00:00
Jagrut Desai 601e0ff89c Merge "Make clear announcment for taskbar education." into tm-qpr-dev 2023-03-23 23:52:24 +00:00
Charlie Anderson b3325e102a Merge "reorder System shortcuts for taskbar and secondary display" into tm-qpr-dev am: bc65c3d442 am: a106266c06
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22225432

Change-Id: I4e634002727b2d3877ddaa7aac8ad0fec7af3bc3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-23 21:51:49 +00:00
Charlie Anderson a106266c06 Merge "reorder System shortcuts for taskbar and secondary display" into tm-qpr-dev am: bc65c3d442
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22225432

Change-Id: Ic742a73372f90ac630af30af51d5313ede0283f4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-23 21:17:39 +00:00
Charlie Anderson bc65c3d442 Merge "reorder System shortcuts for taskbar and secondary display" into tm-qpr-dev 2023-03-23 20:39:06 +00:00
Tony Wickham 7eeb4f485a Merge "Handle swipe down on taskbar to stash" into tm-qpr-dev am: 2b8b47952f am: 0324f024b0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22147222

Change-Id: I255cf982e558e780fde95f51113a08abbaa672ea
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-23 20:20:58 +00:00
Tony Wickham 0324f024b0 Merge "Handle swipe down on taskbar to stash" into tm-qpr-dev am: 2b8b47952f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22147222

Change-Id: I6d774a769e11294efd0b0bd39429807528176b18
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-23 19:47:22 +00:00
Mike Schneider ba19f31669 Auto-stash taskbar when locking device
This greatly reduces the the jank of the taskbar being shown above the
lockscreen.

Before: http://shortn/_PhXhkWR73t
After: http://shortn/_MC3ZLGHp4o

Bug: 264604213
Test: manual (http://shortn/_ISEXThUFM2), tapl
Change-Id: Ib1c5dbaafd4d0e1d69fbc03d908632e0275c8a0b
2023-03-23 19:30:12 +00:00
Tracy Zhou 8e9db80dac Merge "Update home screen trackpad gesture behaviors" into udc-dev 2023-03-23 19:03:40 +00:00
Tony Wickham 2b8b47952f Merge "Handle swipe down on taskbar to stash" into tm-qpr-dev 2023-03-23 18:54:09 +00:00
Jagrut Desai ef1a9b798d Make clear announcment for taskbar education.
Test: Manual
Bug: 273393698
Bug: 273408584
Flag: not needed
Change-Id: I6c6eb1e1e1047a2e702592290bf5735e8bfa6ce2
2023-03-23 11:26:09 -07:00
Jon Miranda 45a3ad23ea Merge "Fix spring not springing when unstashing." into tm-qpr-dev am: cbe578b269 am: 0f43611645
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22202345

Change-Id: Ie8eacb26ccf2234b52ac36cbf81e048e65fa5a49
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-23 18:22:23 +00:00
Jon Miranda 0f43611645 Merge "Fix spring not springing when unstashing." into tm-qpr-dev am: cbe578b269
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22202345

Change-Id: I25e8204b0e93dd986a88329d53fef8e0507b7832
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-23 18:18:42 +00:00
Jon Miranda cbe578b269 Merge "Fix spring not springing when unstashing." into tm-qpr-dev 2023-03-23 17:37:35 +00:00
Charlie Anderson 04c6def895 reorder System shortcuts for taskbar and secondary display
Bug: 269343928
Bug: 272418357
Test: locally on device
Change-Id: Iec7f9ad702214c7ab7f49758dbf2463fe63b0324
2023-03-23 15:27:12 +00:00
Tony Wickham c73db73a79 Handle swipe down on taskbar to stash
- Moved all touch-to-stash logic to new TaskbarStashViaTouchController
  (handles both tap outside to stash instantly as well as swipe down
  inside to stash after letting go)
- This is a TouchController on TaskbarDragLayer, so it intercepts
  touches from TaskbarView before icons can be dragged during swipe down

Test: swipe up to invoke transient taskbar in an app, swipe down or
touch outside to stash
Flag: ENABLE_TRANSIENT_TASKBAR=true
Fixes: 246631710

Change-Id: I5cf64848bba34ad32fcc80a93fb4f79ebd2c10a7
2023-03-23 15:13:52 +00:00
Mike Schneider 6b138d009a Ensure FLAG_IN_APP is correctly set after launcher-restart. am: 43700f61f7 am: 94a6313bbf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22195243

Change-Id: I55dcc38c9633199093f5cafca669f8c059a47d3c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-23 12:13:50 +00:00
Mike Schneider 94a6313bbf Ensure FLAG_IN_APP is correctly set after launcher-restart. am: 43700f61f7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22195243

Change-Id: I71e90d16b58de5f99db0838219e9624b06d77645
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-23 11:33:21 +00:00
Johannes Gallmann c2e5bfca50 Fix taskbar linger above notification shade
Remarks:
1. I think the correct fix for this would be to have the Taskbar z-ordered below the notification shade. That however seems to be difficult because there are cases when the taskbar window must be above the notification shade.
2. This CL improves the behaviour by starting the taskbar disappear animation when the notification panel is half expanded instead of waiting for the full expansion. This improves the UX when expanding the shade slowly. When expanding the shade quickly, this CL does unfortunately not significantly improve the UX.
3. I believe that the `SYSUI_STATE_NOTIFICATION_PANEL_EXPANDED` and `SYSUI_STATE_QUICK_SETTINGS_EXPANDED` flags can be replaced by the newly introduced one. But since this would pose the risk of introducing new bugs, I did not do that in this CL. It is my intention to create a CL with that replacement in udc.

Bug: 272621219
Test: Manual, i.e. observe Taskbar behaviour when pulling down notification shade and expanding quick settings
Change-Id: Ic79d3f41ed224cb1abdbac9011c6d27e0f458ec2
2023-03-23 10:31:25 +01:00
Mike Schneider 43700f61f7 Ensure FLAG_IN_APP is correctly set after launcher-restart.
This is a follow-up to ag/21699905, which caused the nav-bar to be visible after a device-restart alongside the hotseat, until an app was launched.

Currently, when restarting launcher (for example a device restart), there is no guarantee when the SysUI flags are received for the first time. The current init-codepath  expects the launcher to be fully initialized at the time. From there, only deltas are processed:
- during the initial resume, launcher is not considered active because the screen is still off
- the SCREEN_ON event itself is not processed to update the FLAG_IN_APP

Before: http://shortn/_MGQjGFRIaB
After: http://shortn/_awiv2CxFn9

Bug: 261418621
Test: manual (http://shortn/_ty9EDuLM97), tapl
Change-Id: Ie3b3ba1ebe249efe8fc43850052bc9956cafcd24
2023-03-23 08:54:01 +01:00
Jerry Chang 1dcf99f961 Merge "Consolidate split divider show/hide behavior" into tm-qpr-dev am: 064d88d8b8 am: 8ab17926ac
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22099682

Change-Id: I66e1a08ccfbfac1eb314d0a30fc1d9b8d3ffa73c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-23 07:45:53 +00:00
Jerry Chang 8ab17926ac Merge "Consolidate split divider show/hide behavior" into tm-qpr-dev am: 064d88d8b8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22099682

Change-Id: I4c5ee30a5256ff07afb805b7f2f98793976b6e43
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-23 07:07:51 +00:00
Jerry Chang 064d88d8b8 Merge "Consolidate split divider show/hide behavior" into tm-qpr-dev 2023-03-23 06:25:43 +00:00
Tracy Zhou 897e665852 Update home screen trackpad gesture behaviors
- 3-finger swipe up to go to overview
- 2-finger swipe down to pull down notifications
- 2-finger swipe up to open all apps

Fixes: 273972106
Test: manual
Change-Id: I61bd0ad98b21abeb5f9b00786fe358c03a49f539
2023-03-22 23:00:07 +00:00
Tony Wickham 89501aede7 Merge "Set PredictedAppIcon ring disabled when icon is disabled" into tm-qpr-dev am: f93aa98e3a am: b04aeba66b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22125079

Change-Id: Id47004d671ec6f4493217a9e50007b25296e1474
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-22 19:58:53 +00:00
Tony Wickham b04aeba66b Merge "Set PredictedAppIcon ring disabled when icon is disabled" into tm-qpr-dev am: f93aa98e3a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22125079

Change-Id: I245d2ad27841078ceb09476f4c20608d06047753
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-22 19:20:31 +00:00
Jon Miranda 5945226515 Fix spring not springing when unstashing.
The spring animation was getting cancelled by the reset
animation.

Added a check to avoid creating a new reset animation if we
are already animating to the final value.

Bug: 273961611
Change-Id: I3afb62b89b5f6fbe920906499db2497ef8e94069
Flag: ENABLE_TRANSIENT_TASKBAR
Test: stash transient taskbar
2023-03-22 11:53:58 -07:00
Tony Wickham f93aa98e3a Merge "Set PredictedAppIcon ring disabled when icon is disabled" into tm-qpr-dev 2023-03-22 18:46:56 +00:00
Jon Miranda 4e8730f8e9 Merge "Update start radius for reveal animation to match spec." into tm-qpr-dev am: 0a6356a5ea am: dc3e4c972d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22188102

Change-Id: I1ee7430d3eff46b1c8d1331e6457e680f41593d4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-22 18:40:59 +00:00
Jon Miranda dc3e4c972d Merge "Update start radius for reveal animation to match spec." into tm-qpr-dev am: 0a6356a5ea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22188102

Change-Id: I052941fca6d5def9bd9a7a37a0b0d0a8c287af69
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-22 17:44:18 +00:00
Tony Wickham 1e29b04f19 Set PredictedAppIcon ring disabled when icon is disabled
Test: drag a predicted app from taskbar, ensure both ring and icon are
set to grayscale
Fixes: 268759548

Change-Id: I764ebcd486c09eceaf30c5bd5153a1dd2ff5be72
2023-03-22 16:53:10 +00:00
Jon Miranda 0a6356a5ea Merge "Update start radius for reveal animation to match spec." into tm-qpr-dev 2023-03-22 16:51:27 +00:00