Commit Graph

13147 Commits

Author SHA1 Message Date
Tony Wickham a930bca528 Merge "Stash taskbar when IME is present, including during gestures" into sc-v2-dev am: b4aefc1277 am: cc6b8488bf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16325264

Change-Id: I7c71ae9aa8c949907286c31a2e6c75871e599ec7
2021-11-24 18:27:32 +00:00
Tony Wickham b4aefc1277 Merge "Stash taskbar when IME is present, including during gestures" into sc-v2-dev 2021-11-24 17:54:18 +00:00
Tony Wickham 821e37b447 Stash taskbar when IME is present, including during gestures
- SysUI removes SYSUI_STATE_IME_SHOWING when starting a gesture from an app, but because unstashing has implications on the gesture transition (e.g. clips the bottom of the app), we defer handling the ime hiding until the gesture settles. Repurposed the flow that swaps the taskbar background during the gesture to support this case as well.
- Delay the unstash when IME is closing, to align with the end of the IME exit transition
- Remove TaskbarViewController.ALPHA_INDEX_IME now that we stash when IME is opening, since stashing already hides the taskbar icons
- Also support passing a starting progress to the stashed handle reveal animation, to allow it to be reversed when cancelled. For example, when returning to an app that has IME showing, we first start unstashing because we're in an app, but then we get the signal that IME is attached so we stash again almost immediately (within a frame or two).

Test: In both 3 button and fully gestural, open a keyboard in an app, ensure taskbar gets out of the way and then reappears at the end when the keyboard is dismissed
Bug: 202511986
Change-Id: I93c298a98ba369ea6310466ff3f802231c582687
2021-11-23 16:37:06 -08:00
Winson Chung cc60ff2fff Merge "Removing logs" into sc-v2-dev am: c1afaa4042 am: c0098a8628
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16248600

Change-Id: Id59fc54915e3f0c54d38904dff7c62d3c937e028
2021-11-23 22:23:39 +00:00
Winson Chung c1afaa4042 Merge "Removing logs" into sc-v2-dev 2021-11-23 21:58:14 +00:00
Vinit Nayak 9119e1fab3 Merge "Show multiple App Info A11y options for split app icons" into sc-v2-dev am: 458832c09e am: f36ba262a8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16301835

Change-Id: I8fbd6a4122cd1741f7e0c6a6842b0726ca9ec9cf
2021-11-23 20:33:28 +00:00
Vinit Nayak 458832c09e Merge "Show multiple App Info A11y options for split app icons" into sc-v2-dev 2021-11-23 20:09:47 +00:00
Alex Chau 7c6ef08dd2 Merge "Consider launching task's position on screen in pivot calculation" into sc-v2-dev am: 48644c75b3 am: 97c12c8b72
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16306378

Change-Id: Ib92ae0899d08411ce07ddac36cae0f6d4466723d
2021-11-22 21:36:00 +00:00
Alex Chau 48644c75b3 Merge "Consider launching task's position on screen in pivot calculation" into sc-v2-dev 2021-11-22 21:07:41 +00:00
Alex Chau f9c9986c01 Log the display state when number of screen bounds is inconsistent am: 4f49c9ce62 am: 04068586d4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16230738

Change-Id: If21c6b2ebfef0dfd813689087cc65ed5ecb72f29
2021-11-22 17:42:35 +00:00
Alex Chau 4f49c9ce62 Log the display state when number of screen bounds is inconsistent
- If the number of screen bounds a.k.a. number of displays has changed, it should be a bug from system and add a log for that

Bug: 198965093
Test: manual
Change-Id: I74612e6c0d2f3cfd52b509e43ea16adf0eec76de
2021-11-22 15:16:17 +00:00
Alex Chau a0aa9ac6e4 Merge "Remove temporary logging for NO_SCREENSHOT bug/." into sc-v2-dev am: 3c2298668a am: 0c59f1ac7b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16307753

Change-Id: I2c49271d01922df710d53f1d52090ed0c1593880
2021-11-22 11:35:51 +00:00
Zak Cohen d95942132d Remove temporary logging for NO_SCREENSHOT bug/.
Bug: 202414125, 203583301
Test: Local
Change-Id: I8345bd9f1c3ee93971d64ed49cf613cfd09ce10c
2021-11-19 13:49:36 -08:00
Alex Chau af43216f0d Merge "Use only current density to check isTablet" into sc-v2-dev am: 7ba828c1a9 am: 8d3d6b1961
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16306379

Change-Id: I66dd05d8c193cebfafa2095f986d8ea2bc3f9c57
2021-11-19 20:58:15 +00:00
Alex Chau 2998307cd6 Use only current density to check isTablet
- Removed DeviceProfile.allowRotation and use DeviceProfile.isTablet instead, which only uses current density to calculate its value
- Reverted default allow_rotation preference handling to before ag/14234761

Fix: 203817448
Test: isTablet is set correctly in different screen sizes
Change-Id: Ic6c8dfc774e7787f62d489ad27720a7644c1e8c7
2021-11-19 15:27:01 +00:00
Alex Chau 6499e83c57 Consider launching task's position on screen in pivot calculation
- Instead of using RecentsViewScroll, put task's position offset versus current scroll as TaskRect calculation, so it's considered when calculating for putting task to full screen
- Revert back RecentsViewScroll to apply before RecentsViewScale
- Added new property in PagedOrientationHandler to apply both primary/secondary param without clearing the other, and renamed an existing method

Fix: 206972618
Test: Quick switching
Test: Launch task from grid, launch side task from carousel overview
Change-Id: I5977975ed1e930ad70b81d83513d8f3a00c0aed4
2021-11-19 14:42:20 +00:00
Vinit Nayak f957244b88 Show multiple App Info A11y options for split app icons
* AccessibilityNode actions are required to have a
unique resourceId to show as an action in A11y dialog.
For now, only AppInfo option is shown for each app in split,
but moving forward we'll need to add resourceIDs for
each option that can show up for either app.

Fixes: 200609838
Test: Saw multiple options for App Info for each app
come up in talkback mode

Change-Id: I92b349347354ac639537021d775eea814c866a0e
2021-11-18 23:22:46 -08:00
Pratyush dbee088fa2 Merge "Making second argument configurable in wallpaper intent function" 2021-11-19 06:53:55 +00:00
Schneider Victor-tulias 8cd8695a78 Merge "Add TODO to fix b/206508141 before removing or changing the default value to the feature flag ENABLE_LOCAL_COLOR_POPUPS" into sc-v2-dev am: ce740c832c am: 4e9a31bdc9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16285925

Change-Id: Iff67f78518ecdf14671d535fd92c7ea06c1d68ee
2021-11-18 19:18:00 +00:00
Schneider Victor-tulias ce740c832c Merge "Add TODO to fix b/206508141 before removing or changing the default value to the feature flag ENABLE_LOCAL_COLOR_POPUPS" into sc-v2-dev 2021-11-18 18:45:16 +00:00
Thales Lima 29df4a92de Merge "open grid task menu to the right of icon" into sc-v2-dev am: bd1aec6721 am: 86f23841c2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16248618

Change-Id: Ic2fa8bd603abd46f1fcf5d9a1234f1e2ff798e61
2021-11-18 18:42:11 +00:00
Thales Lima bd1aec6721 Merge "open grid task menu to the right of icon" into sc-v2-dev 2021-11-18 18:19:58 +00:00
TreeHugger Robot a516bf169d Merge "Adding back the badges on widgets for widget recommendations." into sc-v2-dev am: 160d85c815 am: cce039642b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16279659

Change-Id: I534d436f36a52cf02104b788d5e2477ed99f80f4
2021-11-18 18:05:21 +00:00
TreeHugger Robot 160d85c815 Merge "Adding back the badges on widgets for widget recommendations." into sc-v2-dev 2021-11-18 17:44:50 +00:00
Thales Lima 45f2306ce9 open grid task menu to the right of icon
This makes the TaskMenuViewWithArrow open to the right of the icon if
there is enough space, and to the left if not. It also works correctly
in RTL, inverting the side to open by default.

Bug: 193432925
Test: open Overview and tap the app icon
Change-Id: Ib1098f48ed28d2e0758fb0e3fb733e86271fa1a0
2021-11-18 12:01:16 -03:00
Pratyush d51057a5d4 Making second argument configurable in wallpaper intent function
Bug: 190080582
Test: Build and Flash on device
Change-Id: I1cc78622d4faaca0aec0be04c28e893eb9d2d0f0
2021-11-18 10:40:28 +00:00
TreeHugger Robot 611327d58b Merge "Use split thumbnail width/height directly" into sc-v2-dev am: 5394db834f am: d5bb753fb0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16290750

Change-Id: I1af553df752b9ae143c1e25b22bf9c715acc9ebb
2021-11-18 05:11:07 +00:00
TreeHugger Robot 5394db834f Merge "Use split thumbnail width/height directly" into sc-v2-dev 2021-11-18 04:42:27 +00:00
Vinit Nayak be7ce023de Use split thumbnail width/height directly
* When swiping to QS from home, the
bounds for the rect on screen are incorrect
because it's technically off-screen when
it's being queried

Fixes: 206155441
Change-Id: Ibb17f2ac291f867b6de06041c980e434ce92cf27
2021-11-17 19:05:29 -08:00
Tony Wickham 519a9a43d2 Merge changes I36871463,I691a5cbb,I62105c1c into sc-v2-dev am: 49da26f636 am: e60d5d4f6d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16192239

Change-Id: I45da18a185b6d4aca7a2f0c5248ea3749adfd47c
2021-11-17 22:32:31 +00:00
Tony Wickham 49da26f636 Merge changes I36871463,I691a5cbb,I62105c1c into sc-v2-dev
* changes:
  Update reorder and folder creation radii
  Fix misaligned folder creation drag over target
  Update CellLayout.DEBUG_VISUALIZE_OCCUPIED to include drag over targets
2021-11-17 22:08:28 +00:00
Schneider Victor-tulias 1a332d85b2 Merge "Add notification dots and popup menu notification support to the taskbar." 2021-11-17 21:51:10 +00:00
Sebastian Franco 0a1328d9fb Adding back the badges on widgets for widget recommendations.
Test: Manual Testing
Fix: 202956924
Change-Id: I859d3d93d95bdc8d0742eb6b5dd40ad12a386928
2021-11-17 15:08:09 -06:00
Winson Chung 7b05bdfebc Merge "Fix issue with grouped task rects being calculated slightly off" into sc-v2-dev am: 0e1cd933ba am: b73106e5b3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16282083

Change-Id: I7e5d556c6b94aee9b9276a1d23f753cd5b16a789
2021-11-17 20:22:33 +00:00
Schneider Victor-tulias 92c6ae64de Add TODO to fix b/206508141 before removing or changing the default value to the feature flag ENABLE_LOCAL_COLOR_POPUPS
Bug: 206508141
Test: None
Change-Id: I8a8290f1e7d24c9fd2e8922f0126fa3d713e10a4
2021-11-17 12:22:02 -08:00
Winson Chung 0e1cd933ba Merge "Fix issue with grouped task rects being calculated slightly off" into sc-v2-dev 2021-11-17 19:42:53 +00:00
TreeHugger Robot 813292ffa9 Merge "Revert "Add feature flag to control two panel home in portrait"" into sc-v2-dev am: 42f111dc27 am: 54dd53876c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16279502

Change-Id: Ic254c821aea315d861b526b7f61e256256652f03
2021-11-17 18:42:22 +00:00
TreeHugger Robot 42f111dc27 Merge "Revert "Add feature flag to control two panel home in portrait"" into sc-v2-dev 2021-11-17 17:47:16 +00:00
Winson Chung 9304879387 Fix issue with grouped task rects being calculated slightly off
- This was causing bleed through between split tasks and perhaps
  some rounded corners to be calculated incorrectly
- Also reset the translation after it is adjusted for dismissing
  in case the dismiss gesture is canceled.  This doesn't fix the
  issue with bleed through between the task views (to be fixed
  separately), but makes sure it isn't permanently set on the task

Bug: 206739664
Test: Split tasks, swipe up and check the bounds

Change-Id: I34430e958ca7a75f48621bc27a281e93fdf97179
2021-11-17 17:40:58 +00:00
Alex Chau 9012582ef7 Revert "Add feature flag to control two panel home in portrait"
This reverts commit b1c36ce938.

Reason for revert: experiment no longer requried
Bug: 197723099

Change-Id: I585fa4364ab5326a19b099a80a1a02a66370d84f
2021-11-17 14:16:58 +00:00
TreeHugger Robot 86d0c44e25 Merge "Fix LauncherProvider newScreenId issue" into sc-v2-dev am: 82fc85f9b8 am: 506927514d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16064580

Change-Id: Iaa46ac7af2731e42c438f907ca80cf982952a381
2021-11-16 19:16:03 +00:00
TreeHugger Robot 82fc85f9b8 Merge "Fix LauncherProvider newScreenId issue" into sc-v2-dev 2021-11-16 19:00:47 +00:00
TreeHugger Robot d8a1b5c366 Merge "Fix overview scroll triggering haptics on swipe up gesture" into sc-v2-dev 2021-11-16 16:48:14 +00:00
Tracy Zhou 36cd649a2b Merge "Track LauncherState, RecentsAnimation, resumed state for task bar in one place" into sc-v2-dev am: 0200636585 am: 022c66327b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16205781

Change-Id: I8d135ccf3b14de2e10384c365ce69d9313984347
2021-11-16 10:09:51 +00:00
Tracy Zhou 0200636585 Merge "Track LauncherState, RecentsAnimation, resumed state for task bar in one place" into sc-v2-dev 2021-11-16 09:41:58 +00:00
Schneider Victor-tulias 5173fd8090 Add notification dots and popup menu notification support to the taskbar.
- Added support for notification dots
- Added support for notifications in popup menu
- Added support for dismissing notifications from the popup menu

Bug: 198438631
Test: long pressed launcher and taskbar icons, clicked notifications, clicked shortcuts
Change-Id: I7c981e60a82b4d6ce28332d804bbbfb5eb89c6a8
2021-11-15 14:47:36 -08:00
TreeHugger Robot 2f08212714 Merge "Deletes old feature flags." into sc-v2-dev am: 3d7084863a am: 2bf1f507d4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15507535

Change-Id: I14fdae195d465fd9cb7faf4ca9711a45e244fe45
2021-11-15 17:13:38 +00:00
TreeHugger Robot 3d7084863a Merge "Deletes old feature flags." into sc-v2-dev 2021-11-13 00:38:07 +00:00
Andras Kloczl 953eb8041e Fix LauncherProvider newScreenId issue
Remove maxScreenId from LauncherProvider and whenever we need
a new screenId, query the database to calculate a new screenId.
Also converted and refactored AddWorkspaceItemsTaskTest
and added some extra test cases.

Test: manual & AddWorkspaceItemsTaskTest.kt
Bug: 199160559
Change-Id: I185f6823fed171d778af0130497f5ffaf89c0a70
2021-11-12 19:56:07 +00:00
Winson Chung 21d129de28 Removing logs
Bug: 201305599
Test: Builds
Change-Id: Ic480136ee6b158dc614d43beaed1dfce91b9ca8a
2021-11-12 17:18:11 +00:00