Commit Graph

14362 Commits

Author SHA1 Message Date
Jagrut Desai a89c52a0d1 Merge "Fix Taskbar Recents Item after unlock" into main 2025-04-08 13:29:00 -07:00
Treehugger Robot 049a8f608d Merge "Let TaskView.bind take GroupTask instead of Task" into main 2025-04-08 12:54:16 -07:00
Treehugger Robot faded705d0 Merge "Use DesktopModeFlags for Alt+Tab CD flags" into main 2025-04-08 10:57:16 -07:00
minch 42efd0c6cc Let TaskView.bind take GroupTask instead of Task
1. Introduce a `groupTask` property to `TaskView` and let all the
   `bind` functions take a type of `GroupTask` as the parameter
   instead of a `Task`.
2. Then let `RecentsView.removeGroupTaskInternal` take the
   `GroupTask` as the parameter instead of a `TaskView`.
3. Caches the `groupTask` before `removeGroupTaskInternal` then
   we can avoid the corresponding `deskId` being set to invalid
   on `removeViewInLayout` in the main thread, which might happen
   before `removeGroupTaskInternal`.

Bug: 408032417
Test: m
Flag: EXEMPT refactor
Change-Id: I51c5b810eb63bc1267b90b915f90164f7ca3cba5
2025-04-08 17:16:08 +00:00
Treehugger Robot 1f4ee92d18 Merge "Fix grammar issue with all set page subtitle" into main 2025-04-08 09:57:13 -07:00
Treehugger Robot b1e5175b76 Merge "Fix blur flash while moving from live tiles to static." into main 2025-04-08 09:50:06 -07:00
Sunny Goyal afd7e35e0d Merge "Moving IconProvider extensions to a separate subclass instead of routing via APIWrapper" into main 2025-04-08 09:46:28 -07:00
Treehugger Robot 5197cda3af Merge "Fix App Chip Menu position in RTL" into main 2025-04-08 09:42:53 -07:00
Jagrut Desai 065a5321a8 Fix Taskbar Recents Item after unlock
we simply fetch the icons at the same time we restore the previously show items.

Test: Manual
Bug: 407932962
Flag: EXEMPT bugfix
Change-Id: I83131ef034fe94583beee32aeeb3e908f07cfc6f
2025-04-08 09:01:59 -07:00
Ajinkya Chalke c86d27deec Use DesktopModeFlags for Alt+Tab CD flags
- Updated flags for both Alt+Tab on CD and KQS flatenning features.

Bug: 407954660
Test: m
Flag: EXEMPT only updated flag usage
Change-Id: If099138c65ae582837293c0929185f61e6f5f350
2025-04-08 15:14:42 +00:00
Schneider Victor-Tulias 02d9e5043a Fix grammar issue with all set page subtitle
Flag: EXEMPT bug fix
Fixes: 392616062
Test: launched all set page with empty and test devices names
Change-Id: I885603f64478642c825e15563f5526399114f0f2
2025-04-08 10:31:19 -04:00
Jordan Silva 1f9073a942 Fix App Chip Menu position in RTL
- Updated IconAppChipView and TaskMenuView to use `Gravity.START` when the layout is natural to launcher (i.e., not fake landscape).
- TaskMenuView updated to use Gravity.START when the layout is natural to launcher as well.
- Updated the RTL translationX for the TaskMenuView.
- Removed the reveal animation when expanding the chip. No longer necessary due to the marquee and horizontal fading.
- Fixed the reveal animation when collapsing the chip in RTL.

Fix: 409035162
Flag: com.android.launcher3.enable_overview_icon_menu
Test: Manual. Using RTL, expand the app chip menu.
Change-Id: I9e7639a62a08133b3fd4a31a932ba65d03c65d53
2025-04-08 07:21:32 -07:00
vinayjoglekar d905645f1e Fix blur flash while moving from live tiles to static.
Fix : 406231674
Test: Manual. Dismiss live tile from Overview. Long press on live tile to invoke AiAi.
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: Ibc4c472f9c26862a4dcf0993ab487a8e52062bcf
2025-04-08 14:42:56 +01:00
Treehugger Robot 75970d1567 Merge "Consider liveTileRemoteTargetHandles when deciding blur layer when launching tasks" into main 2025-04-08 05:00:55 -07:00
Alex Chau 70e22f42c3 Merge "Make HintState transparent when blur is enabled" into main 2025-04-08 02:50:48 -07:00
Alex Chau f995461c1b Consider liveTileRemoteTargetHandles when deciding blur layer when launching tasks
- Simplified setDrawBelowRecents API to setDrawAboveRecents, this clarifies only live tile can be below recents
- Added getDrawAboveRecents to TaskViewSimulator to simplify finding surfaces below recents
- Simplifed updateBlurLayer method that filters below recents live tile surfaces to find the lowest surface

Fix: 406238103
Test: Home to Overview.
Test: App to Overview, launch live tile
Test: App to Overview, launch another task
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I9b6e1cf7b8f1c364a5390c20e0e2b70d72ed18a8
2025-04-08 10:49:42 +01:00
Sunny Goyal a5ddcf78ba Moving IconProvider extensions to a separate subclass instead of routing via APIWrapper
Also adding plugin support for IconProvider

Bug: 366237794
Flag: EXEMPT refactor and extra code behind plugin
Test: Manual
Change-Id: Id286f88b2683e0fabc48c57b7920024f06dd7539
2025-04-07 22:39:58 -07:00
Treehugger Robot 8a7b7a955e Merge "Revert "Revert^2 "Check if all apps are translucent when finishing recents animation.""" into main 2025-04-07 21:57:26 -07:00
Treehugger Robot 49bbc6b324 Merge "Revert "Also cancel TaskView collection Jobs when Overview is not on screen."" into main 2025-04-07 18:37:21 -07:00
Jon Miranda a898bfaee4 Revert "Revert^2 "Check if all apps are translucent when finishing recents animation.""
This reverts commit 73797f8188.
Also reverts commit I82717747408f5776a50aa239c384f87927b54832

Fixes: 406244612
Fixes: 406238331
Bug: 354627538 (reopening)
Test: opening App Info from Overview mutiple times
      opening App, enter Overview, open Split App Pair
Flag: EXEMPT bugfix
Change-Id: Ief81f826cf17ae9ef369eb97d353ebadda8077e3
2025-04-07 16:56:08 -07:00
Treehugger Robot 6b8aba0abb Merge "[CD Taskbar] Fix - Unlock/Lock Removes Recents button + icons" into main 2025-04-07 15:33:50 -07:00
Schneider Victor-tulias 8ae40731ff Merge "Fix Initialization exception when creating RecentsDisplayModel" into main 2025-04-07 15:21:59 -07:00
Treehugger Robot bbd09df63a Merge "Inject and use WindowContext in RotationTouchHelper" into main 2025-04-07 14:45:32 -07:00
Daniel Andersson aba807d57f Merge "desktop-exploded-view: Basic support for minimized tasks" into main 2025-04-07 13:23:45 -07:00
Sukesh Ram cd50c6fd9f [CD Taskbar] Fix - Unlock/Lock Removes Recents button + icons
The SYSUI_STATE_OVERVIEW_DISABLED is being incorrectly set for non-primary displays. Override this behavior on taskbar level for non-primary displays & track the sysUI side fix via b/409075366.

Bug: 408478776
Flag: com.android.window.flags.enable_taskbar_connected_displays
Test: m
Change-Id: Ie93d576dc525e80a8bc1e59dbcefa02b2e50591d
2025-04-07 13:02:57 -07:00
Alex Chau b9c5fa3f12 Make HintState transparent when blur is enabled
- Moved HintState to quickstep to have access to BlurUtils
- Added a dummy HintState outside quickstep

Fix: 406308427
Test: manual
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I8aa2407d87b429584168ebb0601cfffcccad0cfa
2025-04-07 20:17:31 +01:00
Saumya Prakash 830ceb6565 Merge "Don't translate the back button if home button is showing for lockscreen" into main 2025-04-07 11:59:39 -07:00
Daniel Andersson 641ffe50d8 desktop-exploded-view: Basic support for minimized tasks
This makes minimized tasks visible in overview. These tasks are
immediately placed in the exploded position and then fade in during
the course of EXPLODE_PROGRESS.

This CL also moves isLiveTile from TaskTileUiState to TaskData.Data
since it's no longer a TaskView wide state.

Note: this CL only makes the minimized tasks visible in overview. It
does not yet un-minimize tasks on click.

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
BUG=370495260

Change-Id: I5e441e81ae542902be9cd33d49bcb76d06bb1190
2025-04-07 10:31:47 -07:00
Schneider Victor-Tulias 6e79190f45 Fix Initialization exception when creating RecentsDisplayModel
Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/postsubmit tests
Change-Id: I5599b02dd34f92ca8645412b61b3c86b4cd91032
2025-04-07 13:20:16 -04:00
Treehugger Robot 8899e43c8a Merge "Turn on debug logging for RemoteActionShortcut / Pause App Shortcut" into main 2025-04-07 09:05:49 -07:00
Alex Chau bbafc6d79d Inject and use WindowContext in RotationTouchHelper
- Provides a per-display instance of WindowContext to avoid creation of Context
- Inject WindowContext instead of ApplicaitonContext in RotationTouchHelper to have a display associated context required by ScreenDecorationsUtils, as well as being able to have updated Resources upon configuration changes

Bug: 407878199
Test: Verified mWindowContexxt.resources.configuration is updated upon fold/unfold/rotate,
Flag: EXEMPT refactor
Change-Id: Ic032ae3c8c818b150f5e6fca0d531a19ad38986b
2025-04-07 08:39:06 -07:00
Alex Chau b9b817f3c7 Merge "Taskbar nav per-display" into main 2025-04-07 08:31:13 -07:00
Alex Chau 68439fefa4 Merge "Filter tasks by display id" into main 2025-04-07 05:09:49 -07:00
Alex Chau 7dce980f9a Merge "Refactor RotationTouchHelper to be per-display" into main 2025-04-07 04:27:26 -07:00
Treehugger Robot 5dbac00441 Merge "Clear overlay ref to thumbnail on reset" into main 2025-04-07 02:56:13 -07:00
Uwais Ashraf ffb1c80a7c Clear overlay ref to thumbnail on reset
Bug: 402703010
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Manual - checking heap dumps
Test: Presubmit tests
Test: ABTD runs - see comments
Change-Id: Ia42513a9773ae9000cf5aee702bb84dadeae816f
2025-04-05 12:41:04 +00:00
Treehugger Robot 53aff62dbf Merge "[Memory Leak] Fix leak of KeyboardQuickSwitchView and TaskbarOverlayDragLayer by SlideInRemoteTransition" into main 2025-04-04 18:02:08 -07:00
Treehugger Robot ab1cfa9740 Merge "Change Taskbar and Folder radius based on selected shape" into main 2025-04-04 17:10:32 -07:00
Charlie Anderson abd133c04a Turn on debug logging for RemoteActionShortcut / Pause App Shortcut
Bug: 407836418
Test: presubmit
Flag: EXEMPT just logging
Change-Id: I90973f34faf66cffe000645089a79de5f9e6b73c
2025-04-04 16:02:39 -07:00
Eghosa Ewansiha-Vlachavas 6665030709 Merge "[2/n] Isolate desktop entry point disabling from window exemptions" into main 2025-04-04 15:45:16 -07:00
Charlie Anderson 95ad50be6e Change Taskbar and Folder radius based on selected shape
Bug: 387543368
Bug: 408059321
Flag: com.android.launcher3.enable_launcher_icon_shapes
Test: stashing / unstashing taskbar
Change-Id: Ic5483a9dc0ecea47615a9add4b24772ceb97d982
2025-04-04 14:39:39 -07:00
Fengjiang Li 535ecc525e [Memory Leak] Fix leak of KeyboardQuickSwitchView and TaskbarOverlayDragLayer by SlideInRemoteTransition
By the time SlideInRemoteTransition is started, KeyboardQuickSwitchView is already detached from window, causing
1. Rejection from InteractionJankMonitor to mointor jank
2. Leak of KeyboardQuickSwitchView and its parent view TaskbarOverlayDragLayer

We should simply remove jank-monitoring of CUJ_LAUNCHER_KEYBOARD_QUICK_SWITCH_APP_LAUNCH as it's doing no-op and causing leak

Fix: 407032864
Test: manual - verify leak fixed locally
Flag: NONE - released code
Change-Id: I8562d8da1c4f0ec1b88e7ffa8bbb8da75ee57548
2025-04-04 11:56:38 -07:00
Sukesh Ram 0afdd7781c [CD Taskbar] Fix rendering taskbar on CD after reboot
- Use mWindowContexts instead of mTaskbars to recreate taskbars as
  taskbars are not always created - example when user is locked,
  taskbars are not created until after user unlocks.
- Create device profiles for connected displays when user unlocks in
  case those weren't created when display was added.

Bug: 405327859
Flag: com.android.window.flags.enable_taskbar_connected_displays
Test: m
Change-Id: I8d63a7f2b3d8ab95b246010c2fc6295cae22a343
2025-04-04 11:30:02 -07:00
Sukesh Ram 3351985052 Merge "[CD Taskbar] Cache displayId & Consolidate DisplayController methods" into main 2025-04-04 10:57:29 -07:00
Saumya Prakash b2e46eafc8 Don't translate the back button if home button is showing for lockscreen
The back button would get translated to the edge of the screen in
lockscreen apps. This was fine but now that the home button is shown in
these apps, they would overlap. This change prevents the back button
from translating to the edge of the screen when the home button is shown
in certain screens when the device is locked.

Fix: 406104663
Test: Enable 3 button nav and open lock screen apps/ emergency page on
large screen device. Observe that the buttons don't overlap anymore.
Flag: EXEMPT bugfix

Change-Id: Ibb963c1a62de80a990f223797d37a0a5ee294a90
2025-04-04 17:34:34 +00:00
Treehugger Robot 1d8172f685 Merge "Remove haptics on dismiss animation end." into main 2025-04-04 09:52:12 -07:00
Pat Manning b3098b122b Remove haptics on dismiss animation end.
Add fling haptic when passing dismiss threshold. Currently exists only when dragging.

Fix: 406788127
Test: Manual.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I3db0a3a4849f12407911d53702e63a197504a98f
2025-04-04 15:24:37 +01:00
Will Osborn d8be141eed Filter tasks by display id
Test: tested locally on tablet
Flag: com.android.launcher3.enable_overview_on_connected_displays
Bug: 402363691
Change-Id: I5148f2ef09dde4a07d4b34f1752f12249bba69b6
2025-04-04 14:08:20 +00:00
Will Osborn d515f1a3ed Refactor RotationTouchHelper to be per-display
Bug: 398195845
Test: locally tested + ran unit tests
Flag: EXEMPT refactor
Change-Id: I2a5ae4171fd211650624291574f84f8bff8b8825
2025-04-04 12:59:34 +00:00
Will Osborn 90ac376da8 Taskbar nav per-display
Test: local + unit
Bug: 402364626
Flag: com.android.launcher3.enable_overview_on_connected_displays

Change-Id: I9643367e19b107a2811e93db4e3dd32e9355da71
2025-04-04 10:32:46 +00:00