Commit Graph

9143 Commits

Author SHA1 Message Date
Alex Chau a7adf882e1 Merge "Fix launch animation from bottom row and end of grid" into sc-v2-dev am: 7c9055fc6b am: 4cb9af12e9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16261572

Change-Id: I64cb2fbb7dfab422dbfca349a94a13f94064918c
2021-11-17 21:35:46 +00:00
Alex Chau 4cb9af12e9 Merge "Fix launch animation from bottom row and end of grid" into sc-v2-dev am: 7c9055fc6b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16261572

Change-Id: I1bff143ada51bc1de8d8981120fac8384980c4cc
2021-11-17 21:21:14 +00:00
Alex Chau 7c9055fc6b Merge "Fix launch animation from bottom row and end of grid" into sc-v2-dev 2021-11-17 21:02:16 +00:00
Tracy Zhou 9193dd1ef5 Merge "Refine when to move live tile app below recents view" into sc-v2-dev am: a37f8baa1d am: aba6c9296e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16280383

Change-Id: I825f8baddb7d4ea4dd9e05b22a831360b33b19a5
2021-11-17 20:22:48 +00:00
Winson Chung 7b05bdfebc Merge "Fix issue with grouped task rects being calculated slightly off" into sc-v2-dev am: 0e1cd933ba am: b73106e5b3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16282083

Change-Id: I7e5d556c6b94aee9b9276a1d23f753cd5b16a789
2021-11-17 20:22:33 +00:00
Tracy Zhou aba6c9296e Merge "Refine when to move live tile app below recents view" into sc-v2-dev am: a37f8baa1d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16280383

Change-Id: I2d30f89603216b27354668d28bb178127c483dce
2021-11-17 19:54:47 +00:00
Winson Chung b73106e5b3 Merge "Fix issue with grouped task rects being calculated slightly off" into sc-v2-dev am: 0e1cd933ba
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16282083

Change-Id: I64b43cfa8d18266d7d58a3aff53450569a09df45
2021-11-17 19:53:53 +00:00
Tracy Zhou a37f8baa1d Merge "Refine when to move live tile app below recents view" into sc-v2-dev 2021-11-17 19:53:14 +00:00
Winson Chung 0e1cd933ba Merge "Fix issue with grouped task rects being calculated slightly off" into sc-v2-dev 2021-11-17 19:42:53 +00:00
Fedor Kudasov 228f1ef97b Merge "Add some more @Nullable annotations" into sc-v2-dev am: e65c47e60f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16279499

Change-Id: I2c201837c2ff2bb9938103f5d5a3243e3c501aab
2021-11-17 18:58:04 +00:00
Winson Chung 9304879387 Fix issue with grouped task rects being calculated slightly off
- This was causing bleed through between split tasks and perhaps
  some rounded corners to be calculated incorrectly
- Also reset the translation after it is adjusted for dismissing
  in case the dismiss gesture is canceled.  This doesn't fix the
  issue with bleed through between the task views (to be fixed
  separately), but makes sure it isn't permanently set on the task

Bug: 206739664
Test: Split tasks, swipe up and check the bounds

Change-Id: I34430e958ca7a75f48621bc27a281e93fdf97179
2021-11-17 17:40:58 +00:00
Fedor Kudasov 3256e1e744 Add some more @Nullable annotations
Bug: 205828770
Test: m LauncherGoResLib
Change-Id: I6d2f269c4ec5f6cdee31ad68545c2720fbf1d8fc
(cherry picked from commit 9385170c1b)
2021-11-17 08:40:17 +00:00
Fedor Kudasov c62bc172b1 Merge "Add some more @Nullable annotations" 2021-11-17 08:39:58 +00:00
Tracy Zhou a4edc07ec8 Refine when to move live tile app below recents view
- We will still need to figure out why, but currently the overview scrim blocks the cut out during transition. To go around this, we need to move live tile app after the overview transition animation is over
- Some of the logic in RecentsView is no longer necessary since we are no longer reusing live tile params and simulator, but assign new targets each time

Fixes: 205587164
Test: manual
Change-Id: Icadf26182112bba544a4103b626effa37d4028b5
2021-11-16 21:17:19 -08:00
TreeHugger Robot 266b0a96f1 Merge "Fix memory leak in TaskbarLauncherStateController" into sc-v2-dev am: b797ca77b2 am: a4157b6afe
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16275817

Change-Id: Ica815cdb7444d5634f8479a1399373da178a558a
2021-11-16 22:08:48 +00:00
TreeHugger Robot a4157b6afe Merge "Fix memory leak in TaskbarLauncherStateController" into sc-v2-dev am: b797ca77b2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16275817

Change-Id: Ia3cb4b2db5a8dc0bd5cef901259fab01aa2cee34
2021-11-16 21:55:37 +00:00
TreeHugger Robot b797ca77b2 Merge "Fix memory leak in TaskbarLauncherStateController" into sc-v2-dev 2021-11-16 21:34:52 +00:00
TreeHugger Robot 708c403390 Merge "If hometask is last task to be dismissed, show empty recents instead of home screen" into sc-v2-dev am: 36705e6039 am: 38b671d602
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16273821

Change-Id: I7ffc73f71899c11217d0ed1e8da3f42167d437d2
2021-11-16 20:56:18 +00:00
TreeHugger Robot 38b671d602 Merge "If hometask is last task to be dismissed, show empty recents instead of home screen" into sc-v2-dev am: 36705e6039
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16273821

Change-Id: I07a1681b8d5ba1a5699537e4f6e5f981ae09718b
2021-11-16 20:39:18 +00:00
TreeHugger Robot 36705e6039 Merge "If hometask is last task to be dismissed, show empty recents instead of home screen" into sc-v2-dev 2021-11-16 20:25:06 +00:00
Tracy Zhou 1fdea66f16 Fix memory leak in TaskbarLauncherStateController
mIconAlphaForHome.setConsumer(null) in onDestroy()

Test: Run BinderTests#testSwitchToOverview locally
Bug: 206633573
Change-Id: I912cd66097b113ee84197f23a5862e333d7e63f2
2021-11-16 11:31:15 -08:00
Alex Chau f5bc2491ad Merge "Crop letterbox insets when thumbnail is from different aspect ratio" into sc-v2-dev am: 1c4871298e am: 0f38629826
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16166972

Change-Id: I6ce2c962c9bda60c1cc29c81f18e8dd56aea82fb
2021-11-16 19:15:29 +00:00
Alex Chau 0f38629826 Merge "Crop letterbox insets when thumbnail is from different aspect ratio" into sc-v2-dev am: 1c4871298e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16166972

Change-Id: Icf8e6992c6b76fddca4ae25c81a66f6424d9554e
2021-11-16 18:57:56 +00:00
Alex Chau 04309940c0 If hometask is last task to be dismissed, show empty recents instead of home screen
- http://ag/16221737 ensure homescren stub is always added if tasks hasn't been loaded in RecentsView. This introduced an edge case that after dismissing home task view, no task remains in overview and it get dismissed
- The fix is to show empty recents instead of home screen if last task dismissed is a home task (showing empty recents isn't always correct, as there might be unloaded tasks, but it's better than dismissing overview)
- Also tuned the timing of when mLoadPlanEverApplied is set

Fix: 206462357
Test: FallbackRecentsTest.goToOverviewFromHome
Change-Id: I0f395639f57a1a57fddf750623a8a74b8ede8555
2021-11-16 18:48:28 +00:00
Alex Chau 1c4871298e Merge "Crop letterbox insets when thumbnail is from different aspect ratio" into sc-v2-dev 2021-11-16 18:40:31 +00:00
Merissa Tan 0a2ec731b6 Merge "Create new TaskbarUIController class for Kingyo." 2021-11-16 18:18:25 +00:00
Alex Chau b7abf7e96d Fix launch animation from bottom row and end of grid
- Apply gridTranslationY when calculating taskRect so it's used to calculate RecnetsView pivot
- Moved recentsViewScroll to RecentsView group and applied after recentsViewScale
- Before: http://dr/file/d/1-Nrqa80J4FRbjcdZ3GZSeKwfQF8fN9a1/view?resourcekey=0-gYT9z1HA0YksW5Ujbzsmeg
- After: http://dr/file/d/1-DpZrg5_nFeUKS-8APnLvG8SJVvke9BU/view?resourcekey=0-p59hm-abzpU7Y7tqWyneTQ

Fix: 200813202
Test: Launch task from grid from top/bottom/left/right/focus
Test: Launch task from left/middle/right in small screen
Change-Id: I814512c02611f59a5a6d1f53411d42cf4f0f26b3
2021-11-16 13:55:38 +00:00
Fedor Kudasov b807d92aa7 Merge "Annotate RecentsView with @Nullable" into sc-v2-dev am: 72c8e71e06
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16261398

Change-Id: Ic382d5886aa2df5c1bb8f981cbe626f031fd9c51
2021-11-16 10:44:07 +00:00
Fedor Kudasov 72c8e71e06 Merge "Annotate RecentsView with @Nullable" into sc-v2-dev 2021-11-16 10:26:23 +00:00
Tracy Zhou 36cd649a2b Merge "Track LauncherState, RecentsAnimation, resumed state for task bar in one place" into sc-v2-dev am: 0200636585 am: 022c66327b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16205781

Change-Id: I8d135ccf3b14de2e10384c365ce69d9313984347
2021-11-16 10:09:51 +00:00
Tracy Zhou 022c66327b Merge "Track LauncherState, RecentsAnimation, resumed state for task bar in one place" into sc-v2-dev am: 0200636585
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16205781

Change-Id: Ie9ca6ecdd77ac76b5b93461b6c5d7d6e670b71a6
2021-11-16 09:57:38 +00:00
Tracy Zhou 0200636585 Merge "Track LauncherState, RecentsAnimation, resumed state for task bar in one place" into sc-v2-dev 2021-11-16 09:41:58 +00:00
Fedor Kudasov acf07f338e Simplify getTaskViewAt call am: 9d6fb64f45
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16249427

Change-Id: If52c26a38fab17d294b08a34a3e41fd5f88cef27
2021-11-15 20:50:06 +00:00
Fedor Kudasov 3a0f8a90bd Annotate RecentsView with @Nullable
Bug: 205828770
Test: m LauncherGoResLib
Change-Id: I44a4f7ce4258e54d43ca2c5a3937c81a4a686f80
(cherry picked from commit ac9cee5a7c)
2021-11-15 20:39:07 +00:00
Fedor Kudasov 9d6fb64f45 Simplify getTaskViewAt call
RecentsView getTaskViewAt method is nullable and is safe
to call for an out of bound index.

Bug: 205828770
Test: m LauncherGoResLib
Change-Id: I7709d63ad4490fd756a50caaf42ba70c4fad4d06
(cherry picked from commit 41edede1ee)
2021-11-15 20:37:12 +00:00
Fedor Kudasov 9385170c1b Add some more @Nullable annotations
Bug: 205828770
Test: m LauncherGoResLib
Change-Id: I6d2f269c4ec5f6cdee31ad68545c2720fbf1d8fc
2021-11-15 17:03:45 +00:00
Fedor Kudasov 2f2b057710 Merge "Annotate RecentsView with @Nullable" 2021-11-15 12:02:55 +00:00
Fedor Kudasov 913c8aee24 Merge "Add @Nullable annotations for simple cases" into sc-v2-dev am: ba47b591c4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16246987

Change-Id: I4fe20700452492680e0ea1e30577ed04ecda0e4f
2021-11-13 09:17:31 +00:00
Fedor Kudasov ac9cee5a7c Annotate RecentsView with @Nullable
Bug: 205828770
Test: m LauncherGoResLib
Change-Id: I44a4f7ce4258e54d43ca2c5a3937c81a4a686f80
2021-11-13 09:08:03 +00:00
Fedor Kudasov 2fa969b9d9 Merge "Simplify getTaskViewAt call" 2021-11-13 09:01:24 +00:00
Fedor Kudasov ba47b591c4 Merge "Add @Nullable annotations for simple cases" into sc-v2-dev 2021-11-13 09:00:32 +00:00
Winson Chung 131cceecad Merge "Freeze task list if requested when launching split tasks" into sc-v2-dev am: ea77e49524 am: 16d6010418
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16245857

Change-Id: I0b25462982047dfb1ebaa0fd4f86727b540e66f6
2021-11-12 21:26:49 +00:00
Winson Chung 16d6010418 Merge "Freeze task list if requested when launching split tasks" into sc-v2-dev am: ea77e49524
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16245857

Change-Id: Icad379bd6b9302e1dd2903e3e7f8d468f8d87718
2021-11-12 21:08:27 +00:00
Winson Chung ea77e49524 Merge "Freeze task list if requested when launching split tasks" into sc-v2-dev 2021-11-12 20:51:15 +00:00
Merissa Tan 5f2516c03a Create new TaskbarUIController class for Kingyo.
This CL creates a new TaskbarUIController sub-class to allow for taskbar
UI customization on Kingyo.

Recall: http://recall/clips/598d7fc8-fa06-426b-8851-c5d5c1a91eb2

Bug: 202450677
Test: Manual
Change-Id: I9e06fe7556bd9a29d126e29c0277139b2f218069
2021-11-12 12:05:50 -08:00
Alex Chau 8ab30afd53 Fix launch animation from grid am: f75725830a am: 45bb7b48ec
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16240053

Change-Id: Ic0d61f508f16eec3c3163ea358b36b1a3ad6834a
2021-11-12 18:27:51 +00:00
Alex Chau 45bb7b48ec Fix launch animation from grid am: f75725830a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16240053

Change-Id: I6815036c3d3916a4378340c089a35339a52206d4
2021-11-12 18:13:10 +00:00
Alex Chau f75725830a Fix launch animation from grid
- Fixed calculateGridTaskSize to algin to taskRect instead of gridRect
- Extracted end of grid's scroll diff calculation to getOffsetFromScrollPosition to accurately calculate end of grid task's offset between its scroll and visual position (End of grid task's scroll is all the same at the position where ClearAllButton is just invisible)
- Extracted isGridTask in TaskView so TaskViewSimualtor can use the correct task size depedning if it's grid task or not

Bug: 200813202
Test: manual
Change-Id: I11a980345aee2680abf1c2563baadd9718a40192
2021-11-12 16:13:47 +00:00
Fedor Kudasov 2ca545c387 Add @Nullable annotations for simple cases
Add @Nullable annotations for the fields that are expected
to be null at arbitrary lifecycle time and are their usage
is protected by null checks.

Bug: 205828770
Test: m LauncherGoResLib
Change-Id: I9c31e1dc0d01cdd68dfff0a005ba1f40c257f8ea
(cherry picked from commit 920dc2f28f)
2021-11-12 10:01:33 +00:00
Fedor Kudasov 3618de3017 Merge "Add @Nullable annotations for simple cases" 2021-11-12 10:01:18 +00:00