Commit Graph

9114 Commits

Author SHA1 Message Date
Pinyao Ting 39216c1533 Fix the issue deep shortcuts cannot be added to workspace via
voice/switch access

Bug: 140405990
Change-Id: Ie54d9c738fc51445f3aa49458ff4fc1dd6e4fc67
Merged-In: Ie54d9c738fc51445f3aa49458ff4fc1dd6e4fc67
(cherry picked from commit 8a739f9511)
2019-09-12 20:33:03 +00:00
Jon Miranda d6ae55d968 Fix failing test testPromiseIcon_addedFromEligibleSession.
Test: Ran tests on device
Bug: 140819614
Change-Id: I8ee6836d3a06f315518aa4829c8e2ddf8cf5f74d
2019-09-12 16:58:51 +00:00
TreeHugger Robot cfdeb06205 Merge "Fix bug where existing icon is removed when install session is abandonded." into ub-launcher3-qt-qpr1-dev 2019-09-11 20:43:36 +00:00
TreeHugger Robot 791dd73217 Merge "Adding support for building a "spring like animation" with precomputed values" into ub-launcher3-qt-qpr1-dev 2019-09-11 20:16:19 +00:00
Jon Miranda 1c247cf451 Fix bug where existing icon is removed when install session is abandonded.
- Ensure we only add promise icons for apps that aren't already installed to
  our internal list of session ids.
- Ensure we only remove promise icons created from the install session when
  that session is abandonded.

Bug: 140819614
Change-Id: I3c93865b5e96a9c7a160154b45a38eb90ac9d183
2019-09-11 12:37:14 -07:00
Hyunyoung Song e17a699618 When DeviceConfig/FeatureFlag value is different than the previous
value, refresh icon cache

Bug: 135638690
Bug: 138964490

Test: manually toggled feature flag UI on/off
$ adb shell device_config put launcher APP_SEARCH_IMPROVEMENTS [true|false]
when launcher is in foreground and also when it is in the background

Afterwards, saw if "bank" would show BofA app or not

Change-Id: I98b62bd07b14a225168217d7eb9bfdfc7f74435d
2019-09-11 10:38:14 -07:00
TreeHugger Robot 8aee0b2cb5 Merge "Ensure the icon load request matches the ItemInfo for the floating view." into ub-launcher3-qt-qpr1-dev 2019-09-10 16:49:24 +00:00
Jon Miranda bdda7251df Ensure the icon load request matches the ItemInfo for the floating view.
This fixes the bug where the wrong icon is present during the app close
animation.

Bug: 138195597
Change-Id: Ife2c6ad135dde54583f6f2bb2caf3b1e9325e064
Merged-In: Ib3767ec5c2b4eb22b35e5148879e11d2c1b28e3c
2019-09-10 15:51:25 +00:00
Sunny Goyal 3600fb7777 Adding support for building a "spring like animation" with precomputed values
Bug: 138396187
Change-Id: Idba323090ecd9aca43c01414a32ab3b2e292e73e
2019-09-09 17:21:53 -07:00
Jonathan Miranda 735d1fe124 Merge "Add tests for play promise icons." into ub-launcher3-qt-qpr1-dev 2019-09-09 21:44:15 +00:00
vadimt 2bad570b40 Support for getting Launcher Pss by tests
Bug: 139137636
Change-Id: I8cad7dec07ce400cf927e3fc2ba9904fef942d9a
2019-09-06 16:50:51 -07:00
Jon Miranda 4b9edfbbe5 Add tests for play promise icons.
Bug: 139021165
Change-Id: Ie1a049b283b70f6bd22b43c09aef263282cb0f56
Merged-In: I45469b7523d8aea12c34d460c7b69c571a415675
2019-09-06 21:57:04 +00:00
TreeHugger Robot 243dd30da3 Merge "Add tracing for non-dragging icon" into ub-launcher3-qt-qpr1-dev 2019-09-05 21:57:01 +00:00
Tony Wickham d785fc289c Merge "Properly prevent All Apps relayouts by avoiding scrollToPosition" into ub-launcher3-qt-qpr1-dev 2019-09-05 21:27:41 +00:00
vadimt 30618db33f Add tracing for non-dragging icon
Bug: 138729456
Change-Id: Ib18f1544f2520509bd982f032bf3ed0c72ca9529
2019-09-05 14:08:39 -07:00
TreeHugger Robot e1335c2359 Merge "Removing flinging via UI Automator" into ub-launcher3-qt-qpr1-dev 2019-09-05 00:13:30 +00:00
vadimt 758a1d983d Removing flinging via UI Automator
UI Automator loses events. Switching to the homemade scrolling.

Bug: 138729157
Change-Id: Ib09bd5714e83eadfc65b54202867bf375e6b47c5
2019-09-04 16:35:19 -07:00
TreeHugger Robot 1bd96b1e96 Merge "Update app open/close animations." into ub-launcher3-qt-qpr1-dev 2019-09-04 22:33:33 +00:00
Jon Miranda 9b78e190fa Update app open/close animations.
- For app open, the icon text remains where it is and only the icon moves.
- Similarly for app close, the icon text remains where it is and fades in
  with the rest of the other icons text.

- With this change, the original view is always "VISIBLE"
  (if BubbleTextView/FolderIcon) but we hide certain elements.

Added video to bug.

Bug: 137200188
Bug: 139885365
Change-Id: I3d20c5f05bc7c0b9d052d8074ac3bfc21531c83d
Merged-In: I3d20c5f05bc7c0b9d052d8074ac3bfc21531c83d
2019-09-04 21:45:05 +00:00
Tony Wickham bfdeda96e6 Properly prevent All Apps relayouts by avoiding scrollToPosition
Calling scrollToPosition on RecyclerView internally calls
requestLayout() (to cacluate where to scroll and then go there).
Therefore, we should avoid calling that whenever possible, especially
during transitions. In particular, we can optimize scrollToTop() to not
scrollToPosition() if we are already at the top.

This makes some other workarounds unnecessary, namely setting All Apps
to GONE during system gestures.

Test: Open an app, swipe up, ensure AllAppsRecyclerView doesn't get
onLayout().  If we had scrolled to an app first, we get one layout
in prepareRecentsUi(), but not during the transition.

Bug: 140308849
Change-Id: I62ee341bf5893c121cfc013cc6542559f79d2a42
2019-09-03 16:16:54 -07:00
Andy Wickham c40872b913 Marks ScrimView unimportant for accessibility when Widgets screen is opened.
This prevents it from holding focus while the Widgets screen is visible
(after using Widgets action from the All Apps caret thingy).

Test: Manually followed steps provided in bug, and issue not seen after this change.
Fixes: 139918680
Change-Id: I280ac97fb7ff9fa67f1c6a1ce9cdfa9e451231eb
2019-09-03 21:20:22 +00:00
TreeHugger Robot 505a88140e Merge "Only add promise icon if icon is provided in the SessionInfo." into ub-launcher3-qt-qpr1-dev 2019-09-03 16:27:11 +00:00
Sunny Goyal a42681f6d2 Merge "Fix bug where we incorrectly change the default profile id of the database." into ub-launcher3-qt-qpr1-dev 2019-09-03 16:23:18 +00:00
Jon Miranda a8c7c0b713 Only add promise icon if icon is provided in the SessionInfo.
- In some cases, SessionInfo is created without an icon until later on
  in the install process. This prevents promise icons with default Android
  logo from appearing.
- This will also prevent apps without a launching activity from appearing
  as a promise icon and then disappearing when the app is installed.

Bug: 135633159
Change-Id: I30adde8bf2cf583bffca8ed878f9cc20d6d41a13
2019-09-03 08:13:09 -07:00
TreeHugger Robot 78ebf57e9f Merge "Adding tracing for mismatch between current and stable states" into ub-launcher3-qt-qpr1-dev 2019-08-31 00:55:55 +00:00
vadimt 7bfc820d0c Adding tracing for mismatch between current and stable states
Bug: 140311911
Change-Id: Ie6196015a3f1b35b1403a12540ff7e3290f8cb3d
2019-08-30 17:13:43 -07:00
Tony Wickham 7310bb4b5c Don't update all apps content visibility during home animation
We already set the all apps content visibility = GONE at the start of
the gesture to prevent relayouts, but when animating home we were
inadvertently changing it to INVISIBLE, causing a relayout and jank.

Bug: 140308849
Change-Id: I285746f8ac8f3f857282e22ebec8eebd0b98647f
2019-08-30 22:10:55 +00:00
Jon Miranda 768cb139cc Fix bug where we incorrectly change the default profile id of the database.
Change-Id: I0fafc06f5e28c1fdff77003c984e686719a60cd2
2019-08-30 16:11:00 +00:00
Jon Miranda d49fe3130e [DO NOT MERGE] Fix NumberFormatException for launcher.
Fix is already in ub-launcher3-master: I5094b22ddc77c45590cea1a5f5dead0dc7580abf

Bug: 140076379
Change-Id: I01948cf71ef2e058dc1ef8c506f174856ee09e0d
2019-08-29 19:10:28 +00:00
Samuel Fufa 68c97cf5ac Sorting people by key crashes launcher
Approch: approach: filter out people with null getKey before sorting.

Bug:139436782
Change-Id: I6510a12374ff4fec02c879ff76ba42b1fcdb8281
(cherry picked from commit 8628eb9353)
2019-08-26 18:05:59 +00:00
vadimt 197ae725a0 Adding debug tracing for All Apps appearing instead of Overview
Bug: 139941530
Change-Id: Ia9827c6edd48c559e9602e1e37de83293517ad5e
2019-08-23 12:11:00 -07:00
Becky Qiu 6d0d8969f6 Merge "Move swipe actions on container logging to west world." into ub-launcher3-qt-qpr1-dev 2019-08-23 18:03:02 +00:00
Vadim Tryshev 94dcb3b5bf Merge "Not freezing All Apps during user interactions" into ub-launcher3-qt-qpr1-dev 2019-08-23 00:05:38 +00:00
Becky Qiu f0a014d7ff Move swipe actions on container logging to west world.
Test: manual
Bug: 137777105

Log result for swiping in and out of -1 screen.
  data {
    elapsed_timestamp_nanos: 597609736235111
    atom {
      launcher_event {
        action: SWIPE_LEFT
        src_state: HOME
        dst_state: HOME
        is_swipe_up_enabled: true
      }
    }
  }

  data {
    elapsed_timestamp_nanos: 597610569783111
    atom {
      launcher_event {
        action: SWIPE_RIGHT
        src_state: HOME
        dst_state: HOME
        is_swipe_up_enabled: true
      }
    }
  }


Change-Id: Ic84d3c32d1c9f780f13ec5cd6320e9f1d610f018
2019-08-22 16:27:49 -07:00
TreeHugger Robot 418787778b Merge "Adding tracing for suspending via Wellbeing" into ub-launcher3-qt-qpr1-dev 2019-08-22 23:22:02 +00:00
vadimt 2b3303c744 Not freezing All Apps during user interactions
Extremely rarely, All Apps will get stuck in a non-updating state even
after the interaction ends.

It would be impractical to try drilling to the root cause of this,
so it's better to just allow All Apps updates while the user interacts
with it.

Bug: 139384936
Change-Id: I2ed7fb052da77a9e47ef9b9aa7800499071b98c3
2019-08-22 22:34:17 +00:00
vadimt 872cf29211 Adding tracing for suspending via Wellbeing
Bug: 139891609
Change-Id: I3ffb7941f7c4015cba3c65d87e20ccc6be920592
2019-08-22 15:30:42 -07:00
Jon Miranda 89137e7bb8 Add support for adding promise icons for new install sessions by user.
- Added flag PROMISE_APPS_NEW_INSTALLS
- Promise icons only added if flag (above) is on, as well as the setting
  for "Add icon to Home screen"
- Maintains a list of session ids of promise icons that have been added to the
  home screen, so that if the user manually removes the icon, we do not add
  it back to the home screen when the install is completed.
- Queues all applications as promise icons, and replaces with actual
  app info when its being added to the workspace.

Bug: 135633159
Change-Id: Idf2fc9033f890afef924628b76b89ad4692f529c
Merged-In: I411db59f9bd1b346d98b9bb73f5376a5983b8de5
2019-08-22 10:42:45 -07:00
Pinyao Ting d88f63bbed add null check when accessing target component from iteminfo
Bug: 139540363
Change-Id: I25d0100077de67b085c27b5ef91e22c6ac1ad959
Merged-In: I25d0100077de67b085c27b5ef91e22c6ac1ad959
2019-08-16 21:50:21 +00:00
Hyunyoung Song 96eba3aea6 Merge "Make TogglableFlag backed by DeviceConfig for e2e testing" into ub-launcher3-qt-qpr1-dev 2019-08-15 22:25:33 +00:00
Hyunyoung Song d4204437de Make TogglableFlag backed by DeviceConfig for e2e testing
Bug: 138964490

TL;DR;; need this to be part of QQ1 or QD1 to verify if DeviceConfig
can be supported for launcher toggleableFlags.

Not handled in this CL:
- When flag is locally modified, that will override the flag value
How that scenario is handled should be discussed separately and is not
within scope of this CL.

Change-Id: I2e6694a40bee9202ed0b0d559e3b5607634071bf
2019-08-15 14:02:28 -07:00
TreeHugger Robot 46463f6a19 Merge "Adding support for storing keywords in iconCache" into ub-launcher3-qt-qpr1-dev 2019-08-14 23:08:43 +00:00
TreeHugger Robot 4c19f94181 Merge "Adding app search improvement flag" into ub-launcher3-qt-qpr1-dev 2019-08-14 23:08:43 +00:00
Sunny Goyal 934ebd087b Adding support for storing keywords in iconCache
Change-Id: I1183e63a6556ebfb3eee5df23d149e09728193a9
Merged-In: I1183e63a6556ebfb3eee5df23d149e09728193a9
(cherry picked from commit e529a86fbd)
2019-08-14 22:12:49 +00:00
Alex Mang 713cd6fd56 Adding app search improvement flag
Bug: 125027540
Change-Id: I68fd7710b108e9f2fa1f5ff335326585a92deb23
Merged-In: I68fd7710b108e9f2fa1f5ff335326585a92deb23
(cherry picked from commit d27e31995b)
2019-08-14 21:58:57 +00:00
yingleiw 02cc848896 Add directional accessibility page actions to PagedView
For PagedView, when isPageOrderFlipped is true, it means the LTR mode is
flipped. For the "recents" in launcher, isPageOrderFlipped is true.
However, this doesn't affect the directional page operations since
scrollLeft()/Right() already has correct Rtl considerations. See
b/78788182 for more information on the LTR mode.

Test: Tested with the "recents" in launcher. Verified that page left
action always move pages to the right (so that the next page from the
left side shows), and page right actions always move pages to the left
(so that the next page from the right side shows). Also tested with the
home screen 1/2, 2/2 paging.
Bug: 136277517

Change-Id: I965d651c37d258eaa8ea347d1ad6f698f9b590bf
2019-08-14 18:05:08 +00:00
Becky Qiu 22edac9bf5 Merge "Log the event for swiping up to dismiss a task in Overview." into ub-launcher3-qt-qpr1-dev 2019-08-14 17:48:45 +00:00
Becky Qiu 90ea00b399 Log the event for swiping up to dismiss a task in Overview.
Test: manual
Bug: 137777105

Demo logging for dismissing a task:
  data {
    elapsed_timestamp_nanos: 70772067228810
    atom {
      launcher_event {
        action: DISMISS_TASK
        src_state: OVERVIEW
        dst_state: BACKGROUND
        is_swipe_up_enabled: true
      }
    }
  }

Change-Id: I5569b80e2e1f35661bc5e9e343c6c298791a1ec1
2019-08-09 10:57:05 -07:00
vadimt c1a2764a6e Support for memory tests
Change-Id: I867a232a293f7bddbc630f563f18c0db94ac4b6e
2019-08-08 12:03:09 -07:00
Pinyao Ting e4061fc931 show dot in deep shortcuts when notification contains exactly identical
set of person

Bug: 132336512
Change-Id: I975524e28168c10a186cdc24b188c161faf433cf
Merged-In: I975524e28168c10a186cdc24b188c161faf433cf
2019-08-05 23:31:35 -07:00