Commit Graph

2474 Commits

Author SHA1 Message Date
Treehugger Robot 59e208c28e Merge "Moving various launcher binding logic, outside LauncherModel" into main 2025-04-23 12:32:54 -07:00
Sunny Goyal 3678af5a81 Fixing crashes due to code 1032 SQLITE_READONLY_DBMOVED
1) Moving any DB file deletion before opening the DB to avoid deleting already opened file
2) Using a sandbox directory for BackupAndRestoreDBSelectionTest which can delete actively opened files causing other tests to fail

Bug: 403551539
Flag: EXEMPT bugfix
Test: Presubmit
Change-Id: Ib1088a0e486edf755e5f7dcd738eb835af78b4c4
2025-04-22 16:09:52 -07:00
Sunny Goyal c078d6554c Moving various launcher binding logic, outside LauncherModel
This brings the BgCallbacks closer to a repository pattern making is easier to switch eventually

Bug: 390572144
Flag: EXEMPT refactor
Test: Updated AsyncBindingTest to use real ModelCalbacks
Change-Id: I9c932b00ea8ac7330473b9c0f5d778453fe7a390
2025-04-22 14:12:17 -07:00
Sebastián Franco 8c96a1528c Merge "Adding screenrecord for IntegrationReorderWidgetsTest" into main 2025-04-18 11:38:20 -07:00
Sebastián Franco 95aa4a3267 Merge "Revert "No-op change, remove methods from BaseLauncherActivityTe..."" into main 2025-04-16 09:58:09 -07:00
Sebastián Franco a746ec8aa4 Revert "No-op change, remove methods from BaseLauncherActivityTe..."
Revert submission 32999330-activity-test-refactor-1

Reason for revert: b/410713970

Reverted changes: /q/submissionid:32999330-activity-test-refactor-1

Change-Id: Id9dd4692bc5c500fd8831a2edad80a034c4fa405
2025-04-15 15:55:35 -07:00
Treehugger Robot 0aa937de1a Merge "Enforce a mutex in all remote tapl tests" into main 2025-04-15 14:52:13 -07:00
Schneider Victor-Tulias d079748134 Enforce a mutex in all remote tapl tests
Flag: EXEMPT test fix
Fixes: 405849365
Test: TAPL tests; pre/postsubmit
Change-Id: Icf5b3c6b43b4d8ecc39246f3eb03e32738af7444
2025-04-15 15:05:26 -04:00
Sebastian Franco d330fdce3a Adding screenrecord for IntegrationReorderWidgetsTest
Bug: 408279425
Flag: EXEMPT bug fix
Test: IntegrationReorderWidgetsTest
Change-Id: I302a35304a145f90d7d49f93044787350c466ad1
2025-04-14 13:56:48 -07:00
Sebastian Franco c08c7de5e3 No-op change, remove methods from BaseLauncherActivityTest into Utilities
Bug: 324261526
Test: all test that inherit BaseLauncherActivityTest
Flag: TEST_ONLY
Change-Id: I0851373d179f064721a3a618853a05796cc1379f
2025-04-14 13:38:20 -07:00
Sebastian Franco 089f07c2b6 Use LauncherActivityScenarioRule in BaseLauncherActivityTest
The goal is that eventually remove BaseLauncherActivityTest and
uase LauncherActivityScenarioRule by compositions instead of
using inheritance and move methods that make sense to have in
LauncherActivityScenarioRule and other in utility classes.

Bug: 324261526
Test: All Tests that inherit from BaseLauncherActivityTest
Flag: TEST_ONLY
Change-Id: I1b2f3ed9e9d41a9185711ba682895b0b3fffe2df
2025-04-03 15:35:20 -07:00
Sunny Goyal 50884dadfe Lazily loading theme icons
Theme icons are generated and stored in cache, but only loaded if requested in lookup flags
This allows to keep the memory usage low, but not loading theme icons for all the apps

Bug: 381897614
Flag: com.android.launcher3.extendible_theme_manager
Test: Updated tests
Change-Id: I494eab9c4f70670e6f5aeb864ed5287f6b9f1b9e
2025-03-31 13:07:03 -07:00
Sunny Goyal bdd3f29342 Using item inflater for predicted items and previews
Bug: 406668365
Test: Verified manually in picker
Flag: EXEMPT refactor
Change-Id: If8ca919a19b7d1b6cbdc33823a9f294df1afa968
2025-03-28 13:05:25 -07:00
Sunny Goyal 2201485e22 Merge "Using ItemInflator for inflating Folder instead of duplicating code" into main 2025-03-27 12:45:01 -07:00
Sunny Goyal 0479ff832c Using ItemInflator for inflating Folder instead of duplicating code
Bug: 406668365
Flag: EXEMPT refactor
Test: atest FolderTest
Change-Id: I63186ba620b5380edfc5e8cded253a85379a5d82
2025-03-27 09:48:46 -07:00
Sunny Goyal 3b307455a0 Revert^2 "Simplifying model testing rules"
35b6d322ab

Change-Id: I3ed574a517dbe350b6dfe5b1d3ed198203d22f44
2025-03-26 23:08:55 -07:00
Priyanka Advani (xWF) 35b6d322ab Revert "Simplifying model testing rules"
Revert submission 32704934-model-test-cleanup

Reason for revert: Droidmonitor created revert due to b/406588406. Will be verifying through ABTD before submission.

Reverted changes: /q/submissionid:32704934-model-test-cleanup

Change-Id: Ieeb7f5b5699afeae27f946f060147bb68afc36e5
2025-03-26 16:12:16 -07:00
Sunny Goyal cb84230913 Simplifying model testing rules
> Using Sandbox application everywhere to avoid test leaks
> Removing LauncherModelHelper and moving some utility methods to rules and extensions

Bug: 406521480
Flag: EXEMPT test only
Test: Presubmit

Change-Id: I17bd5ec2bdb0fc0cbe02be9c8ee76595effe3f11
2025-03-26 11:34:15 -07:00
Treehugger Robot e0a018785e Merge "Add screenrecord for TaplUninstallRemoveTest#testUninstallFromAllApps" into main 2025-03-24 11:03:55 -07:00
Treehugger Robot d3e559a244 Merge "Add logging for which type of migration occurs." into main 2025-03-20 11:13:55 -07:00
Federico Baron c7e8c4e8e7 Add logging for which type of migration occurs.
When upgrading from non one grid to one grid, we should do the row
shift migration type, here we are logging data to make sure that is what
happens on upgrade

Flag: EXEMPT logging
Test: n/a
Bug: 393175684
Change-Id: Id09257094bc9bc44da757c73a4f63bf15987772c
2025-03-20 01:31:45 +00:00
Charlie Anderson 19c4a92ebc Avoid downgrading archived app icon when widget is restored and when apps are archived.
- Restored widget were requesting icons through iconcache, and overwriting the restored icon from restored db.
	- Manually archiving icons would delete icon in cache, we should instead reuse the icon from when it was installed.

Bug: 399649982
Test: Manually performing restore with apps, widgets and shortcuts.
Flag: com.android.launcher3.restore_archived_app_icons_from_db
Change-Id: I4184af480f29eb3ef41173fe5edc5307f263d0b0
2025-03-19 21:28:37 -04:00
Federico Baron 896f1a66bf Add screenrecord for TaplUninstallRemoveTest#testUninstallFromAllApps
Flag: EXEMPT test only
Test: TaplUninstallRemoveTest#testUninstallFromAllApps
Bug: 386231522
Change-Id: Ic1f0f343153b2052438ea8ea6b9d84c429f844c1
2025-03-19 21:57:29 +00:00
Sunny Goyal 25f5c7e761 Making ModelDbController injectable
Bug: 361850561
Test: Updated tests
Flag: EXEMPT dagger
Change-Id: Ie600469476ce5eb60813a3c8b57b9445fcf82c24
2025-03-13 11:23:23 -07:00
Treehugger Robot ace69f7644 Merge "Making various model objects injectable" into main 2025-03-11 14:48:30 -07:00
Sunny Goyal 42975c39db Making various model objects injectable
Bug: 361850561
Test: Updated tests
Flag: EXEMPT dagger
Change-Id: Ibb45b72c186e6aeeed7a37b0ae3f8083472019d7
2025-03-10 14:37:43 -07:00
Treehugger Robot 313d7e1ce3 Merge "Revert "Add screenrecord for uninstallWorkspaceIcon"" into main 2025-03-10 13:36:11 -07:00
Federico Baron 8dcf879c14 Revert "Add screenrecord for uninstallWorkspaceIcon"
This reverts commit 66999f0a19.

Reason for revert: no longer an issue

Change-Id: I55a045846825e6b62fac4a9ed59380620870e953
2025-03-10 11:26:15 -07:00
Sebastian Franco aeb99f8d24 Moving zip rule to Multivalent to fix roboelectric test in A-studio
This fixes roboelectric test Running in Android Studio.

Bug: 390496167
Flag: TEST_ONLY
Test: all dumpTest
Test: Running roboelectric test in Android Studio
Change-Id: I903c6cea3c981a9c38cfcd05b54e4095b6fe2a8a
2025-03-07 11:56:45 -08:00
Sebastián Franco 2bab5687b0 Merge "Enabling Fixed Landscape in Launcher3 tests" into main 2025-03-06 15:06:03 -08:00
Treehugger Robot 3a000d06fa Merge "Revert "Ignore the tests temporarily."" into main 2025-03-06 13:09:43 -08:00
Federico Baron 7610b9c17f Revert "Ignore the tests temporarily."
This reverts commit de0d4498c8.

Reason for revert: b/353505773 seems to have rolled out 

Change-Id: I3ddcdb1b2de2cfd07e12af284f1f784996f82623
2025-03-06 10:58:12 -08:00
Sebastian Franco c9f6668ab1 Add all the dumpt test results into a zip in artifacts
Bug: 390496167
Flag: TEST_ONLY
Test: all dumpTest
Test: dump files should now be available in test artifacts
Change-Id: Ic77b75f7792bc511e364a6af697eb1282ad49ab3
2025-03-04 13:16:47 -08:00
Sebastian Franco 331fd2dac6 Enabling Fixed Landscape in Launcher3 tests
Bug: 398279312
Test: Any test using PortraitLandscapeRunner
Test: IntegrationFixedLandscape
Flag: com.android.launcher3.one_grid_specs
Change-Id: I5a1801374f39381e678e764f8e417cf0f8bf6ad7
2025-03-04 13:15:26 -08:00
Sunny Goyal 372c483eda Merge "Moving widgetFilter to dagger" into main 2025-03-04 09:03:10 -08:00
Treehugger Robot f42f516621 Merge "Remove unused spec in device_profiles.xml" into main 2025-03-03 17:24:20 -08:00
Federico Baron d8f0bed596 Remove unused spec in device_profiles.xml
Bug: 395912263
Flag: com.android.launcher3.one_grid_specs
Test: n/a, code cleanup
Change-Id: Ifd1ecf905427902f895a1b4e16711874fd52ddf3
2025-03-03 18:35:10 +00:00
Sunny Goyal 5025b9ab04 Moving widgetFilter to dagger
Moving widget filtering to UI layer as it changes with surface

Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: I9d9377540ca36873659cea4ecc91fb162d82cd44
2025-03-03 10:27:14 -08:00
Federico Baron 66999f0a19 Add screenrecord for uninstallWorkspaceIcon
Bug: 399756302
Flag: EXEMPT TEST_ONLY
Test: TaplUninstallRemoveTest
Change-Id: I4bdf8087276a93f8f736c23ba95f35acb7f05c3a
2025-02-28 21:27:07 +00:00
Treehugger Robot 087e54c81c Merge "Removing temporary debug tracing" into main 2025-02-24 14:55:05 -08:00
Sunny Goyal b1fab90e26 Enforcing grid customization permission in manifest instead of code
Bug: 389173244
Test: Updated tests
Flag: EXEMPT manifest change
Change-Id: I0fee57f935156da6b2b5a612259db2c4b3605846
2025-02-24 10:40:43 -08:00
Sunny Goyal c9f697aeb5 Converting LauncherAppState to Dagger
Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger

Change-Id: I336a233d2703c23a7e9065474bde471786886144
2025-02-20 19:13:49 -08:00
Sunny Goyal db724a010c Removing temporary debug tracing
Bug: 378167329
Flag: EXEMPT bugfix
Test: Presubmit
Change-Id: I06ed0d96a83c13b1bce9aff8e2e21fa1510bc4c2
2025-02-20 12:26:35 -08:00
Owner Cleanup Bot a5d9e8a600 Merge "[owners] Remove zakcohen@google.com from tests/src/com/android/launcher3/widget/picker/OWNERS" into main am: c3a2e87058 am: aa4f86641c
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/3490672

Change-Id: Ic91f4281f7e12f23046a7e739830c5d76dbeccb5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-02-18 14:33:03 -08:00
Charlie Anderson 3487ef52f2 Merge "Temporarily disable shapes flag in image and device dump tests." into main 2025-02-18 10:14:11 -08:00
Charlie Anderson 24e65da8b3 Temporarily disable shapes flag in image and device dump tests.
Will re-enable after more shapes changes, as part of b/396211437

Bug: 396211437
Bug: 395952745
Flag: com.android.launcher3.enable_launcher_icon_shapes
Test: Presubmit
Change-Id: Ib0c85167df2723632adce9dadae718a2a1b7b757
2025-02-14 15:14:19 -05:00
Anushree Ganjam 5a8fcc3d40 Merge "Refactor TestEmitter and it doesn't need to be MainThreadInitializedObject" into main 2025-02-14 10:35:40 -08:00
Anushree Ganjam 7128c6fcfb Refactor TestEmitter and it doesn't need to be MainThreadInitializedObject
Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger

Change-Id: I30e7c3c165db698785e9e4d7e2256ab061ff71a2
2025-02-13 15:20:17 -08:00
Charlie Anderson 527be0c133 Temporarily disable shapes flag for tests that it breaks.
- when done with breaking changes will update tests as part of b/396211437

Bug: 395952745
Bug: 396211437
Flag: com.android.launcher3.enable_launcher_icon_shapes
Test: Presubmit

Change-Id: I461f6834932a710efa439a112bce23359aee13de
2025-02-13 09:32:52 -08:00
Owner Cleanup Bot 40e6a538ab [owners] Remove zakcohen@google.com from tests/src/com/android/launcher3/widget/picker/OWNERS
This suggested change is automatically generated based on group
memberships and affiliations.
If this change is unnecessary or in error, vote the lowest CR value
(i.e. reject the CL) and the bot will abandon it. Vote the highest CR to
approve this change. You may also abandon this change.

See the owner's recent activity for context:
https://android-review.googlesource.com/q/zakcohen@google.com

To report an issue, file a bug in the Infra>Codereview component.

Change-Id: I012d61af6b55dd1ae2f00be846af393bc7bc2f38
2025-02-11 16:03:09 -08:00