Anushree Ganjam
18b120dce4
Merge "Implement ImpressionLogging v2." into udc-qpr-dev am: 4cd4ed090e am: 935e03400e
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24016221
Change-Id: Ic2ddc5b8486430b485ba5924cfd0a4f22e6248dc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-20 00:19:30 +00:00
Anushree Ganjam
935e03400e
Merge "Implement ImpressionLogging v2." into udc-qpr-dev am: 4cd4ed090e
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24016221
Change-Id: I5d0c6b19dcaaac32b9470a9f0d7b9559532f5f70
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-19 23:37:43 +00:00
Anushree Ganjam
4cd4ed090e
Merge "Implement ImpressionLogging v2." into udc-qpr-dev
2023-07-19 23:17:10 +00:00
Sunny Goyal
bb50f3cd8e
Fixing ViewCaptureRule not unregistered if activity is destroyed
...
Bug: 291638593
Test: Presubmit
Flag: N/A
Change-Id: I86daf9fac210340b037d376d882ac5872c596ae4
2023-07-19 16:14:47 -07:00
Vinit Nayak
247ab6aabd
Merge changes Ib1728d85,Ia5683a28 into udc-qpr-dev am: 45c11ade08 am: 769e39b0ce
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24122626
Change-Id: I8bdf689f3e833a093f533a8ad225e5e11925fb35
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-19 21:29:55 +00:00
Vinit Nayak
769e39b0ce
Merge changes Ib1728d85,Ia5683a28 into udc-qpr-dev am: 45c11ade08
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24122626
Change-Id: Id21625d485eb1a96a90bf478d9eb5d155990f9f1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-19 21:25:51 +00:00
Liran Binyamin
60240207bb
Handle the event of first bubble added.
...
When the first bubble is added we set the visibility of the bubble bar
to VISIBLE if the stash controller is unstashed. The issue is that once
bubbles are gone we no longer update the stash state in the controller,
so it becomes stale and can't be used when the first bubble is added.
This change introduces a new method for handling the transition from
the state where both bar and handle are invisible into the state where
one of them becomes visible. We can't use the existing stashBubbleBar
and showBubbleBar methods because those transition from one to the other.
Using them when both are invisible results in one of them becoming visible
and then invisible again.
Fixes: 290992144
Fixes: 291074646
Test: Manual:
- Add bubble in the test app by double-tapping on a chat (non expanding notification)
- Observe that the handle becomes visible and the bar is invisible
- Dismiss bubble
- Add bubble in the test app by tapping on the button on the right (auto expanding)
- Observe that the bar becomes visible and expanded
Change-Id: I61334c67c255a6ed074fa8c834f4a5a1547539bf
2023-07-19 17:02:57 -04:00
Vinit Nayak
45c11ade08
Merge changes Ib1728d85,Ia5683a28 into udc-qpr-dev
...
* changes:
Add test logs for animating in split launch
Add granular transition names for launching split
2023-07-19 20:56:30 +00:00
Pat Manning
d1bac73daa
Merge "Sends user home when stashed taskbar handle is clicked." into udc-qpr-dev am: d35d630745 am: c80ec22cb1
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23728944
Change-Id: I9a6026ed1044bc0667837838d56f1c1c8a436540
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-19 19:10:05 +00:00
Jeremy Sim
6dd6145d0a
Merge "Fix order invariance when checking for GroupedTaskViews" into udc-qpr-dev am: 6779101b26 am: 9440f98af2
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24120730
Change-Id: I9e346805f66fbaed489390243715c0c30b76173a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-19 19:09:24 +00:00
Pat Manning
c80ec22cb1
Merge "Sends user home when stashed taskbar handle is clicked." into udc-qpr-dev am: d35d630745
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23728944
Change-Id: I85c33fbae2e70e5b8576e7345bbea60f62ba246a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-19 18:30:15 +00:00
Jeremy Sim
9440f98af2
Merge "Fix order invariance when checking for GroupedTaskViews" into udc-qpr-dev am: 6779101b26
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24120730
Change-Id: Idb1f730af891f6c6089571c9298463ddf648dd8c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-19 18:29:54 +00:00
Pat Manning
d35d630745
Merge "Sends user home when stashed taskbar handle is clicked." into udc-qpr-dev
2023-07-19 18:24:06 +00:00
Jeremy Sim
6779101b26
Merge "Fix order invariance when checking for GroupedTaskViews" into udc-qpr-dev
2023-07-19 18:13:35 +00:00
Jeremy Sim
ca4c321ffe
Fix order invariance when checking for GroupedTaskViews
...
This patch makes it so that Overview will return the correct GroupedTaskView even when the set of taskIds passed in is in the opposite order.
Previously, we didn't account for order variation when checking for a GroupedTaskView, which would cause bugs when the GroupedTaskView had had its ordering swapped.
Fixed by modifying getTaskViewByTaskIds() to return true even if the order of ids was swapped.
Fixes: 290135090
Test: Manual
Change-Id: I2d94fadfee3cd478801b25cdbc699295179c8bd1
2023-07-19 11:06:34 -07:00
Liran Binyamin
51a4453f60
Merge "Check that a bubble exists before reordering it" into udc-qpr-dev am: 0706a81907 am: 85bfb4fa90
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24119403
Change-Id: I32e147765ca617be9ec725939b6547f1c7791bd7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-19 15:29:39 +00:00
Liran Binyamin
85bfb4fa90
Merge "Check that a bubble exists before reordering it" into udc-qpr-dev am: 0706a81907
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24119403
Change-Id: I0cba344c8834f1cf3c2e9a172b38bb1255c5534f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-19 14:46:37 +00:00
Liran Binyamin
0706a81907
Merge "Check that a bubble exists before reordering it" into udc-qpr-dev
2023-07-19 13:39:55 +00:00
Pat Manning
6a4e491da1
Prevent showing action button edu tooltip in grid only overview.
...
Fix: 291232225
Test: OverviewActionsControllerTest.
Flag: ENABLE_GRID_ONLY_OVERVIEW
Change-Id: I3d2881fea26ddfdda8540e3609733f6261e40458
2023-07-19 12:26:35 +01:00
Vinit Nayak
3d293c432a
Add test logs for animating in split launch
...
Bug: 288939273
Change-Id: Ib1728d859f33fa3f673f67eca754ec9813b0562b
2023-07-18 17:19:29 -07:00
Vinit Nayak
993c311bb7
Add granular transition names for launching split
...
Bug: 288939273
Test: Compiles
Flag: None
Change-Id: Ia5683a281786901a41fc1c6dba1bca408410910a
2023-07-18 17:19:29 -07:00
Anushree Ganjam
a9645535b8
Implement ImpressionLogging v2.
...
Deprecate V1 implementation and keep only V2.
Bug: 285964742
Test: Manual
Flag: NA
Change-Id: If27f02f7142abf7960f74252d1e46bcd8c5b5e2a
2023-07-18 21:56:28 +00:00
Liran Binyamin
36325fd9d7
Check that a bubble exists before reordering it
...
This avoids re-adding bubbles that have already been removed
after dismissing multiple bubbles at once.
Fixes: 291738088
Test: Manual
- Add 2 bubbles A and B to the bubble bar
- Expand the bubble bar
- Tap 3 dot menu and dismiss
- Repeat for the next bubble
- Observe that bubble bar is gone
- Add a new bubble C
- Observe that the bubble bar contains only bubble C
Change-Id: Id53811a103d245647489ab8d442cbb2004e0e700
2023-07-18 15:42:56 -04:00
Bill Yi
31855be8d4
Import translations. DO NOT MERGE ANYWHERE
...
Auto-generated-cl: translation import
Change-Id: I3dc01f06b2302cea0b5435a745e0e96c8a465bea
2023-07-18 11:56:05 -07:00
Vinit Nayak
7027f334cb
Merge "Keep track of multiple TasksIDs and Targets in GestureState" into udc-qpr-dev am: 80fddb6e40 am: 3ae98b4507
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23680185
Change-Id: Id66d6c87c2ace41a8fe05ba9bc47ad56f396dc69
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-18 04:08:50 +00:00
Vinit Nayak
78207fd80b
Change split toast exit asset to "X"
...
* TODO: Probably need to change tint based on theme
Bug: 276361926
Flag: ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE
Test: Shows up as expected
Change-Id: I28a2eefa115cb15aab560d750103c7946639c18b
2023-07-17 20:19:16 -07:00
Vinit Nayak
3ae98b4507
Merge "Keep track of multiple TasksIDs and Targets in GestureState" into udc-qpr-dev am: 80fddb6e40
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23680185
Change-Id: I9fdab12585372479545ef431a85548e872200115
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-18 03:18:27 +00:00
Vinit Nayak
80fddb6e40
Merge "Keep track of multiple TasksIDs and Targets in GestureState" into udc-qpr-dev
2023-07-18 02:47:39 +00:00
Vinit Nayak
f5ea7390dc
Merge "Show split select instructions toast when starting split on workspace" into udc-qpr-dev am: b9a5c4551f am: 0a4e37506e
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24062180
Change-Id: Iec48c62a4b1c973bc25639a59ce53605c89d58e2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-17 23:15:31 +00:00
Schneider Victor-tulias
5a50c877c8
Merge "Fix null pointer in createRecentsWindowAnimator." into udc-qpr-dev am: 5c825f4cda am: 78d0cdde1f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24056554
Change-Id: I431666b003b90c65421a18194a856a9c66d1af7a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-17 23:15:19 +00:00
Vinit Nayak
0a4e37506e
Merge "Show split select instructions toast when starting split on workspace" into udc-qpr-dev am: b9a5c4551f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24062180
Change-Id: Ifac48dc2f1cbf06506ec4c59003e2224aba060ee
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-17 22:35:37 +00:00
Schneider Victor-tulias
78d0cdde1f
Merge "Fix null pointer in createRecentsWindowAnimator." into udc-qpr-dev am: 5c825f4cda
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24056554
Change-Id: I5be8df549f9b476fb65bedf55dee0e2ae5d7f012
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-17 22:34:15 +00:00
Vinit Nayak
b9a5c4551f
Merge "Show split select instructions toast when starting split on workspace" into udc-qpr-dev
2023-07-17 22:11:36 +00:00
Alex Chau
1cdf7a72e6
Merge "Clean-up b/260135164 logs" into udc-qpr-dev am: 7d89646585 am: bd0269207f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24058374
Change-Id: Ib8c8cc222924e43f35945c8dfb3e47656af9479e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-17 21:59:23 +00:00
Brian Isganitis
7913080166
Merge "Initial Taskbar drag-n-drop support for search results." into udc-qpr-dev am: 3f0e7e7c5d am: 22bc9983ed
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24011563
Change-Id: I58e7edc548d4691bcc912579f4c5778e8f59685e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-17 21:55:14 +00:00
Pat Manning
73f0772669
Merge "Show tooltips on cursor hover of taskbar icons." into udc-qpr-dev am: f351e515f7 am: f2aa70c477
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23369318
Change-Id: I3a15b72ec49c4c6e22fda6ba9c61bed7338c428a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-17 21:54:43 +00:00
TreeHugger Robot
d22aebd2af
Merge "Clean up SplitData refactor flag" into udc-qpr-dev am: 61c2bbe5b8 am: 42064106ba
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24082168
Change-Id: I93fc98cdf01c25de263fc38fbc8402b39f884993
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-17 21:53:45 +00:00
Schneider Victor-tulias
5c825f4cda
Merge "Fix null pointer in createRecentsWindowAnimator." into udc-qpr-dev
2023-07-17 21:43:12 +00:00
Vinit Nayak
e7e7a6e522
Keep track of multiple TasksIDs and Targets in GestureState
...
* Quickswitching between fullscreen and split tasks breaks split,
need that to be fixed to further test these code changes
Bug: 236226779
Change-Id: I332ad6e2d98760ec1d691dae76e8e3ab8b839c75
2023-07-17 14:37:06 -07:00
Alex Chau
bd0269207f
Merge "Clean-up b/260135164 logs" into udc-qpr-dev am: 7d89646585
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24058374
Change-Id: I859fc1a2652070b5bdea3de55a9910cacb5b0933
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-17 19:35:25 +00:00
Alex Chau
7d89646585
Merge "Clean-up b/260135164 logs" into udc-qpr-dev
2023-07-17 18:32:46 +00:00
Brian Isganitis
22bc9983ed
Merge "Initial Taskbar drag-n-drop support for search results." into udc-qpr-dev am: 3f0e7e7c5d
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24011563
Change-Id: I6838291da55f690898946094c5a6e8ece27a4d3b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-17 17:38:02 +00:00
Brian Isganitis
3f0e7e7c5d
Merge "Initial Taskbar drag-n-drop support for search results." into udc-qpr-dev
2023-07-17 17:08:15 +00:00
Alex Chau
625709617e
Clean-up b/260135164 logs
...
Fix: 271242509
Test: manual
Change-Id: I2c5421539f8f70897b142dfdaa6bc97a10225309
2023-07-17 15:30:31 +01:00
Pat Manning
f2aa70c477
Merge "Show tooltips on cursor hover of taskbar icons." into udc-qpr-dev am: f351e515f7
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23369318
Change-Id: I5f5e14c6d79a1c393ce04bae663aec1282296396
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-17 10:51:19 +00:00
Pat Manning
f351e515f7
Merge "Show tooltips on cursor hover of taskbar icons." into udc-qpr-dev
2023-07-17 10:15:46 +00:00
Vinit Nayak
5f09091583
Show split select instructions toast when starting split on workspace
...
* Used same animation properties that RecentsView uses to
show the instructions view unfolding
* TODOs:
* UI polish (correct asset, animation timings, etc)
* Hook into existing animations (if possible)
* Migrate recentsView splitInstructionsView to use same/similar code path;
remove RecentsView#safeRemoveDragLayerView
Bug: 276361926
Test: Create split w/ and w/o flag, works as expected
Flag: ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE
Change-Id: I7a51b71c358902399ad73b650287cdbf1dad07c6
2023-07-14 17:49:42 -07:00
TreeHugger Robot
42064106ba
Merge "Clean up SplitData refactor flag" into udc-qpr-dev am: 61c2bbe5b8
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24082168
Change-Id: Ie3a5fbf2967a7acd2ccdc41ed64697ad81a09518
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-07-15 00:36:51 +00:00
Bill Yi
eb9d20f37d
Merge "Import translations. DO NOT MERGE ANYWHERE" into main
2023-07-15 00:10:20 +00:00
TreeHugger Robot
61c2bbe5b8
Merge "Clean up SplitData refactor flag" into udc-qpr-dev
2023-07-14 23:25:27 +00:00