Commit Graph

17011 Commits

Author SHA1 Message Date
Thales Lima a40adc925f Merge changes from topic "cherrypicker-L55500000962914710:N74000001402311199" into main
* changes:
  Create new hotseat spec tests
  Add new attribute to hotseat specs
2023-09-06 13:24:02 +00:00
Brandon Dayauon cc9a529293 Merge "Add nullable annotation" into udc-qpr-dev am: 31679166a7 am: b33d906d87
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24544468

Change-Id: I21f2072984d2620a0012180ea8ef0ffc1f78c110
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-05 18:59:17 +00:00
Brandon Dayauon 31679166a7 Merge "Add nullable annotation" into udc-qpr-dev 2023-09-05 16:50:38 +00:00
Thales Lima 8e11d531e8 Add new attribute to hotseat specs
Edge padding is used as the space between hotseat and the edge of the screen. In most cases it is used in a height spec, but for vertical bar, i.e. when a handheld is in landscape, it is used a width spec.

Fix: 292204436
Test: CalculatedHotseatSpecTest
Test: HotseatSpecsTest
Test: DeviceProfileResponsiveAlternativeDisplaysDumpTest
Test: DeviceProfileResponsiveDumpTest
Flag: ENABLE_RESPONSIVE_WORKSPACE
Change-Id: Ib75ffcdd33925ee9ef156dcb70eefd133c9b458b
2023-09-05 16:31:06 +01:00
Andy Wickham 733e116f94 Merge "Remove unnecessary hide keyboard call in onKeyPreIme." into udc-qpr-dev am: fd14de35c8 am: f1475596bc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24560115

Change-Id: If06c2776bf06a67fd908ee00a106f59880856087
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-31 23:37:21 +00:00
Andy Wickham fd14de35c8 Merge "Remove unnecessary hide keyboard call in onKeyPreIme." into udc-qpr-dev 2023-08-31 21:43:21 +00:00
Brandon Dayauon 75d8994e6f Add nullable annotation
It looks like from the stack trace that there is an NPE during the setApps() call. So adding nullable and null checking
to make sure mApps is not null.

bug: 296920692
test: presubmit
flag: n/a
Change-Id: If402c0b68db159f7a698e8e2e139d9bd5041b1c1
2023-08-31 13:59:13 -07:00
Federico Baron 62b4fa7a77 Merge "Fix bug where suggested widget overlaps widget list" into udc-qpr-dev am: c207167124 am: dd15270625
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24606284

Change-Id: I29a2bf71a88f856bd8daeea20393ee966c9ac33a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-31 20:24:16 +00:00
Anushree Ganjam 20bbe42cad Merge "Remove the test aconfig lib." into main 2023-08-31 19:24:23 +00:00
Federico Baron c207167124 Merge "Fix bug where suggested widget overlaps widget list" into udc-qpr-dev 2023-08-31 18:52:44 +00:00
Treehugger Robot c1ad48386c Merge "Add widget layout transition when resizing" into main 2023-08-31 16:56:22 +00:00
fbaron 5a190c5efe Fix bug where suggested widget overlaps widget list
We scroll to top when rotating device, which is a behavior that aligns with other AbstractSlideInView's like allApps

Fix: 293203839
Test: verify that when rotating in widget sheet that the suggested widget no longer overlaps with widget list
Flag: no-flag
Change-Id: Icf021a46ae2c2b85b4c55e40cbd2f7e70f83c248
2023-08-31 09:18:52 -07:00
Charlie Anderson d48f89be9d Merge "Remove ENABLE_MATERIAL_U_POPUP flag and cleanup dead code" into main 2023-08-31 15:09:25 +00:00
Vadim Tryshev 2ba6ef0cb0 Merge "Removing verifying touch events in TAPL" into udc-qpr-dev am: b75add7a5f am: 9734478ec8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24588973

Change-Id: I60a751986bf753588b4415e5a1429cf88027fc69
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-30 23:25:08 +00:00
Sihua Ma 324d3b0fdc Add widget layout transition when resizing
Also getting rid of part of the logic that updates the frame size in multi-window mode since multi-window is no longer supported

Test: N/A
Bug: 268553314
Flag: ENABLE_WIDGET_TRANSITION_FOR_RESIZING. OFF
Change-Id: I081b11441b562fccec7feb12cec0b28b9a0ea3a2
2023-08-30 22:41:13 +00:00
Anushree Ganjam 2a14b978c6 Remove the test aconfig lib.
zhidou@ from ACE team is working on AConfigFakelib which will be useful
to set fake flag values in both unit tests and UI automator tests.
Meanwhile, we will mock the flag values for unit tests and UI automator
tests will have all flags values defaulted to false.

testAConfigLib with "test:true" doesn't generate fake flags values and
forces us to set the flag values using "SetFlagsRule". "SetFlagsRule"
doesn't work with Out Of Proc tests and hence doesn't serve the purpose
for us. AConfigFakelib and FakeFlagTargetPreparer should use for Out Of
Proc tests.

testAConfigLib with "test:true" is suitable for java host tests where
there is no device involved. Launcher tests are instrumentation tests and tests run on actual
devices. So we can use the production version of the AConfig lib and device
config flag values will be fetched for UI Automator tests.

Also migrating "enable_twoline_allapps" to trunk stable. Unit tests is
using mockito to mock the flag value as false. The owner of
"enable_twoline_allapps" can mock the value to true in unit tests as
next step.

Bug: 294913042
Test: Local studio build and soong build
Flag: enable_twoline_allapps

Change-Id: Iea42bf18197832a9ecbddc1c3aaa8c9e36169131
2023-08-30 15:20:51 -07:00
Vadim Tryshev 0e97dff0da Removing verifying touch events in TAPL
They are perceived to produce too much noise and maintenance.

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I062eb5670a92a2ccc7039108829b09ca9d9127ae
2023-08-30 13:57:18 -07:00
Charlie Anderson 69524513db Remove ENABLE_MATERIAL_U_POPUP flag and cleanup dead code
- removes a lot of dead code for the old popup design and especially around adding notifications to popups
- renames several resource files to remove the material_u specification, as it is now the only design

Test: manually run through launcher popups
Bug: 270395516
Flag: ENABLE_MATERIAL_U_POPUP
Change-Id: I462063482206578b4b896a6d405dc2383f2da510
2023-08-30 20:40:25 +00:00
Sukesh Ram 3f2338a8e8 Remove Windowing Prototype 1 from Codebase
Refactor codebase to remove Proto1 as it is no longer supported.

Test: aTest WMShellUnitTests
Bug: 297217817
Change-Id: Ifaf67754c048d913fe203f4b34efc3c9c611039c
2023-08-30 17:40:13 +00:00
Charlie Anderson 3f8ce20b61 Merge "Move AppWidgetsRestoredReceiver methods to enable adding tests for restoring widget Ids" into main 2023-08-29 18:30:08 +00:00
Treehugger Robot 5d5c7d9644 Merge "Add logs around hotseat suggested apps" into udc-qpr-dev am: 41d269a43b am: cde39e3cfd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24529027

Change-Id: I04f52c10ad56418d64d39cc1ec2cd083f4c4ce6c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-29 17:48:04 +00:00
Pat Manning 42895a1e73 Merge "Scale Launcher folders on hover." into udc-qpr-dev am: 0ff8103c66 am: 9ab2e7613a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24295554

Change-Id: I97f33dcad68d13e63c198bf7e1a409be4bdf95af
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-29 17:47:34 +00:00
Anushree Ganjam 9d01e1a7f8 Merge "Move aconfig files to aconfig folder" into main 2023-08-29 17:42:16 +00:00
Anushree Ganjam 8a6b74e51b Move aconfig files to aconfig folder
- Set packageName as com.android.launcher3
- Follow folder structure as per go/sysui-aconfig-structure

Bug: 294913042

Test: adb shell device_config put launcher com.android.launcher3.enable_all_apps_rv_preinflation true

Flag: enable_all_apps_rv_preinflation

Change-Id: Ib45a24d9100b657e7776c6120bdf9625533e9ed7
2023-08-28 18:27:11 -07:00
Treehugger Robot 41d269a43b Merge "Add logs around hotseat suggested apps" into udc-qpr-dev 2023-08-28 23:09:44 +00:00
Matt Sziklay e9dd0d6d49 Merge "Specify stage and bounds for desktop split." into udc-qpr-dev am: 8020100928 am: a5e28a3af2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24376138

Change-Id: I6283b096a6e3f03204c37bb67446318d8a5dff9b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-28 20:18:24 +00:00
Charlie Anderson 5f263a7ae1 Move AppWidgetsRestoredReceiver methods to enable adding tests for restoring widget Ids
Bug: 294386159
Test: Ran unit tests locally
Change-Id: Ib9657e6a0faa876197e0106b8729dcc606562d09
2023-08-28 11:08:12 -04:00
Andy Wickham 336c6669b0 Remove unnecessary hide keyboard call in onKeyPreIme.
The default handling of back in this preIme case already closes
the keyboard if we return false, so adding it before our own key
handling was stomping on our existing syncronized keyboard.

We should still handle other cases where the system ime animation
coincides with our control, but we at least shouldn't force it on
ourselves.

This fixes the back issue in 3 button mode, and also closes all
apps on the first back gesture as intended (if you hadn't entered
0 state that is).

Demo after fix: https://drive.google.com/file/d/1pK18iEdgxQ0HQmilAMFzn66LVyCH5Ma1/view?usp=drive_link&resourcekey=0-kW4BOC-Pj-wZ_DZL51z6Rg

Bug: 270144901
Bug: 277738379
Test: Manual with 3 button mode and gesture nav, with always on
keyboard on and off
Flag: N/A

Change-Id: I9b1c525494b49cde3307df8b0a73d6143ac9c616
2023-08-25 17:26:33 -07:00
Pat Manning 0ff8103c66 Merge "Scale Launcher folders on hover." into udc-qpr-dev 2023-08-25 22:23:20 +00:00
Matt Sziklay 8020100928 Merge "Specify stage and bounds for desktop split." into udc-qpr-dev 2023-08-25 20:50:59 +00:00
Pat Manning cc0d8919ee Scale Launcher folders on hover.
Bug: 243191650
Test: PreviewBackgroundTest
Flag: ENABLE_CURSOR_HOVER_STATES
Change-Id: I8035501203af5c2d97b62cc79e576303e57f8b99
2023-08-25 20:02:23 +01:00
Vinit Nayak ddc9d5eb73 Merge "Add back gesture support when split selection active" into main 2023-08-24 22:27:39 +00:00
Anushree Ganjam 29e1e61e07 Merge "Add Launcher aconfig." into main 2023-08-24 22:03:18 +00:00
fbaron 6707ddd016 Add logs around hotseat suggested apps
Bug: 295892343
Test: n/a
Flag: no flag
Change-Id: Id6f464c8614317f58f6886734ad1f9b9709d6aa3
2023-08-24 11:15:46 -07:00
Anushree Ganjam d1a28fe08d Add Launcher aconfig.
Use `enable_expanding_pause_work_button` as an example.

See go/trunk-stable-launcher for implementation details

Bug: 294913042

Test: adb shell device_config put launcher com.google.android.platform.launcher.aconfig.flags.enable_expanding_pause_work_button true

Flag: enable_expanding_pause_work_button
Change-Id: I732722c8b219c023adf5bf31f132ce9da72fc4d5
2023-08-24 11:11:02 -07:00
Vinit Nayak 654604037a Add back gesture support when split selection active
* Currently this exits the current launcher state
back to homescreen whenever back is performed while
split selection is active.
* Open UX question if that needs to be changed.

Test: Did back gesture from workspace, overview, all apps
http://recall/-/cMb5xTTxhmZtFt04eYnmQj/g0kpGTsqlj0RSt4OfDBkpf
Bug: 295449659
Flag: ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE
Change-Id: I74fe51aaf4301fb723d2e69e6b1b39d127f492d8
2023-08-24 17:52:37 +00:00
Pat Manning 3bf51bac77 Merge "Do not clip scaled Launcher icons on hover." into udc-qpr-dev am: 77dce5f27a am: 7f1968f948
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24210851

Change-Id: Icf2eeefd9f37fd30edf6a6c039568d6de4df3b60
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-24 12:54:09 +00:00
Kevin Lim 898a7ccbd9 Merge "[NexusLauncher] Expose setLayoutHorizontal." into udc-qpr-dev am: ceab9a2c85 am: 6cd69b0e9e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24156948

Change-Id: Icdb67a085616c599ffe2f0304711d0b4c756a67a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-24 12:53:44 +00:00
Treehugger Robot 652f66d9d0 Merge "Adding CannedAnimationCoordinator to enable running a predefined animation in Launcher" into udc-qpr-dev am: 1d235fca54 am: d1c514f863
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24487141

Change-Id: Ied18ff8d6d99545545da03b03771261f6c368cef
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-24 12:53:14 +00:00
Treehugger Robot 904590a4a4 Merge "Re-enable ALL_APPS_GONE_VISIBILITY and ENABLE_ALL_APPS_RV_PREINFLATION" into udc-qpr-dev am: 05776a707d am: 8b3a1b62b0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24516480

Change-Id: I5ab5e96cf1291dcc7f17040f9e1b5f2061e27a10
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-24 12:52:06 +00:00
Pat Manning 77dce5f27a Merge "Do not clip scaled Launcher icons on hover." into udc-qpr-dev 2023-08-23 22:24:40 +00:00
Kevin Lim ceab9a2c85 Merge "[NexusLauncher] Expose setLayoutHorizontal." into udc-qpr-dev 2023-08-23 21:29:49 +00:00
Treehugger Robot 1d235fca54 Merge "Adding CannedAnimationCoordinator to enable running a predefined animation in Launcher" into udc-qpr-dev 2023-08-23 20:28:04 +00:00
Jordan Silva 6a5f5bb962 Merge "Fix hotseat border space crash GSI" into udc-qpr-dev am: c6b6a4f3d5 am: f17a1d43f3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24464809

Change-Id: Ia2784fb0bb345b988be15f32492064768881b1fd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-23 20:06:05 +00:00
Sebastián Franco 2cde130da8 Merge "Remove odd screen ids when isTwoPanels is true" into udc-qpr-dev am: 2c9a2f2353 am: 4c366730a0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24216066

Change-Id: Ib18557bedda11c0722c49577bb1b2ff2b2fafae0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-23 19:55:55 +00:00
Treehugger Robot 05776a707d Merge "Re-enable ALL_APPS_GONE_VISIBILITY and ENABLE_ALL_APPS_RV_PREINFLATION" into udc-qpr-dev 2023-08-23 19:26:40 +00:00
Kevin Lim b3b467c27f [NexusLauncher] Expose setLayoutHorizontal.
mLayoutHorizontal is exposed so that classes that extend BubbleTextView
can override this programmatically based on LayoutType.

mLayoutHorizontal prevents the title in horizontal cases affecting the
icon bounds measure, and shifting things such as the icon halo.

Bug: b/288471727
Test: See ag/24199217
Test: New tests in SearchResultIconTest
Test: No regression in SearchResultSmallIconRowTest
Change-Id: I424c1597d29ed26d7dea9e666ff2d274847e3217
2023-08-23 19:13:59 +00:00
Fengjiang Li d28bada405 Merge "Revert "Turn on ENABLE_ALL_APPS_RV_PREINFLATION and ALL_APPS_GONE_VISIBILITY for udc-qpr branch"" into udc-qpr-dev am: 053c11a344 am: 0e3893af19
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24514676

Change-Id: I3816bfc7bcf6bfec90ee7ce4733ff49052a3ea76
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-23 18:39:21 +00:00
Fengjiang Li 63878fbd2b Merge "Turn on ENABLE_ALL_APPS_RV_PREINFLATION and ALL_APPS_GONE_VISIBILITY for udc-qpr branch" into udc-qpr-dev am: 2474a8c1fb am: edb42db791
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24499161

Change-Id: If6584aadd63ff44588a23338739172b80f6a99af
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-23 18:19:38 +00:00
Jordan Silva c6b6a4f3d5 Merge "Fix hotseat border space crash GSI" into udc-qpr-dev 2023-08-23 18:11:03 +00:00