Commit Graph

18365 Commits

Author SHA1 Message Date
Fengjiang Li a3e89b0cd2 Merge "Log warning when UserHandle in UserManagerState#allUsers get overridden" into main 2024-05-17 05:56:12 +00:00
Fengjiang Li 172e454e2c Log warning when UserHandle in UserManagerState#allUsers get overridden
Bug: 340362067
Test: manual
Flag: NONE
Change-Id: I123f02f52408db0f7c711ee420743ac01df04156
2024-05-16 13:59:47 -07:00
Treehugger Robot 7ca8954796 Merge "Clean up some old (pre-aconfig) flags." into main 2024-05-16 18:37:43 +00:00
Luca Zuccarini 2d3dae75be Clean up some old (pre-aconfig) flags.
These have been enabled for a long time and are safe to remove.

Fix: 270394392
Fix: 270394041
Flag: NONE removing an old flag
Test: everything still works as expected (no-op change)
Change-Id: Id5fc356a29a7e85324a8c3f922709251f371b2c5
2024-05-16 16:43:27 +00:00
Alex Chau ed9e3a8701 Merge "Convert TaksView to Kotlin" into main 2024-05-16 14:00:02 +00:00
Charlie Anderson a8058669d5 Merge "Adding additional logging around updated shortcuts" into main 2024-05-16 13:52:02 +00:00
Alex Chau 9565667813 Convert TaksView to Kotlin
- PS1: Android Studio conversion (unformatted, cannot compile)
- PS2: Fix compilation issues and formatting
- PS3: First pass ready for review
- PS4: Minor changes (Remove Consumer, remove unnecessary null-checks)
- PS5: Removed check() around taskContainers, which is now lateinit and should always be initiailzed. Also ensure TaskView is bound before adding to parent.
- PS6: Move a bunch of getters to use .property style
- PS8: Refacoted RecentsView.applyLoadPlan bind logic, to avoid inflating TaksView, bind, add then immediatley remove
- PS10: Turned more functions to express functions; added an extension function
- PS11: Re-order functions, no code changes
- PS12: Reverted unit express function back to {} style

Bug: 339787593
Test: Manual
Flag: NONE
Change-Id: I75c06cf29718d8f258a4124997bcb054f5eb056f
2024-05-16 12:33:28 +01:00
Sam Cackett 1ee568bf13 Merge "Add metric logging for fake landscape usage" into main 2024-05-16 10:28:26 +00:00
Charlie Anderson 1e96d751d2 Adding additional logging around updated shortcuts
Bug: 338218961
Test: locally
Flag: N/A
Change-Id: Ic72ec2686de20036928c1e98b52677bd82368282
2024-05-15 14:18:21 -04:00
samcackett 76331b6c17 Add metric logging for fake landscape usage
- Reuse existing TaskSwitcherContainer for Overview metric logging
- Log current orientation state for Overview when interacting with
gestures or via three button nav
- Log current orientation state on each phone rotation

Bug: 332870519
Test: Manual
Flag: NA
Change-Id: Ia10cf1acb809432175daab55151998f0d77362f9
2024-05-15 09:42:08 +01:00
Brandon Dayauon e369bd6502 Merge changes I7c303e66,Idc03b9d3 into main
* changes:
  Add floatingMaskView when animating to mimic bottom container.
  Add private_space_floating_mask_view flag.
2024-05-14 23:15:40 +00:00
Anushree Ganjam a77c28cd78 Merge "Add 0-state web data loader logs" into main 2024-05-14 23:13:03 +00:00
Charlie Anderson 8aa2898a58 Merge "Fix blank pink loading icons by ensuring that cache entry won't downgrade existing icon." into main 2024-05-14 18:57:09 +00:00
Shamali Patwa 8a5eddb923 Merge changes from topic "update-strings" into main
* changes:
  Add comments on suggestion category related strings
  Clean-up unused categories (follow up cleans up strings)
2024-05-14 18:38:54 +00:00
Chris Göllner fa09b12443 Merge "Convert SysUiState flags from int to long" into main 2024-05-14 10:44:40 +00:00
Shamali P 4f492626bd Clean-up unused categories (follow up cleans up strings)
Bug: N/A
Test: Unit tests
Flag: N/A
Change-Id: Id3bd76858d731b9e0eb977c094ebd3b19e1338ce
2024-05-13 23:13:56 +00:00
Treehugger Robot 0d4567b57b Merge "Remove COLLECT_SEARCH_HISTORY" into main 2024-05-13 18:15:58 +00:00
Brandon Dayauon 1d3ddb877d Add floatingMaskView when animating to mimic bottom container.
- On expand, we add the floating mask view and translate it out at the end.
- On collapse, we translate off the mask view in the beginning once the floating mask view is added
so that we can translate it in before the actual collapsing part of the animation

bug:339850589
Test manually:
https://drive.google.com/file/d/1YNc3vq9Cb5BcbcPOHp8H3lhe6KmYBdLI/view?usp=sharing
Flag:ACONFIG com.android.launcher3.private_space_floating_mask_view STAGING

Change-Id: I7c303e6629d83408bd314886fe10113246e44dcb
2024-05-13 11:08:05 -07:00
Charlie Anderson d073ab0b39 Fix blank pink loading icons by ensuring that cache entry won't downgrade existing icon.
Bug: 326607598
Test: manually tested B&R
Flag: N/A
Change-Id: I8aac643ec5ca3162cd62bf1051cc751800c626dd
2024-05-13 13:55:15 -04:00
Andrew Cole f3fe08388c Merge "Always Return Adaptive Icon" into main 2024-05-13 16:42:35 +00:00
Chris Göllner 0cd995e4ef Convert SysUiState flags from int to long
We already reached the limit of 32 flags for an int. To be able to have
more, changing from int to long.

This is needed, as new flags have to be added.

Flag: NONE
Test: Manually running SysUI and Launcher
Test: Unit tests in CL
Bug: 335625543
Change-Id: Iec1d40218264c7c64c50fd09764aa07c0caa7787
2024-05-13 14:47:33 +01:00
Anushree Ganjam 7ca0231aa4 Add 0-state web data loader logs
Bug: 328525875
Test: Manual
Flag: Aconfig com.google.android.apps.nexuslauncher.zero_state_web_data_loader DEVELOPMENT

Change-Id: I8492bade13962587f301c4bec461af291fa394d1
2024-05-10 16:05:48 -07:00
Fengjiang Li 1db1dfcb67 Do not use PackageManagerHelper created on boot for LoaderTask.
This CL partially reverts ag/26827295.

Re-using the PackageManagerHelper obj created earlier than LoaderTask obj will lead to the bug where private space user handle is not recognized. This is a temporary fix to create a separate PackageManagerHelper obj for LoaderTask. The real fix should be on framework side.

Also note that PackageManager service instance is now created much later in launcher lifecycle than before.

Fix: 338091143
Test: manual
Flag: NONE
Change-Id: Iab467fe8979aec52c5837c8fd676f821b2e3eb3c
2024-05-10 22:49:21 +00:00
Andrew Cole 10149b6656 Always Return Adaptive Icon
As part of a cleanup for how we deal with legacy icons, we are consolidating our handling of how we wrap non-adaptive icons in an adaptive icon format. This requires adding a parameter to make these functions conform to their earlier specifications.

Bug: 318867282
Flag: None
Test: AllAppsSearchImageTest
Change-Id: I002c430646f8933c638b78a409c9766b6328838a
2024-05-10 14:04:23 -07:00
Charlie Anderson 0171058c0f Merge "add more logging around package updates and widget click handling in Launcher" into main 2024-05-10 17:19:06 +00:00
Helen Cheuk 399638ac23 Merge "Add focus outline to AppPairIcon" into main 2024-05-10 16:46:09 +00:00
Shamali Patwa 26d55c2a7e Merge "Fix NPE in WidgetsTwoPaneSheet" into main 2024-05-10 14:28:00 +00:00
Charlie Anderson 5fa4f02c70 add more logging around package updates and widget click handling in Launcher
Bug: 336976070
Test: locally verified
Flag: N/A

Change-Id: I8a1204fb6d96eccbc20b0ddd3c1e6fb1ae75fc6c
2024-05-10 10:00:51 -04:00
hyunyoungs aa0633b508 Remove COLLECT_SEARCH_HISTORY
Bug: 270391455
Test: compiles
Flag: LEGACY COLLECT_SEARCH_HISTORY DISABLED
Change-Id: If250dc6548e5572dbb34e5b7afdc50a5fa09d9af
2024-05-10 01:40:49 -07:00
Winson Chung 36f38cb028 Merge "Add multi-instance state to item infos" into main 2024-05-10 04:16:38 +00:00
Willie Koomson 2b73f89b14 Fix NPE in WidgetsTwoPaneSheet
Check if mSelectedHeader is null.

Bug: 27214675
Test: build
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add NEXTFOOD
Change-Id: I640ac0b46846b94655414788177fcc1fa52fcee8
2024-05-10 00:52:31 +00:00
Anushree Ganjam 798340dc6d Merge "Hardcode the className instead of class.getSimpleName()." into main 2024-05-09 20:13:13 +00:00
Willie Koomson 8b0469b096 Merge changes I2fd961c0,Id3d21f44 into main
* changes:
  Go to NORMAL state before adding widget with add button
  Retain add button on rotation for two-pane and bottom sheet
2024-05-09 19:04:15 +00:00
Winson Chung 94e8ad0731 Add multi-instance state to item infos
- Add legacy resource for supported multi-instance apps that
  matches the current SystemUI resource of the same name, and will
  be removed as apps migrate to the V manifest property to declare
  multi-instance support
- Load the multi-instance state from PackageManager when the db is
  first loaded or when packages are updated
- The multi-instance check is then used to determine if an app pair
  can be saved (ie. whether the action can be shown)

Bug: 323112914
Test: atest NexusLauncherTests

Change-Id: I565b4bee4ab5f7040910306b1fd60a4fc3bf9a1c
2024-05-09 18:43:38 +00:00
Willie Koomson badcf77c28 Go to NORMAL state before adding widget with add button
Updates add button behavior to go to NORMAL state before adding the
widget to the workspace. This has the effect of dismissing the All Apps
view if it is open.

This fixes an issue where the add button did not work if used from the
WidgetsBottomSheet while All Apps is open, particularly if a new screen
had to be created. See screencasts in gerrit for before/after.

Bug: 335906123
Test: manual, add widget with button from all apps > bottom sheet while
 there is no space on the launcher
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add NEXTFOOD
Change-Id: I2fd961c09c473045088feba5d572c26a812e6619
2024-05-08 22:56:53 +00:00
Willie Koomson 245c244fed Retain add button on rotation for two-pane and bottom sheet
Reselects the WidgetCell that was selected when reloading the sheet on
rotation. WidgetsFullSheet is excluded because it does not retain the
open header on rotation.

Bug: 331429554
Test: manual, see screencast
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add NEXTFOOD
Change-Id: Id3d21f44b1dc525e144296f513f5a460fc51474c
2024-05-08 22:56:52 +00:00
Anushree Ganjam c9eda41c31 Hardcode the className instead of class.getSimpleName().
class.getSimpleName() causes issues with obfuscation.

Bug: 332171918
Test: Manual
Flag: NA
Change-Id: I5119a7ba0e4e27d8745c94df67881934fed282a4
2024-05-08 12:31:24 -07:00
helencheuk cc54eb4907 Add focus outline to AppPairIcon
Bug: 327470960
Test: Manual
Flag: ACONFIG com.android.launcher3.enable_focus_outline Trunkfood
Change-Id: I6a9c6abc3441b5f40bb4f352a844cecad4a1474b
2024-05-08 18:10:52 +01:00
Anna Zhuravleva 9f3bca37e6 Merge "Log animation jank" into main 2024-05-08 08:22:57 +00:00
Andy Wickham 48d3d47c1f Merge "Use ValueAnimator instead of property setter" into main 2024-05-08 01:25:13 +00:00
Sunny Goyal 85fe0d96cf Merge "Fixing LauncherIcons leaking outside sandbox context" into main 2024-05-07 21:42:59 +00:00
Sunny Goyal bf3efe8af0 Fixing LauncherIcons leaking outside sandbox context
Since LauncherIcons was using a global static pool, a custom
instance for a test could leak into the global pool, affecting
other tests

Bug: 335280439
Test: Verified image test on device
Flag: None
Change-Id: Iedd19c8e69c928e44b65eae7eba0167b03b5df6b
2024-05-07 12:13:37 -07:00
Shamali Patwa b257ac4289 Merge "Fix close animation issue during predictive back / swipe up" into main 2024-05-07 18:07:28 +00:00
Brandon Dayauon c2ce6254c3 Use ValueAnimator instead of property setter
Referencing the view by ID animates correctly. Passed in views are supposedly not the same
and therefore, not animating the correct thing. (fixes on the device that can repro issue).

Bug:339179262
Bug:299294792
Test manually verified on device that can repro:https://drive.google.com/file/d/16L4wEroGEDsp_BIkmoARg9vR43upF6_8/view?usp=sharing
Flag: aconfig com.android.launcher3.enable_private_space nextfood

Change-Id: I20b06cc50928c35afa3dc1e8800b3a5bff0769be
2024-05-07 10:30:18 -07:00
Schneider Victor-tulias c6c8a22daf Merge "Add debug logs for b/319168409" into main 2024-05-07 13:56:56 +00:00
Shamali P ac5c6c775b Fix close animation issue during predictive back / swipe up
Bug: 333714698
Test: Manual
Flag: N/A
Change-Id: I07859bc0a3783356cc27358bb23a0d6555aa1492
2024-05-07 13:47:24 +00:00
Shamali Patwa 4f8ef8f54b Merge "Readjust the available size for the recommendations in 2-pane sheet" into main 2024-05-06 22:53:19 +00:00
Brandon Dayauon 9fa457e876 Merge "Update private space animation timings" into main 2024-05-06 18:15:05 +00:00
Schneider Victor-tulias 8288819aa6 Add debug logs for b/319168409
Flag: N/A
Bug: 319168409
Test: TaplDragTest#testDragAppIcon

Change-Id: I96d26cc78af0a3f4145fc3486c4b6adfbd110c9e
2024-05-06 16:22:03 +00:00
Shamali P c0e4dcf238 Readjust the available size for the recommendations in 2-pane sheet
Now that we exclude the space taken by size string and description,
offsetting the size provided to the recommendation table to keep the
widgets within non-scrollable view as much possible.

Bug: N/A
Test: Screenshot
Flag: N/A

Change-Id: I0193cd1ba5de0b0ff98dab9aeb352264afd3ff3a
2024-05-06 15:50:42 +00:00