Commit Graph

11442 Commits

Author SHA1 Message Date
Ats Jenk 5719808945 Merge "Rename removeBubble method to clarify it is for dismissing via drag" into main 2024-05-16 22:00:56 +00:00
Liran Binyamin 013a4121be Merge "Suppress bubble animation when IME is visible" into main 2024-05-16 18:22:38 +00:00
Liran Binyamin 2cbb6dc5e4 Suppress bubble animation when IME is visible
When the IME is visible we now don't animate the bubble bar.

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 340532785
Test: manual
Change-Id: I31fcf6a1fe81d907a9a02780ba42813111ac7e90
2024-05-16 10:15:19 -04:00
Alex Chau ed9e3a8701 Merge "Convert TaksView to Kotlin" into main 2024-05-16 14:00:02 +00:00
Liran Binyamin 606e9fde47 Merge "Animate bubble update notifications" into main 2024-05-16 13:13:57 +00:00
Eghosa Ewansiha-Vlachavas c36afd3e26 Merge "[2/n] Unify DesktopModeStatus between Shell and Sysui" into main 2024-05-16 12:43:26 +00:00
Chris Göllner 4b6d2d4fa3 Merge "Shortcut Helper - Integrate with launcher 3 button nav translation" into main 2024-05-16 12:40:22 +00:00
Alex Chau 9565667813 Convert TaksView to Kotlin
- PS1: Android Studio conversion (unformatted, cannot compile)
- PS2: Fix compilation issues and formatting
- PS3: First pass ready for review
- PS4: Minor changes (Remove Consumer, remove unnecessary null-checks)
- PS5: Removed check() around taskContainers, which is now lateinit and should always be initiailzed. Also ensure TaskView is bound before adding to parent.
- PS6: Move a bunch of getters to use .property style
- PS8: Refacoted RecentsView.applyLoadPlan bind logic, to avoid inflating TaksView, bind, add then immediatley remove
- PS10: Turned more functions to express functions; added an extension function
- PS11: Re-order functions, no code changes
- PS12: Reverted unit express function back to {} style

Bug: 339787593
Test: Manual
Flag: NONE
Change-Id: I75c06cf29718d8f258a4124997bcb054f5eb056f
2024-05-16 12:33:28 +01:00
Sam Cackett 1ee568bf13 Merge "Add metric logging for fake landscape usage" into main 2024-05-16 10:28:26 +00:00
Pragya Bajoria 571c9b288d Merge "Remove obsolete desktop stashing logic from platform/packages/apps/Launcher3 [5/n]" into main 2024-05-16 09:50:17 +00:00
Liran Binyamin 03a2ab1e56 Animate bubble update notifications
Updates to existing bubbles now cause the bubble bar to animate in
similarly to new bubble notifications.

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605846
Test: manual
Change-Id: Ib53316889170e0392f055242c6206882084b4a46
2024-05-15 12:13:12 -04:00
Sam Cackett 155e558b5b Merge "Fix crash resulting from missing entry in the taskViewIdArray" into main 2024-05-15 12:48:08 +00:00
samcackett a24cb0e0fc Fix crash resulting from missing entry in the taskViewIdArray
Bug: 338057269
Test: Manual
Flag: NA
Change-Id: Ifa99fe87423ba75f52c43248c8fd730667803d1a
2024-05-15 11:32:48 +01:00
Pragya Bajoria d9900e0d17 Remove obsolete desktop stashing logic from platform/packages/apps/Launcher3 [5/n]
Bug: 309481654
Change-Id: Id7b5db662d578eb625171055d30c37cd59e7d73c
Flag: EXEMPT refactor since it is removing obsolete code with no changes to current behavior.
2024-05-15 09:16:13 +00:00
samcackett 76331b6c17 Add metric logging for fake landscape usage
- Reuse existing TaskSwitcherContainer for Overview metric logging
- Log current orientation state for Overview when interacting with
gestures or via three button nav
- Log current orientation state on each phone rotation

Bug: 332870519
Test: Manual
Flag: NA
Change-Id: Ia10cf1acb809432175daab55151998f0d77362f9
2024-05-15 09:42:08 +01:00
Ats Jenk 50eb8e78f1 Rename removeBubble method to clarify it is for dismissing via drag
The removeBubble method was only used for dismissing a bubble via drag
in Launcher. Renaming the method to indicate it is only for this
purpose.
This allows us to reduce remote calls from launcher to shell when a
bubble is dismissed via drag. Otherwise we would need to make two calls,
one for removing a bubble and other for stopping the drag.
As shell keeps track of drag status in launcher for hiding the expanded
view.
Also removing the bubble key from remote call to shell to signal drag
has finished. The bubble key was not used.

Bug: 330585402
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: drag a bubble that is not expanded to dismiss target, previously
  expanded bubble should expand again
Change-Id: I57484aa3a2c0585ff7c3974d9f0d19dc1ab9dbd2
2024-05-14 20:37:47 -07:00
Holly Sun 49dc99abb0 [omni] Handle touch slop for LPAA.
Only handle touch slop when the taskbar is pinned (not isTransientTaskbar).

Bug: 335018496
Test: manual
Flag: legacy CUSTOM_LPAA_THRESHOLDS disabled
Change-Id: I4dc6dba473455b02208ef254c271a767bd7c8d42
2024-05-14 16:16:02 -07:00
Holly Jiuyu Sun 5334c82136 Merge "[omni] Dynamically configure timeout for LPAA." into main 2024-05-14 21:45:03 +00:00
Holly Sun 8b38295fb2 [omni] Dynamically configure timeout for LPAA.
Video: https://drive.google.com/file/d/1N7qOIolcSYM9n3z40FO9O6S_IdLJav9l/view?usp=sharing

Bug: 335018496
Test: manual
Flag: legacy CUSTOM_LPAA_THRESHOLDS disabled
Change-Id: I5b0f7cc7815ecd85c51254ad34f2be521c44795c
2024-05-14 12:42:28 -07:00
Eghosa Ewansiha-Vlachavas 1c44de9cdb [2/n] Unify DesktopModeStatus between Shell and Sysui
Remove `DesktopModeStatus` from quickstep and instead access through
shell/shared to shell/shared.

Flag: None
Bug: 335401172
Test: atest -c NexusLauncherTests:com.android.quickstep.DesktopSystemShortcutTest

Change-Id: I42f8b6e5f97f13fda22ed34bda4aa712ead53349
2024-05-14 15:26:15 +00:00
Chris Göllner fa09b12443 Merge "Convert SysUiState flags from int to long" into main 2024-05-14 10:44:40 +00:00
Luca Zuccarini de2e793f53 Merge "Tune the window to icon and home scaling animation." into main 2024-05-14 09:12:24 +00:00
Orhan Uysal 3da07952c5 Merge "Disable drag from taskbar while in desktop." into main 2024-05-14 09:02:45 +00:00
Ben Lin aca7b1cb19 Merge "Update SystemUiProxy signature." into main 2024-05-14 02:22:02 +00:00
Treehugger Robot 878a547f54 Merge "Convert GroupedTaskView to Kotlin" into main 2024-05-13 20:28:00 +00:00
Jeremy Sim 6243da4667 Merge "Fix bug with flickering actions bar" into main 2024-05-13 19:27:02 +00:00
Jeremy Sim 6198cf6544 Fix bug with flickering actions bar
This CL fixes a bug caused by ag/27148514. The bug occurred because:

1) The new way we use FloatProperty to set the alpha did not have a working `get()` function, so it just returned a junk value, set to `-1f` (I didn't think `get()` would ever be called meaningfully for this property).

2) However, during certain UI interactions, `RecentsView#updateActionsViewFocusedScroll()` is called many times in a loop, which repeatedly tries to re-start the fade-in animation for actions bar. Pre ag/27148514, even though the fade-in animation was called repeatedly, it would start and then immediately stop running because it realized that it was already set to the desired alpha. However now that we return a junk value for `get()`, it didn't know to skip and just ran the full fade-in animation again and again.

Fixed by refactoring FLOAT_SETTER (now ALPHA_PROPERTY) and creating a new data class, OverviewActionsAlphaProperty, that handles some of the intricacies of this increasingly complicated alpha system.

Fixes: 339545510
Test: Swipe to Overview, move tiles around, actions bar does not flicker.
Flag: ACONFIG com.android.wm.shell.enable_app_pairs NEXTFOOD
Change-Id: I1093363780db5e0780deda2ff14b4f7361d63940
2024-05-13 10:40:31 -07:00
Liran Binyamin 3fcdc0a39f Merge "Handle touch on bubble bar while animating" into main 2024-05-13 17:30:40 +00:00
Alex Chau 5867d8e175 Convert GroupedTaskView to Kotlin
Bug: 339787593
Test: Manual
Flag: None
Change-Id: I18522f8cadbfe5a0c0a74a5fa9c498a7fb3ce30f
2024-05-13 17:38:04 +01:00
Chris Göllner 11398e2a36 Shortcut Helper - Integrate with launcher 3 button nav translation
Fixes: 335625543
Test: Unit tests in this CL
Test: Manually
Flag: ACONFIG com.android.systemui.keyboard_shortcut_helper_rewrite DEVELOPMENT
Change-Id: I0367bf4b73994a49ca65b8047bd76d3dc2b3faca
2024-05-13 14:47:57 +01:00
Chris Göllner 0cd995e4ef Convert SysUiState flags from int to long
We already reached the limit of 32 flags for an int. To be able to have
more, changing from int to long.

This is needed, as new flags have to be added.

Flag: NONE
Test: Manually running SysUI and Launcher
Test: Unit tests in CL
Bug: 335625543
Change-Id: Iec1d40218264c7c64c50fd09764aa07c0caa7787
2024-05-13 14:47:33 +01:00
Liran Binyamin 6097a29158 Handle touch on bubble bar while animating
This change handles touches on the bubble bar while the bubble bar is animating.
We now update the taskbar touch region during the animation to make the bubble bar touchable.
When the bubble bar is touched during the animation, we now cancel the animation and allow dragging or clicking to expand.

Demo: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/gtGS6FCrygN5RKueFtPs5E

BubbleBarTest 100x run: https://android-build.corp.google.com/abtd/run/L42600030003675041
Note that in the abtd run above there's a flake but that's for a different test which I'll look into separately.

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605790
Bug: 280605846
Bug: 339066271
Fixes: 339244038
Test: See demo
Test: atest BubbleBarViewAnimatorTest
Change-Id: Icb8f4fa46ae4bb8c94ca931193d4a3cc49c5b718
2024-05-13 09:41:23 -04:00
Luca Zuccarini 50a7190efa Merge "Update alpha animation for All Apps / Divider icon." into main 2024-05-13 13:32:23 +00:00
Luca Zuccarini a152f8f044 Tune the window to icon and home scaling animation.
Result of several rounds of testing with UX and product. Ready to start
rolling out after this CL.

Bug: 298089923
Flag: ACONFIG com.android.launcher3.enable_scaling_reveal_home_animation DISABLED
Test: tested with the help of UX and PM
Change-Id: I2bcdfa5a314aeeb60acf7b38f3f3d463fedc277e
2024-05-13 13:31:20 +00:00
Pat Manning f0bff25b1e Merge "Unstash taskbar after timeout when cursor hovers bottom edge." into main 2024-05-13 12:44:21 +00:00
Orhan Uysal c42c8e76e4 Disable drag from taskbar while in desktop.
Currently drag from taskbar is broken. It will be fixed once drag from
taskbar to desktop is implemented in b/297921594.

Bug: 323388149
Test: Try to drag an app from taskbar while in desktop, see that app is
not launch and icon goes back to it's place in taskbar.
Flag: NONE

Change-Id: I27e73d8262e14944b34e193397a83f8435813339
2024-05-13 09:23:34 +00:00
Alex Chau 42af1f0725 Merge "Convert DesktopTaskView to Kotlin" into main 2024-05-10 21:32:52 +00:00
Vadim Tryshev 575d15f231 Cleaning up TestProtocol
Bug: 262282528, 279059025, 322823209
Test: presubmit
Flag: N/A
Change-Id: I9af6e3f1fc49b2ebf0d99df8c4514de0bddee8f2
2024-05-10 11:03:24 -07:00
Alex Chau a88d3beed7 Convert DesktopTaskView to Kotlin
Bug: 339787593
Test: Manual
Flag: None
Change-Id: I94ee4675c11ef64c12b0e3278d4af367b764375e
2024-05-10 16:11:52 +01:00
Treehugger Robot a8c1628d6e Merge "Fix bug where hotseat disappears" into main 2024-05-10 08:47:33 +00:00
Jordan Demeulenaere 3af63d8504 Merge "Delay TransitionAnimator.onAnimationEnd by one frame (2/4)" into main 2024-05-10 07:36:34 +00:00
Winson Chung 36f38cb028 Merge "Add multi-instance state to item infos" into main 2024-05-10 04:16:38 +00:00
Ats Jenk 8ed5d288d2 Merge "Get display size from DisplayController instance" into main 2024-05-09 22:58:38 +00:00
fbaron cf10603ed3 Fix bug where hotseat disappears
Fix: 336096469
Bug: 339700174
Flag: NONE
Test: n/a
Change-Id: Ie567c08445d7743281f501c782a8fd51a75ad9bc
2024-05-09 15:44:57 -07:00
Jon Miranda c7e5813d97 Update alpha animation for All Apps / Divider icon.
This prevents the icons from lingering as the spring settles for the scaling reveal
home animation.

Bug: 298089923
Test: go from app to home, from overview to home, vice versa
Flag: ACONFIG com.android.launcher3.enable_scaling_reveal_home_animation DISABLED
Change-Id: I6bc3f0fcbdc63f0c064d425c8ebaf62a20451ac1
2024-05-09 13:34:46 -07:00
Ben Lin c305263a55 Update SystemUiProxy signature.
Bug: 199333223
Test: Build
Flag: None
Change-Id: I9b9f38b02e81735ed682558ad4bc7a55df5a987f
2024-05-09 13:32:00 -07:00
Anushree Ganjam 798340dc6d Merge "Hardcode the className instead of class.getSimpleName()." into main 2024-05-09 20:13:13 +00:00
Ats Jenk 5b650d0796 Merge "Update expanded view drop target size based on value from shell" into main 2024-05-09 20:06:10 +00:00
Winson Chung 94e8ad0731 Add multi-instance state to item infos
- Add legacy resource for supported multi-instance apps that
  matches the current SystemUI resource of the same name, and will
  be removed as apps migrate to the V manifest property to declare
  multi-instance support
- Load the multi-instance state from PackageManager when the db is
  first loaded or when packages are updated
- The multi-instance check is then used to determine if an app pair
  can be saved (ie. whether the action can be shown)

Bug: 323112914
Test: atest NexusLauncherTests

Change-Id: I565b4bee4ab5f7040910306b1fd60a4fc3bf9a1c
2024-05-09 18:43:38 +00:00
Sukesh Ram e514bac5e3 Merge "Remove Logs for TaplOverviewIconTest#testOverviewActionsMenu" into main 2024-05-09 18:26:31 +00:00