Commit Graph

9249 Commits

Author SHA1 Message Date
Ats Jenk a37f3f2c2c Animate in desktop app select toast
Add an animation for the desktop app select toast.
Played when the toast is added to the screen.

Bug: 261234402
Test: have an app on desktop, swipe up to home, verify that the toast
  has an appear animation, per the spec
Test: when toast is visible, tap on cancel button, observe toast fades
  out
Test: when toast is visible, launch an app, verify toast fades out
Change-Id: I593d6c326d6d638f1bc06e8c6add31b0244e4cb5
2023-06-05 16:39:29 -07:00
Ats Jenk 8fe538b1b9 Merge "Use listener to track desktop task visibility in launcher" into udc-qpr-dev 2023-06-05 16:44:28 +00:00
Sunny Goyal 6773667e34 Revert "Revert "Adding main thread binder tracing in development..."
Revert submission 23522417-revert-23482347-launcher-binder-tracing-RBUMTFPXQG

Reason for revert: Fixed broken build
Reverted changes: /q/submissionid:23522417-revert-23482347-launcher-binder-tracing-RBUMTFPXQG

Change-Id: I3e130a780b8641c4a17a5cdf799513f2ba08b16e
2023-06-02 18:14:35 -07:00
Sunny Goyal c41af6d681 Merge "Enabling app tracing for Launcher" into udc-qpr-dev 2023-06-03 01:05:19 +00:00
Brian Isganitis 992065ba38 Merge changes from topics "all-apps-search-delegate-qpr", "search-container-view" into udc-qpr-dev
* changes:
  Add initial support for search session in Taskbar All Apps.
  Add All Apps search delegate for inflating search box.
2023-06-03 00:59:47 +00:00
Ats Jenk da7e55591e Use listener to track desktop task visibility in launcher
Launcher registers a listener with WMShell to receive updates about
desktop stashed state. The same listener can be used to receive updates
about desktop visibility.
Previously launcher was relying on sysui state flag for desktop
visibility. But this flag is not checked when launcher starts. Only
updates are handled. When launcher restarts and desktop is visible,
launcher state was not correctly set.
This listener is "sticky", meaning when a listener registers, it will
receive a callback with the current value. This allows launcher to
update its state on start.

Flag: persist.wm.debug.desktop_mode_2
Bug: 280490493
Test: move an app to desktop, observe launcher icons are hidden
Test: swipe home from a desktop app, observe launcher icons shown
Test: while desktop app is open, change system theme to dark or light,
  observer launcher is restarted and icons remain hidden
Change-Id: Id8be1989b32d9ccd2e0539b65529fed096342ac3
2023-06-02 23:20:58 +00:00
Saumya Prakash 217b1f3559 Merge "Match displayed instruction with voiceover text." into udc-dev am: 0ebdfc6660 am: 1e65cdcdd7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23450321

Change-Id: I9ab9421797150c221202be6817d4414f1dbecfb8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-02 23:09:35 +00:00
Mady Mellor 0175c0080b Merge "Modify Taskbar code to accommodate bubble bar gesture to stash/unstash" into udc-qpr-dev 2023-06-02 22:08:10 +00:00
Saumya Prakash 0ebdfc6660 Merge "Match displayed instruction with voiceover text." into udc-dev 2023-06-02 22:00:25 +00:00
Brian Isganitis 70da3e6452 Merge "Fix how task stack listener closes overlays on task changes." into udc-dev 2023-06-02 21:49:27 +00:00
Sunny Goyal a8209d5da9 Enabling app tracing for Launcher
Bug: 273718665
Test: None
Flag: N/A
Change-Id: Ie6fa50b602bf180dd5dcba999c9e18f07a17d589
2023-06-02 19:21:10 +00:00
Saumya Prakash fbeb143ea6 Match displayed instruction with voiceover text.
When users are using TalkBack, the text being read aloud did not match
the text displayed on the screen. This change fixes that in accordance
to the accessibility testing principles by changing the text spoken
aloud.

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fix: 274996517
Test: Manually went through both versions of the tutorial using talkback
and without using it. Ensured the spoken text matched the displayed
text

Change-Id: I896f2c09bd220615722777c73935f70c946715b2
2023-06-02 18:32:33 +00:00
TreeHugger Robot b73bafc52a Merge "Log windowManager.getPossibleMaximumWindowMetrics" into udc-dev am: 014a684343 am: 43b4a71690
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23517420

Change-Id: Id44d5120ed1083870c7d3b9256978ab940d03379
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-02 18:31:08 +00:00
TreeHugger Robot 014a684343 Merge "Log windowManager.getPossibleMaximumWindowMetrics" into udc-dev 2023-06-02 17:09:46 +00:00
Brian Isganitis 7a5809e47b Add initial support for search session in Taskbar All Apps.
A search session is represented as a stub ResourceBasedOverride that can
be extended for controlling a search session.

Test: Manual (including aosp Quickstep)
Bug: 216683257
Flag: ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
Change-Id: I9cf4b5f84feec5215840d456b601c6a9f7c4c211
2023-06-02 15:55:46 +00:00
Brian Isganitis 0aa30e2292 Fix how task stack listener closes overlays on task changes.
Originally gated onTaskMovedToFront behind prototype because looked like
it was causing overlay to close when it shouldn't. However, it turns out
it was actually onTaskStackChanged that was doing this.

Additionally, changing onTaskMovedToFront to close with animation, because this will fire if swiping up from all apps (going to overview so Launcher is considered as the task moving to front). Also, registered onTaskCreated to be a bit more thorough.

Test: Manual (EDU, All Apps, and EDU + All Apps)
Fix: 283373523
Flag: none
Change-Id: I4cd3969f91a93bab190b764a656d9cfc03d1ce09
(cherry picked from commit 34c6b871af)
2023-06-02 15:34:35 +00:00
Alex Chau eb9171c378 Log windowManager.getPossibleMaximumWindowMetrics
Bug: 283944974
Test: manual
Change-Id: I15d4bb81604b018f8a2c69c56509e2a66caae306
2023-06-02 15:44:54 +01:00
Santiago Aboy Solanes 0edac04688 Merge "Revert "Adding main thread binder tracing in development build."" into udc-qpr-dev 2023-06-02 09:06:26 +00:00
Santiago Aboy Solanes ee846feb80 Revert "Adding main thread binder tracing in development build."
Revert submission 23482347-launcher-binder-tracing

Reason for revert: Broken Build 10242119 on git_master on errorprone b/285434612

Reverted changes: /q/submissionid:23482347-launcher-binder-tracing

Change-Id: Id9726474265e839a59d6eb34822e7a86d40f0fc9
2023-06-02 08:59:28 +00:00
Treehugger Robot 329f11180d Merge "Create separate fullscreen launch type for shortcuts" into udc-dev am: 55f38fb397 am: 0189f4454a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23480181

Change-Id: I79987e6f9f237cbaf2f2a4317e93506fe216b7d1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-02 06:37:06 +00:00
Treehugger Robot 55f38fb397 Merge "Create separate fullscreen launch type for shortcuts" into udc-dev 2023-06-02 05:22:23 +00:00
Anushree Ganjam 87cb7ad06a Merge "Add UID in AppInfo." into udc-dev am: 9b4f62e681 am: eb9cd7e26e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23331302

Change-Id: I2bfbbf5fd5ec777baca79d89c13204857e600f8d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-02 01:46:38 +00:00
Anushree Ganjam 9b4f62e681 Merge "Add UID in AppInfo." into udc-dev 2023-06-02 01:17:29 +00:00
Vinit Nayak 748bbe46a5 Merge "Skip drawing taskbar background in setup" into udc-dev am: e65bf2a620 am: c037eb916c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23481079

Change-Id: I4d9793f98148910b0f2414c292f5c6be7cabf5aa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-02 00:36:41 +00:00
Vinit Nayak e65bf2a620 Merge "Skip drawing taskbar background in setup" into udc-dev 2023-06-01 23:13:19 +00:00
Anushree Ganjam 97434eea53 Add UID in AppInfo.
Create a reverse hashmap of PackageUserKey to Uid in AllAppsStore for
faster lookup of uid based on packageName and userHandle.

Log Uid in Impression Logging.

Bug: 282849559
Test: Manual. See various usecases documented in http://shortn/_UcvAYOmLIP
Flag: NA

Change-Id: I416426214f6b6efc45f7d4c0433bbbfca9056adf
2023-06-01 22:45:19 +00:00
Sunny Goyal cbb13841f5 Merge "Revert "Add hover state border line to overview task item by usi..."" into udc-qpr-dev 2023-06-01 21:39:15 +00:00
Sunny Goyal 8dbdd3d702 Revert "Add hover state border line to overview task item by usi..."
Revert submission 23378417-cherrypick-overview-border-249859410-786docmioso

Reason for revert: flaky implementation

Reverted changes: /q/submissionid:23378417-cherrypick-overview-border-249859410-786docmioso

Change-Id: I6792fc25dbbd80db24df93ebd7a974b0dc0ba5d5
2023-06-01 21:29:13 +00:00
Vinit Nayak 5364b0dac9 Skip drawing taskbar background in setup
Test: Manually went into SUW and observed
Fixes: 272674390
Change-Id: I102d1433692793f51d930e710d68134d4536c397
2023-06-01 10:52:39 -07:00
Sunny Goyal 50c9126cc3 Merge "Adding main thread binder tracing in development build." into udc-qpr-dev 2023-06-01 17:27:21 +00:00
Sunny Goyal 3db98b1152 Adding main thread binder tracing in development build.
> Unifying multiple binder tracing implementations
> Removing wallpaper customization check as it has been rolled out
  few years ago, this avoids additional RPC to check for wallpaper
> Removing RaceConditionReproducer as it is not used anywhere and
  is not integrated with this tracing anymore

Bug: 273718665
Test: Presubmit
Flag: N/A
Change-Id: I801af5d039a9d38d5d39e803723ec6da50a9d59f
2023-06-01 09:39:50 -07:00
Helen Cheuk ed4c2acf58 Merge "Add hover state border line to overview task item by using the same approach used by keyboard focus state" into udc-qpr-dev 2023-06-01 15:45:01 +00:00
Nick Chameyev c1eafd92ab Merge "[Unfold animation] Do not preemptively start the animation if it has run already" into udc-qpr-dev 2023-06-01 12:55:27 +00:00
Jagrut Desai 9edf316ca3 Merge "Fixing Toast Hiding behind Taskbar - Part 2" into udc-dev am: e208e02aba am: 3d630fdddb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23455641

Change-Id: I4b47b8d6304830311eef6545ee08bfee51554269
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-31 21:26:47 +00:00
Jagrut Desai e208e02aba Merge "Fixing Toast Hiding behind Taskbar - Part 2" into udc-dev 2023-05-31 20:45:37 +00:00
Schneider Victor-tulias fc32303ebf Merge "Fix launcher activity leak in TouchInteractionService" into udc-dev am: 8f95307087 am: 9dd8eacd99
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23375885

Change-Id: I7b6cfeb031aefc61441a030aac15d2674ef83b1d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-31 19:20:54 +00:00
Schneider Victor-tulias 8f95307087 Merge "Fix launcher activity leak in TouchInteractionService" into udc-dev 2023-05-31 17:49:35 +00:00
Jagrut Desai 84e959a72a Fixing Toast Hiding behind Taskbar - Part 2
Test: Visual, Manual
Bug: 282964229
Flag: not needed
Change-Id: If2373d8f0bc44a555844c78d20877e9636a7e176
2023-05-31 10:41:16 -07:00
Nick Chameyev 6d756970e7 [Unfold animation] Do not preemptively start the animation if it has run already
Currently if we open an app, unfold the device and then go to home
screen we will start the unfold animation preemptively in Launcher
because Launcher activity will receive updated configuration change
(where isTablet = true) only after going back to home screen, not
when unfolding the device.

This causes a problem because SystemUI won't send the unfold animation
events after going back home as the animation has already run, so we
end up with wrongly started animation in Launcher.

This CL fixes the issues by checking if SystemUI has finished the
animation (or if it is currently running) to avoid preemptive animation
start in this case. This is done by subscribing to the original
unfold transition progress provider which emits progress events
sent through IPC from SystemUI.

Bug: 285150685
Test: open an app on folded screen, unfold, go to home screen =>
  check that icons are not squished
Test: fold/unfold when launcher is open
Change-Id: Ic437ff4d19cbd5764635f3007d99880622150f5b
2023-05-31 17:12:08 +00:00
Kateryna Ivanova 72fbdc7976 Merge "Migrate Interpolators from Launcher3 to the public animation library" into udc-qpr-dev 2023-05-31 15:25:40 +00:00
Vinit Nayak 9cea469bc9 Merge "Resize mRemoteTargetHandles when RecentsAnimationStarts" into udc-dev am: 52ac882e9b am: 7916ab1e26
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23267214

Change-Id: Ib0895dfd51575b5e43cb60c73c28a5c047eb9c51
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-30 23:39:52 +00:00
Vinit Nayak 52ac882e9b Merge "Resize mRemoteTargetHandles when RecentsAnimationStarts" into udc-dev 2023-05-30 22:10:28 +00:00
Vinit Nayak 8852010eb8 Create separate fullscreen launch type for shortcuts
Bug: 283045822
Test: Verified via debugger the right API is called,
still have issues on split side
Flag: none

Change-Id: Ic2fcbf4ffe05503b0c2e1fade3e3e990498cf6cf
2023-05-30 13:43:24 -07:00
helencheuk 64975ae992 Add hover state border line to overview task item by using the same approach used by keyboard focus state
Reviewed TAPL DD: https://docs.google.com/document/d/1OmCLgTDw3gFOMXjEvH0W1XoAe0n2J5pPdyMcAHtflMA/edit?resourcekey=0-bXle-rOnQqOR_RJBffRybQ
Fix: 249859410
Test: OverviewTaskImageTest

Change-Id: Ic9ce4e9fe90f38a4bf4be6c7deed302a12a3192a
2023-05-30 21:30:14 +01:00
Brian Isganitis 1f2919d634 Merge "Fix how task stack listener closes overlays on task changes." into udc-qpr-dev 2023-05-30 19:21:15 +00:00
Stefan Andonian 4439bec7aa Merge "Use LockedUserState in TouchInteractionService." into udc-qpr-dev 2023-05-30 18:55:02 +00:00
Tracy Zhou 073a04f639 Merge "Simplify trackpad multi-finger gesture recognition logic for gesture nav" into udc-qpr-dev 2023-05-30 16:38:16 +00:00
Kateryna Ivanova 7120373bbc Migrate Interpolators from Launcher3 to the public animation library
Test: atest
Bug: 271850966
Change-Id: Iba999f2e753764a37d35e508e707df02388432e9
2023-05-30 07:20:38 +00:00
Tracy Zhou 48ac5a0f74 Simplify trackpad multi-finger gesture recognition logic for gesture nav
Now we can use AXIS_GESTURE_SWIPE_FINGER_COUNT per ag/23288416

Test: swipe up to overview / home; workspace scroll 2-finger only / quick switch/ pull down notifications works
Bug: 284463803
Change-Id: Ie1c7d13f4683d3b9c8de6e5ea2821df73b97ca29
2023-05-27 21:16:25 -07:00
Achim Thesmann 5644e3f1fd Merge "Allow BAL in Launcher" into udc-dev am: 2bcfbd3739 am: fc6ffba0bb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23342819

Change-Id: I0773e3c7123af7066eec8e29c5bc9c8fc40c4c59
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-27 19:18:44 +00:00