Commit Graph

4247 Commits

Author SHA1 Message Date
Jordan Silva a244c0b70e Fix TAPL OverviewTask to use correct resource to measure height
The background in DesktopTaskView wasn't added for accessibility, so it couldn't be retrieved from the view hierarchy during e2e tests. This view is necessary to calculate the correct size of the DesktopTaskView.

The changes in this cl:
- Add backgroundView to DesktopTaskView's children for accessibility
- Use the correct snapshot resource for desktop mode in OverviewTask

Bug: 353948500
Change-Id: I83746510849e4013d623d49cbaccebd81daba96d
Flag: EXEMPT bugfix
Test: TaplTestsOverviewDesktop
2024-10-28 12:25:25 +00:00
Jordan Silva 7054095b16 Add TAPL test for dismiss DesktopTaskView
This CL adds 2 new E2E Tapl tests for checking dismiss DesktopTaskView.
- dismissFocusedTask_thenDesktopIsCentered validates the following scenarios:
  - Scenario: When Focused Task is in the center of the screen, with 1 other task in the grid and 1 desktop task.
  - When focused task is dismissed, the next task in the grid takes its place to be the next focused task at the center of the screen.
  - When the last focused task is dismissed, the desktop task takes its place at the center of the screen.

- dismissDesktopTask_thenFocusedTaskIsCentred validates the following scenarios:
  - Scenario: When Desktop Task is in the center of the screen, with 1 focused task and 1 task in the grid.
  - When focused task is dismissed, the next task in the grid takes its place, adjacent to desktop task.
  - When desktop task is dismissed, the focused task takes its place at the center of the screen.

Fix: 353948500
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Test: TaplTestsOverviewDesktop
Change-Id: Ie2aa28cd2b30a2bf10e877721416399bcf47acf6
2024-10-28 12:25:25 +00:00
fbaron a796d74e36 Refactor grid migration
In this CL:
-Make GridsizeMigrationLogic functions pure (no side effects)
-Make it so GridSizeMigrationLogic contains the migration logic and does NOT interact with the database
-Let GridSizeMigrationUtil receive the results from the logic layer and use those results to interact with the database appropriately

In future CLs:
-Refactor GridSizeMigrationLogic to Kotlin

Bug: 358399271
Flag: com.android.launcher3.grid_migration_refactor
Test: GridSizeMigrationTest
Change-Id: Ifcc5ca356558a7463352580f2e89eef8c86ed16b
2024-10-23 22:26:38 +00:00
Shamali Patwa d6f39e3f45 Merge "Enforce system radius instead of separate value for widgets in launcher" into main 2024-10-23 00:04:50 +00:00
Treehugger Robot 08007068d4 Merge "Generalize ActivityTracker to support RecentsWindowManager" into main 2024-10-22 21:26:58 +00:00
Schneider Victor-Tulias 8463dc47eb Generalize ActivityTracker to support RecentsWindowManager
Continued quick switch couldn't work using existing infrastructure until RecentsWindowManager could be properly tracked by ActivityTracker. Refactored ActivityTracker into ContextTracker to support this.

Also refactored ActivityInitListener into ContextInitListener to fit the updated pattern.

Flag: com.android.launcher3.enable_fallback_overview_in_window
Fixes: 366023051
Test: RecentsWindowSwipeHandlerTestCase; Attempted continued quick switch from home and launched app
Change-Id: Ic38ebf3611ef22fbfd1ddeb79d72d8a3621940a0
2024-10-22 15:29:59 -04:00
Shamali Patwa 2fc32dc2d8 Enforce system radius instead of separate value for widgets in launcher
The change is behind a flag. This is to get to the stage of having
consistent corner radius across rectangular widgets.

Bug: 373351337
Test: Unit test and manual
Flag: com.android.launcher3.enforce_system_radius_for_app_widgets
Change-Id: I23d8d3bb2561b4fc3f780fc4ddce62e8b9293192
2024-10-22 18:03:07 +00:00
Sunny Goyal 0b7f4cf1e2 Fixing deadlock in dagger singletons
Bug: 373557167
Flag: EXEMPT dagger
Test: atest DaggerSingletonDeadlockTest

Change-Id: I2304237bfd818c99b82bbfceea8a81ddb136b5a1
2024-10-21 18:09:37 +00:00
Sunny Goyal 4eaf3df1fe Merge "Moving PluginManager to dagger" into main 2024-10-17 21:47:28 +00:00
Schneider Victor-tulias 892ad69191 Merge "Improve test isolation in AbstractLauncherUiTests" into main 2024-10-17 19:22:37 +00:00
Sunny Goyal 9cd3154952 Moving PluginManager to dagger
Multiple singletons depend on Plugin which can cause deadlock
if PluginManager is initialized on main thread

Test: presubmit
Bug: 361850561
Bug: 373557167
Flag: EXEMPT dagger
Change-Id: I79f17ac6b78a2ce60df2d27a6e794b9e4eba1b51
2024-10-17 11:48:38 -07:00
Treehugger Robot 642e84e397 Merge "Cleanup for TAPL Debugging" into main 2024-10-17 02:18:08 +00:00
Sukesh Ram fc6cc4e409 Cleanup for TAPL Debugging
Cleaning up leftover log statements.

Flag: EXEMPT bugfix
Bug: 324419890
Test: Manual
Change-Id: I54145d07f0699f68c44aaa34e1692c8fe2f7b780
2024-10-16 16:55:45 -07:00
Schneider Victor-Tulias 07669e9575 Improve test isolation in AbstractLauncherUiTests
- Removing suspicious duplicate uses of AbstractLauncherUiTest.initialize to prevent unnecesary launcher restarts
- Adding UiDevice#pressHome to AbstractLauncherUiTests.verifyLauncherState to ensure the next test starts with a known clean state

Flag: EXEMPT test fix
Fixes: 372956489
Test: AbstractLauncherUiTest
Change-Id: Id68ece4ab195a4f6c47aa401eb50a91b8ff70e10
2024-10-16 13:18:36 -04:00
Brian Isganitis fa6ca0fe6f Have external resource call init() explicitly.
Change-Id: Ibdd444478d0d171353a58c060022f5a181f9d1c4
Flag: TEST_ONLY
Test: go/testedequals
Bug: 230027385
2024-10-15 23:43:31 +00:00
Treehugger Robot 8915d3c3b8 Merge "[Dagger] Make CustomWidgetManager provided by DaggerSingletonObject" into main 2024-10-15 19:19:36 +00:00
Sihua Ma 58fc65dedf [Dagger] Make CustomWidgetManager provided by DaggerSingletonObject
Test: presubmit
Bug: 361850561
Flag: NONE Dagger change
Change-Id: I9c2a9cc12aa2a409e8f9053a059426843f72deed
2024-10-14 22:35:59 +00:00
Brian Isganitis a3ec98e06d Migrate to FakeLauncherPrefs for Taskbar unit tests.
Deprecates the preference rules.

Flag: TEST_ONLY
Test: go/testedequals
Bug: 230027385
Change-Id: Ic3a9e589b556232d196942d687e2e2bddc000877
2024-10-14 18:13:23 -04:00
Sunny Goyal 0bf39fdf26 Merge "Removing unnecessary SafeClosable requirement from DaggerSingletonObject" into main 2024-10-14 17:06:13 +00:00
Sunny Goyal bf9d047b53 Removing unnecessary SafeClosable requirement from DaggerSingletonObject
Test: presubmit
Bug: 361850561
Flag: EXEMPT dagger
Change-Id: I453159be83e92eee92f5a18cfe0d3ea9a3123f47
2024-10-12 01:26:50 -07:00
Treehugger Robot 99f6d447ea Merge "Cleaning up temporary interfaces which were created for refactoring" into main 2024-10-11 23:02:52 +00:00
Sunny Goyal 43b01b9900 Cleaning up temporary interfaces which were created for refactoring
Bug: 366237794
Test: Presubmit
Flag: EXEMPT refactor
Change-Id: Ic2c69bcdde1429c787903c24f0e19ea26b91d314
2024-10-11 11:03:47 -07:00
Treehugger Robot 247bc0461a Merge "Revert "Demote TaplThemeIconsTest#testShortcutIconWithTheme"" into main 2024-10-10 23:35:41 +00:00
Brian Isganitis 0e27df431a Merge changes from topic "launcher-prefs-abs" into main
* changes:
  Add FakeLauncherPrefs with basic tests.
  Split LauncherPrefs into abs class / impl.
2024-10-10 19:31:04 +00:00
Federico Baron f20255fd09 Revert "Demote TaplThemeIconsTest#testShortcutIconWithTheme"
This reverts commit 7672f320e8.

Reason for revert: issue no longer happening

Change-Id: I6dd0b00deb626e0248abc9007c0ae58743931f0c
2024-10-10 18:45:56 +00:00
Sunny Goyal 266f51b488 Converting LauncherModel to kotlin
> This will make it easier to migrate to dagger as it will
  increase the number of constructor parameters significantly

Test: presubmit
Bug: 361850561
Flag: EXEMPT dagger migration
Change-Id: Id06246ec74c678d7614f4c6a798c5644b40a0545
2024-10-10 00:34:12 +00:00
Brian Isganitis 7f6ecaaa06 Add FakeLauncherPrefs with basic tests.
Flag: TEST_ONLY
Bug: 369504330
Test: go/testedequals
Change-Id: I1cc408451b1f6e316c0ec6b087989323bcd9da4d
2024-10-09 18:55:51 -04:00
Brian Isganitis 9cbc478574 Split LauncherPrefs into abs class / impl.
Splitting allows easily making a fake that doesn't have to override the implementation details of LauncherPrefs. The fake should not deal with SharedPreferences.

LauncherPrefs could be an interface, but then the companion object has more limitations. The solution there is to have a dedicated object class, e.g. `LauncherPrefItems`. I went with an abs class to make the refactor simpler.

Flag: EXEMPT refactor
Bug: 369641781
Test: go/testedequals
Change-Id: I97a2d495d3b5fa892fa53a11fb3f7a7dfb98515b
2024-10-09 18:55:51 -04:00
Sunny Goyal f7ae1ec325 Merge "Moving manifest initialization to RoboApplication instead of a separate rule" into main 2024-10-09 07:52:37 +00:00
Sunny Goyal 6a207fc4f9 Moving manifest initialization to RoboApplication instead of a separate rule
This makes the behavior same as instrumentation test

Bug: 370080120
Test: Presubmit
Flag: EXEMPT test fix
Change-Id: Id4183c91f3951748b657b583fde8860abe55d3a8
2024-10-08 11:00:22 -07:00
Sunny Goyal 9dcf307a62 Merge "Fixing test flakiness in Launcher initialization" into main 2024-10-08 17:29:27 +00:00
Brian Isganitis 67ed920053 Merge changes from topic "brianji-object-sandbox" into main
* changes:
  Add SandboxApplication for keeping created contexts in sandbox.
  Allow specifying base for SandboxModelContext.
  Rename to ObjectSandbox.
2024-10-08 16:33:47 +00:00
Sunny Goyal b619d2c297 Removing dependency on PackageInfo in IconCache
Bug: 363324203
Flag: EXEMPT bugfix
Test: atest IconCacheTest
      atest IconCacheUpdateHandler

Change-Id: I85005ef1069960a17a0f3e7265749a8ef3004172
2024-10-08 04:09:54 +00:00
Brian Isganitis d04464ac39 Add SandboxApplication for keeping created contexts in sandbox.
Flag: TEST_ONLY
Bug: 230027385
Test: go/testedequals
Change-Id: I14c277325bd4b3b7cf59ed31dedad338bf1e4440
2024-10-07 16:50:59 -04:00
Brian Isganitis 4d6194f432 Allow specifying base for SandboxModelContext.
Flag: TEST_ONLY
Bug: 230027385
Test: go/testedequals
Change-Id: I2d6c90eda30cb80fd7124d35bab62b1af1b10902
2024-10-07 16:50:59 -04:00
Fengjiang Li 49df29669d [Dagger] Make ScreenOnTracker provided by DaggerSingletonObject
Test: presubmit
Bug: 361850561
Flag: NONE - dagger
Change-Id: I305ee47f2da92972e9b5effe3c3e02504cd5a3b0
2024-10-07 11:45:16 -07:00
Sunny Goyal 95045ce03a Fixing test flakiness in Launcher initialization
Using same key for blob store and content provider based layouts

Using a single key for layout provider. This ensures that if one
test doesn't cleanup properly, any followup test which relies on
model initialization overrides the key appropriately

Bug: 370080120
Test: Presubmit
Flag: EXEMPT bugfix
Change-Id: Idef0a89a5d1ec89e24aae8a4549fd122634dad2f
2024-10-04 20:52:17 +00:00
Jagrut Desai 831ca957c0 Merge "Remove unused TestProtocol" into main 2024-10-02 20:51:10 +00:00
Sunny Goyal e14af2316b Merge "Converting some caching logic booleans to lookup flags" into main 2024-10-02 20:34:16 +00:00
Treehugger Robot 3faec179c0 Merge "Add debug memory logs to AbstractLauncherUiTest" into main 2024-10-02 15:39:05 +00:00
Anushree Ganjam 0dc88fece8 Merge "Make InstallSessionHelper injected by Dagger (7/n)" into main 2024-10-02 01:57:48 +00:00
Anushree Ganjam 29e060408f Make InstallSessionHelper injected by Dagger (7/n)
Bug: 361850561
Test: Manual
Flag: NONE Dagger Integration

Change-Id: Ib1833436bfd1079ae78f1d865831c1aa8a7a0c41
2024-10-01 12:45:53 -07:00
Schneider Victor-Tulias 63dfd60b23 Add debug memory logs to AbstractLauncherUiTest
Flag: EXEMPT test debug logs
Bug: 365628676
Test: TAPL tests
Change-Id: Ia019bc128b76b9b2d776c54ad93713ae4110b2de
2024-10-01 18:15:13 +00:00
Sunny Goyal e978f6cedb Converting some caching logic booleans to lookup flags
Bug: 366237794
Test: atest IconCacheTest
Flag: EXEMPT refactor

Change-Id: I0d25996181954df22e1cb61596be0a2694ee7068
2024-10-01 17:59:48 +00:00
Jagrut Desai 85a8898402 Remove unused TestProtocol
Test: Presubmit
Bug: 319501259
Flag: TEST_ONLY
Change-Id: Ibe261ec8820f5d6e8415f5085c21a0adfef37462
2024-10-01 09:24:38 -07:00
Treehugger Robot 0c1db56f2f Merge "Requesting ApplicationInfo in cached object" into main 2024-09-28 00:08:58 +00:00
Mykola Podolian 410aa60a6c Merge "Update device profile dumps for bubbles" into main 2024-09-27 23:38:22 +00:00
Treehugger Robot 947a932a33 Merge "Cleanup for TAPL Debugging" into main 2024-09-27 21:21:49 +00:00
Sunny Goyal f7c32a29fd Requesting ApplicationInfo in cached object
Bug: 363324203
Test: Presubmit
Flag: EXEMPT refactor
Change-Id: I92f3d3ed8c267b895dc439ba1f01eb67d7f63965
2024-09-27 14:04:16 -07:00
Federico Baron bb4ae757f6 Update device profile dumps for bubbles
Test: DeviceProfileDumpTest
Bug: 346381754
Flag: com.android.wm.shell.enable_bubble_bar_in_persistent_task_bar
Change-Id: If68bb298bb81347f301cb268f8e43e207c2ac503
2024-09-27 20:46:00 +00:00