PawletOS/Lawnchair
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
71,475 Commits 1 Branch 0 Tags
a1a5e087133c51c48dd3be33f088de76585d460e
Commit Graph
9822 Commits
Author SHA1 Message Date
Schneider Victor-tulias a1a5e08713 Replace all uses of string concatenation with CompoundString in ActiveGestureLog 
Flag: not needed
Fixes: 300926831
Test: ran launcher, tested gestures and checked logs
Change-Id: Iede0881be315cb1ef0a30eaf2a9e17e020828586
 2023-09-18 15:51:14 -04:00
Brian IsganitisandAndroid (Google) Code Review a46e03ad90 Merge "Stash transient Taskbar on overlay task stack changes." into main 2023-09-12 22:20:24 +00:00
Ats JenkandAndroid (Google) Code Review d4d114f9cd Merge "Fix flicker when swiping from desktop to home" into main 2023-09-12 20:44:20 +00:00
Federico BaronandAndroid (Google) Code Review 092064e1d0 Merge "Add smartspace custom widget" into main 2023-09-12 18:43:58 +00:00
Tracy ZhouandAndroid (Google) Code Review ca9b884118 Merge "Always recreate TaskbarActivityContext" into main 2023-09-12 02:24:45 +00:00
Jagrut DesaiandAutomerger Merge Worker fb4694d51e Merge "Apply ForciblyShown WindowLayoutParam flags for Transient Taskbar" into udc-qpr-dev am: 733d440ac1 am: a1e8f327ff 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24709295

Change-Id: Id84c65adba08bae631cccfd6792c6a90b6992637
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-11 23:47:46 +00:00
Mady MellorandAndroid (Google) Code Review 3edb22bd09 Merge "Stash taskbar when bubbles is expanded in overview" into main 2023-09-11 23:14:40 +00:00
Jagrut DesaiandAutomerger Merge Worker a1e8f327ff Merge "Apply ForciblyShown WindowLayoutParam flags for Transient Taskbar" into udc-qpr-dev am: 733d440ac1 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24709295

Change-Id: I0066e91a986878debb75663fa68d4f5408af8898
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-11 22:57:58 +00:00
Jagrut DesaiandAndroid (Google) Code Review 733d440ac1 Merge "Apply ForciblyShown WindowLayoutParam flags for Transient Taskbar" into udc-qpr-dev 2023-09-11 21:52:08 +00:00
Ats Jenk 521a7e428c Fix flicker when swiping from desktop to home 
When swiping up from desktop, we need to temporarily show launcher views
when user may go to overview. Hide them again when user just swiped up for
taskbar. But not hide them user is swiping home.
Previously we were always hiding launcher views when user swiped up from
desktop and that led to home or transient taskbar.
This change ensures that we only change the visibility of launcher views
when overview ui is hidden, freeform tasks are still visible, and
gesture has ended.
Otherwise there were flickers when, after swiping home, we were hiding
launcher views and then showing them again shortly after as the freeform
tasks were now hidden.

Bug: 297562634
Test: be on desktop with some open apps
      - swipe up to go home, observe that there are no flickers from
        home screen icons, widgets or hotseat
      - swipe up for transient taskbar, observe desktop apps remain
        visible
      - swipe up to go to overview, observe the other fullscreen apps
        flow in from the side

Change-Id: I14f9f95a3a22fbca6878ecea24848f271dc951d7
 2023-09-11 21:43:02 +00:00
Brian Isganitis 3cfc2a338d Stash transient Taskbar on overlay task stack changes. 
Test: Manual
Fix: 299515360
Flag: No
Change-Id: I3c182fa51bcb7af908aebf168f017923aff8c789
 2023-09-11 20:32:44 +00:00
Ivan TkachenkoandAndroid (Google) Code Review 068d1ea839 Merge "Bubble bar user education" into main 2023-09-11 17:59:08 +00:00
Brian IsganitisandAndroid (Google) Code Review cbaf0a7f70 Merge "Close overlay onTaskStackChanged when All Apps is visible." into main 2023-09-11 17:46:16 +00:00
Mady Mellor 2da9c114c4 Stash taskbar when bubbles is expanded in overview 
Test: manual - have transient taskbar
             - have a bubble
             - go to overview
             - expand bubbles
             => observe that transient taskbar stashes
             - collapse bubbles
             => observe that transient taskbar unstashes

             - verify that expanding bubbles in app and on launcher
               home behaves as expected (stashes taskbar in app and
               don't see taskbar or stashed handle on home)
Bug: 284104811

Change-Id: I3d7057ed651e66ab2a0292725f30153ee4d6d51e
 2023-09-11 09:41:14 -07:00
Jagrut Desai 6472119d4b Apply ForciblyShown WindowLayoutParam flags for Transient Taskbar 
Test: Manual
Bug: 278078311
Flag: Not needed
Change-Id: Ia963e45b3b4e6d928b6292b80b73394e76fe2325
 2023-09-11 09:39:23 -07:00
Schneider Victor-tuliasandAutomerger Merge Worker ad147bbc0d Merge "Add error handling to prevent IllegalArgumentException" into udc-qpr-dev am: 9e6a845ca4 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24622404

Change-Id: I543b44b24c93508776bcc4a7c24a8142a70d698c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-11 16:29:01 +00:00
Schneider Victor-tuliasandAndroid (Google) Code Review 9e6a845ca4 Merge "Add error handling to prevent IllegalArgumentException" into udc-qpr-dev 2023-09-11 15:30:05 +00:00
Tracy Zhou 01cc856157 Always recreate TaskbarActivityContext 
- Add ENABLE_TASKBAR_NO_RECREATION flag
  When the flag is turned on,
  * Always destroy and recreate
  * Move task bar drag layer lifecycle from TaskbarActivityContext to TaskbarManager
  * Wrap the drag layer into a fullscreen root view

Note that in order to preserve the window across multiple TaskbarActivityContext creations, the inset types and ids must stay the same, so it's extracted out.

Bug: 274517647
Test: Fold and unfold a few times. Use a few applications. Make sure the task bar is visible and in the right place (tested with ENABLE_TASKBAR_NO_RECREATION and FLAG_HIDE_NAVBAR_WINDOW both on, both off, and one on and one off)
Change-Id: Ic3f0aa3d056fe178a53b76b2ad6cc6b9bffd5898
 2023-09-10 22:43:47 -07:00
Jagrut DesaiandAndroid (Google) Code Review 2a0d7b5a11 Merge "Add haptic feeback for Transient Taskbar" into main 2023-09-09 02:54:02 +00:00
Andy WickhamandAutomerger Merge Worker 43da2dc409 Merge "Add tests for LPH override for 3 button mode Taskbar." into udc-qpr-dev am: 3289e4fa35 am: 294a40b1be 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24607784

Change-Id: Id8ba2e642aad256612f21e6026adbf5c2e756123
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-08 23:49:12 +00:00
Brian IsganitisandAndroid (Google) Code Review 648d917a29 Merge "Add All Apps search icon variant behind flag." into main 2023-09-08 23:39:23 +00:00
Jagrut Desai 54677143b1 Add haptic feeback for Transient Taskbar 
Bug: 264851582
Test: Manual
Flag: Not needed
Change-Id: Id5f0e386968291f4c4a897bebf40c59aba33c3d4
 2023-09-08 15:39:12 -07:00
Brian Isganitis 8215d8be32 Close overlay onTaskStackChanged when All Apps is visible. 
We have too many cases where All Apps can relaunch the current task
behind it to the point where it will not be sustainable to manually
close AFVs in all of these cases.

Test: Manual
Fix: 299169192
Fix: 299169075
Fix: 299169073
Flag: No
Change-Id: If3d9aa756ff5e5d6fbaf5f91d2ccc0c5c11a5c23
 2023-09-08 20:51:58 +00:00
Andy WickhamandAutomerger Merge Worker 294a40b1be Merge "Add tests for LPH override for 3 button mode Taskbar." into udc-qpr-dev am: 3289e4fa35 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24607784

Change-Id: I87cd79905c5febcd0391d75b9756522ad3d1ba34
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-08 16:44:53 +00:00
Brian IsganitisandAutomerger Merge Worker 46cabfebdc Register OnAttachStateChangeListener before attaching to container. am: 503f04f86d am: a62d85752e 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24681979

Change-Id: I18e1ee9b5c46affdf90f3fbbb9327db4bbe178e2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-07 23:44:35 +00:00
Andy WickhamandAndroid (Google) Code Review 3289e4fa35 Merge "Add tests for LPH override for 3 button mode Taskbar." into udc-qpr-dev 2023-09-07 23:43:42 +00:00
Brian IsganitisandAutomerger Merge Worker a62d85752e Register OnAttachStateChangeListener before attaching to container. am: 503f04f86d 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24681979

Change-Id: Iae9abea705e1f379cb605ed286de6ee4e6df8168
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-07 22:54:25 +00:00
fbaron 30d9e3fb06 Add smartspace custom widget 
Flag: SMARTSPACE_AS_A_WIDGET
Test: no test
Bug: 200721106
Change-Id: I4ae4ff72ff7267bab0b5a928f3f78b47f7cfbc1f
 2023-09-07 20:27:59 +00:00
Brian Isganitis 503f04f86d Register OnAttachStateChangeListener before attaching to container. 
If we do the reverse, there is a change onAttach will occur before the
callback is registered and invokable (e.g. overlay window already exists
for EDU).

Test: Manual
Fix: 299335210
Flag: None
Change-Id: Ic4befe900c9582e1b01c2bc4699b431f95efa617
 2023-09-07 19:15:10 +00:00
Brian Isganitis 0b9c0589b7 Add All Apps search icon variant behind flag. 
Bug: 265170176
Test: https://b.corp.google.com/issues/265170176#comment15
Flag: ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
Change-Id: I0f5fa4fbbab687d92435d299656b9c27d93525b4
 2023-09-07 18:29:46 +00:00
Vinit NayakandAndroid (Google) Code Review e6747e4caa Merge "Revert "Revert "Revert "Hold WeakReference to split callback"""" into main 2023-09-07 18:29:40 +00:00
Vinit NayakandAndroid (Google) Code Review 8248585a0c Revert "Revert "Revert "Hold WeakReference to split callback""" 
This reverts commit bb9fe16254.

Reason for revert: b/299403672

Change-Id: I8107bc69c033cb70333d5920cfee0700fe1f63a6
 2023-09-07 18:15:17 +00:00
Brian IsganitisandAndroid (Google) Code Review c9420c3561 Merge "Close IME on Taskbar drag." into main 2023-09-07 17:41:51 +00:00
Schneider Victor-tuliasandAndroid (Google) Code Review f573abadb7 Merge "Add error handling to prevent IllegalArgumentException" into main 2023-09-07 16:03:17 +00:00
Vinit NayakandAndroid (Google) Code Review 6fe9c3e555 Merge "Revert "Revert "Hold WeakReference to split callback""" into main 2023-09-07 04:55:33 +00:00
Brian Isganitis 1219d69625 Close IME on Taskbar drag. 
Matches LauncherDragController#startDrag impl.

Test: Manual
Fix: 299167809
Flag: No
Change-Id: If6552b0c9cf7bfcdd01f1802eaf895bde4f357d8
 2023-09-06 22:06:54 +00:00
Jagrut Desai cd667ed4ad Clear TaskbarDividerPopupView callback upon closing 
- Breakout CL part 4
- This is a breakout cl from ag/24272821 to make it more readable and atomic.
- This cl consist of clearing callbacks after calling close once, so that we don't run into scenario where user is able to close popup multiple times leading to crash.

Test: Manual, Visual
Bug: 265170176
Flag: ENABLE_TASKBAR_PINNING
Change-Id: Ie4cd95c69a559a17b7c19a64a71ccf6ac20542d7
 2023-09-06 17:53:34 +00:00
Ivan Tkachenko 72597e32cb Bubble bar user education 
Launcher support for the user education logic described in ag/24587530.

Bug: 275077944
Test: TBD
Flag: WM_BUBBLE_BAR
Change-Id: I2b9a6ecde332de6305ad574c41d8322d8bb5d7ad
 2023-09-06 14:19:31 +00:00
Brandon DayauonandAutomerger Merge Worker cc9a529293 Merge "Add nullable annotation" into udc-qpr-dev am: 31679166a7 am: b33d906d87 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24544468

Change-Id: I21f2072984d2620a0012180ea8ef0ffc1f78c110
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-05 18:59:17 +00:00
Brandon DayauonandAutomerger Merge Worker b33d906d87 Merge "Add nullable annotation" into udc-qpr-dev am: 31679166a7 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24544468

Change-Id: Ifd6ac159f610f6a9a3a0f409778a6084f411949f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-05 18:09:33 +00:00
Brandon DayauonandAndroid (Google) Code Review 31679166a7 Merge "Add nullable annotation" into udc-qpr-dev 2023-09-05 16:50:38 +00:00
Schneider Victor-tulias 785a7511b6 Add error handling to prevent IllegalArgumentException 
ActivityLaunchAnimator.Controller.fromView requires an instance of LaunchableView, however findViewWithBackground had no checks to return one. updated the check to make the exception less likely.

Flag: not needed
Fixes: 297564681
Test: ran launcher and launched apps
Change-Id: Iddbe55c1ff66b067f8456d058cbc60a2a698c4ae
Merged-In: Iddbe55c1ff66b067f8456d058cbc60a2a698c4ae
 2023-09-05 13:58:42 +00:00
Schneider Victor-tulias 0fb4b268e5 Add error handling to prevent IllegalArgumentException 
ActivityLaunchAnimator.Controller.fromView requires an instance of LaunchableView, however findViewWithBackground had no checks to return one. updated the check to make the exception less likely.

Flag: not needed
Fixes: 297564681
Test: ran launcher and launched apps
Change-Id: Iddbe55c1ff66b067f8456d058cbc60a2a698c4ae
 2023-09-05 13:57:11 +00:00
Saumya PrakashandAutomerger Merge Worker 53b19f1b6a Merge "Ensure Gesture Nav Edu animation scales to fit different screen sizes" into udc-qpr-dev am: 15b0c9ea54 am: a2c965726e 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24623620

Change-Id: Ice6431407e0a6cf6f69eb9440f79c38badbcaa81
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-02 01:44:51 +00:00
Sunny GoyalandAutomerger Merge Worker 175ad05a06 Merge "Fixes broken callbacks in RecentsAnimationCallbacks" into udc-qpr-dev am: a6f089c5fc am: aee84be4b6 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24589979

Change-Id: I7139b62fe6985e407880966c434d621da3af508c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-02 01:43:11 +00:00
Saumya PrakashandAutomerger Merge Worker a2c965726e Merge "Ensure Gesture Nav Edu animation scales to fit different screen sizes" into udc-qpr-dev am: 15b0c9ea54 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24623620

Change-Id: I76dcb5ab590f458fdebb2b171e3faf58d7d919f7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-02 00:48:43 +00:00
Sunny GoyalandAutomerger Merge Worker aee84be4b6 Merge "Fixes broken callbacks in RecentsAnimationCallbacks" into udc-qpr-dev am: a6f089c5fc 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24589979

Change-Id: I790f16e73181bd299e9e229401015784588bd245
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-02 00:48:15 +00:00
Tony WickhamandAutomerger Merge Worker 7bbc5a3c01 Merge "Update TaskView corner radius dynamically" into udc-qpr-dev am: 2677e04510 am: 0eb2b24d68 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24627246

Change-Id: Ib3fb4c43fd651a017746e2ff8cff17dec3eab057
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-02 00:04:10 +00:00
Saumya PrakashandAndroid (Google) Code Review 15b0c9ea54 Merge "Ensure Gesture Nav Edu animation scales to fit different screen sizes" into udc-qpr-dev 2023-09-01 23:49:30 +00:00
Sunny GoyalandAndroid (Google) Code Review a6f089c5fc Merge "Fixes broken callbacks in RecentsAnimationCallbacks" into udc-qpr-dev 2023-09-01 23:46:02 +00:00