Commit Graph

4275 Commits

Author SHA1 Message Date
Winson Chung 00850fb588 Create a new instance of rotation touch helper per device state
Change-Id: I4e4288eaf37aab5bf0b8115f5e06e64459c20f00
2020-07-20 13:57:56 -07:00
Jon Miranda a73b532e87 Fix bug where double swipe gets us stuck in Hint state while in Overview. am: a8c08584a7 am: 721d5c7cc7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12173854

Change-Id: Iaab1df73b6f7a60ef829ec9372b71b0266641d50
2020-07-20 18:45:50 +00:00
Jon Miranda a8c08584a7 Fix bug where double swipe gets us stuck in Hint state while in Overview.
With the second swipe, we never complete the swipe to Overview

NoButtonNavbarToOverviewTouchController#maybeSwipeInteractionToOverviewComplete
- mReachedOverview = true
- mDetector.isSettlingState = false

And then the second swipe starts the state transition to Hint but then
it never gets completed because:
1. The animation starts
2. Gets cancelled
3. Starts again
4. Finishes, but is not marked as success since the cancel in #2 was never
   set back to false

Bug: 160759508
Change-Id: I8c3972e6209c3d5a4a0bdd9f9b7683de18105d57
2020-07-20 10:29:29 -07:00
TreeHugger Robot d8181f4dd3 Merge "Removing workarounds for a fixed bug" into ub-launcher3-master 2020-07-18 19:38:56 +00:00
TreeHugger Robot f9db9d321d Merge "Notify TaskViews of updated orientation state" into ub-launcher3-rvc-qpr-dev am: dbca5a4190 am: 3857d2645f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12142279

Change-Id: I1085f9a8652a38c3daa0fb83b4de2d8d84ba4364
2020-07-18 00:19:58 +00:00
TreeHugger Robot dbca5a4190 Merge "Notify TaskViews of updated orientation state" into ub-launcher3-rvc-qpr-dev 2020-07-17 23:31:54 +00:00
TreeHugger Robot f7ca580c99 Merge "Prevent showing TaskMenuView if icon isn't present" into ub-launcher3-rvc-qpr-dev am: 4b1d1a0f18 am: 3a80d76fac
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12130181

Change-Id: If090c1028ce2a6656390a93607a6d0822a09f97b
2020-07-17 23:06:12 +00:00
TreeHugger Robot 12dc76e76c Merge "Move rotation logic to RotationTouchHelper" into ub-launcher3-rvc-qpr-dev am: eb2eb38cc2 am: eb682915f0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12155343

Change-Id: Idd86a05c6b3d4a1765d53ccea81b509d7b779acb
2020-07-17 23:05:48 +00:00
Sreyas Rangaraju c2ceba35c8 Merge "Disabling overview actions when thumbnail is not loaded." into ub-launcher3-rvc-qpr-dev am: e1037c63dd am: d84cdd36ab
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12160683

Change-Id: Ib90f7fa91ec6e74830466b662b45a0c7b0f6cd83
2020-07-17 23:05:43 +00:00
Sreyas d246ad18da Reset disabled flags when action buttons lose visibility. am: 0d2eea3316 am: e73bd5ed99
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12161695

Change-Id: If89964f90a2cf4d78e343d8514e08e92be9be6a3
2020-07-17 23:05:36 +00:00
Tony Wickham 60bc684060 Merge "Wait until activity present before calling onEndTargetCalculated()" into ub-launcher3-rvc-qpr-dev am: 032db3289a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12141305

Change-Id: Ib91c86e49145874b481554fa2382678eb03e4239
2020-07-17 20:26:29 +00:00
Sunny Goyal 7d9c18392d Merge "Preventing disambiguation screen when swiping up" into ub-launcher3-rvc-dev am: c031040a2f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12141301

Change-Id: I59ec7dd9e689d4f3a712364a74f341d730f00f8e
2020-07-17 19:20:16 +00:00
TreeHugger Robot 21ff5c4ff0 Merge "Persist prediction cache on every update" into ub-launcher3-rvc-dev am: 1cc0010eba
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12077679

Change-Id: I5f2cbe314dfb249594a2dff70cda5188cad60fa1
2020-07-17 19:19:40 +00:00
Sunny Goyal 5d09b2e358 Updating some comments and variables
Change-Id: Ib3223c66e9ce187cebc6ce26a46b228f95787778
2020-07-17 18:58:49 +00:00
Sunny Goyal 12f46d521a Fixing recents orientation (when home rotation is allowed) during swipe-up
Bug: 158781568
Bug: 160149607
Change-Id: I27be09febcdb6f19687469db34b002ce682aa0cb
Merged-In: I27be09febcdb6f19687469db34b002ce682aa0cb
(cherry picked from commit 141c231d2f)
2020-07-17 18:53:01 +00:00
TreeHugger Robot 1d96d2370f Merge "Let AllAppsEduView consume touch until animation is done and view is removed." into ub-launcher3-rvc-qpr-dev am: 95c620c38d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12121641

Change-Id: I70aa4d0ffa4dfd2ef21d7ea54a7293b4243cf1cd
2020-07-17 01:48:23 +00:00
TreeHugger Robot 30d771860e Merge "Updating gesture tutorial home animation" into ub-launcher3-rvc-qpr-dev am: 24ddf21cea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12117946

Change-Id: I6a86fd320482d9f3b894b8ff8eb5c7f0d5bdc9ca
2020-07-17 01:47:52 +00:00
TreeHugger Robot d7ef768f51 Merge "Adding nullcheck while launching task during quickswitch" into ub-launcher3-rvc-qpr-dev am: 6381d38249
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12119527

Change-Id: I48126c4905e20135cdb7091777d9cdf0e2d5f6ba
2020-07-17 01:47:19 +00:00
TreeHugger Robot 4b1d1a0f18 Merge "Prevent showing TaskMenuView if icon isn't present" into ub-launcher3-rvc-qpr-dev 2020-07-17 00:04:41 +00:00
Sunny Goyal 852537fd98 Using StatsLog for notifyingAppPredictor
> Adding a listener in StartsLogManager for listening to events.
  This allows events to be directored to the predictor only if
  it is already running, instead of creating it.
> Unifying the event format to be same as hotseat predictor

Bug: 160748731
Change-Id: Ib00e6249ff642c030f00bcad5b748255e704d16a
2020-07-16 14:12:15 -07:00
Tony Wickham 94be66acd6 Fix tracking window being slightly off when swiping from an app
Test: swipe up from an app in landscape, seascape, and portrait,
and verify the window tracks with the finger 1:1 until pullback

Bug: 149934536
Change-Id: Ia469877e7152c8135e0b9153f69c191ba86cbd14
(cherry picked from commit f0a1b2ccd8)
2020-07-16 20:03:36 +00:00
TreeHugger Robot eb2eb38cc2 Merge "Move rotation logic to RotationTouchHelper" into ub-launcher3-rvc-qpr-dev 2020-07-16 05:14:25 +00:00
Vinit Nayak 0affd89031 Move rotation logic to RotationTouchHelper
No functional changes.

Fixes: 159764370
Change-Id: Ie7739a62242377bda69c86bd46e24d2f847f17e0
2020-07-15 22:03:14 -07:00
Sreyas Rangaraju e1037c63dd Merge "Disabling overview actions when thumbnail is not loaded." into ub-launcher3-rvc-qpr-dev 2020-07-15 23:31:51 +00:00
Sreyas 0d2eea3316 Reset disabled flags when action buttons lose visibility.
Bug: 159993889
Change-Id: Id2a38eee5de067d5e8f1df425644dfdcb3334cdb
2020-07-15 16:16:43 -07:00
Sreyas 68330a93fa Disabling overview actions when thumbnail is not loaded.
Bug: 160331177
Change-Id: I05eaec7d6f2e3f2ba71d8148a4e97dcf5a1522c6
2020-07-15 19:46:09 +00:00
Sunny Goyal 75bf867d96 Fixing swiping up on home interrupting animation am: 369501d8aa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12152001

Change-Id: I7dc92aae75718c5460a2a2981880b536339f39d9
2020-07-14 19:57:54 +00:00
Sunny Goyal 369501d8aa Fixing swiping up on home interrupting animation
Bug: 161180005
Change-Id: Ida59b87b2fb5905d98b0090630a6ce32fc9c36c8
(cherry picked from commit 93188d61da)
2020-07-14 19:07:51 +00:00
Sunny Goyal ec78aef4fc Merge "Fixing swiping up on home interrupting animation" into ub-launcher3-rvc-qpr-dev 2020-07-14 16:01:43 +00:00
Tracy Zhou 0ca024d259 Merge "Place launcher above the target app in live tile mode" into ub-launcher3-master 2020-07-14 05:35:28 +00:00
vadimt 4bc691b988 Removing workarounds for a fixed bug
Bug: 148422894
Change-Id: Ic6faa173ac5f28c8656daf68ac8304563264afdd
2020-07-13 20:02:13 -07:00
Sunny Goyal 93188d61da Fixing swiping up on home interrupting animation
Bug: 161180005
Change-Id: Ida59b87b2fb5905d98b0090630a6ce32fc9c36c8
2020-07-13 17:44:56 -07:00
TreeHugger Robot add69c70c4 Merge "Fix velocity in StaggeredWorkspaceAnimation." into ub-launcher3-rvc-qpr-dev 2020-07-13 22:20:33 +00:00
TreeHugger Robot 054280dba4 Merge "Using original taskInfo to create the taskKey instead of fake data" into ub-launcher3-rvc-qpr-dev 2020-07-13 22:06:13 +00:00
Jon Miranda aee792403d Fix velocity in StaggeredWorkspaceAnimation.
* Velocity should match the direction of the spring values.
  (Swipe direction is upwards, but icons move downwards on screen).
* Remove additional conversion to pxPerS since getDimension already does that.

Bug: 160003774
Change-Id: I12912edb2354c4a30c538da6ca3789c46d82b94d
(cherry picked from commit 54003963d8)
2020-07-13 21:48:19 +00:00
Sunny Goyal 55a9b544c9 Using original taskInfo to create the taskKey instead of fake data
Change-Id: Ie4e35b35484e0f6cb939febe6357b37381d81682
(cherry picked from commit fabfb3ae90)
2020-07-13 21:47:16 +00:00
Pinyao Ting 9d51e49cec Fixes the issue Launcher state propagation is slower than onDeferredResume.
There's currently a bug prevents Launcher release drag lock for two step
widgets. Supposedly, onDeferredResume should release the drag lock; However,
in 3-button navigation mode, the transition from Overview -> Normal is
triggered in Launcher#onNewIntent, which happens after onDeferredResume.

This issue is not reproducible with gesture navigation because its
transition from Overview -> Normal is handled in NavBarToHomeTouchController

Test: manual verified with following steps
1. Enable 3-button navigation
2. Long press in WorkSpace -> Widgets
3. Drag Settings Widget to WorkSpace
4. When the config activity is shown, press "recents" button to see Overview
5. press "home" button to go back to workspace
6. repeat 2 and 3, verify the widget can be dragged
Bug: 149659788

Change-Id: I396ffa8a7db44bf3872a10de4208340a99a7efe8
(cherry picked from commit 3bf889a02f)
2020-07-13 21:46:05 +00:00
Vinit Nayak de43fb6323 Notify TaskViews of updated orientation state
There was a race condition between when recent
tasks get loaded for overview and when the
RecentsOrientationState gets updated based on
which orientation was touched. Now notify
tasks view every time orientation state
updates.

Fixes: 160912655
Test: Kill launcher while landscape app
is open then swipe up to recents.
App in correct location.

Change-Id: If2b239f748c000257bd91b14a23d68ba026e3a48
2020-07-13 14:31:24 -07:00
TreeHugger Robot 5491b2e2e0 Merge "Fix shelf tracking distance for landscape app over portrait launcher" into ub-launcher3-rvc-qpr-dev 2020-07-13 20:44:30 +00:00
Tony Wickham 032db3289a Merge "Wait until activity present before calling onEndTargetCalculated()" into ub-launcher3-rvc-qpr-dev 2020-07-13 20:37:15 +00:00
Tony Wickham 452db0db0c Fix shelf tracking distance for landscape app over portrait launcher
Bug: 149934536
Change-Id: I14fa62fa9f51356613f4a3827446b00af774dbf5
2020-07-13 13:21:02 -07:00
Sunny Goyal 386b75305c Merge "Preventing disambiguation screen when swiping up" into ub-launcher3-rvc-dev am: c031040a2f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12141301

Change-Id: Icca8524c3d2ea19c50015825138dd916d5e13161
2020-07-13 19:44:03 +00:00
Tony Wickham ddbaadb562 Wait until activity present before calling onEndTargetCalculated()
At least one code path relies on the activity to be created: if the
end target is RECENTS, we add a state manager listener to see when
user goes to NORMAL state.

Fixes: 160903658
Change-Id: I3449dec773399f7e9cf2e7ef8b79734b1baa59b4
2020-07-13 12:32:37 -07:00
Sunny Goyal a639d46c8b Preventing disambiguation screen when swiping up
Bug: 161052537
Change-Id: Ibeeba0841963dc5eb1b5a09847cafc26eb6e4adc
2020-07-13 10:42:47 -07:00
Tracy Zhou 611fe76180 Place launcher above the target app in live tile mode
Fixes: 160361464
Test: manual
Change-Id: Id9d012fb71c6817ce82aa048d3dd56ea4d456f01
2020-07-11 20:54:31 -07:00
Bill Yi 2ef5f38ae5 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I7f36648a52740ae4e104c8bd2f0321f541ee218f
2020-07-10 14:54:57 -07:00
Bill Yi 7a1ffa3222 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I89c54ef089cf1b7db377ec3d7759e1e727b7bd70
2020-07-10 14:54:19 -07:00
Vinit Nayak 2060a4b9e1 Prevent showing TaskMenuView if icon isn't present
Also fixed another bug where the wrong layout
orientation was being applied when overview rotated
when launcher was in fixed portrait orientation.

Fixes: 160182914
Test: Tested w/ PIP, split screen,
w/o split screen w/ and w/o home rotation

Change-Id: Iccffb637ae5c22d07745f2108facd4de716dc8d3
2020-07-10 11:55:06 -07:00
TreeHugger Robot c3c15cc946 Merge "Updating some comments and variables" into ub-launcher3-rvc-qpr-dev 2020-07-10 00:50:36 +00:00
Tracy Zhou fdfe61071b Merge "Update the position of the live tile overlay upon swipe up" into ub-launcher3-master 2020-07-10 00:23:46 +00:00