Commit Graph

1148 Commits

Author SHA1 Message Date
Brandon Dayauon 1507785a36 Merge "Method to override feature flag" into tm-qpr-dev am: fb9c4d25c4 am: ebd8065f19
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21306841

Change-Id: I6b442087c14ef91f3283c00fb85fd8d72a55aa27
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-10 00:41:39 +00:00
Brandon Dayauon fb9c4d25c4 Merge "Method to override feature flag" into tm-qpr-dev 2023-02-09 23:31:47 +00:00
Thales Lima bb056c6001 Merge "Create an XML parser for WorkspaceSpecs" into tm-qpr-dev am: 5d5aad3024 am: 0ebaf3a46c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20643018

Change-Id: I471bb3ccd04a0598a309e53038976fbccb638ce1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-09 13:01:28 +00:00
Brandon Dayauon 533e4856b4 Method to override feature flag
- Replaced where it's used in GridSizeMigrationUtilTest.kt

bug: 268094298
test: manually/presubmit and GridSizeMigrationUtilTest photo: https://screenshot.googleplex.com/7cLtFSbBvxnYAFM
Change-Id: Id8e688b95b91b1b6a4962a4e092505cbb79603f7
2023-02-08 17:01:46 -08:00
Thales Lima 1a2d4bd6f4 Create an XML parser for WorkspaceSpecs
Extract DeviceProfileTest to Launcher3 so it can be used in other tests as well, and change name of previous base test to be more descriptive.

Bug: 241386436
Test: WorkspaceSpecsTest
Change-Id: I64613bb5a23c374ed15fb6d936192236a541ab9b
2023-02-08 11:20:14 +00:00
Thales Lima a91f5251b6 Merge "Improvements for All Apps on different display sizes" into tm-qpr-dev am: fcb6a5fc06 am: f0c4b41bf1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21116563

Change-Id: Ifbf110cb76d348a8b6a3b3fdd0f47a4b10dcfe4d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-08 11:05:07 +00:00
Thales Lima fcb6a5fc06 Merge "Improvements for All Apps on different display sizes" into tm-qpr-dev 2023-02-08 10:02:17 +00:00
TreeHugger Robot 4a2bf3b131 Merge "Update tests to support floating search." into tm-qpr-dev 2023-02-06 23:50:49 +00:00
Andy Wickham 8d004b0f49 Update tests to support floating search.
Tests need to be updated to account for the new placement of the
searchbar because it overlapped with touch events for scrolling:
 - Scroll back to top: Instead of scrolling from the top of the
   container which could overlap status bar in landscape, scroll
   from the bottom of the top-most visible app icon.
 - Scroll down: swipe up from bottom padding to top of top-most
   visible icon.
 - Close all apps: swipe down more quickly from top icon insetad
   of the search bar (more quickly helps it be detected as a
   fling on more cramped devices).

For Launcher3, the floating flag is not fully supported yet, so
there were some layout issues which are now resolved by ignoring
the flag if the searchbar is still at the top.

Fix: 268052768
Test: Ran tests, manual
Change-Id: If54717e2835c7cc4ed1368554bbc493193945c1d
Merged-In: I406fbcbe12acddb1dd4b862a380576a48cabbebc
2023-02-06 13:49:14 -08:00
Andy Wickham 8353c38f92 Merge "[revert ^2] Enable Floating Search and update tests accordingly." 2023-02-04 09:19:18 +00:00
Andy Wickham 346771550e [revert ^2] Enable Floating Search and update tests accordingly.
Tests need to be updated to account for the new placement of the
searchbar because it overlapped with touch events for scrolling:
 - Scroll back to top: Instead of scrolling from the top of the
   container which could overlap status bar in landscape, scroll
   from the bottom of the top-most visible app icon.
 - Scroll down: swipe up from bottom padding to top of top-most
   visible icon.
 - Close all apps: swipe down more quickly from top icon insetad
   of the search bar (more quickly helps it be detected as a
   fling on more cramped devices).

For Launcher3, the floating flag is not fully supported yet, so
there were some layout issues which are now resolved by ignoring
the flag if the searchbar is still at the top.

Fix: 261873937
Test: Ran tests, manual
Change-Id: I406fbcbe12acddb1dd4b862a380576a48cabbebc
2023-02-03 14:24:22 -08:00
Sebastián Franco 04ba7b0e23 Merge "Adding test to make sure the icons seen when unfolded are the same when folded" into tm-qpr-dev am: b57479c189 am: 591b511565
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21120301

Change-Id: Ib3709fdadf7a07006f5916461f636ea7abc81b03
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-03 21:35:38 +00:00
Sebastián Franco b57479c189 Merge "Adding test to make sure the icons seen when unfolded are the same when folded" into tm-qpr-dev 2023-02-03 20:39:04 +00:00
Sam Dubey 51e1ef37f7 Merge "Revert "Enable Floating Search by default and update tests accordingly."" 2023-02-03 14:42:49 +00:00
Sam Dubey 29f78a597b Revert "Enable Floating Search by default and update tests accordingly."
This reverts commit 952400d2f2.

Reason for revert: b/267743311

Change-Id: I007274cdea1c424c87ddea4592e9e1c7a273bea9
2023-02-03 12:45:15 +00:00
Andy Wickham 89638d2252 Merge "Enable Floating Search by default and update tests accordingly." 2023-02-03 10:27:38 +00:00
Sunny Goyal f98fc1d099 Merge "Exposing method to register content providers in sandbox context" into tm-qpr-dev am: de15772052 am: 459f2c7114
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21236578

Change-Id: Icb74ab16c876aa65db0110a6e39faa50ec4f0a09
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-03 08:29:53 +00:00
Sunny Goyal de15772052 Merge "Exposing method to register content providers in sandbox context" into tm-qpr-dev 2023-02-03 07:34:10 +00:00
Andy Wickham 952400d2f2 Enable Floating Search by default and update tests accordingly.
Tests need to be updated to account for the new placement of the
searchbar because it overlapped with touch events for scrolling:
 - Scroll back to top: Instead of scrolling from the top of the
   container which could overlap status bar in landscape, scroll
   from the bottom of the top-most visible app icon.
 - Scroll down: swipe up from bottom padding to top of top-most
   visible icon.
 - Close all apps: swipe down fom top of recyclerview instead
   of search bar.

For Launcher3, the floating flag is not fully supported yet, so
there were some layout issues which are now resolved by ignoring
the flag if the searchbar is still at the top.

Fix: 261873937
Test: Ran tests, manual
Change-Id: I7d6fc7deac630835b96fc173211ce31271152607
2023-02-02 21:05:52 -08:00
Jon Miranda 3c76c2212a Merge "Update notification dot renderer when we update the taskbar icon size." into tm-qpr-dev am: 5903751ee3 am: 82382fc784
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21225224

Change-Id: Iec7cd640cb84417f231dd440490a6d1c78b38465
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-03 02:29:15 +00:00
Jon Miranda 5903751ee3 Merge "Update notification dot renderer when we update the taskbar icon size." into tm-qpr-dev 2023-02-03 01:34:05 +00:00
Stefan Andonian c0d6de8bcf Merge "Migrate "isRotationAllowed" setting to LauncherPrefs." into tm-qpr-dev am: 6a4e9a34ab am: 424c469513
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21061164

Change-Id: I81a4aff8f133dfef57205cc423471fbb4fb2c08c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-03 01:18:45 +00:00
Stefan Andonian 6a4e9a34ab Merge "Migrate "isRotationAllowed" setting to LauncherPrefs." into tm-qpr-dev 2023-02-03 00:27:14 +00:00
Sunny Goyal 305cb87891 Exposing method to register content providers in sandbox context
Bug: 263286512
Test: presubmit
Change-Id: I04a8160afec2ea0d153eca113537a8778d8f3514
2023-02-02 15:20:58 -08:00
Jon Miranda 2b25ded506 Update notification dot renderer when we update the taskbar icon size.
Test: swipe to home with an app that has a notification dot
      observe no jump in dot size
Bug: 264709741

Change-Id: I5d56fe57e74ed7b094477ecd8727152f3f522042
2023-02-02 23:10:42 +00:00
TreeHugger Robot b59cdf26ab Merge "Add @ScreenRecord to testPressHomeOnAllAppsContextMenu" into tm-qpr-dev am: 18be12d0dd am: fda08cb9cb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21136643

Change-Id: Id5d7459eb28d8c4cf9e992e1f2ac61d05e11dd19
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-01 21:28:20 +00:00
Sebastian Franco 48c7f8e035 Adding test to make sure the icons seen when unfolded are the same when folded
Bug: 188081026
Test: atest FoldableItemsIntegrity
Change-Id: I7e09c03fccb89b1d218bf196433b2fe4ad09d8e0
2023-02-01 13:22:33 -08:00
Stefan Andonian 1d7f703514 Migrate "isRotationAllowed" setting to LauncherPrefs.
This semi-complicated case requires use of a context in order to get the
default value. That is why it was migrated by itself.

Bug: 261635315
Test: Manually tested all the base functionality of the launcher.
Change-Id: I40d8ccd414402b55921a0a224264414d3245871b
2023-02-01 20:26:41 +00:00
TreeHugger Robot 18be12d0dd Merge "Add @ScreenRecord to testPressHomeOnAllAppsContextMenu" into tm-qpr-dev 2023-02-01 18:51:31 +00:00
Thales Lima e9273ea743 Improvements for All Apps on different display sizes
Bug: 262912817
Test: DeviceProfileAlternativeDisplaysDumpTest
Change-Id: I50e980183b4d5c1a46cca8f1c867b866b9eae4b5
2023-02-01 11:34:12 +00:00
Sunny Goyal 5fc8131b60 Merge "Introducing CellPosMapper which allows mapping between UI position and model position" into tm-qpr-dev am: 126ac14112 am: a19f661961
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21128574

Change-Id: Id2cdf2a5262def0401cd2a60fbe89044f55a9c98
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-31 19:30:30 +00:00
Sunny Goyal 669b71f5b3 Introducing CellPosMapper which allows mapping between UI position
and model position

Test: atest CellPosMapperTest
Bug: 188081026
Change-Id: If5c6b3df5ad240317bb535c675f6ead94084238e
2023-01-30 12:17:09 -08:00
hyunyoungs 50b824392a Add @ScreenRecord to testPressHomeOnAllAppsContextMenu
Bug: 264538883
Test: seems to run fin on tm-qpr-dev
Change-Id: If395260ba58496282b651e1938e28f3cef22654f
2023-01-28 18:55:05 -08:00
Thales Lima d852d65693 Create attr for padding between icon and text in cells
Bug: 265210314
Test: DeviceProfileDumpTest
Change-Id: I00af790d0c21c35f1cbce1362e63d3ab8259244a
Merged-In: I00af790d0c21c35f1cbce1362e63d3ab8259244a
2023-01-26 22:50:18 +00:00
Thales Lima 903d0a3e63 Create attr for padding between icon and text in cells
Bug: 265210314
Test: DeviceProfileDumpTest
Change-Id: I00af790d0c21c35f1cbce1362e63d3ab8259244a
(cherry picked from commit 60cab75576e9f844fcaae8f0723a075f2a00bb1f)
Merged-In: I00af790d0c21c35f1cbce1362e63d3ab8259244a
2023-01-26 15:40:27 +00:00
Sebastián Franco 1b3d1cfa64 Merge "Adding the avility to add icons on multiple CellLayouts on tests." into tm-qpr-dev am: 68f5667338 am: 56f91702d2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20890013

Change-Id: I3b9bad730707d9e5dca8f10acdb43991cd51c290
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-24 23:11:45 +00:00
Sebastián Franco 68f5667338 Merge "Adding the avility to add icons on multiple CellLayouts on tests." into tm-qpr-dev 2023-01-24 20:02:35 +00:00
Sunny Goyal a992ac9e8d Moving all intent receiver register calls to a single place
This is eventually allow us to move all register to background thread
Also creating a single ScreenOn tracked which is used at multiple places

Bug: 264465756
Test: Verified on device
Change-Id: Ibadf9ca43218e578954420d97a733adfa0a94fc7
Merged-In: Ib410e5bf02773cefde5bf0a0a1f2f1c108718d24
2023-01-22 05:24:48 +00:00
Sunny Goyal a1692a467f Moving all intent receiver register calls to a single place
This is eventually allow us to move all register to background thread
Also creating a single ScreenOn tracked which is used at multiple places

Bug: 264465756
Test: Verified on device
Change-Id: Ibadf9ca43218e578954420d97a733adfa0a94fc7
2023-01-20 23:50:00 +00:00
Sebastián Franco a1707e3007 Merge "Remove unused Throw Throwable from clearHomescreen method" into tm-qpr-dev am: 48651b2109 am: c18a4081d5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20831584

Change-Id: Ie10f728d6e544214f2ac91a209fd500635030a5a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-18 02:29:42 +00:00
Sebastián Franco 48651b2109 Merge "Remove unused Throw Throwable from clearHomescreen method" into tm-qpr-dev 2023-01-18 01:12:23 +00:00
Stefan Andonian 6a651e63c9 Merge "Expanded LauncherPrefs APIs to Replace Direct Shared Preference Usage." into tm-qpr-dev am: 1eb59d6c6a am: 60e3b74522
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20764866

Change-Id: I7a69b534e3df890034eb897e8d61517e75828702
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-17 19:29:02 +00:00
Stefan Andonian 1eb59d6c6a Merge "Expanded LauncherPrefs APIs to Replace Direct Shared Preference Usage." into tm-qpr-dev 2023-01-17 18:23:10 +00:00
Sebastian Franco de1fe14a47 Adding the avility to add icons on multiple CellLayouts on tests.
I needed to change the code so that you can pass the CellX/Y
position to the drag function instead of the pixel coordinates
and we can pass X position bigger than one CellLayout.

Also, I notice that getCellCenter only worked for 1x1 items
so I added the option to specify the widget size.

Fix: 262431878
Test: atest ReorderWidgets#multipleCellLayoutsSimpleReorder
Change-Id: I3b09de770e8f99aa10cae8cea32e7e6bc02c7b8b
2023-01-16 10:32:40 -06:00
Stefan Andonian d1b33b311c Expanded LauncherPrefs APIs to Replace Direct Shared Preference Usage.
LauncherPrefs will contain Launcher's shared preference functionality.
It controls optimizations and classifications such as restorable vs
non-restorable data, bootaware vs non-bootaware data, and configurations
such as default values  so the calling code doesn't need to and our code
base can have a single source of truth for items that are used in
multiple places.

The old APIs remain in place, but are deprecated and will be removed
after all Shared Preference usage has been gated by LauncherPrefs in
future CLs.

Bug: 261635315
Test: Manually tested themed icon, Workspace configuration, and app
install functionality.

Change-Id: I29fd516468bc93fda393062e95be26b6d55c816e
2023-01-14 00:54:15 +00:00
Sebastian Franco 877088e6c3 Change the access of cellX/Y of CellLayoutLayoutParams to private
Bug: 188081026
Test: no op change, should compile
Test: ReorderWidgets
Change-Id: I20367974e5a4cead406e18eb66dafd4d59651b2a
Merged-In: I20367974e5a4cead406e18eb66dafd4d59651b2a
2023-01-13 18:25:10 +00:00
Sebastián Franco f55e3690ea Merge "Change the access of cellX/Y of CellLayoutLayoutParams to private" 2023-01-12 21:14:23 +00:00
Christophe Pinelli 2acf5a8492 Merge "Make mutable PendingIntent explicit" into tm-qpr-dev am: 3cd6cbe6b4 am: ab2c2d9576
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20953789

Change-Id: Iafef3bf70a5dfb0c5a72bf814d23d952cfd7f2f9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 20:02:04 +00:00
Sebastian Franco 9db35f7a37 Remove unused Throw Throwable from clearHomescreen method
Test: presubmit
Bug: 263802298
Change-Id: I4b81e044eb4f6a84730fb4d61403cbfcadefd282
2023-01-12 10:41:34 -06:00
Christophe Pinelli 9d46bca1b9 Make mutable PendingIntent explicit
Starting from target SDK U, we will block creation of mutable
PendingIntents with implicit Intents because attackers can mutate the
Intent object within and launch altered behavior on behalf of victim
apps. For more details on the vulnerability, see go/pendingintent-rca.

From a quick analysis, we concluded that the PendingIntent here was only
destined to the test app/to the app, so it was made explicit. Reviewers,
please call out if this is not the case.

Bug: 236704164
Test: atest NexusLauncherTests:com.android.quickstep.DigitalWellBeingToastTest
Test: atest RequestPinItemTest
Change-Id: I81311b0588b7b712c97de6cb016a62bb91c7a77c
2023-01-12 01:51:44 +00:00