Jagrut Desai and Android (Google) Code Review
24231d9994
Merge "Taskbar pinning animation with no recreate" into main
2023-10-26 21:33:41 +00:00
Jagrut Desai
631b284836
Taskbar pinning animation with no recreate
...
Test: Manual, Visual
Bug: 265436799
Flag: LEGACY ENABLE_TASKBAR_PINNING DISABLED
Change-Id: I84a4d1efdb0bd4a0f856fa1f46b6489ef54a3841
2023-10-26 10:36:48 -07:00
Pat Manning and Android (Google) Code Review
821bc0d034
Merge "Clean up overview icon menu flag after tests and refresh device profile." into main
2023-10-26 16:00:48 +00:00
Pat Manning
999af9cab9
Clean up overview icon menu flag after tests and refresh device profile.
...
Fix: 306089019
Test: TaplOverviewIconAppChipMenuTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TRUNKFOOD
Change-Id: I04335967e6bfa52d143a399859e2e745d428ab30
2023-10-26 12:02:40 +01:00
Pat Manning
3a2fde4db4
Go home before getting overview in test to ensure overview will exist.
...
Also when opening settings, do not wait for A11Y event which never fires. (added in ag/24777489, but seems to fail as mentioned here b/303329286#comment2 and tracked here b/298114205)
Fix: 307379525
Fix: 307397957
Bug: 298114205
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TRUNKFOOD
Test: TaplOverviewIconTest
Change-Id: Icd8a47b47d22ddb32db7df6882ec655f0e6f54c1
2023-10-24 14:43:11 +00:00
Pat Manning and Android (Google) Code Review
1f5d5be70d
Merge "Move overview tests to quickstep package." into main
2023-10-23 18:26:38 +00:00
Pat Manning and Android (Google) Code Review
1eb8bd8735
Merge "Increase pinned taskbar height to fit tooltips." into main
2023-10-23 16:13:03 +00:00
Pat Manning
954e3b8dee
Move overview tests to quickstep package.
...
Fix: 305394234
Test: TaplOverviewIconAppChipMenuTest, TaplOverviewIconTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu DEVELOPMENT
Change-Id: Ib39e2ec7f53de0c4b557558776c7ad428e4cab22
2023-10-23 16:15:33 +01:00
Pat Manning
5643e7c047
Increase pinned taskbar height to fit tooltips.
...
Fix: 305706286
Flag: ACONFIG com.android.launcher3.enable_cursor_hover_states TRUNKFOOD
Test: TaskbarHoverToolTipControllerTest
Change-Id: I767947a752eae7a928d59fe332bc62b9fd5b5f37
2023-10-23 15:52:48 +01:00
Jagrut Desai and Android (Google) Code Review
2e53885e86
Merge "Adding screen record TaplTestsQuickStep#testOverviewForTablet" into main
2023-10-20 20:23:16 +00:00
Pat Manning
4c27e8c6f0
Migrate cursor feature flag to trunk stable flag.
...
Fix: 300054410
Test: TaplTestsTransientTaskbar, TaplTestsQuickstep
Flag: enableCursorHoverStates
Change-Id: I5c320e0fd2bdd2ed39b00b62b1399e163c3384e7
2023-10-20 12:17:36 +01:00
Jagrut Desai
caf5c815f3
Adding screen record TaplTestsQuickStep#testOverviewForTablet
...
Test: Presubmit
Bug: 306089019
Flag: NONE
Change-Id: I1e7474fe5f32e895859ca726fc63f40833ada118
2023-10-20 00:38:14 +00:00
Pat Manning and Android (Google) Code Review
df72740384
Merge "Revert "Revert "Combine icon app tests to allow overriding flag ..."" into main
2023-10-17 17:28:24 +00:00
Pat Manning
24cec69361
Revert "Revert "Combine icon app tests to allow overriding flag ..."
...
Revert submission 25032768-revert-25007147-tapl-flag-SBORVHYDTI
Reason for revert: Resubmitting for b/304470271
Reverted changes: /q/submissionid:25032768-revert-25007147-tapl-flag-SBORVHYDTI
Change-Id: Ib0bd13a5c2a366160b185a2c6409c607ed7525a1
2023-10-17 15:56:48 +00:00
Anushree Ganjam and Uwais Ashraf
6ee3a32b12
[Trunk Stable] Use SetFlagsRule.initAllFlagsToReleaseConfigDefault instead of disabling all flags in setUp.
...
Bug: 294913042
Flag: NA
Test: Unit tests
Change-Id: Ib570ce67f53d4af7407b36f6fee1a3517800155f
2023-10-17 10:27:54 +00:00
Sebastián Franco and Android (Google) Code Review
87d482cd3e
Merge "Unifying constant app names used in Tests" into main
2023-10-13 18:28:38 +00:00
Jeremy Sim
7dc3bdcd85
Migrate ENABLE_APP_PAIRS flag to aconfig
...
Fixes: 303323964
Flag: com.android.wm.shell.Flags.FLAG_ENABLE_APP_PAIRS
Test: Unit tests still run correctly
Change-Id: I617c699746492c9c0d131a28791d984afbbdda4d
2023-10-12 15:06:32 -07:00
Tyler Freeman and Android (Google) Code Review
22781d97d9
Merge "Revert "Combine icon app tests to allow overriding flag for new ..."" into main
2023-10-12 20:06:56 +00:00
Tyler Freeman and Android (Google) Code Review
1468467706
Revert "Combine icon app tests to allow overriding flag for new ..."
...
Revert submission 25007147-tapl-flag
Reason for revert: Breaks build: https://b.corp.google.com/issues/305033049
Reverted changes: /q/submissionid:25007147-tapl-flag
Change-Id: I99b5883e64ae25476394a4207c5d6a4d22fc27dc
2023-10-12 18:04:05 +00:00
Pat Manning and Android (Google) Code Review
654c05837e
Merge "Combine icon app tests to allow overriding flag for new icon app chip menu testing as well." into main
2023-10-12 15:59:17 +00:00
Pat Manning
236e738907
Combine icon app tests to allow overriding flag for new icon app chip menu testing as well.
...
Platinum exlude cl update: cl/572225659
Test: TaplOverviewAppIconMenuTest
Test: TaplAppIconAppChipMenuTest
Bug: 303329286
Bug: 303266562
Fix: 304470271
Change-Id: I4ca163401d6a42961e8955e06c164af0254b1231
2023-10-12 14:53:08 +01:00
Treehugger Robot and Android (Google) Code Review
bcd5555863
Merge "Adding Mateusz as an OWNER for Launcher tests" into main
2023-10-11 21:53:30 +00:00
Vadim Tryshev
e86761a225
Adding Mateusz as an OWNER for Launcher tests
...
Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I07a891fe766549208e4402726ee66998db22956d
2023-10-11 14:48:17 -07:00
Vadim Tryshev
f782eaba73
Improving diagnostics from fallback recents tests when phone is not unlocked
...
Failing earlier so that we don't get strange messages from the middle of the test.
Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I1e3c70623e6f907bcc6bd0486b6c75afecb610e3
2023-10-10 19:18:22 -07:00
Federico Baron and Android (Google) Code Review
ca39bd99cc
Merge "Add screenrecord to testOverviewActionsMenu_iconAppChipMenu" into main
2023-10-09 21:29:11 +00:00
Sebastian Franco
02a4fb41c7
Unifying constant app names used in Tests
...
Bug: 298234173
Test: No-op changes, all test should pass
Change-Id: I3cd4854b150d827393bff6eada7aa9a9201dadaa
2023-10-09 14:25:49 -07:00
Vadim Tryshev and Android (Google) Code Review
6bc3f5e0e1
Merge "Introducing a method for execution an action on Launcher for teardown" into main
2023-10-09 21:22:47 +00:00
Vadim Tryshev
39b4fad9b0
Introducing a method for execution an action on Launcher for teardown
...
If the test fails to initialize properly, tearDown is still called,
and we may have null Launcher activity.
We want to safely skip using that activity to avoid a NullPointerException
that would hide the original error message.
Bug: 304306290
Test: presubmit
Flag: N/A
Change-Id: I89774a92ede046fa3afadacc62df25f4f496f4e7
2023-10-09 11:29:42 -07:00
Alex Chau
a0c149fc8d
Use mock TaskStackChangeListeners in RecentsModelTest
...
- Also unregistered TaskStackChangeListeners and TaskIconCache listeners in RecentsModel.close(), so clean-up will happen if it's in a SandboxContext
Bug: 303259446
Test: RecentsModelTest
Change-Id: I438a499be8e737de7df79b670ecfd26f0ee70662
2023-10-09 14:31:58 +01:00
fbaron
263644524e
Add screenrecord to testOverviewActionsMenu_iconAppChipMenu
...
Bug: 303329286
Test: n/a
Flag: no flag
Change-Id: Iab1f9e38ef1d05d56b08f62a5b3b973e96cc6f60
2023-10-06 15:38:08 -07:00
Brian Isganitis and Android (Google) Code Review
96224ef755
Merge "Migrate Kotlin tests to use mockito-kotlin2." into main
2023-10-06 17:54:56 +00:00
Vadim Tryshev and Android (Google) Code Review
e8f7dd5a51
Merge "Further tightening leak detector checks" into main
2023-10-04 22:18:18 +00:00
Vadim Tryshev
c116cee748
Further tightening leak detector checks
...
Some checks see 2 activities for some reason: Launcher and Overview.
Both active.
I'll have to decide what to do with these cases, but for now, I simply don't pass 'true' from places where this can happen.
When we have 2 activities:
Either Overview is present (and I guess we have to close it before the check) or the screenshot shows that there is no Overview, but internally, apparently, Overview activity is active and therefore, technically, is not leaked.
For the latter case, I may need to do some kind of investigation.
But for now, I'm tightening the check where there is no Overview.
Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I1f1619093e0948b8112f29fd7e94facbf7093983
2023-10-04 22:18:12 +00:00
Jeremy Sim and Android (Google) Code Review
4986aa85e5
Merge "App Pairs: App pairs now save with automatic default name and custom split ratios" into main
2023-10-04 00:06:57 +00:00
Vadim Tryshev and Android (Google) Code Review
23825e84a8
Merge "Tearing down the test safely." into main
2023-10-03 21:02:51 +00:00
Brian Isganitis
06139e079c
Migrate Kotlin tests to use mockito-kotlin2.
...
Test: atest
Bug: 300509464
Flag: No
Change-Id: I5e0d0f1f29d51cdbfacd51f7229afddf8bd66f7e
2023-10-03 16:04:19 -04:00
Jeremy Sim
6ac8949fc4
App Pairs: App pairs now save with automatic default name and custom split ratios
...
[App Pairs 4/?]
This patch includes:
- Ability to save and launch app pairs with custom 0.3, 0.7, or 0.5 split ratios
- App pairs now save with default name "App1 | App2"
- Grid migration, prediction, and other misc. flows should now work with app pairs
Flag: ENABLE_APP_PAIRS (set to false)
Bug: 274189428
Test: AppPairsControllerTest.java
Change-Id: I46dd3e30f8de03dd3e6d086c8ff9fc52e7e7fd2b
2023-10-03 10:38:03 -07:00
Vadim Tryshev
c0489b41a7
Tearing down the test safely.
...
If the test fails to initialize properly, tearDown is still called,
and we may have null Launcher activity.
We want to safely skip using that activity to avoid a NullPointerException
that would hide the original error message.
Bug: 303070230
Test: presubmit
Flag: N/A
Change-Id: I3bb07fa55e5793c73caaaeda57168aa11c85893e
2023-10-02 18:51:42 -07:00
Vadim Tryshev
d8c049f2af
Starting to tighten leak detector checks
...
This will help to detect leaks earlier, not when we have 3 activities in some cases, but when we have 2.
Adding a parameter that enables more strict detection, and using it in some places.
I'll try to convert as many places as possible to the more strict check after landing this CL.
Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: Idd5a0386005e46dad8aab222bd77c0240f23f43a
2023-10-02 18:34:32 -07:00
Vadim Tryshev and Android (Google) Code Review
a6b74ffdfc
Merge "Verifying that workspace looks correct at the end of the test." into main
2023-10-02 21:48:04 +00:00
Tracy Zhou and Android (Google) Code Review
fe38407873
Merge "Repostion contextual buttons upon layout changes" into main
2023-10-02 20:15:31 +00:00
Alex Chau and Android (Google) Code Review
8eb662c67b
Merge "Create icon app chip menu for overview tasks." into main
2023-10-02 17:40:33 +00:00
Pat Manning and Alex Chau
1695cc724c
Create icon app chip menu for overview tasks.
...
Fix: 257951354
Test: TaplTestsQuickstep
Test: TaplTestsSplitscreen
Flag: ENABLE_OVERVIEW_ICON_MENU
Change-Id: Id8a14b1970ae42bcc74e95419caeaf52ef63638b
2023-10-02 12:51:56 +00:00
Vadim Tryshev
b57e25127e
Verifying that workspace looks correct at the end of the test.
...
I hope that this will lock bugs like b/298114205 in the test that created the bad condition, not the next one.
Bug: 298114205
Test: presubmit
Flag: N/A
Change-Id: If9b48fb5159fc35948607a99f87199d5a32e64d6
2023-09-29 18:31:04 -07:00
Pat Manning
ff74bb5ded
Mark existing Launcher CUJs as Platinum tests.
...
Exclusion CL: cl/565329636 & cl/569615823
Acceptance Criteria:
- TaplTestsQuickstep#testOverviewActionsMenu: https://android-build.corp.google.com/test_investigate/?invocationId=I68300010197543619&testResultId=TR13128935381586398&tab=performance
- OopTaplOpenCloseAllApps#testAllAppsSwipeUpToWorkspace: https://android-build.corp.google.com/test_investigate/?invocationId=I29900010197342608&testResultId=TR26328933842394642&tab=performance
- AddWidgetTest#testResizeWidget: https://android-build.corp.google.com/test_investigate/?invocationId=I56600010197561454&testResultId=TR14428935383013115&tab=performance
- TaplTestsLauncher3#testLaunchHomeScreenMenuItem: https://android-build.corp.google.com/test_investigate/?invocationId=I56600010197561454&testResultId=TR20028935383489058&tab=performance
Bug: 300249773
Test: TaplTestsLauncher3
Test: OopTaplOpenCloseAllApps
Test: AddWidgetTest
Test: TaplTestsQuickstep
Change-Id: Ica71dbad91efe8f5b4fd243f0ec78fc3c3c4d456
2023-09-29 23:27:27 +00:00
Jagrut Desai and Android (Google) Code Review
9c80d72947
Merge "Fixing testQuickSwitchToPreviousAppForTablet" into main
2023-09-29 19:38:48 +00:00
Schneider Victor-tulias and Android (Google) Code Review
0606b1f296
Merge "Add TAPL tests for the keyboard quick switch view" into main
2023-09-29 18:42:11 +00:00
Schneider Victor-tulias
41b42bf7d5
Add TAPL tests for the keyboard quick switch view
...
Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Bug: 267520665
Test: TaplTestsKeyboardQuickSwitch
Design doc: go/kqs-tapl-tests
Change-Id: I1c3c5c758011a36ed405426f543ce450910f774e
2023-09-29 14:39:35 -04:00
Vinit Nayak and Android (Google) Code Review
5b759afe90
Merge "Revert "Unignore splitscreen tapl tests"" into main
2023-09-28 23:14:29 +00:00
Vinit Nayak and Android (Google) Code Review
8d0442372b
Revert "Unignore splitscreen tapl tests"
...
This reverts commit 80d274e041 .
Reason for revert: b/302542596
Change-Id: Iac1274dd844ff1baea1e8c7b22a54bf353c69974
2023-09-28 18:45:37 +00:00