PawletOS/Lawnchair
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
56,233 Commits 1 Branch 0 Tags
a084dbd3bd4063c51d2089a855d548e8fca2e111
Commit Graph

1008 Commits

Author SHA1 Message Date
Sunny Goyal a084dbd3bd Merge "Fixing background jump when closing a widget" into tm-qpr-dev am: 031ee4cbcb am: 6988b7b308 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20304438

Change-Id: I578ef759545b5bebcf314a2022f99e428bb7ee1a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-03 02:02:24 +00:00
Sunny Goyal 39b07fd66c Fixing background jump when closing a widget 
We do not add background animation when opening target is translucent
Added additional check to not animate background if launcher is not
closing (which is already a subset of all-targets-translucent)

Also removing reverse background animation from widgets, similar
to app-icons as it is never added for launcherNotClosing path

Bug: 242379946
Test: Added translucent activtiy and widget and verified manually
      that the behavior does not change
Change-Id: Icda8007c0063295bf8431c00a0f0b665ecdef109
 2022-11-02 19:17:18 +00:00
David Saff 31aabd93ee Merge "Mark broken tests that are blocking presubmit" 2022-11-01 13:37:21 +00:00
Sunny Goyal 7550a67d90 Merge "Adding screenrecord for debug failing test" into tm-qpr-dev am: c93eb630e6 am: 4f5d276233 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20330482

Change-Id: I039c65677505a6e77b6d2b2e87ef0f21afad30f4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-11-01 00:57:57 +00:00
Sunny Goyal c93eb630e6 Merge "Adding screenrecord for debug failing test" into tm-qpr-dev 2022-10-31 23:53:43 +00:00
Sunny Goyal d6e9c601d8 Adding screenrecord for debug failing test 
Bug: 256659409
Test: n/a
Change-Id: I1d804a92f81069df8d86f5b4ee2f21179f390d98
 2022-10-31 13:25:17 -07:00
David Saff ef47bf0071 Mark broken tests that are blocking presubmit 
Bug: 256615483
Test: presubmit
Change-Id: Ie42885b65f1e4652a36cf9018bf43573fd0fec9f
 2022-10-31 16:31:05 +00:00
Sihua Ma ce1b37ccd4 Merge "Created LauncherWidgetHolder as a wrapper for LauncherAppWidgetHost" into tm-qpr-dev am: 17137e8bce am: fe121a99c6 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20106227

Change-Id: I67fff40251e2feb6beaf0b45e5352dd5dae642de
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-27 19:01:32 +00:00
Sihua Ma 17137e8bce Merge "Created LauncherWidgetHolder as a wrapper for LauncherAppWidgetHost" into tm-qpr-dev 2022-10-27 17:53:28 +00:00
Sihua Ma 0593a0d3ec Created LauncherWidgetHolder as a wrapper for LauncherAppWidgetHost 
The wrapper class is created for further changes that will run the wrapped host in the background.

Test: N/A
Bug: 235358918
Change-Id: I9bd6fc2749c5d4a4d3391fb75d0c3ff1e13d17bf
 2022-10-26 10:57:13 -07:00
Sunny Goyal c5d63bcac5 Merge "Merging MultiValueAlpha with MultiPropertyFactory" into tm-qpr-dev am: 3912808183 am: 34da3ed6df 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19944063

Change-Id: Iecd1429f926172eea4c551667d7995c1a9750bc3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-25 23:12:13 +00:00
Sunny Goyal d859060860 Merging MultiValueAlpha with MultiPropertyFactory 
Bug: 246644619
Test: Presubmi
Change-Id: Id5abc5f3169544656f1139ae17ca59e34ac65dac
 2022-10-24 14:38:18 -07:00
Hui Kang 9a34b122bf Merge "Fix AddWidgetTest flake Test: ABTD" into tm-qpr-dev am: 07949ff3c8 am: ae9ee2bc27 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20261595

Change-Id: I1378c314d0921b80847e4ed027368e7ef9a4a69d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-24 21:29:20 +00:00
Sunny Goyal 85cf449fcc Merge "Revert "Revert "Updating the scroll calculation from recyclerView to avoid view inflation""" into tm-qpr-dev am: 0cf401d0eb am: 1baaac662b 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20260484

Change-Id: I38c6cec592377e77294e02c70af28ab72d70e90c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-24 20:16:56 +00:00
Hui Kang 4b87b9e521 Fix AddWidgetTest flake 
Test: ABTD

200 all PASS: https://android-build.googleplex.com/builds/tests/view?invocationId=I20300010100881398

Without this CL, 1/100 FAIL: https://android-build.googleplex.com/builds/abtd/run/L73700000956982533

Change-Id: Ia9d7746144e9838798332f4eea223a9529551713
 2022-10-24 18:09:15 +00:00
Sunny Goyal f34811d3a3 Revert "Revert "Updating the scroll calculation from recyclerView to avoid view inflation"" 
Test: ABTD
https://android-build.googleplex.com/builds/abtd/run/L52600000956969786

This reverts commit cee6ddf3de.

Reason for revert: Fixed in ag/20239136

Change-Id: I0e8446e66d9a86a94b40fcbd6de14da07abe8e5c
 2022-10-22 15:37:47 +00:00
Hui Kang 70765883c5 Merge "Revert "Updating the scroll calculation from recyclerView to avoid view inflation"" into tm-qpr-dev am: 2a28ae8a3f am: da45ddb921 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20213328

Change-Id: Ib0198ed6d4c19b1889bde9144ed33b30a0dedae7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-17 22:24:43 +00:00
Hui Kang 2a28ae8a3f Merge "Revert "Updating the scroll calculation from recyclerView to avoid view inflation"" into tm-qpr-dev 2022-10-17 21:20:09 +00:00
Hui Kang cee6ddf3de Revert "Updating the scroll calculation from recyclerView to avoid view inflation" 
This reverts commit 20bbe95ddb.

Reason for revert: Causing flake in Ironwood test: b/248295569

Test: ABTD
Before: Flaky, 14/50 PASSED
https://android-build.googleplex.com/builds/abtd/run/L33900000956890639

Revert: 50/50 PASSED
https://android-build.googleplex.com/builds/abtd/run/L49200000956887317

Change-Id: I41f4428c74e581323f90c716a7852b5e553ae27d
 2022-10-17 20:37:49 +00:00
Pat Manning 1a2e1ea4fc Merge "Add screenshot test for edit state drop targets." into tm-qpr-dev am: 956631ec3a am: 423ad32120 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19852201

Change-Id: Ic7287a3a8e99e3b82c0fd28e3e4d0c14044c299f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-14 14:09:26 +00:00
Pat Manning 956631ec3a Merge "Add screenshot test for edit state drop targets." into tm-qpr-dev 2022-10-14 12:49:09 +00:00
Sebastián Franco 28f5901264 Merge "Fix ReorderWidgets by removing faulty 4x4 cases" into tm-qpr-dev am: 9eeeeacf30 am: 35c4d65dc2 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20003360

Change-Id: Iee094d591a60938cd2ba54ac7e66e45b23fdbf92
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-07 21:38:44 +00:00
Sebastián Franco 9eeeeacf30 Merge "Fix ReorderWidgets by removing faulty 4x4 cases" into tm-qpr-dev 2022-10-07 20:33:41 +00:00
Ming-Shin Lu cb4f9b8dc5 Merge "TAPL: add setIgnoreTaskbarVisibility in LauncherInstrumentation" into tm-qpr-dev am: 8ff85dc733 am: 6013ab3776 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20064292

Change-Id: I6aaeb6efe4af83a5c8621cceb3154be4d53be58c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-10-05 07:47:04 +00:00
Ming-Shin Lu 4d4f62ac77 TAPL: add setIgnoreTaskbarVisibility in LauncherInstrumentation 
As now FlickerTests is leveraging TAPL to interact devices CUJs,
we realized in LauncherInstrumentation will verify task bar visibility
automatically to expect it always visible when quick-switch, which is
not always reliable since the task bar may be hidden by manual or
when the activity requests to show IME.

Add setIgnoreTaskbarVisibility in LauncherInstrumentation for the caller
to ignore taskbar visibility if the test does not need to verify it.

Bug: 228012334
Bug: 240306344
Test: atest FlickerTests:SwitchImeWindowsFromGestureNavTest
      in tablet device
Test: atest NexusLauncherOutOfProcTests:com.android.quickstep.\
       TaplTestsQuickstep#testQuickSwitchToPreviousAppForTablet

Change-Id: Id0a35561523d733b8434acb702ec7dcaa466a1c2
 2022-10-05 11:37:37 +08:00
Pat Manning a34a9a0a18 Add screenshot test for edit state drop targets. 
see: go/tapl-run-on-hold-event

Bug: 241386128
Test: HomeScreenImageTest.java
Change-Id: I5d6421c8da7d06a9eb77da249957c64d413524f1
 2022-09-29 11:12:31 +01:00
Sebastian Franco a44d255c8f Fix ReorderWidgets by removing faulty 4x4 cases 
Fix: 242323136
Test: atest ReorderWidgets (the device has to be cf_x86_64_phone-userdebug)
Change-Id: Ic545409ecc20420be6c7377513c704822dbaf75e
 2022-09-27 09:37:54 -05:00
Vadim Tryshev 8cfd3f699d Merge "Verifying a theory that sometimes a leak disappears while saving an object dump" into tm-qpr-dev am: af91a58659 am: c7f9e903bd 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20009128

Change-Id: Icc1ff73190b117b1f1560daca9c8e2f9e147827f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-23 06:27:23 +00:00
vadimt 592b3f9885 Verifying a theory that sometimes a leak disappears while saving an object dump 
Bug: 241585675
Test: presubmit
Change-Id: If9c559619507002ed7ec4b1a8b96a5f62e2dbe41
 2022-09-21 10:56:04 -07:00
TreeHugger Robot 8eed4f30a9 Merge "Explicit Nullbility in Launcher (Part 5)" into tm-qpr-dev am: 69c04c21c5 am: ab6be24eec 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19976255

Change-Id: Ie607c03fb5aa6ca01648ebfeeba10cecf2d3bf80
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-19 18:30:23 +00:00
TreeHugger Robot 69c04c21c5 Merge "Explicit Nullbility in Launcher (Part 5)" into tm-qpr-dev 2022-09-19 17:12:40 +00:00
TreeHugger Robot ca5a1a6c60 Merge "Updating the scroll calculation from recyclerView to avoid view inflation" into tm-qpr-dev am: 860657a5f2 am: cd4951f54b 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19469421

Change-Id: I5f9c405e1bff93b3e96b051bcb9b6ad0a87eecb5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-17 01:14:58 +00:00
Pinyao Ting 777c13eb00 Explicit Nullbility in Launcher (Part 5) 
This CL addresses the nullbility in LauncherModel and update tasks.

Bug: 242895652
Test: manual
Change-Id: Ied635c944c3656f0d493b295f772aa0329b354b9
 2022-09-16 17:17:16 -07:00
TreeHugger Robot 860657a5f2 Merge "Updating the scroll calculation from recyclerView to avoid view inflation" into tm-qpr-dev 2022-09-16 23:07:54 +00:00
Sebastián Franco f1aa20d811 Merge "Revert "Prevent dragging widgets to another page in tests when starting a drag."" into tm-qpr-dev am: 09a98dfdbd am: 47c78bed9b 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19969101

Change-Id: I01ad05d37ca822f501e6f2520249734c7e9de167
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-16 17:52:11 +00:00
Sebastián Franco 09a98dfdbd Merge "Revert "Prevent dragging widgets to another page in tests when starting a drag."" into tm-qpr-dev 2022-09-16 16:49:26 +00:00
Sebastián Franco a798be2ff5 Revert "Prevent dragging widgets to another page in tests when starting a drag." 
This reverts commit 749b2b8493.

Reason for revert: Causing tests to fail b/246972374

Change-Id: I9fc1f6d2e924f4ac5484c6674fd0adf49d04536f
 2022-09-15 21:19:12 +00:00
Sebastián Franco b35ae4fc42 Merge "Prevent dragging widgets to another page in tests when starting a drag." into tm-qpr-dev am: 610db4fc94 am: 0eaacbc644 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19945446

Change-Id: Id8e822bf084248c7618cd23837ccb1f558eedc64
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-15 18:22:33 +00:00
Sebastián Franco 610db4fc94 Merge "Prevent dragging widgets to another page in tests when starting a drag." into tm-qpr-dev 2022-09-15 17:19:42 +00:00
Alex Chau 019f5c4324 Remove ScreenRecord for a test 
- ScreenRecord might have increased flankiness of a test, reverting to verify

Bug: 242163855
Bug: 243688989
Change-Id: I6578a5ce2498f68e9b0102a2d9cb5bce91422f85
 2022-09-15 05:12:08 +00:00
TreeHugger Robot fb77b34d1d Merge "Change wallpaper depth in widget picker" into tm-qpr-dev am: 3ded296cee am: 9c43626a36 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19852193

Change-Id: Ie17c03949c3ac30156129182fec88f19cfb46e1d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-13 23:38:23 +00:00
Sebastian Franco 749b2b8493 Prevent dragging widgets to another page in tests when starting a drag. 
The function Launchable.startDrag it's supposed to grab and icon or widget
and start the dragging by moving it only in the verticall position but
because it uses the coordinates of the object before entering the
SPRING_LOADED_STATE_ORDINAL state then the coordiates where it moves
are outisde of the cell layout and it moves to a new page. This only happens
if the phone is too slow and it triggers the page change, otherwise it would
be too fast.

To fix it, I'm moving the icon/widget to the center of the screen minus
getStartDragThreshold() to ensure the drag is always triggered.

Fix: 242323136
Fix: 244224955
Fix: 241019568
Fix: 241583798
Test: atest ReorderWidgets
Change-Id: I0e431b994aa4a3d5c8be45b6c73263732553b36c
 2022-09-13 15:54:58 -07:00
TreeHugger Robot 3ded296cee Merge "Change wallpaper depth in widget picker" into tm-qpr-dev 2022-09-13 18:46:53 +00:00
Sebastián Franco 7ec80322bb Merge "Add hotseat icons to TestWorkspaceBuilder and submit everything in a batch" into tm-qpr-dev am: 5587ef3262 am: 1163c5ea7a 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19759371

Change-Id: I9a9f63c26ce8184f0c0cc1f8b4073f17e8b21726
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-13 18:09:10 +00:00
Sebastián Franco 5587ef3262 Merge "Add hotseat icons to TestWorkspaceBuilder and submit everything in a batch" into tm-qpr-dev 2022-09-13 16:53:36 +00:00
Alex Chau 3d2c062567 Change wallpaper depth in widget picker 
- Also changed widget picker open/close duration, refactored the values into DeviceProfile
- Generalized MultiAdditivePropertyFactory to accept aggregator as parameter

Bug: 240580498
Test: manual
Change-Id: I6886ca514593e404b8d7b0e8ed44f20ec2b77c73
 2022-09-13 12:20:56 +08:00
Sunny Goyal 20bbe95ddb Updating the scroll calculation from recyclerView to avoid view inflation 
> Updating the LayoutManager's scroll calculation instead of a separate
  implementation to better support recyclerView's calculations
> Caching the view sizes during layout to avoid view-inflation for
  unknown types
> Fixing scrollbar jump during scroll when widget list is expanded
> Fixing scrollbar never reaching end when onboarding card is displayed
  in work tab

Bug: 240343082
Test: Verified on device that new views are not inflated
Change-Id: Ied11ccf65b053691c5c126c4bf8de306ec24786d
 2022-09-12 12:24:34 -07:00
Sebastian Franco 5434c9d370 Add hotseat icons to TestWorkspaceBuilder and submit everything in a batch 
Now TestWorkspaceBuilder has the logic to add hotseat icons and
the operations to add items to the Workspace is done in batches
which is faster and more stable. To submit everything in batches
it uses the FavoriteItemsTransaction.

This improves the design because TestWorkspaceBuilder and
HomeScreenImageTest belong to the Test layer and they should
only deal with the logic to run a test and TestWorkspaceBuilder
is the Model layer and holds all the logic to interact with the
Launcher model/data, so this separates the concern of each class.

Also, chagned the name from CellLayoutBoardBuilder to
TestWorkspaceBuilder to make it clearer.

Bug: 243440737
Bug: 235518637
Bug: 242323136
Test: atest HomeScreenImageTest
Test: atest ReorderWidgets
Change-Id: I14eef064fade153b8362537743b061958bb3071d
 2022-09-12 10:54:53 -07:00
Qing Wang 67e22eff1f Add tests to Launcher P0 CUJ Homescreen navigation via TAPL. am: 30c3552e7e am: 46320961b9 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19773679

Change-Id: I4f1b1330c4084e09c6af077803c9abbc17d57d46
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-10 20:39:36 +00:00
Qing Wang 30c3552e7e Add tests to Launcher P0 CUJ Homescreen navigation via TAPL. 
1. Implement API to help to get page count.
2. Add test add and delete page.

Bug: 241685418
Bug: 232584721
Test: android.platform.test.scenario.launcher.integration_tests.ScreenNavigationTests#testAddAndDeletePageAndFling
Change-Id: I2e04b9ef1f2ca65ba14d6939b7b51fead6b6f6ca
 2022-09-10 17:46:24 +00:00