Commit Graph

5709 Commits

Author SHA1 Message Date
Pat Manning f4bd9b6304 Merge "Update workspace, cell layout, shortcut and widget, and cell size calculations." into tm-dev 2022-05-04 18:19:02 +00:00
Pat Manning b45d6c421d Update workspace, cell layout, shortcut and widget, and cell size calculations.
Test: DeviceProfileGridDimensionsTest.kt
Fix: 230862148
Change-Id: Ib1d577bf21beb45b2f8b3d4bd57e72c188e0f71b
2022-05-04 15:39:03 +01:00
TreeHugger Robot 3fd92a955e Merge "Use isTablet instead of isPhone for check" into tm-dev 2022-05-04 11:52:53 +00:00
TreeHugger Robot c8b095e28c Merge "Don't fade out live tile when dismissed" into tm-dev 2022-05-04 02:47:02 +00:00
Anushree Ganjam 32a05ae3f0 Use isTablet instead of isPhone for check
Bug: 228803923
Bug: 227565451

Test: Manual.
Change-Id: If7a21495b126230de8e91126ef0f3fcf54f9c900
2022-05-03 23:10:47 +00:00
Vinit Nayak 13b16060f3 Don't fade out live tile when dismissed
* Fading out exposes the wallpaper underneath
since the task is layered below launcher and
we draw a cutout in the scrim

Fixes: 230916221
Test: Swiping up on live tile task doesn't fade
Change-Id: Ie4a81aeed3de242146248ecae7734e5e02985040
2022-05-03 15:35:34 -07:00
Sunny Goyal f76524151d Merge "Replacing ItemInfoMatcher with predicate" into tm-dev 2022-05-03 20:04:55 +00:00
Vinit Nayak 38ebd4b41c Merge "Revert "Revert "Use new onStartSplitLegacy when starting split f..."" into tm-dev 2022-05-03 19:56:34 +00:00
Sunny Goyal 32084d49d3 Replacing ItemInfoMatcher with predicate
This removed unnecessary componentName lookups when it
is not required. Many checks just rely on IDs and
userHandle

Bug: 231153610
Test: Presubmit
Change-Id: Ief93954abc5861062a9f55dc2ef181d3de106c62
2022-05-03 10:07:22 -07:00
Jon Miranda e73c3075c1 Merge "Fix all app button taskbar animation in LTR and RTL." into tm-dev 2022-05-03 17:03:22 +00:00
Tracy Zhou 0c625f7472 Merge "Originate split select animation from the original icon view instead of the split menu icon" into tm-dev 2022-05-03 16:48:39 +00:00
Justin Weir df073f0e93 Merge "Ensure log buffers are dumped to file on uncaught exceptions" into tm-dev 2022-05-03 11:38:58 +00:00
TreeHugger Robot f1a4296cd0 Merge "Tune AllApps dismiss animation" into tm-dev 2022-05-03 11:23:46 +00:00
Jon Miranda e7b977ddd5 Fix all app button taskbar animation in LTR and RTL.
Bug: 225154998
Test: Open app, view taskbar, go back to home
      Repeat for both RTL, LTR

Change-Id: Ifdc8074bef6e5f5a447a1f4110ccb387b18a7ea9
2022-05-02 15:31:21 -07:00
Justin Weir 811e76353a Ensure log buffers are dumped to file on uncaught exceptions
Update PluginManagerWrapper according to changes in ag/17915248

Bug: 213884413
Test: manually verified, added tests, and ran atest
Change-Id: If829fc33769819624530f766178689ecf0374926
2022-05-02 15:28:44 -04:00
Schneider Victor-tulias 9b6babf839 Translate the 3 navigation buttons to/from their in-app position when animating to/from the -1 screen, all apps and widgets.
Bug: 221455508
Test: opened all apps, widgets, -1 screen, notifications shade and keyboard in various combinations and orders; locked screen, launched app, returned home with the back/home buttons, opened overview
Change-Id: Ia0b406aacf72b34bd6b7ff1c01278ab6895a7da4
Merged-In: Ia0b406aacf72b34bd6b7ff1c01278ab6895a7da4
(cherry picked from commit 9c1a452a1d)
2022-05-02 18:45:01 +00:00
Schneider Victor-tulias c0b30dc266 Fix taskbar 3-button truncation on rotate
- Fixed truncation issue in overview and home on rotation
- Fixed 3 buttons translating incorrectly when switching to/from overview

Fixes: 205057824
Fixes: 215482458
Test: Manual
Change-Id: I0b89010a2b6ed03a34c3443fc6e1edc81f8d9f20
Merged-In: I0b89010a2b6ed03a34c3443fc6e1edc81f8d9f20
(cherry picked from commit 8aa99c72b1)
2022-05-02 18:12:00 +00:00
TreeHugger Robot eba6a95a29 Merge "Provide the back callback instance when unregistering it from SysUI." into tm-dev 2022-05-02 16:18:43 +00:00
Shan Huang 883e7e412b Provide the back callback instance when unregistering it from SysUI.
Bug: 228535747
Test: atest BackAnimationControllerTest
Test: Make sure back to home animation works on tablets and phones.
Change-Id: Iacbd581f382da50e96cfefbefe569800e9e1043b
2022-05-02 04:57:11 +00:00
TreeHugger Robot 002e1fcde5 Merge "Do not add HOTSEAT_ICONS to visible elements for device type "phone" in ALL_APPS State" into tm-dev 2022-04-30 17:12:35 +00:00
TreeHugger Robot 3e8f0c9bb6 Merge "Update home, back and overview gesture tutorial introductions to be clearer for blind users" into tm-dev 2022-04-30 02:13:14 +00:00
Anushree Ganjam f6254c5947 Do not add HOTSEAT_ICONS to visible elements for device type "phone" in
ALL_APPS State

HOTSEAT_ICONS got added to visible elements for ALL_APPS State in ag/16992837.

============================================================
Phone
Before:
HotSeat present in view hierarchy - https://hsv.googleplex.com/4906040983289856?node=41
Video: https://b.corp.google.com/issues/228803923#comment9

After:
HotSeat not present in view hierarchy - https://hsv.googleplex.com/5379653922455552?node=42
Video: https://b.corp.google.com/issues/228803923#comment11
============================================================

Tablets

I couldn't test this implementation on tablet. But I have verified on a phone
locally by adding HOTSEAT_ICONS to visible elements and then verifying
"IMPORTANT_FOR_ACCESSIBILITY_NO_HIDE_DESCENDANTS" get set and hotseat icons are not focusable in all apps.
Video : https://b.corp.google.com/issues/228803923#comment14

============================================================

Bug: 228803923
Bug: 227565451

Test: Manual. See the video attached in bug.
Change-Id: I055e3bb61c8cfd240e0fe1000fe3a391a150f6d1
2022-04-29 23:33:48 +00:00
Sunny Goyal 34f51fbfc4 Merge "Removing unused SearchSessionManager" into tm-dev 2022-04-29 23:30:13 +00:00
Schneider Victor-tulias 8e0e88bb2f Update home, back and overview gesture tutorial introductions to be clearer for blind users
Added A11Y strings for the home, back and overview gesture tutorial step introductions. These strings give clearer instructions that work with talkback.

Fixes: 202492454
Test: manual
Change-Id: I1eefd6ecf3e3c576a7c1cf6dbf7b824e5be13860
2022-04-29 16:09:11 -07:00
TreeHugger Robot 47a137e05d Merge "Update TaskOverlay corner radius as fullscreen parameters are updated." into tm-dev 2022-04-29 22:34:31 +00:00
Alex Chau f39cc126bf Tune AllApps dismiss animation
- Avoid overriding interpolator in AllAppsTransitionController.setStateWithAnimation as it's no longer needed and it'll wrongly override interpolator for ANIM_ALL_APPS_FADE
- Override ANIM_ALL_APPS_FADE to FINAL_FRAME in QuickstepAtomicAnimationFactory for tap deadzone to dismiss animation, also added EMPHASIZED_ACCELERATE for the dismiss animation
- Tuned dismiss animation across form factors to 300ms

Fix: 220336617
Test: manual
Change-Id: I4b3e827b503dcb1dd39f0bd99d4c1dd5ffdba0f3
2022-04-29 20:31:26 +01:00
Pat Manning d9ddf6c12b Merge "Re-land "Animate overivew actions view hiding on scroll."" into tm-dev 2022-04-29 18:01:30 +00:00
Pat Manning d44f9c9741 Merge "Finish recents animation on activity destroyed." into tm-dev 2022-04-29 17:43:21 +00:00
Zak Cohen f2cd2f7748 Update TaskOverlay corner radius as fullscreen parameters are updated.
Bug: 230470826
Test: Build and run
Change-Id: I3b6914bf7423ec60d28d2d06ee5225de1b6862c1
2022-04-29 10:27:53 -07:00
Thales Lima 828875cd12 Fix hotseat width to span a number of columns
Bug: 227344807
Test: manual
Change-Id: Ice4e37929bcbb8c9cf3af340e67b6bec002578bd
2022-04-29 14:56:30 +00:00
Pat Manning d08e03388f Re-land "Animate overivew actions view hiding on scroll."
Reverts commit f5f14acba3

Bug: 228137694
Bug: 221113300
Change-Id: I683092796f5de0476e09692897d80a3655ae6925
2022-04-29 13:49:09 +00:00
Pat Manning 0fd3b13d01 Finish recents animation on activity destroyed.
Do not remove acitivity lifecycle callback on reset.

Test: TaplTestsQuickstep.java testQuickSwitchFromApp
Fix: 228137694
Change-Id: I454db1d029af479624999f2e5736aea1a8a97b87
2022-04-29 11:55:40 +00:00
Sunny Goyal a3f014d737 Removing unused SearchSessionManager
Bug: 220922858
Test: Presubmit
Change-Id: I8264a2e9b978a850aa6ce69fcb698b0a3494c6c5
2022-04-28 19:44:03 -07:00
Shan Huang 8073fc8daf Merge "Fix screen rounded corner flicker." into tm-dev 2022-04-28 19:34:37 +00:00
Mateusz Cicheński f312acc081 Merge "Make Hotseat report shelf height on large screen devices." into tm-dev 2022-04-28 18:48:11 +00:00
Anushree Ganjam fa693be19f Merge "Revert "Refactors Search results into separate RV for Toast."" into tm-dev 2022-04-28 04:52:01 +00:00
Anushree Ganjam 5cc7ff0990 Revert "Refactors Search results into separate RV for Toast."
This reverts commit 6729f0b950.

Reason for revert: This change caused b/230648542.

Please see https://b.corp.google.com/issues/230648542#comment5 for the video after reverting this change.

Bug: 206905515
Bug: 230648542

Change-Id: I85f063c56cad137c05b810204244bba7e8f94ee7
2022-04-28 01:37:49 +00:00
Alex Chau 2a6e364e91 Remove unnecessary updatePivots
- Follow-up of http://ag/17888303 to remove extra code that didn't get clean up

Bug: 209981696
Test: manual
Change-Id: I37f68dd52adacfd033eaeaeca52c98a4a06d556d
2022-04-27 13:57:39 +01:00
Alex Chau a80efcee9f Merge "Update overview actions alignment" into tm-dev 2022-04-27 12:24:24 +00:00
Jerry Chang 59939e9e94 Merge "Fix divider bar won't fade-in as the other splitting tasks" into tm-dev 2022-04-27 03:02:57 +00:00
Tracy Zhou 023537038d Originate split select animation from the original icon view instead of the split menu icon
Bug: 226395821
Test: https://recall.googleplex.com/projects/f46cfe9c-8076-4efe-bf8a-b1cc4f1f5e1b/sessions/ed355c4f-b9d3-4b85-870f-2decb0b786db
Change-Id: I7277a9de212328d6f580bff5d28338ea0c058d99
2022-04-26 18:00:25 -07:00
Mateusz Cicheński 76fb120994 Make Hotseat report shelf height on large screen devices.
Test: http://recall/-/ekEuGtt9d9HWqkUtAzpHx8/ckTLvEEiaCugieedwOU6tj
Bug: 198311114
Change-Id: I9d5bc6ab031fb6d07d5205581c33aa5ab9b45a8c
2022-04-26 23:34:22 +00:00
Tracy Zhou 7183e4b460 Merge "Add originalView of the menu to SystemShortcut" into tm-dev 2022-04-26 17:28:40 +00:00
Shan Huang 3e952539a1 Fix screen rounded corner flicker.
We've previously always played transitions with a fixed start corner
radius. This should however be an interpolated value based on gesture
progress.

Bug: 230115505
Test: Turn on predictive animations. Try completing a back swipe as well
as canceling a back swipe. Observe corner radius to make sure there's no
flicker.

Change-Id: Iae2517d969ed1b779bced866407b939b3a011b68
2022-04-26 17:16:22 +00:00
Vinit Nayak 2d1a69e58b Revert "Revert "Use new onStartSplitLegacy when starting split f..."
Revert submission 17918609-revert-17779173-startSplitLegacy-OOWPZEFFGI

Reason for revert: Running through TH
Reverted Changes:
I6d81e0584:Revert "Use new onStartSplitLegacy when starting s...
I754bc308f:Revert "Remove check for preventing re-parenting n...

Change-Id: I6eea82f34b3680020b49ec7fe19eb61cc68286a5
2022-04-25 19:55:31 +00:00
Alex Chau a2fc764405 Update overview actions alignment
- Align overview actions to the top with a defined margin below task thumbnail, except for vertical bar layout
- In modal state, use task view's bottom as pivot, and expand using all the space about pivot
- Simplified overview actions margin calculation and moved some logic to DeviceProfile

Bug: 209981696
Test: manual on various devices
Change-Id: I4c96cb02c6f3d6adf30633ddeb883bc4eec16f36
2022-04-25 19:20:21 +01:00
Jerry Chang c3865b86e4 Fix divider bar won't fade-in as the other splitting tasks
Bug: 226271407
Test: manual check the divider bar fade-in animation after launchTasks
Change-Id: I5ea7c6ea5ac3f3550b28e9c0f854e70edcfc97b0
2022-04-25 15:41:28 +00:00
Andy Wickham 6729f0b950 Refactors Search results into separate RV for Toast.
This will help enable transitions between A-Z apps lists and
search results because both can be seen simultaneously and
manipulated independently.

Some high level items of the refactor:
 - SearchRecyclerView is added; logic that populated the main
   (personal) tab with search results was simply redirected to
   this RV instead.
 - BaseAllAppsContainerView added isSearching() method. Returns
   false, and ActivityAllAppsContainerView overrides (as search
   is handled there).
 - Renamed BaseRecyclerView to FastScrollRecyclerView to better
   describe what it does. SearchRecyclerView extends this, but
   returns false for supportsFastScrolling().
 - AlphabeticalAppsList#mAllAppsStore is now optional, so the
   Search RV doesn't need to store/listen to apps. Note this
   doesn't affect the predicted app row which is still updated
   if one of the predicted apps is uninstalled (I tested this).

Future work:
 - Determine why dispatchRestoreInstanceState is not called for
   BaseAllAppsContainerView. Save is called, e.g. on rotation.
   Effect of restore not called: rotating while searching goes
   back to A-Z list.
 - Keep suggested apps in Header while searching. Currently they
   are rendered in the SearchRV above search results, as before.
 - Potentially extract Personal/Work tabs to move independently of
   header.
 - AlphabeticalAppsList is a misleading name because it can also
   contains search results. However, things are pretty intertwined
   between that and BaseAllAppsAdapter (effectively a circular
   dependency), so I figured cleaning all that up was out of the
   immediate scope of this refactor, which is mainly meant to
   unblock transition work.

Bug: 206905515
Test: Manually checked for regressions, ran tests.
Change-Id: I4d3757c8a8f9b774956ca6be541dd4fcdad1de13
2022-04-24 17:36:48 -07:00
TreeHugger Robot 1582aafbc0 Merge "Provide more accurate feedback on nav bar region gestures during the back gesture tutorial." into tm-dev 2022-04-23 02:51:20 +00:00
Tony Wickham aed0c4d73e Defer onIsStashedChanged() until all controllers are initialized
Test: N/A
Fixes: 230133882
Change-Id: I27df993a08327d28669963e3cecfaa133daf11c9
2022-04-22 17:28:35 -07:00