Commit Graph

4748 Commits

Author SHA1 Message Date
Sebastián Franco b11936e0f5 Merge "Moving AllApps device profile variables to their own class" into main 2025-06-02 13:34:10 -07:00
Treehugger Robot 2f9d81a9d7 Merge "Converting FastBitmapDrawable to kotlin" into main 2025-05-30 17:38:05 -07:00
Treehugger Robot 66b2ec3129 Merge "Remove screenrecord for TaplUninstallRemoveTest" into main 2025-05-30 12:23:49 -07:00
Catherine Liang 829f57c522 Merge "Move custom Launcher theme flag to shared SysUI package (1/3)" into main 2025-05-30 10:51:09 -07:00
Federico Baron 9f429958f8 Remove screenrecord for TaplUninstallRemoveTest
Flag: EXEMPT test only
Bug: 386231522
Test: TaplUninstallRemoveTest#testUninstallFromAllApps
Change-Id: Iff5e8b081e2e26c83b6d3cfdb0ebb82d7eb0fd7b
2025-05-30 17:02:44 +00:00
Sebastian Franco 136295f62a Moving AllApps device profile variables to their own class
Bug: 419264653
Flag: EXEMPT refactor
Test: DeviceProfileDumpTest
Test: All Image tests
Change-Id: I6490422d04f9f0aeaadf8271d4d11172f344660a
2025-05-30 09:56:01 -07:00
Sunny Goyal e674891dfa Converting FastBitmapDrawable to kotlin
Will be adding more functionality in followup cl, and this will make it easier

Bug: 421146818
Flag: EXEMPT refactor
Test: atest FastBitmapDrawableTest
Change-Id: I7ce3ca0dc126efe410c8b7ebec6c601666b7cb54
2025-05-30 08:52:52 -07:00
Shamali Patwa cddba00520 Merge changes from topic "widget-picker-launcher" into main
* changes:
  Add dagger2-compiler to some of picker module targets.
  Add no-op widget picker module to some test modules / graphs.
  Wire the compose based widget picker in widget picker activity
  Repository and datasource implementations backing the widget picker.
  Add widget picker module dependency to launcher when compose is enabled
  Open widget picker activity instead of full sheet when refactor flag is on
2025-05-30 04:18:55 -07:00
Shamali Patwa 9d946aa755 Add no-op widget picker module to some test modules / graphs.
Bug: 408283627
Flag: EXEMPT not applicable
Test: dagger build
Change-Id: I77b2f9f32037303ddfd7f2950c7b235f9aff8f2c
2025-05-29 13:26:10 -07:00
Catherine Liang 4bbf978043 Move custom Launcher theme flag to shared SysUI package (1/3)
This allows the flag to be shared with Customization Picker.

Flag: com.android.systemui.shared.extendible_theme_manager
Test: manually verified by building w/ soong and gradle
Test: manually verified by flipping flag
Bug: 397782741
Change-Id: I131f54602e33dd2b92ce0068f5fc43da3e150a01
2025-05-29 18:47:43 +00:00
Treehugger Robot ba8a5a2235 Merge "Disable surface effects when a theme controller doesn't support adaptive themed icons" into main 2025-05-29 09:57:49 -07:00
Treehugger Robot 3893804a59 Merge "Moving hotseat variables in DeviceProfile to their own class" into main 2025-05-29 09:01:51 -07:00
Uwais Ashraf 478f07798e Moving hotseat variables in DeviceProfile to their own class
Bug: 419264653
Flag: EXEMPT refactor
Test: DeviceProfileDumpTest
Test: All Image tests
Change-Id: I377b33668c3ed330d362527f62226dd84a5773db
2025-05-29 13:16:05 +00:00
Treehugger Robot baacf9f4df Merge "Converting StatsLogManager to kotlin" into main 2025-05-28 18:29:53 -07:00
Sunny Goyal ac35781625 Disable surface effects when a theme controller doesn't support adaptive themed icons
Bug: 420985075
Bug: 415118235
Flag: com.android.launcher3.extendible_theme_manager
Test: Verified on device
Change-Id: I82c46e529aa59be345bf6cdfcfa29fdf784c0068
2025-05-28 16:38:24 -07:00
Vadim Tryshev a5c22505bb Merge "Removing ViewCaptureRule" into main 2025-05-28 15:01:22 -07:00
Sunny Goyal bb0f554148 Converting StatsLogManager to kotlin
This is make it easier to create factory classes for individual when adding more injected parameters

Bug: 361850561
Test: Presumit
Flag: EXEMPT refactor
Change-Id: Ie68e9e24aae801b7fed14d1b03df760e5b67c183
2025-05-28 14:12:13 -07:00
Vadim Tryshev f3112aea02 Removing ViewCaptureRule
Bug: 315482167
Flag: EXEMPT test fix
Test: presubmit
Change-Id: If60412dcec9614fefe897e766395660acb8fa4f8
2025-05-28 11:53:07 -07:00
Vadim Tryshev eb10725b17 Merge "Better trace for sampler rule." into main 2025-05-28 10:00:56 -07:00
Treehugger Robot 13a600cd96 Merge "Adding ListenableRef as an alternative to StateFlows." into main 2025-05-27 18:01:25 -07:00
Vadim Tryshev d9c2c46d2a Better trace for sampler rule.
Bug: 415910933
Flag: EXEMPT test fix
Test: presubmit
Change-Id: Ic6a39d7c70cbc0dad9b2e8b208a07414122a307b
2025-05-27 16:06:17 -07:00
Sebastián Franco aeab3c0d79 Merge "Revert "Revert "Moving DeviceProfile properties into DevicePrope..."" into main 2025-05-23 17:03:18 -07:00
Sebastián Franco e1d31e5406 Revert "Revert "Moving DeviceProfile properties into DevicePrope..."
Revert submission 33716851-revert-33672643-DataDeviceProfile1-XHYRAPLEBK

Reason for revert: Error is fixed

Reverted changes: /q/submissionid:33716851-revert-33672643-DataDeviceProfile1-XHYRAPLEBK

Change-Id: Ib86824134955903c11e51e52dbfd6368aba1cd50
2025-05-23 14:08:11 -07:00
Priyanka Advani (xWF) 7705e92d93 Revert "Moving DeviceProfile properties into DeviceProperties da..."
Revert submission 33672643-DataDeviceProfile1

Reason for revert: Droidmonitor created revert due to b/419867875. Will be verifying through ABTD before submission.

Fix: 419867875

Reverted changes: /q/submissionid:33672643-DataDeviceProfile1

Change-Id: Icb66aefbbcee24e05806b2139923e1f2ea1c65e3
2025-05-23 13:53:04 -07:00
Sunny Goyal a57d75cd11 Adding ListenableRef as an alternative to StateFlows.
This allows using listener pattern instead of coroutines within the recommended repository pattern and avoid the jank due to coroutines

Bug: 390572144
Test: atest ListenableRefTest
Flag: com.android.launcher3.model_repository
Change-Id: I9f74166e01e1bdb4cb8afce3213022ea10137230
2025-05-23 13:52:16 -07:00
Sebastian Franco e1111e28c2 Moving DeviceProfile properties into DeviceProperties data class
Bug: 419264653
Flag: EXEMPT refactor
Test: DeviceProfileDumpTest
Test: All Image tests
Change-Id: I638f88cd76b926917965dbf9e70b5bdfff5971e0
2025-05-23 10:42:26 -07:00
Sebastian Franco c5f5569f52 Removing methods from BaseLauncherActivityTest to make tests by composition
Bug: 324261526
Flag: EXEMPT test only
Test: All test using BaseLauncherActivityTest
Change-Id: If7cbe84b219b174cd51fac20f104080f735c03f4
2025-05-23 10:08:57 -07:00
Sebastián Franco 48e7365190 Merge "Removing getOnceNotNull from BaseLauncherActivityTest to launcherActivity" into main 2025-05-23 09:16:49 -07:00
Helen Cheuk 73661fda2e Merge "[Action Corner] Add padding between action corner and taskbar" into main 2025-05-23 06:35:28 -07:00
Jordan Silva f21e4b8023 Merge changes from topics "app-chip-compose", "launcher-compose-tests" into main
* changes:
  Add AppChip in Compose
  Update build to support Compose tests custom directory
2025-05-23 05:18:32 -07:00
Sebastian Franco 1fcb21621b Removing getOnceNotNull from BaseLauncherActivityTest to launcherActivity
This is to make tests by composition instead of inheritance.

Bug: 324261526
Flag: EXEMPT test only
Test: All test using BaseLauncherActivityTest
Change-Id: I616207da890e1979480d1b748f69a9c27c53f9db
2025-05-22 12:06:25 -07:00
Treehugger Robot e5b641dde1 Merge "Update TestLauncherActivity to send TAPL launcher stopped message" into main 2025-05-22 11:36:54 -07:00
Sebastián Franco b01c488915 Merge "launcher: Add e2e quickstep tests to NexusLauncherE2ETests" into main 2025-05-22 10:08:04 -07:00
Jordan Silva 4de09ab0ee Update build to support Compose tests custom directory
- Support for Compose Screenshot tests using ScreenshotComposeLib.
- Support for custom directory for tests to be used when compose flag is enabled.

Bug: 400436593
Fix: 366387927
Flag: EXEMPT Build flag: RELEASE_ENABLE_COMPOSE_IN_LAUNCHER
Test: Build
Change-Id: I9a5a5fd4942da2b5d8be0e554e1a42b1cde5f2af
2025-05-22 17:29:51 +01:00
Schneider Victor-Tulias 9705f8fefa Update TestLauncherActivity to send TAPL launcher stopped message
This removes the need for a workaround in LauncherInstrumentation.executeAndWaitForLauncherStop for FallbackRecentsTests with recents window enabled

Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 377678992
Test: FallbackRecentsTest
Change-Id: I1b974cb2bfff4c14e99abb96c35dcdff04ed0be7
2025-05-22 09:01:14 -07:00
helen cheuk 6e5225bd77 [Action Corner] Add padding between action corner and taskbar
This is to avoid triggering unstashing taskbar and action corner at the same time.
A padding is added between the two areas.

Bug: 411091884
Test: TaplTestsTransientTaskbar
Flag: com.android.systemui.shared.cursor_hot_corner

Change-Id: I4e380a3d004977c96502af23f6126f22749e0a8f
2025-05-22 12:23:34 +00:00
Treehugger Robot 091890adbc Merge "Support workspace cells with two-line labels" into main 2025-05-21 18:25:15 -07:00
Toni Barzic 83b8cc19ca Support workspace cells with two-line labels
Adds `maxLineCount` attribute to CellSpec. The attribute indicates the max
number of lines of text the cell was speced to support. It's used to:
*   enable two-line labels in `BubbleTextViews` for workspace (including
    folder children) items
*   Update cell dimension calculation to inform cell vertical padding

When calculating cell content size the icon text size will be included
`maxLineCount` times, so the cell content gets centered as if it
contains `maxLineCount` lines of text. That way the icon position will
be consistent between cells with text that fits into one line, and cells
that contain two lines of text.

Adds `maxLineCountMatchesWorkspace` attribute to specify that the cell
should inherit `maxLineCount` from workspace cell spec.

Bug: 30153091
Flag: com.android.launcher3.enable_scalability_for_desktop_experience
Test: Manual

Change-Id: I150a62f427a0ad755a4746a736d9846d3bea4d2e
2025-05-21 22:04:33 +00:00
Kevin Lim f7ce5a06fe [Multiline] Clean-up multiline flag on Launcher3
Bug: b/409605328
Flag: EXEMPT removing multiline_search_bar
Test: Unit tests all passing
Change-Id: Id377b7c99af0d0265102888b8021c0809f53a6b9
2025-05-20 18:52:14 -07:00
Alex Chau 13d1b07304 Merge "Reland "Recreate Launcher activity when blur enabled changes"" into main 2025-05-19 07:03:27 -07:00
Treehugger Robot 5ae4fb14f4 Merge "Wait for all springs to finish before running end snapping and relayout." into main 2025-05-19 03:47:48 -07:00
Vadim Tryshev a3e63d1e20 Merge "Skip all tests after a test times out" into main 2025-05-16 14:06:56 -07:00
Shamali Patwa b7b5e60d9f Merge "Pass device profile as constructor arg to DatabaseWidgetPreviewLoader" into main 2025-05-16 14:06:39 -07:00
Sebastian Franco 57da21d3c4 launcher: Add e2e quickstep tests to NexusLauncherE2ETests
The test target apk will remain commented until we fininsh adding
all the tests there.

Bug: 324261526
Flag: EXEMPT test only
Test: atest NexusLauncherE2ETests
Change-Id: I989c85baf87cfb15eca817f0c725968dedf015ce
2025-05-16 21:03:03 +00:00
Shamali Patwa 35c051001c Merge "Centralize all entry points for widget picker" into main 2025-05-16 13:41:26 -07:00
Shamali P 4cb6ff3838 Pass device profile as constructor arg to DatabaseWidgetPreviewLoader
This is so, we can use it with compose, and let caller pass the needed
dependencies. May also convert to dagger in
 followup

Bug: 408283627
Flag: EXEMPT BUGFIX
Test: N/A
Change-Id: I9b04011ec2592df3bd02bd74ec4889eb05928e7f
2025-05-16 11:47:18 -07:00
Pat Manning e229b40329 Wait for all springs to finish before running end snapping and relayout.
- Adds a SpringSet to track all running springs.
- Rearranges the code into blocks: end runnable, reflow, dismiss, neighbor bounce, etc.
- Renames all instances of draggedTaskView to dismissedTaskView for consistency
- To stop blocking touch earlier, run grid end translation without waiting for the neighbor bouncing to finish.
- Update TAPL split screen launching logic to wait for dismiss animation to end.

Fix: 415327465
Test: TaplTestsQuickstep.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I59ade102e35e3528971907e898dac9555c6de796
2025-05-16 19:10:00 +01:00
Alex Chau 557d8e6d7f Reland "Recreate Launcher activity when blur enabled changes"
- When battery saver changes, WallpaperThemeManager always recreate activity to reapply theme base on wallpaper color hint changes
- Battery saver change can also result in light/dark theme changes, for which WallpaperThemeManager also recreate activity to apply theme changes
- As a result, it'll be much simpler to recreate activity whenever isBlurEnabled changes
- Exposed recreateToUpdateTheme API from WallpaperThemeManager to achieved this
- Greatly simplified Overview styling to read from styles

Reland fix:
- Removed mBlursEnabled in BaseDepthController, and only use `mCrossWindowBlursEnabled` to control swapping between blur style and fallback style
- Temporary variables like `mPauseBlurs` and `hasOpaqueBg` should only affect if blurs are applied, but not result in swapping of blur style, otherwise this cause unnecessary redraw or activity recreate

Reason for revert: reland
Reverted changes: /q/submissionid:33581402-revert-33554447-b/414789280-CTVRJLPLRT
Bug: 414789280
Test: manually toggling battery saver and light/dark theme and WallpaperThemeManagerTest
Test: PressBackFromLaunchedApp.testPressBackFromLaunchedApp
Flag: EXEMPT bugfix

Change-Id: Iac2b0c00811e0e79684da0cf77df76a120c1272a
2025-05-16 12:33:44 +01:00
Vadim Tryshev 3743ca97c7 Skip all tests after a test times out
That test can continue running in the "Time-limited test" thread,
and we don't know whether it makes sense to wait for its completion.

Flag: EXEMPT test fix
Fixes: 405849365
Test: TAPL tests; pre/postsubmit
Change-Id: I3bdd6e5b07f109124f938766b7f2e427d2e39b01
2025-05-15 13:44:40 -07:00
Alex Chau 38efd382b7 Merge "Revert "Recreate Launcher activity when blur enabled changes"" into main 2025-05-15 13:07:22 -07:00