Commit Graph

16822 Commits

Author SHA1 Message Date
Schneider Victor-tulias 9dfffc7df1 Merge "Fix flaky RuntimeException in CellLayout." into udc-qpr-dev am: 06ca4d9c6e am: 12c0933c6a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24212787

Change-Id: Ibfce519ee888b3652e76eac6ac1b60d75c92867b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-26 22:17:24 +00:00
Schneider Victor-tulias 06ca4d9c6e Merge "Fix flaky RuntimeException in CellLayout." into udc-qpr-dev 2023-07-26 20:35:15 +00:00
Schneider Victor-tulias 750c5af2da Fix flaky RuntimeException in CellLayout.
Changing the grid while a previous loader is running (more likely to happen in test) can cause a saved item info to have a cell position outside the bounds of the new grid. This should just be handled the same way as other item infos being loaded in an occupied space.

Flag: not needed
Fixes: 233989158
Test: changed grid sizes multiple times
Change-Id: Ibba337c224e7a08533331a87b1369ebf96e3c9a3
2023-07-26 10:20:24 -07:00
Vinit Nayak 841d577849 Merge "Enable ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE for TEAMFOOD" into udc-qpr-dev am: dc53fdc717 am: 7b35f7a3e0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24152622

Change-Id: I07318e5e4cb72074f016e2a458714b375ee2b3dd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-26 02:07:51 +00:00
Vinit Nayak dc53fdc717 Merge "Enable ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE for TEAMFOOD" into udc-qpr-dev 2023-07-26 00:50:33 +00:00
Schneider Victor-tulias ba31fc7917 Merge "Fix home animation jank when quickly pressing home button" into udc-qpr-dev am: c73b653e1d am: e07ea9d25c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24180027

Change-Id: I064a701cb7c72af53113cffbdb10bf586926ae9c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-25 21:55:49 +00:00
Schneider Victor-tulias c73b653e1d Merge "Fix home animation jank when quickly pressing home button" into udc-qpr-dev 2023-07-25 21:01:47 +00:00
Greg Kaiser 2a2e30ed88 Merge "Revert "Change Overview Actions to round buttons."" into udc-qpr-dev am: b095594afd am: d4ed91551d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24191951

Change-Id: Ie0d08c25f1c5db107df84204713ed390b7533d42
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-25 18:23:06 +00:00
Greg Kaiser b095594afd Merge "Revert "Change Overview Actions to round buttons."" into udc-qpr-dev 2023-07-25 16:44:28 +00:00
Greg Kaiser f849f2856f Revert "Change Overview Actions to round buttons."
Revert submission 23784078-overview-actions

Reason for revert: b/293081298

Reverted changes: /q/submissionid:23784078-overview-actions

Change-Id: I185cfc6baf8dd2243f6fb5a585c926f9df3b3934
2023-07-25 14:27:28 +00:00
Thales Lima 90b8b9f5fe Merge "Add twoPanelId attribute for responsive grid in device profile" into udc-qpr-dev am: d9f4d93cbf am: a23bf8144b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24160393

Change-Id: I3ee9ccbeabeb3ddec44ed1ff304d4992acb63a8b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-24 22:14:21 +00:00
Thales Lima d9f4d93cbf Merge "Add twoPanelId attribute for responsive grid in device profile" into udc-qpr-dev 2023-07-24 21:24:00 +00:00
Andy Wickham 2000264559 Merge "Change Overview Actions to round buttons." into udc-qpr-dev am: 03b5f8b1d1 am: 48445a5fb2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23783599

Change-Id: I5e5ffed6f3eee007dffb60a56f9a1cd4c0dfd8d6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-24 21:05:43 +00:00
Andy Wickham 03b5f8b1d1 Merge "Change Overview Actions to round buttons." into udc-qpr-dev 2023-07-24 19:56:23 +00:00
Charlie Anderson 7c3ed1ddc6 Merge "When unpausing work profile after reboot, we should do a single reload of the workspace." into udc-qpr-dev am: a1bcd4b146 am: 36f71229e7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24154771

Change-Id: Ibc3aae32003b2d6ddcee723971d4652c7f1b386c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-24 17:49:11 +00:00
Schneider Victor-tulias 3913e297e9 Fix home animation jank when quickly pressing home button
Pressing the home button a second time while the app icon is animating cancels the animation. The listener view's AFV doesn't need to be explicitly closed since it will be cleaned up.

Flag: not needed
Fixes: 291807246
Test: manually pressed the home button twice quickly
Change-Id: Ia963e06da78742eade91a6174c3d5f5328368bc5
2023-07-24 10:44:41 -07:00
Andy Wickham f98949cac3 Change Overview Actions to round buttons.
If floating search is active in Overview (flag enabled and we are
the active Launcher), these buttons will be aligned to the search
bar relative to the bottom of the screen. Otherwise, the buttons
will be aligned below the active task like before.

Demo for Launcher3 build:
https://drive.google.com/file/d/1fVzRRnW5AFDMPkW-E8_w4BOCzTAOURQ_/view?usp=drive_link&resourcekey=0-6-EbFZXkBqcu0rw7uuEzjw

Bug: 292000892
Test: Manual with floating enabled/disabled and
SEPARATE_RECENTS_ACTIVITY enabled/disabled (simulating not being
the active Launcher). Also tested with a 3P Launcher, Nova.
Flag: N/A; this change is enabled by default, but also verified
UI looks correct with ENABLE_FLOATING_SEARCH_BAR.

Change-Id: Ia45f88d2c691c4525b1e73cca4707498d058a917
2023-07-22 07:43:17 +00:00
Charlie Anderson 673a81be1e When unpausing work profile after reboot, we should do a single reload of the workspace.
Prevents greyed out work items from persisting that are not actually paused.

Bug: 290870690
Test: manually tested pausing work profile, rebooting, unpausing work profile. Also tested just pausing/unpausing work profile.
Change-Id: Iab6d51c9bf47b1732b9cc4278bec5119e7c6afbf
2023-07-22 02:29:50 +00:00
Jordan Silva 575c3bddec Add twoPanelId attribute for responsive grid in device profile
Three new attributes were created to be used in device profile. These attributes will provide the responsive specs for two panel devices.

Fix: 292204121
Flag: ENABLE_RESPONSIVE_WORKSPACE
Test: DeviceProfileDumpTest
Test: DeviceProfileResponsiveDumpTest
Test: DeviceProfileResponsiveAlternativeDisplaysDumpTest
Change-Id: I35c93e16dde043b0fd611b81bf2de74e3621818e
2023-07-21 12:00:43 +01:00
Brian Isganitis 33b95b2bae Notify Taskbar search session of All Apps transitions. am: c90df24e1c am: c3ad647a4f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24024253

Change-Id: I396db136b58b803c58599198adc4fd25683da200
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-21 01:29:28 +00:00
Brian Isganitis c3ad647a4f Notify Taskbar search session of All Apps transitions. am: c90df24e1c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24024253

Change-Id: I84b68eb4933b575b84e00d1b39ceb3ea0e5e71ea
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-21 01:09:35 +00:00
Brian Isganitis 5cc62b13ee Merge changes from topics "taskbar-search-back", "taskbar-search-transition" into udc-qpr-dev
* changes:
  Support system back in Taskbar search session.
  Notify Taskbar search session of All Apps transitions.
2023-07-21 00:14:04 +00:00
Vinit Nayak d49239be89 Enable ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE for TEAMFOOD
Bug: 276361926
Flag: ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE
Change-Id: I55c8e8293eeadeca623ae879ca62d8d7c405f486
2023-07-20 16:32:51 -07:00
Fengjiang Li cc83032318 Merge "Log appear animation's scale factor" into udc-qpr-dev am: bebcaaae19 am: 3ff869be8f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24119210

Change-Id: I2611a1f8052ef1cacdc513c2fd8b3375365b48a7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-20 21:53:34 +00:00
Fengjiang Li bebcaaae19 Merge "Log appear animation's scale factor" into udc-qpr-dev 2023-07-20 21:02:42 +00:00
Fengjiang Li da718e9749 Log appear animation's scale factor
Test: Grabbed a bug report b/291974797
Flag: N/A
Bug: 290320302
Change-Id: Ic33dc94806b838a03a2203bdd5701a1eeaeeb7bf
2023-07-20 11:08:14 -07:00
Brian Isganitis c90df24e1c Notify Taskbar search session of All Apps transitions.
Test: Manual
Bug: 290819902
Flag: ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
Change-Id: I9ff5ec7d55c33f9987aec79ebae31c38c710a920
2023-07-20 13:41:14 -04:00
Jordan Silva ab8c185507 Merge "Implement responsive grid for foldables 4x4 grid" into udc-qpr-dev am: 9dbe9e34af am: 68d0e4891d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23765913

Change-Id: I59236eeb1b7743fdf2c7962ef84fd10644e820bb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-20 17:39:09 +00:00
Jordan Silva c118fb5dea Implement responsive grid for foldables 4x4 grid
Bug: 277064862
Fix: 289888732
Flag: ENABLE_RESPONSIVE_WORKSPACE
Test: DeviceProfileResponsiveDumpTest
Test: DeviceProfileResponsiveAlternativeDisplaysDumpTest
Test: ResponsiveHomeScreenImageTest
Test: ResponsiveAllAppsImageTest
Test: ResponsiveFolderImageTest
Change-Id: Idf21fc0dc71f9cea474dc9515a4695ccaf6bc094
2023-07-20 11:37:00 +01:00
Anushree Ganjam 18b120dce4 Merge "Implement ImpressionLogging v2." into udc-qpr-dev am: 4cd4ed090e am: 935e03400e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24016221

Change-Id: Ic2ddc5b8486430b485ba5924cfd0a4f22e6248dc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-20 00:19:30 +00:00
Brian Isganitis 4b43de28fa Merge "Start drag from current translation shift during animation." into udc-qpr-dev am: 62b59f9a81 am: 268ba3f6dc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24130990

Change-Id: I5d15dfe1cb24fec970552d14e5c2b75beed3e816
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-20 00:19:16 +00:00
Anushree Ganjam 4cd4ed090e Merge "Implement ImpressionLogging v2." into udc-qpr-dev 2023-07-19 23:17:10 +00:00
Brian Isganitis 62b59f9a81 Merge "Start drag from current translation shift during animation." into udc-qpr-dev 2023-07-19 23:06:32 +00:00
Brandon Dayauon ba39c6a3e8 Merge "Make mDisplay DISPLAY_SEARCH_RESULT visible for test" into udc-qpr-dev am: cff52a4db6 am: 7f88952e20
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24013857

Change-Id: Icc55dfb940f9c230286a7d0f47fe8882452a01ac
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-19 22:52:37 +00:00
Brandon Dayauon cff52a4db6 Merge "Make mDisplay DISPLAY_SEARCH_RESULT visible for test" into udc-qpr-dev 2023-07-19 22:02:22 +00:00
Thales Lima 20c13c54f8 Merge "Improving responsive grid xml parser" into udc-qpr-dev am: 6382afd657 am: 9b915f6f73
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23766603

Change-Id: Ibaad19450258120849cc94d37ae9442b0aa3631a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-19 21:28:31 +00:00
Fengjiang Li 86c6840352 Merge "Fix bug where all apps rv preinfaltion is not enabled when work profile is disabled" into udc-qpr-dev am: 82ddd8ac97 am: 5b2008e0bf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24119000

Change-Id: Ifd48b6c04dffa63aff1f7872adca0914014f0150
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-19 21:25:43 +00:00
Thales Lima 6382afd657 Merge "Improving responsive grid xml parser" into udc-qpr-dev 2023-07-19 20:56:04 +00:00
Fengjiang Li 82ddd8ac97 Merge "Fix bug where all apps rv preinfaltion is not enabled when work profile is disabled" into udc-qpr-dev 2023-07-19 20:03:48 +00:00
Anushree Ganjam 514314c7ee Merge "Introduce onAnimateToSearchStateCompleted() in SearchUiDelegate." into udc-qpr-dev am: 55405157e2 am: b561ec2921
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24069799

Change-Id: I537885e676a1e4555a90bf41da73b4fc11a3affd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-19 19:09:09 +00:00
Pat Manning a38c61d900 Merge "Update scaleRectAboutCenter to correctly account for negative left/top values and floating point errors using centerX/Y." into udc-qpr-dev am: 933f2b9f27 am: e7048dd987
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23917023

Change-Id: If4358fb96e42da9492a2ff3372c5958f46b57c1f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-19 19:08:56 +00:00
Brian Isganitis f3ebdd4819 Start drag from current translation shift during animation.
Test: Manual
Fix: 291950331
Flag: No
Change-Id: I67fe6a474fc1b10d8e34fb047f98af2c1e6e085c
2023-07-19 14:15:31 -04:00
Anushree Ganjam 55405157e2 Merge "Introduce onAnimateToSearchStateCompleted() in SearchUiDelegate." into udc-qpr-dev 2023-07-19 18:02:41 +00:00
Pat Manning 933f2b9f27 Merge "Update scaleRectAboutCenter to correctly account for negative left/top values and floating point errors using centerX/Y." into udc-qpr-dev 2023-07-19 17:20:39 +00:00
Cameron Brown 089094ab40 launcher3: add missing whitespace to log
Change-Id: Ia3f4ec3bd46647eb3e0ee5a3a5e38d748a8ae02b
2023-07-19 15:08:48 +00:00
Pat Manning 75708262fc Update scaleRectAboutCenter to correctly account for negative left/top values and floating point errors using centerX/Y.
Fix: 290211274
Test: manual.

Change-Id: Ieddce683d76c696b5ac3eae4fb9f73a5827a50ad
2023-07-19 14:47:32 +00:00
Anushree Ganjam a9645535b8 Implement ImpressionLogging v2.
Deprecate V1 implementation and keep only V2.

Bug: 285964742
Test: Manual
Flag: NA

Change-Id: If27f02f7142abf7960f74252d1e46bcd8c5b5e2a
2023-07-18 21:56:28 +00:00
Fengjiang Li bafbdfbfd6 Fix bug where all apps rv preinfaltion is not enabled when work profile is disabled
When work profile is disabled, we should also let main RV use AllAppsStore's recycler view pool.

Test: Turn off work profile, kill launcher process, swipe up all apps, start record perfetto trace, scroll down all apps, then stop record, verify no BubbleTextView inflation after change
Bug: 287523421
Flags: ENABLE_ALL_APPS_RV_PREINFLATION
Change-Id: Idd5f8193e85fc2a250877affc3b2e4ab4a704797
2023-07-18 14:05:36 -07:00
Jordan Silva 8bd7af2b3f Improving responsive grid xml parser
Refactors AllAppsSpecs, FolderSpecs and WorkspaceSpecs initialization to use the same code to parse the xml with different map function. This CL improves the readability of the code and remove code duplication.

Fix: 286538013
Flag: ENABLE_RESPONSIVE_WORKSPACE
Test: AllAppsSpecsTes
Test: CalculatedAllAppsSpecTest
Test: CalculatedFolderSpecsTest
Test: CalculatedWorkspaceSpecTest
Test: FolderSpecsTest
Test: WorkspaceSpecsTest
Test: DeviceProfileResponsiveDumpTest
Test: DeviceProfileResponsiveAlternativeDisplaysDumpTest
Change-Id: Iec5863619399efd2e80f3db46b75c4d785e1656f
2023-07-18 18:03:16 +01:00
Anushree Ganjam 660679f91f Introduce onAnimateToSearchStateCompleted() in SearchUiDelegate.
This will be called when transition animation to search is completed.

Bug: 285166099
Flag: NA
Test: Manual
Change-Id: I69e594cbf3564a866d258654fc23a00410e7deab
2023-07-18 02:16:42 +00:00