Commit Graph

10389 Commits

Author SHA1 Message Date
Becky Qiu 9db4cb559c Merge "[Toast] Add query_length for launcher latency logging." into tm-dev am: fe83fce489 am: f9dfd06424
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18783028

Change-Id: Ieacb02db6f2a4a0c9e5035e4a421a076cab18d1f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-08 18:52:40 +00:00
Becky Qiu f9dfd06424 Merge "[Toast] Add query_length for launcher latency logging." into tm-dev am: fe83fce489
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18783028

Change-Id: I95de30e9971e85981814ca5298d1956870720c76
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-08 18:26:24 +00:00
Becky Qiu fe83fce489 Merge "[Toast] Add query_length for launcher latency logging." into tm-dev 2022-06-08 18:02:07 +00:00
Winson Chung 0cf33355a0 Merge "Revert changes waiting for launcher to resume when transitioning to home" into tm-dev am: 46c9c66048
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18764661

Change-Id: I94743a4cf5b3db0d65e1139c715048b16f9c77a5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-08 03:20:12 +00:00
Winson Chung 2bd8504363 Merge "Revert changes waiting for launcher to resume when transitioning to home" into tm-dev am: 46c9c66048
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18764661

Change-Id: I138786ffdb4f73b4046ae03d4f8bb34a7664c37d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-08 03:18:38 +00:00
Winson Chung 46c9c66048 Merge "Revert changes waiting for launcher to resume when transitioning to home" into tm-dev 2022-06-08 03:11:16 +00:00
TreeHugger Robot df4ac7549c Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-dev 2022-06-08 02:31:19 +00:00
Jon Miranda aced0aaf38 Merge "Pause expensive view updates before setting hw/sw layers." into tm-dev am: 2dac4f7f4c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18673700

Change-Id: Idfe7a978e9fd248ef1f8842881911f535af5a5a1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-08 00:37:27 +00:00
Jon Miranda 2dac4f7f4c Merge "Pause expensive view updates before setting hw/sw layers." into tm-dev 2022-06-08 00:15:35 +00:00
Becky Qiu a61a2cc962 [Toast] Add query_length for launcher latency logging.
Bug: 235249335
Test: no test needed.
Change-Id: Ia16c241a2eb3cb50a17713216182192f7902be9e
2022-06-07 14:20:52 -07:00
Bill Yi 774a541d61 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I6b3c69716125ca572ccb9b5cbd35831c60620519
2022-06-07 13:55:30 -07:00
Winson Chung 29c68e73dc Revert changes waiting for launcher to resume when transitioning to home
- This was added for Go when they had their own recents implementation
  and isn't necessary for the default implementation

Bug: 229668039
Test: Follow steps using test apk from the bug
Change-Id: I0c36f98683e1bf9a3dc11cde2d1113ed1c4d6448
2022-06-06 22:28:09 +00:00
TreeHugger Robot 3ecc8654a6 Merge "Don't allow swiping to HintState if we're already in HintState" into tm-dev am: c012085c6c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18521352

Change-Id: Ida20af0c835cb08a070d450f37a8c3c5eb54ad18
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-04 01:59:41 +00:00
TreeHugger Robot c012085c6c Merge "Don't allow swiping to HintState if we're already in HintState" into tm-dev 2022-06-04 01:38:29 +00:00
Tony Wickham 8d72018a87 Don't allow swiping to HintState if we're already in HintState
Context: there was a bug where you could get stuck in HintState if you
did the following (timing is critical):
1. Short swipe from nav region towards HintState, but not far enough or
   fast enough to commit before letting go; this cancels the state
   animation, returning towards Normal (but, crucially, StateManager
   still has state set as Hint)
2. While previous animation is animating back to Normal, swipe up again,
   but this time faster/farther to actually reach Hint; this time, the
   animation does go towards Hint, but gets stuck there. The reason it
   gets stuck is because StateManager thinks we're already in Hint from
   step 1, so doesn't call onStateTransitionEnd(Hint) in step 2. Thus,
   we never get QuickstepLauncher#onStateSetEnd(Hint), which is what we
   rely on to return to Normal.

The simple fix is to prevent the second swipe in the first place.

Test: short swipe followed immediately by fast fling from nav region on home successfully stays in Normal state intead of getting stuck in HintState
Test:
NexusLauncherOutOfProcTests: com.google.android.apps.nexuslauncher.TaplTestsNexus
Fixes: 228276181
Change-Id: I54c371c8518a9a220e75c98003331b552d8bf8af
2022-06-03 14:56:04 -07:00
Jon Miranda 46ecc0ca08 Pause expensive view updates before setting hw/sw layers.
Prevents widgets from updating mid animation.
Also pauses view updates during app close animation.

Bug: 220939231
Bug: 230617085
Bug: 226171754
Test: manual

Change-Id: I0138d57e6a7b2c22fd9a029e971b3e27c7e9f22e
2022-06-02 12:21:01 -07:00
Winson Chung d419e40223 Merge "Ignore pinned tasks for purposes of gesture nav" into tm-dev am: 238f380853
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18638308

Change-Id: I8feccb2f5ec58799bb82c5e5c5550061cd35bbed
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 22:23:11 +00:00
Winson Chung 238f380853 Merge "Ignore pinned tasks for purposes of gesture nav" into tm-dev 2022-06-01 22:06:48 +00:00
Luca Zuccarini eb49ab04c8 Merge "Remove workspace fade from ALL_APPS > NORMAL transition." into tm-dev am: 46338b09e3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18670230

Change-Id: I24c475f36abe82a7be97334832a3820837619410
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 09:52:47 +00:00
Winson Chung 7ca87c785a Ignore pinned tasks for purposes of gesture nav
Bug: 234170890
Test: Enter content pip, swipe up and see if a duplicate stub taskview
      is created
Change-Id: I62a994749fcaeff48901410ede26b848fa15b830
2022-05-31 23:32:26 +00:00
Luca Zuccarini a36af25ab7 Remove workspace fade from ALL_APPS > NORMAL transition.
This applies to phones only for the one-off transition (Home gesture or
swipe back. See before and after videos in the bug.

Bug: 234359814
Test: manual
Change-Id: I8f4fc9ec40687b641a721bd28b32fcf50514861f
2022-05-31 15:46:28 +00:00
TreeHugger Robot 08de084307 Merge "Use DeviceProfile.widthPx to initialize Taskbar touchableRegion" into tm-dev am: 192b3c3118
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18634727

Change-Id: I7c21408da55e104ca4a57e18f63f89a10edd431f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-27 23:33:25 +00:00
Brian Isganitis ea0cc00256 Merge "Have separate DeviceProfile instances for taskbar and all apps windows." into tm-dev am: deaf8985f6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18618746

Change-Id: Idf5f156ab8fca8a0fce460fbba96574ee3a3a12f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-27 17:56:24 +00:00
Alex Chau 4eebbac3b7 Use DeviceProfile.widthPx to initialize Taskbar touchableRegion
- TaskbarDraglayer.width isn't initialize when Taskbar is recreated before layout, so use DeviceProfile.widthPx instead
- Also listen for DeviceProfile change in TaskbarInsetsController to update Taskbar touchableRegion

Fix: 233316713
Test: Switch to 3 button, nav button works. Swtich to gesture nav, taskbar icon can be tapped
Test: Rotate deice, whole Taskbar should still be touchable
Change-Id: I29ff86fd8616a620f98d9b5438cc586bd69fac33
2022-05-27 18:35:26 +01:00
Brian Isganitis deaf8985f6 Merge "Have separate DeviceProfile instances for taskbar and all apps windows." into tm-dev 2022-05-27 17:25:16 +00:00
Vinit Nayak 4e40207246 Merge "Limit starting bounds of swipe to animation start rect" into tm-dev am: e8a4e0e2dc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18607508

Change-Id: I7524fc3777b7db298adf846862f7184dfdb689c5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-27 03:10:27 +00:00
Vinit Nayak e8a4e0e2dc Merge "Limit starting bounds of swipe to animation start rect" into tm-dev 2022-05-27 02:52:36 +00:00
Andy Wickham f79a5cf7da Merge "Moves Search results into a separate RV (take 2)." into tm-dev am: 4ca247a6bb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18420827

Change-Id: Id20e41c851fcfd3ebbeb80d1f7013da8cc9ddfe4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-26 21:59:18 +00:00
Vinit Nayak f7b4e7f497 Limit starting bounds of swipe to animation start rect
* If the starting point is greater than that of the current
device's width (in either positive or negative direction),
reset the starting rect to be fullscreen task bounds
* More details at b/228829958#comment12

Fixes: 228829958
Test: Reboot device and swipe up from home immediately,
app doesn't fling from the side.
Tested with portrait and landscape launcher.
Tested with fake landscape launcher.

Change-Id: I6ea24e30e9de5716b7830f487b2ed63f56598c50
2022-05-26 14:43:26 -07:00
Andy Wickham 4ca247a6bb Merge "Moves Search results into a separate RV (take 2)." into tm-dev 2022-05-26 21:41:55 +00:00
Brian Isganitis afd72f0726 Have separate DeviceProfile instances for taskbar and all apps windows.
We want to scale down the DeviceProfile for taskbar, but the all apps
window should rely on the original DeviceProfile.

Test: Manual
Fix: 232907361
Change-Id: Ia09f674ada9e445c1d7278fa94c536ea9de13ef9
Merged-In: Ia09f674ada9e445c1d7278fa94c536ea9de13ef9
(cherry picked from commit a9a78117c7)
2022-05-26 17:21:50 +00:00
Alex Chau 9f368706cf Merge "Fix taskbar icon flicker and jump when transforming to hotseat" into tm-dev am: 56e367b744
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18598420

Change-Id: I4d3a292663b1c65b3da8a9175abc4f74995239fd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-26 15:05:02 +00:00
Alex Chau 56e367b744 Merge "Fix taskbar icon flicker and jump when transforming to hotseat" into tm-dev 2022-05-26 09:24:23 +00:00
Sunny Goyal dc497cb1a4 Merge "Creating the transaction on the UI thread" into tm-dev am: 279911fafc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18591002

Change-Id: I6e5433d99d7fe5d5a8a6b1c4c2fea66ece22a95a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-25 22:43:23 +00:00
Sunny Goyal 279911fafc Merge "Creating the transaction on the UI thread" into tm-dev 2022-05-25 22:24:04 +00:00
Schneider Victor-tulias 87313cb18c Merge "Add screen recording to drag to splitscreen taskbar tests to help with debugging." into tm-dev am: 467f30dbb7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18529596

Change-Id: I74743963b18e905a13626bae3b4461061447a14b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-25 21:23:01 +00:00
Schneider Victor-tulias 467f30dbb7 Merge "Add screen recording to drag to splitscreen taskbar tests to help with debugging." into tm-dev 2022-05-25 21:03:04 +00:00
TreeHugger Robot 177b7150e9 Merge "Attempt to preload the Launcher activity when the user reaches the All Set Page." into tm-dev am: 9557b10c59
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18400686

Change-Id: Id9d10958bd8f6e77368199ee3163aa350224ea05
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-25 19:09:34 +00:00
TreeHugger Robot 9557b10c59 Merge "Attempt to preload the Launcher activity when the user reaches the All Set Page." into tm-dev 2022-05-25 18:48:17 +00:00
Bill Yi e965dfe6eb Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-dev 2022-05-25 18:43:37 +00:00
Schneider Victor-tulias 3efef1ce5a Attempt to preload the Launcher activity when the user reaches the All Set Page.
Preloading the Launcher activity once the user reaches the SUW All Set app allows for a smoother first reveal transition. Refactored TIS and TISBinder to make this possible.

Fixes: 226726244
Test: factory reset and flashed a build onto a pixel 6 pro
Change-Id: I1be3383bafdde17b951329de4c7d6b87affd210c
2022-05-25 10:02:20 -07:00
Alex Chau e2e1509d55 Fix taskbar icon flicker and jump when transforming to hotseat
- Apply additional translation on TaskbarView to account for difference between taskbar icon to bottom spacing compared to hotseat icon to bottom spacing
- Call updateIconAlignment outside of synchronizeNextDraw's then block, which get run after the synchronization

Bug: 204850744
Test: manual
Change-Id: Id65842f506eb342105082649446eb694cd5c33a4
(cherry picked from commit 51da219869)
Merged-In: Id65842f506eb342105082649446eb694cd5c33a4
2022-05-25 10:53:29 +00:00
Sunny Goyal cdc111a158 Creating the transaction on the UI thread
This avoids the error when the transaction is created after
the surface is released. In case the surface is released after
transaction object is created, the apply() call simply ignores
that error, whereas previously the transactionCreation will throw
an error

Bug: 231889963
Test: Verified by manually releasing the surface that there is no crash
Change-Id: I9a4b9ca0be2ed687b2fc692570415256e3e479f7
2022-05-24 17:14:44 -07:00
Andy Wickham 2ba7797edb Moves Search results into a separate RV (take 2).
Bug: 206905515
Test: Manually verified b/230648542 did not resurface. Tested
on phone and tablet with and without work profile.

Change-Id: If724f635286b9dff2c64255f9ece3568a5cb4ea9
2022-05-24 17:10:24 -07:00
Bill Yi dbaeaa5c05 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I8dab647a81e5f333a8c4d9ad5dbe13247429f7c1
2022-05-24 14:49:54 -07:00
Sunny Goyal 595c9c37f5 Merge "Avoiding updating task via scroll if RectF spring animation is running" into tm-dev am: 689b000316
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18561212

Change-Id: I1f764d6df15bdb67a040adcfb30b6ed5c4b39c9b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 21:38:19 +00:00
Schneider Victor-tulias aa5ae621c5 Add screen recording to drag to splitscreen taskbar tests to help with debugging.
Test: presubmit and local
Bug: 231615831
Change-Id: I87ea5eb30eaf9ec1f4f96572c78bc9daf976a589
2022-05-24 11:46:31 -07:00
Sunny Goyal 617f9fae3d Avoiding updating task via scroll if RectF spring animation is running
Bug: 231333965
Test: Verified no update at the end of home transition
Change-Id: I2a106f4d7661f9d409425ce2ed755e74e1abe14b
2022-05-23 10:13:10 -07:00
Winson Chung e02cd37542 Merge "Ensure that we're animating the current live tasks when going back" into tm-dev am: 3e6cd99990
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18461390

Change-Id: Ic834d4d2458f2f3be7ff384b835d02b3dda1f343
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-19 07:54:56 +00:00
Luca Zuccarini 0816768dc9 Merge "Additional polish for the NORMAL<->ALL_APPS transitions." into tm-dev am: 175fc66aa8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18375247

Change-Id: I192035c57915775ae411e433da85f134a2c5e187
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-18 22:23:23 +00:00