Commit Graph

18818 Commits

Author SHA1 Message Date
Brian Isganitis 9cbc478574 Split LauncherPrefs into abs class / impl.
Splitting allows easily making a fake that doesn't have to override the implementation details of LauncherPrefs. The fake should not deal with SharedPreferences.

LauncherPrefs could be an interface, but then the companion object has more limitations. The solution there is to have a dedicated object class, e.g. `LauncherPrefItems`. I went with an abs class to make the refactor simpler.

Flag: EXEMPT refactor
Bug: 369641781
Test: go/testedequals
Change-Id: I97a2d495d3b5fa892fa53a11fb3f7a7dfb98515b
2024-10-09 18:55:51 -04:00
Sunny Goyal 9dcf307a62 Merge "Fixing test flakiness in Launcher initialization" into main 2024-10-08 17:29:27 +00:00
Fengjiang Li a49a2a32be Merge "[Dagger] Make SettingsCache provided by DaggerSingletonObject" into main 2024-10-08 17:13:20 +00:00
Brian Isganitis 67ed920053 Merge changes from topic "brianji-object-sandbox" into main
* changes:
  Add SandboxApplication for keeping created contexts in sandbox.
  Allow specifying base for SandboxModelContext.
  Rename to ObjectSandbox.
2024-10-08 16:33:47 +00:00
Fengjiang Li 4d819d9dea [Dagger] Make SettingsCache provided by DaggerSingletonObject
Test: presubmit
Bug: 361850561
Flag: NONE - dagger
Change-Id: Id709a6e1d14446b8361cf292d5f5422f2ea3524c
2024-10-07 23:10:53 -07:00
Sunny Goyal b619d2c297 Removing dependency on PackageInfo in IconCache
Bug: 363324203
Flag: EXEMPT bugfix
Test: atest IconCacheTest
      atest IconCacheUpdateHandler

Change-Id: I85005ef1069960a17a0f3e7265749a8ef3004172
2024-10-08 04:09:54 +00:00
Mykola Podolian 5ddf3ba31f Merge "Fixed the hotseat placement in RTL mode" into main 2024-10-08 02:05:42 +00:00
Brian Isganitis bae6a107de Rename to ObjectSandbox.
Flag: TEST_ONLY
Bug: 369504330
Test: go/testedequals
Change-Id: Iacfdc62270aa6f23e7c9b79205d967272e0a7a66
2024-10-07 16:50:59 -04:00
Treehugger Robot a68110f339 Merge "[Dagger] Make ScreenOnTracker provided by DaggerSingletonObject" into main 2024-10-07 20:49:13 +00:00
Catherine Liang 53683d4ca4 Merge "Handle messages to update Launcher preview color" into main 2024-10-07 19:00:14 +00:00
Fengjiang Li 49df29669d [Dagger] Make ScreenOnTracker provided by DaggerSingletonObject
Test: presubmit
Bug: 361850561
Flag: NONE - dagger
Change-Id: I305ee47f2da92972e9b5effe3c3e02504cd5a3b0
2024-10-07 11:45:16 -07:00
mpodolian 3dcb19f33a Fixed the hotseat placement in RTL mode
Updated logic that computest the hotseat shift.

Fixes: 372014534
Flag: com.android.wm.shell.enable_bubble_bar
Test: Manual. Put device into 3 buttons navigation mode, force RTL.
Hotseat is placed next to the navigation buttons bar.

Change-Id: Ie7b6be11a093ffa4006182bdc0b73018ba799246
2024-10-07 10:34:42 -07:00
Sunny Goyal 95045ce03a Fixing test flakiness in Launcher initialization
Using same key for blob store and content provider based layouts

Using a single key for layout provider. This ensures that if one
test doesn't cleanup properly, any followup test which relies on
model initialization overrides the key appropriately

Bug: 370080120
Test: Presubmit
Flag: EXEMPT bugfix
Change-Id: Idef0a89a5d1ec89e24aae8a4549fd122634dad2f
2024-10-04 20:52:17 +00:00
Catherine Liang b5fdc80bb2 Handle messages to update Launcher preview color
Receive color update messages with a list of color resource ids and a
corresponding list of color overrides, and adjust the preview
accordingly.

Flag: com.android.systemui.shared.new_customization_picker_ui
Test: manually verified that the selected colors are previewed
Bug: 350718581
Change-Id: Ibcde0575416df00b76627ac1004f21f5f9af1196
2024-10-04 19:33:45 +00:00
Ats Jenk 2f3d7b16c6 Merge "Apply bubble bar background alpha to stroke paint" into main 2024-10-03 20:20:08 +00:00
Sunny Goyal e14af2316b Merge "Converting some caching logic booleans to lookup flags" into main 2024-10-02 20:34:16 +00:00
Brandon Dayauon 17b246a556 Merge "Don't call onAppsUpdated() when in testHarness" into main 2024-10-02 19:53:36 +00:00
Ats Jenk ad7a938268 Apply bubble bar background alpha to stroke paint
Alpha was applied to fill paint only. Add it to stroke paint as well.
Introduce a new method in Utilities to map range of ints and not only
floats.

Bug: 345687278
Test: compare bubble bar shadow and stroke before and after change
Flag: com.android.wm.shell.enable_bubble_bar

Change-Id: I7c9e8d6337a857a661de0c945181cdd5ef2fd4ca
2024-10-02 10:20:06 -07:00
Anushree Ganjam 0dc88fece8 Merge "Make InstallSessionHelper injected by Dagger (7/n)" into main 2024-10-02 01:57:48 +00:00
Anushree Ganjam 29e060408f Make InstallSessionHelper injected by Dagger (7/n)
Bug: 361850561
Test: Manual
Flag: NONE Dagger Integration

Change-Id: Ib1833436bfd1079ae78f1d865831c1aa8a7a0c41
2024-10-01 12:45:53 -07:00
Sunny Goyal e978f6cedb Converting some caching logic booleans to lookup flags
Bug: 366237794
Test: atest IconCacheTest
Flag: EXEMPT refactor

Change-Id: I0d25996181954df22e1cb61596be0a2694ee7068
2024-10-01 17:59:48 +00:00
Brandon Dayauon 32007e05cd Don't call onAppsUpdated() when in testHarness
Suspect that the jump in these flakes where it cannot find the private space container is due to this calculateDiff call when onAppsUpdate() is called

bug: 355466672
Test: tapl presubmit and vid: https://drive.google.com/file/d/1hshI6g7oqvi45EiO92Rl4e-gaXfDVe_b/view?usp=sharing
Flag: NONE trying to fix flake
Change-Id: I0bff416624c5b9e2cb7a4fe32834f9d521507922
2024-10-01 09:32:50 -07:00
Treehugger Robot 49e27e5257 Merge "Make widget sheet layout container not focusable" into main 2024-09-30 22:44:28 +00:00
Treehugger Robot 2b1208e803 Merge "Animated fullscreen and desktop carousel attaching together" into main 2024-09-30 17:39:55 +00:00
Alex Chau 396441545f Animated fullscreen and desktop carousel attaching together
desktopCarouselDetachProgress:
- Controls whether desktop and fullscreen carousel is attached (RecentsView..DESKTOP_CAROUSEL_DETACH_PROGRESS)
- When fully detached (progress==1), hide the carousel (RecentsView.applyAttachAlpha)
- As the detach progress increase, we animate the other carousel away by using `getMaxHorizontalOffsetSize`, with additional maxOverscroll to make sure the other carousel won't be seen even if user overscroll RecentsView (RecentsView.updatePageOffsets)

min/max scroll changes
- When desktop and fullscreen carousel detaches, disallow scrolling to the detached carousel. This avoids quickswitching or scroll to the other carousel (RecentsView.getFirstViewIndex and RecentsView.getLastViewIndex)

State machine changes:
- On Overview states, desktop and fullscreen carousel is attached. Otherwise, they're detached, including in quick switch and home. (BaseState, RecentsState, OverviewState, BackgroundAppState)
- StateController set/animate desktopCarouselDetachProgress between the above states (BaseRecentsViewStateController, FallbackRecentsStateController)
- On swipe up gesture release and going to Overview, animate attaching back the 2 carousels (RecentsView.onPrepareGestureEndAnimation)

Bug: 353948100
Test: quick switch; swipe from home/app; scroll in Overview; with normal/3p launcher
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Change-Id: Ic4217efb07db079825a3210afd306d9ef627c873
2024-09-30 11:43:31 +01:00
Treehugger Robot 0c1db56f2f Merge "Requesting ApplicationInfo in cached object" into main 2024-09-28 00:08:58 +00:00
Mykola Podolian 7ae8937eed Merge "Added nav bar properties to DeviceProfile dump() method" into main 2024-09-27 23:38:22 +00:00
mpodolian 518d404509 Added nav bar properties to DeviceProfile dump() method
Added logging of inlineNavButtonsEndSpacingPx and
navButtonsLayoutWidthPx

Test: DeviceProfileDumpTest
Bug: 346381754
Flag: com.android.wm.shell.enable_bubble_bar_in_persistent_task_bar
Change-Id: I9e537db3d8edf815c131fa9f872193f0d16c259d
2024-09-27 14:06:20 -07:00
Sunny Goyal f7c32a29fd Requesting ApplicationInfo in cached object
Bug: 363324203
Test: Presubmit
Flag: EXEMPT refactor
Change-Id: I92f3d3ed8c267b895dc439ba1f01eb67d7f63965
2024-09-27 14:04:16 -07:00
Sunny Goyal 63c24aeacb Merge "Updating IconProvider API to use a single API to load icons" into main 2024-09-27 19:43:54 +00:00
Mykola Podolian 6f231f694d Merge "Update placement of the hotseat according to the bubble bar location." into main 2024-09-27 15:45:04 +00:00
Helen Cheuk e710e70bc8 Merge "[Contextual Edu] Not update edu stats when swiping down all apps panel" into main 2024-09-27 14:58:18 +00:00
Treehugger Robot dee5061e78 Merge "Converting various cache lookup option booleans to flags, so that it can easily be extended" into main 2024-09-27 07:00:52 +00:00
Sunny Goyal a1cebfa0c0 Updating IconProvider API to use a single API to load icons
Bug: 366237794
Test: atest IconProviderTest
Flag: EXEMPT refactor, changes in underlying API

Change-Id: If8c6a4f13de7e7d262ee0b6d0c6897981f75e639
2024-09-26 22:13:11 -07:00
mpodolian dfb48214ea Update placement of the hotseat according to the bubble bar location.
Update the hotseat and Qsb placement according to the 3 nav buttons bar.

Test: Manual.
Set navigation mode to 3 buttons.
On launcher home screen move the bubble bar from one side to another.
Observe that the Hotseat and Qsb moving together with the navigation
bar.
Once moved the bubble bar, expand the bubble bar and collapse it.
Observe how the Hotseat is stashing and un-stashing.
After bubble bar changes position hit the recent apps button, observe
the transition.
On launcher home screen start application with the hotseat icon and exit
opened application. Observe that flying icon comes back to the correct
position in the hotseat.
Video with the above scenarios:
http://recall/-/gx8ASgewUeUS3QYohfrd1J/blTYrKopTyufOcRoPuVpYK
Bug: 346381754
Flag: com.android.wm.shell.enable_bubble_bar_in_persistent_task_bar

Change-Id: Ic8c6acdffbbb111cbe4f3fd6bc60195578d7035d
2024-09-26 19:04:01 -07:00
Sunny Goyal 6813d878ef Converting various cache lookup option booleans to flags, so that it can
easily be extended

Bug: 366237794
Test: Presubmit
Flag: EXEMPT refactor, method signature change
Change-Id: I4c334d05c30bfd9eff61c3a01a6b74feb8012322
2024-09-26 13:29:27 -07:00
Treehugger Robot c0e0b21a64 Merge "Fixing wallpaper preview rendered not being cleaned properly" into main 2024-09-26 20:02:32 +00:00
Sunny Goyal be796be5e6 Fixing wallpaper preview rendered not being cleaned properly
> Using a single RunnableList for all the cleanup
> Performing cleanup when renderer surface is released

Bug: 362292374
Test: Verified manually using heapdump
Flag: EXEMPT bugfix
Change-Id: Idc1ee20dee2a2944d8e1c1d06b2662818d2b7001
2024-09-26 19:46:45 +00:00
Sunny Goyal 984e2d7a5d Merge "Fixing flakiness in robo tests" into main 2024-09-26 16:58:20 +00:00
helencheuk 392a265c1d [Contextual Edu] Not update edu stats when swiping down all apps panel
It should only update edu stats of home gesture when user swipe up to go home. It is already handled in AbsSwipeUpHandler.
This change avoids updating edu stats when users swipe down the all apps panel as it is not considered as home gesture.

Bug: 363480554
Test: Manual
Flag: com.android.systemui.keyboard_touchpad_contextual_education
Change-Id: Ib859cef5cbb2805fd2b596c6c40a67a5f21cceae
2024-09-26 15:34:48 +01:00
Treehugger Robot bb87ff95e8 Merge "Fixing package override is applied in all lookup options" into main 2024-09-25 19:18:36 +00:00
Sunny Goyal fdc09f4a7c Fixing package override is applied in all lookup options
Bug: 369205074
Test: Verified manually
Flag: com.android.launcher3.enable_support_for_archiving
Change-Id: If9fff32ca3574c4b367c3e149a72b2e63c18c3b4
2024-09-25 19:17:28 +00:00
Sunny Goyal 37182de670 Fixing flakiness in robo tests
Bug: 352288591
Flag: EXEMPT test fix
Test: Presubmit
Change-Id: I15dd91815f7ae4d3cf3c9e1fd4c2b5e07052ab3f
2024-09-25 10:52:14 -07:00
Treehugger Robot 9a77922424 Merge "Fix for bug where we don't use default grid on comet, and migrate normally if not in a B&R case" into main 2024-09-25 17:01:54 +00:00
fbaron b633b9aa2b Fix for bug where we don't use default grid on comet, and migrate normally if not in a B&R case
-The grid migration where we just copy the grid and move everything one row up should only occur in a B&R scenario, so now we add that restriction
-We should default to 4x5 in comet if migrating from a 4x4 grid if the device we're migrating from does not have any other grids saved
-if we have other grids saved, then we'll try using the saved grid if possible. If not possible, we use the default grid for the new device

Bug: 360462379
Test: GridSizeMigrationUtilTest
Flag: EXEMPT bugfix
Change-Id: Ia905081046431c08dc058bd61b2b4ab42dee0506
2024-09-24 16:52:05 -07:00
Brian Isganitis bfe4d6b469 Merge changes Ie1b6609b,If115625c,I418675ba,I930e7458 into main
* changes:
  Add tests for TaskbarAllAppsViewController.
  Add tests for TaskbarAutohideSuspendController.
  Add tests for TaskbarScrimViewController.
  Add tests for TaskbarStashController.
2024-09-24 22:53:24 +00:00
Brian Isganitis 3231ba01e6 Add tests for TaskbarStashController.
Test: TaskbarStashControllerTest
Bug: 346394503
Flag: TEST_ONLY
Change-Id: I930e745826f2512d04434ad689a3e42cac7e9901
2024-09-24 18:51:46 -04:00
Sunny Goyal e1b7ca566e Merge "Moving various application into related methods to a separate class" into main 2024-09-24 22:05:52 +00:00
Randy Pfohl 31aefc3290 Merge changes from topic "windowRecents" into main
* changes:
  Cleaning up unusued handlers
  Moving RecentsWindowManager away from the singleton pattern
  Limited recents in window introductory cl
  abstracting fallback views to support container instead of activity
2024-09-24 16:13:30 +00:00
Sunny Goyal 28d6bbd6b4 Moving various application into related methods to a separate class
> This avoids duplicate RPCs when trying to get multiple properties
  from AppInfo
> This would be used in a followup cl when AppInfo is added to caching
  logic in IconCache

Bug: 366237794
Test: atest ApplicationInfoWrapperTest
Flag: EXEMPT refactor
Change-Id: I55b964d4f8cfa1ff1770e310ac278719495e285d
2024-09-23 22:09:24 -07:00