Commit Graph

6802 Commits

Author SHA1 Message Date
TreeHugger Robot 9c871ae7b6 Merge "Reset split selection state on animation end instead of success" into sc-v2-dev 2021-09-28 03:43:09 +00:00
Vinit Nayak df7a526931 Merge "Unbind service only if it was bound" into sc-v2-dev 2021-09-27 23:56:21 +00:00
Vinit Nayak 29e900b907 Reset split selection state on animation end instead of success
When overview button tapped in while in overview,
the animation to undo split gets cancelled
(probably because Launcher gets destroyed before the animation
can fully run successfully)

Fixes: 201011797
Test: Same steps in bug don't cause placeholder view
to be shown

Change-Id: I2ea1eac637d6f2a3185d50d01601d3588ec9f535
2021-09-27 16:14:58 -07:00
Vinit Nayak a26e4f8e43 Unbind service only if it was bound
Removed unused SplitPlaceholderView

Fixes: 200004580
Change-Id: I54ee819260ad6e4e6da2d3efafd38bad0336486e
2021-09-27 14:56:45 -07:00
TreeHugger Robot fd583efb71 Merge "Remove screen actions plugin" into sc-v2-dev 2021-09-27 17:52:28 +00:00
TreeHugger Robot d58e7b6fc4 Merge "Cleanup split screen offset in TaskViewSimulator" into sc-v2-dev 2021-09-25 04:06:48 +00:00
Jonathan Miranda 2eb7511781 Merge "Avoids animating the background when launching app targets are translucent." into sc-v2-dev 2021-09-25 02:04:48 +00:00
Zak Cohen 0ba6058f8c Remove screen actions plugin
Bug: 201115460
Test: local build
Change-Id: I22774e464d1230fffff3d512b0b906f999d51080
2021-09-24 23:11:18 +00:00
Jon Miranda 3940470bed Avoids animating the background when launching app targets are translucent.
Bug: 200052247
Test: Pause an app, click on paused app and ensure background does not animate
Change-Id: Ib0a7cac0ab866441dd8fb27831a8333d0c931723
2021-09-24 16:00:25 -07:00
Tony Wickham 2fb815b2fd Cleanup split screen offset in TaskViewSimulator
- Removed mRunningTargetWindowPosition and mSplitOffset, as they countered each other out anyway
- Removed PagedOrientationHandler#setLeashSplitOffset() since it's no longer used

Test: Swipe up from split and non split apps in both orientations on large and small devices, with and without home rotation enabled
Bug: 200817624
Change-Id: I78a80cbc718ee38a8933fa323798fb436710d59f
2021-09-24 15:37:30 -07:00
Tony Wickham 9a0d98f483 Merge "Fix right split screen app going to wrong target" into sc-v2-dev 2021-09-24 22:01:06 +00:00
Schneider Victor-tulias 405400c2fe Merge "Fix stalled gesture navigation tutorial." into sc-v2-dev 2021-09-24 19:12:26 +00:00
Vadim Tryshev fcc51bd1fa Merge "Allowing having only SysUI views before pressHome()" into sc-v2-dev 2021-09-24 18:15:07 +00:00
Vinit Nayak f2907c6ce3 Merge "Hide split options for focused task." into sc-v2-dev 2021-09-24 17:18:02 +00:00
TreeHugger Robot 3eecc1b472 Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-v2-dev 2021-09-24 16:45:36 +00:00
Bill Yi a08c24cb12 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I6cbb9e2db4da931ba13fa066ae4b1e1553a8a3dd
2021-09-24 09:25:02 +00:00
Iris Yang 8bf24a58ae Move/Launch task on the TaskView's display.
Add ActivityOptions#setLaunchDisplayId to the display that the TaskView
is currently on. So the task will be moved to the display as the user is
interactiving with.

This change is adding ag/15604010 back since b/197293995 is fixed.

Bug: 183461428
Test: Manually tested using Exo. Open appliction(e.g.Calculator) on
Exo virtual display, and tapping on the phone's recents to bring the
application back to phone.
The demo video  https://drive.google.com/file/d/1JMncvsI-VPosK4ql2xeVA8csVAF7Rb16/view?usp=sharing&resourcekey=0-PYRw1k3KdtY0-KZNo6OqjQ

Change-Id: I39b1825b69d55001f66ee01a982e3cd366da56bd
2021-09-24 05:27:32 +00:00
Vinit Nayak e046ea22e9 Merge "Don't show taskbar when keyguard occluded" into sc-v2-dev 2021-09-24 03:02:34 +00:00
vadimt bf41844ad4 Allowing having only SysUI views before pressHome()
pressHome can be called just after another test that
can, for example, pull down the status bar to
occupy the whole screen.

Bug: 201005881
Test: presubmit
Change-Id: Ifc0ae4d66d573720f70aa4e734da03add3d86b57
2021-09-23 19:19:53 -07:00
Vinit Nayak e9fbcc4aeb Merge "Reset floating split task view after remote animation finished" into sc-v2-dev 2021-09-24 01:18:03 +00:00
Tracy Zhou ba086b8125 Merge "Hide task bar icons when notification shade is expanded" into sc-v2-dev 2021-09-24 00:57:26 +00:00
Vinit Nayak 8df5833bc7 Hide split options for focused task.
Fixes: 197245395
Test: Tap app icon on focused task,
no split options.

Change-Id: I329ee3d6e911c16ba2f3b265e2eb42466369df28
2021-09-23 17:22:25 -07:00
Vinit Nayak 03396d4fba Merge "Allow tapping on app icon for second split app." into sc-v2-dev 2021-09-24 00:17:57 +00:00
Tony Wickham 2424f1f3b5 Fix right split screen app going to wrong target
- applyWindowToHomeRotation() to both Matrix's individually
- Move matrix.postTranslate(mSplitOffset) into applyWindowToHomeRotation so it applies both during swipe up and animation to home

Test: Swipe up from vertical and horizontal split screen, ensure both app windows go towards the same target
Fixes: 200817624
Change-Id: I5769da2adb1abb967fa465fc8371b5c9484a32d0
2021-09-23 16:24:21 -07:00
Jonathan Miranda e2455aa1cf Merge "Significantly reduce gesture feedback when swiping up to home screen." into sc-v2-dev 2021-09-23 23:14:50 +00:00
Andy Wickham 768e686466 Merge "Makes All Set layout more responsive." into sc-v2-dev 2021-09-23 23:12:44 +00:00
Andy Wickham 13c3f31a0d Makes All Set layout more responsive.
- No longer forced portrait mode
 - Bottom texts are aligned proportionally to the screen height
   to avoid overlapping in landscape folded
 - Subtitle text width is limited to force wrapping to avoid an
   awkward line of text on wider screens

Fix: 189896987
Bug: 187701213
Test: Manually went between portrait/landscape/folded/unfolded.
Change-Id: Ibb2bbe545cf7f154ad77e10d574e72f8d9110a72
2021-09-23 23:11:59 +00:00
Jerry Chang d3ceb3dc88 Reset floating split task view after remote animation finished
Move reseting floating task view for entering split after remote
animation finished to prevent the floating task view disappear before
opening split task view being visible and causing flicker.

Bug: 199377815
Test: Manual check the flicker disappear
Change-Id: I4a864335972842570c61291a7a0c423edeb74578
2021-09-23 16:01:18 -07:00
Vinit Nayak ea7e9a48fd Don't show taskbar when keyguard occluded
* Show only back button in taskbar for 3
button nav.

Fixes: 199406716
Test: From lock screen view home controls
or double-tap camera, no taskbar shown.

Change-Id: Ia603c7dbe584e3fab62365de4fc5a790c48d1340
2021-09-23 15:55:22 -07:00
Vinit Nayak 9299a743af Allow tapping on app icon for second split app.
Fixes: 200851336
Test: Split with one app from overview,
tap on app icon for second app. Gets
selected as second app.

Change-Id: I312169fe7bc42007c2f1a0146a5fef5f8d5f46d6
2021-09-23 14:46:59 -07:00
Jon Miranda 13519e4402 Significantly reduce gesture feedback when swiping up to home screen.
- Uses overscroll damping logic to reduce the velocity
- The start to target rect interpolation can be from the
  start, center, or bottom of the rect depending on where the item
  is on the workspace. This reduces the  amount of distance needed to
  travel between, which helps further reduce gesture feedback.

Bug: 173107751
Test: test closing app that is on:
      -  top row of home screen
      -  middle of home screen
      - in hotseat

Change-Id: I055dd61ca3491807109ff2f6c501bf710c8d340f
2021-09-23 20:13:40 +00:00
Vinit Nayak 5dded93a72 Merge "Shorten and center TaskMenuView for landscape" into sc-v2-dev 2021-09-23 05:55:17 +00:00
Tony Wickham d523841ab4 Merge "Allow visual stashing when going to overview in tests" into sc-v2-dev 2021-09-23 00:39:01 +00:00
Vinit Nayak 9e6a642d8b Shorten and center TaskMenuView for landscape
* The width of the task menu view for landscape
(both fake and real) is the same as the width
it would be in portrait.
* With the shorter width, we also center the
positioning of the TaskMenuView
* Note this is only for phone, large screen
changes TODO

Bug: 193432925
Test: Tested real/fake landscape + seascape,
view is centered. Portrait same as before.

Change-Id: Ide41e252a3c177c4a911aab544f78930fed2e76f
2021-09-22 14:55:29 -07:00
Tony Wickham 25b6d9783f Allow visual stashing when going to overview in tests
- Seprate out supportsStashing() into supportsVisualStashing() and supportsManualStashing().
- Manual stashing is when user explicitly long presses to stash, which we disable for tests.

Test: testStressSwipeToOverview
Fixes: 200273854
Change-Id: Ib07efa31a1b073de45fdcfac26215129b1b1985b
2021-09-22 13:58:10 -07:00
Schneider Victor-tulias b2339e37d7 Fix stalled gesture navigation tutorial.
Touching the screen after completing the gesture removed all callbacks, preventing the tutorial to progess. Added logic to only remove logic if the gesture is incomplete.

Fixes: 198285152
Test: manual, touched screen and attempted all gestures after completing a step
Change-Id: I320b13cd9b7632a9fb722bc10d3d0a96dc111144
2021-09-22 12:04:24 -07:00
Jonathan Miranda e37b51b30f Merge "Play window close animation to home for most app to launcher scenarios" into sc-v2-dev 2021-09-22 18:26:44 +00:00
Vinit Nayak 9693766477 Merge "Show distinct TaskMenus for each task in GroupedTaskView" into sc-v2-dev 2021-09-22 17:25:08 +00:00
Alex Chau 8f990b94a2 Merge "Keep insets stable when taskbar is destroyed/recreated" into sc-v2-dev 2021-09-22 13:34:12 +00:00
Jon Miranda 8d3d2757e2 Play window close animation to home for most app to launcher scenarios
- Animates into icon/widget location on workspace (when applicable)
- Excludes unlock animation
- Excludes when user goes back to to All Apps state

Bug: 197656197
Bug: 197450256
Bug: 197656915
Test: go in app, swipe back to land on home
Change-Id: Icdf680bd88599f1b6288822a177087283668431c
2021-09-21 20:19:23 -07:00
Vinit Nayak 7caf5f0ea4 Show distinct TaskMenus for each task in GroupedTaskView
* For now we only show the App Info option
for each task icon clicked for GroupedTaskView
* Have TaskMenuView operate on a specific task instead
of only a TaskView
* NOTE: getItemInfo() in TaskIdAttributeContainer needs to
dynamically call getItemInfo(Task) because at the time of
creation of the container in TaskView#bind(), the task
object provided initially is a palceholder task which only
has a taskId and no other attributes set.
getItemInfo() needs a non-null baseIntent, which the
placeholder task doesn't have.
Right fix for this is to have GestureState hold onto
multiple running tasks when in split screen that are
provided by ActivityManagerWrapper when the gesture starts
(but that change is extensive and out of scope w/ this
workaround available)

Bug: 181704764
Test: Open TaskMenuView's w/ either task icon for
GroupedTaskView, opens up corresponding tasks menu.

Change-Id: I70b7c13394ad4980cabbd611cb928bb03d8a2924
2021-09-21 17:47:54 -07:00
TreeHugger Robot c48f770a3d Merge "Adding screen record for a flake" into sc-v2-dev 2021-09-21 21:49:58 +00:00
Tony Wickham 7eb5b53865 Keep insets stable when taskbar is destroyed/recreated
- Calculate nav bar insets ourselves. Currently when taskbar is going to be present, we use taskbarSize as the nav bar insets. This is consistent with other existing calculations, but going forward we should instead always use the nav bar size instead of taskbar size, given we don't want taskbar to inset launcher (since taskbar is hidden).
- Also update tappable insets to be 0 in gesture mode. Test: Swipe to all apps, ensure there's no background protection at the bottom.

Test: Rotate device, no visual jumps
Test: Stash taskbar, quick switch a couple times without settling, and swipe up to overview; no jank due to reapplyState()

Bug: 198798034
Fixes: 197232424
Fixes: 197212581
Change-Id: I4c2bb5816dbb214846bd9f2a46c6f759c0545911
2021-09-21 13:52:36 -07:00
Vinit Nayak 5f412199ad Merge "Prevent focusing next task if focused task part of split select" into sc-v2-dev 2021-09-21 17:28:01 +00:00
TreeHugger Robot 139dee45dd Merge changes I675dbe99,Ia6daa741 into sc-v2-dev
* changes:
  [Hotseat] Fix hotseat edu flicker
  [Hotseat] Show edu tip within screen bounds
2021-09-21 16:33:10 +00:00
sfufa@google.com 5b38ff6d16 [Hotseat] Fix hotseat edu flicker
When edu view animation is not started in closed state, it results in a single frame showing right before the animation begins.

Bug: 184610272
Test: visual
Change-Id: I675dbe9927771f4b64d1d81c637f19621037b415
2021-09-21 01:50:41 -07:00
Samuel Fufa e4057e628c Merge "[Hotseat] Fix legacy shortcut with config activity drawing on top of predicted app" into sc-v2-dev 2021-09-21 06:33:06 +00:00
Samuel Fufa cf175820c4 Merge "[Hotseat] Fix hotseat migration in landscape mode" into sc-v2-dev 2021-09-21 06:24:37 +00:00
vadimt 99479a9925 Adding screen record for a flake
Test: presubmit
Bug: 195673272
Change-Id: I3ea99f68872554d688b30bf87f595fef1538a7cb
2021-09-20 20:09:07 -07:00
Evan Rosky 26c596b813 Merge "Register remote transitions on activity start" into sc-v2-dev 2021-09-20 22:29:57 +00:00