Commit Graph

3 Commits

Author SHA1 Message Date
Andrew Cole f9b87e3907 Updating isTextClippedVerticallyTest
Updating the isTextClippedVertically test to accomodate a different aspect ratio for raven devices

Bug: 279464742
Test: isTextClippedVerticallyTest
Change-Id: I4a4b740513914f1e76db18a00b65e4f881535d4a
2023-05-12 16:55:41 +00:00
Andrew Cole 47e1423584 Reverting isTextClippedVerticallyTest
Reverting the isTextClippedVerticallyTest Unit test becase it is causing errors in post submit.

Test: Run isTextClippedVerticallyTest
Bug: 279464742
Change-Id: I766c867d07f0a911fd4017c9505e68638a9a3643
2023-04-24 15:32:35 -07:00
Andrew Cole 44898c3db4 Unit testing ButtonDropTarget
Originally there was a bug in a method (isTextClippedVertically) in ButtonDropTarget. While attempting to write a unit test it became necessary to refactor ButtonDropTarget and DeleteDropTarget to decouple them from their dependency on launcher in order to allow for a unit test to be written

The pattern we are introducing here is to decouple Launcher from a controller, in order to facilitate easier testing.
Instead of calling Launcher.getLauncher() we call the method through ActivityContext, which has a testing wrapper already defined. Here is a diagram that explains the old and new pattern

Design Pattern: https://screenshot.googleplex.com/7apiE2DaGDrFzy9.png

Test: isTextClippedVerticallyTest
Bug: b/274402490

Change-Id: I1f3003d0b62dddbceb6e492b15aa5d7352d3a293
2023-04-20 11:22:27 -07:00