Commit Graph

270 Commits

Author SHA1 Message Date
Uwais Ashraf 9c2f5a4c62 Remove classes related to E2E testing from deviceless test classpath
Fix: 327187136
Flag: NA
Test: gradlew :NexusLauncher:testGoogleWithQuickstepDebugUnitTest
Test: atest Launcher3RoboTests
Test: presubmits passing
Change-Id: I4f05524bdc55d8473f3b5115cc239eb8cc48a856
2024-03-04 13:45:32 +00:00
Uwais Ashraf 77b97c0729 Replace existing Robolectric test task with functioning one.
This CL does the following:
- Creates a dir for multivalentTests
- Creates symlinks for the dir to keep Android Studio happy
- Moves many files to the multivalentTests dir
- Adjusts gradle and soong build files to use the new dir as part of
their source sets.

Test: ./gradlew :NexusLauncher:testGoogleWithQuickstepDebugUnitTest
Test: atest Launcher3RoboTests
Fix: 316553886
Bug: 316553889
Flag: NA
Change-Id: Iae28fd0c0191b3ecf9bd2950800875950cca2622
2024-01-19 21:39:23 +00:00
Vadim Tryshev d48279bf1d Merge "Disabling ViewCaptureRule" into main 2023-12-12 23:10:57 +00:00
Vadim Tryshev 79e12b893d Disabling leak checks in presubmits
They block 36% of presubmit runs

Bug: 313501215
Test: presubmit
Flag: N/A
Change-Id: Id91e5a467dfe2485614a4ac99861670a1afaa533
2023-12-11 10:16:13 -08:00
Vadim Tryshev 229a181771 Disabling ViewCaptureRule
Looks like vire capture needs some time to stabilize; for now,
 it sometimes generates empty view capture data.

Bug: 315482167
Flag: N/A
Test: presubmit
Change-Id: I864ffacf4a3a28cfc01b300ac1df71890f93c5e1
2023-12-08 10:44:48 -08:00
Vadim Tryshev 0ad6d9bcee Waiting for Launcher to stop after quick-starting test apps
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I795571ec191b01929bb871fd021d8653449bb608
2023-12-01 18:22:04 +00:00
Sebastian Franco 0e02d74cbf Moving the static initialization method from TaplTestsLauncher3 to AbstractLauncherUiTest
Flag: NA
Bug: 298234173
Test: atest TaplWorkspaceTest
Change-Id: I49dadefa17ef0ea78ca342b8b6d7bb9e38d4d0c9
2023-11-22 12:43:44 -06:00
Vadim Tryshev ebf08d8b75 Having longer period of waiting for Launcher restart only in Launcher test suites
This will help to avoid breaking other test suites by this increase.

Bug: 311023703
Test: presubmit
Flag: N/A
Change-Id: Ia91b03b72fa6592684e7a1673b9b56448f637dd4
2023-11-15 13:00:37 -08:00
Vadim Tryshev 18c1038ddf Merge "Making killing setup wizard a permanent solution" into main 2023-11-13 20:20:07 +00:00
Vadim Tryshev 94cb915d38 Disabling strict activity leak check more aggressively than in ag/25340909
That CL wasn't sufficient, still seeing:
https://android-build.corp.google.com/test_investigate/?blocking=warning&invocationId=I37300010216048087&status=none&testResultId=TR78329041431354974

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I36979a8929ccb996b81e8d41ec75b9713258c1c3
2023-11-10 16:41:42 -08:00
Vadim Tryshev 1f8ff66235 Making killing setup wizard a permanent solution
It will be killed only in presubmit. In postsubmit, we want to be a true
e2e test exposed to all actual problems, including setup wizard that
doesn't go away.

Bug: 309471958
Test: presubmit
Flag: N/A
Change-Id: I2e877eade060e75e277eb3603d90b659207b5a47
2023-11-10 12:20:45 -08:00
Vadim Tryshev f0732e73d5 Merge "Workarounding setup wizard non-disappearance only in presubmit" into main 2023-11-08 20:29:00 +00:00
Vadim Tryshev e5a1b89220 Making keyguard dismissal a permanent solution
Before, it was considered to be a workaround while System UI has
keyguard bugs. But these bugs will happen in future, and they are
unlikely to be prevented by presubmit tests since they are usually flakes.

The solution that this CL makes permanent is: in presubmit attempt
to unlock SysUI if it's locked. In postsubmit, just make sure it's
unlocked. This way, in postsubmit, we'll know whether tere are active
keyguard bugs.

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: Ia9602bc6e9cc8400e939051c45aba92bc197d428
2023-11-07 14:45:58 -08:00
Vadim Tryshev 341e5598b5 Workarounding setup wizard non-disappearance only in presubmit
In postsubmit, we want to see the actual behavior to be aware of real e2e issues.

Bug: 309008042
Test: presubmit
Flag: N/A
Change-Id: Icedf381545dda32ea1dbdd8d215581265627bf3f
2023-11-07 12:33:21 -08:00
Vadim Tryshev 06de17be39 Merge "Adding a TODO to productize killing/dismissal of setup wizard" into main 2023-11-06 22:19:23 +00:00
Vadim Tryshev ca90b8d7d9 Removing assert that setup wizard is visible
Bug: 309496273
Test: presubmit
Flag: N/A
Change-Id: Ie6b77673c120a94d211662c71467635923dda622
2023-11-06 12:38:35 -08:00
Vadim Tryshev a7e283b605 Adding a TODO to productize killing/dismissal of setup wizard
Bug: 309471958
Test: presubmit
Flag: N/A
Change-Id: I8ef3a7310829333132b03453dbb6f3c37b88c364
2023-11-06 10:31:29 -08:00
Vadim Tryshev 8b1881223b Merge "Waiting for the setup wizard to go away" into main 2023-11-06 18:17:46 +00:00
Vadim Tryshev 0fe753af2a Waiting for the setup wizard to go away
This is a workaround for b/309008042 where it appears that after being
dismissed by the test infra, setup wizard doesn't immediately go away.

This CL will wait 2 minutes for the dismissal, and provide a better
diags when the wizard doesn't go away after 2 min.

Bug: 309008042
Test: presubmit
Flag: N/A
Change-Id: I26eb2f202842702af08c424929d74fbd21eb872d
2023-11-04 21:37:25 -07:00
Vadim Tryshev 5ad63608f7 Clean up comment
Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: Ibe17cd8142689598db1ce5700ef122b67b37e1a7
2023-10-31 15:49:52 -07:00
Uwais Ashraf 4fc9a1001f Replace usage of deprecated initAllFlagsToReleaseConfigDefault() method
Bug: 306088813
Flag: NA
Test: Presubmits passing
Change-Id: Iff852702424f4e18c67a6bd3b110beb528b39e3b
2023-10-31 15:31:18 +00:00
Vadim Tryshev 8695855591 Aggressively unlocking phone while in presubmit
Bug: 303755862
Test: presubmit
Flag: N/A
Change-Id: I6c314c9a42b4e4935cbbfc0faaf7d788c1020697
2023-10-20 19:40:58 +00:00
Pat Manning 24cec69361 Revert "Revert "Combine icon app tests to allow overriding flag ..."
Revert submission 25032768-revert-25007147-tapl-flag-SBORVHYDTI

Reason for revert: Resubmitting for b/304470271

Reverted changes: /q/submissionid:25032768-revert-25007147-tapl-flag-SBORVHYDTI

Change-Id: Ib0bd13a5c2a366160b185a2c6409c607ed7525a1
2023-10-17 15:56:48 +00:00
Tyler Freeman 22781d97d9 Merge "Revert "Combine icon app tests to allow overriding flag for new ..."" into main 2023-10-12 20:06:56 +00:00
Tyler Freeman 1468467706 Revert "Combine icon app tests to allow overriding flag for new ..."
Revert submission 25007147-tapl-flag

Reason for revert: Breaks build: https://b.corp.google.com/issues/305033049

Reverted changes: /q/submissionid:25007147-tapl-flag

Change-Id: I99b5883e64ae25476394a4207c5d6a4d22fc27dc
2023-10-12 18:04:05 +00:00
Pat Manning 654c05837e Merge "Combine icon app tests to allow overriding flag for new icon app chip menu testing as well." into main 2023-10-12 15:59:17 +00:00
Pat Manning 236e738907 Combine icon app tests to allow overriding flag for new icon app chip menu testing as well.
Platinum exlude cl update: cl/572225659

Test: TaplOverviewAppIconMenuTest
Test: TaplAppIconAppChipMenuTest
Bug: 303329286
Bug: 303266562
Fix: 304470271
Change-Id: I4ca163401d6a42961e8955e06c164af0254b1231
2023-10-12 14:53:08 +01:00
Vadim Tryshev 9bf8a4bbc1 Merge "Moving verifyKeyguardInvisible() after other initializations" into main 2023-10-11 20:17:04 +00:00
Vadim Tryshev f782eaba73 Improving diagnostics from fallback recents tests when phone is not unlocked
Failing earlier so that we don't get strange messages from the middle of the test.

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I1e3c70623e6f907bcc6bd0486b6c75afecb610e3
2023-10-10 19:18:22 -07:00
Vadim Tryshev 3c1def4810 Moving verifyKeyguardInvisible() after other initializations
verifyKeyguardInvisible can fail, and then tear down will be called,
potentially accessing fields that currently get assigned after this
call, causing crashes.

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I865dfd70ce1821cee26800f57a13fb202626ea84
2023-10-10 16:37:14 -07:00
Vadim Tryshev 39b4fad9b0 Introducing a method for execution an action on Launcher for teardown
If the test fails to initialize properly, tearDown is still called,
and we may have null Launcher activity.

We want to safely skip using that activity to avoid a NullPointerException
that would hide the original error message.

Bug: 304306290
Test: presubmit
Flag: N/A
Change-Id: I89774a92ede046fa3afadacc62df25f4f496f4e7
2023-10-09 11:29:42 -07:00
Vadim Tryshev d8c049f2af Starting to tighten leak detector checks
This will help to detect leaks earlier, not when we have 3 activities in some cases, but when we have 2.

Adding a parameter that enables more strict detection, and using it in some places.

I'll try to convert as many places as possible to the more strict check after landing this CL.

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: Idd5a0386005e46dad8aab222bd77c0240f23f43a
2023-10-02 18:34:32 -07:00
Vadim Tryshev b57e25127e Verifying that workspace looks correct at the end of the test.
I hope that this will lock bugs like b/298114205 in the test that created the bad condition, not the next one.

Bug: 298114205
Test: presubmit
Flag: N/A
Change-Id: If9b48fb5159fc35948607a99f87199d5a32e64d6
2023-09-29 18:31:04 -07:00
Vinit Nayak df751430bc Revert "Verifying that workspace looks correct at the end of the test."
This reverts commit 62e3b162ba.

Reason for revert: Possible culprit for b/301966780

Change-Id: Ice6babe404feeddf9f8b13ce2a6288005402c9cd
2023-09-26 15:19:20 -07:00
Sebastián Franco 8171e2fb84 Merge "Moving test related to Dragging to their own class from TaplTestsLauncher3" into main 2023-09-20 22:08:03 +00:00
Sebastian Franco 6b059deea6 Moving test related to Dragging to their own class from TaplTestsLauncher3
Renaming the following test names:
 - testDragAppIconToWorkspaceCell to testDragAppIconToMultipleWorkspaceCells
 - testDragShortcutToMultipleWoCells to testDragShortcutToMultipleWorkspaceCells

Bug: 298234173
Test: atest OopTaplDragTest
Change-Id: I16707e0a882164c7a5acec6a4197bd0bea8514a7
2023-09-20 18:56:13 +00:00
Vadim Tryshev 62e3b162ba Verifying that workspace looks correct at the end of the test.
I hope that this will lock bugs like b/298114205 in the test that created the bad condition, not the next one.

Bug: 298114205
Test: presubmit
Flag: N/A
Change-Id: I6ad3598fb675d8b24ec0f273d255b7f2464dc53f
2023-09-14 10:11:25 -07:00
Vadim Tryshev 84f51ec03e Revert "Prevent some leaks from leaking to the next test"
This reverts commit d17a270b31.

Reason for revert: Perhaps, caused failures like: Launcher internal state didn't switch to Home, https://android-build.corp.google.com/test_investigate/?invocationId=I32700010190010056&testResultId=TR70828881289196802

Change-Id: I1c7afb75785aac6b02f451b9d5b74de7833abfed
2023-08-22 18:30:48 +00:00
Vadim Tryshev d17a270b31 Prevent some leaks from leaking to the next test
Now when exiting the test, we finish Launcher activity and force the leak check.
I've seen this helping one of the leaks to stay within the test that caused it instead of failing the next test.

Bug: 187761685
Flag: N/A
Test: presubmit, local
Change-Id: I7eac26f749433c37a6880a2f035ab1ba9c5fef6e
2023-08-18 18:55:11 -07:00
Treehugger Robot 17988825f2 Merge changes I45b6f858,I28120248 into udc-qpr-dev
* changes:
  Verifying that ViewCapture data is not empty
  Restoring starting capturing existing activity.
2023-07-26 18:33:07 +00:00
Vadim Tryshev cb5b7335f4 Fix a typo
Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: Ib2f5bfde644cf4489f71d4207c3e8eb1936f8742
2023-07-24 13:16:43 -07:00
Vadim Tryshev 101ea3e4e5 Restoring starting capturing existing activity.
ag/24138143 made the rule to produce empty captures in many cases.

ag/24138143 aimed to fix a leak that was caused by a local var
alreadyOpenActivity still referring the activity when the leak check
executes.

Fixing that by moving the variable to a method startCapturingExistingActivity.

Bug: 291638593
Test: local, presubmit
Flag: N/A
Change-Id: I281202488c6c85e2e2c5b5b3300e26d808167104
2023-07-24 19:09:48 +00:00
Sunny Goyal bb50f3cd8e Fixing ViewCaptureRule not unregistered if activity is destroyed
Bug: 291638593
Test: Presubmit
Flag: N/A
Change-Id: I86daf9fac210340b037d376d882ac5872c596ae4
2023-07-19 16:14:47 -07:00
Sunny Goyal f6b79f7caf Removing LauncherActivityRule as it can be flaky based on when
the rule was initialized

Bug: 289161193
Test: Presubmit and PostSubmit
Flag: N/A
Change-Id: I0e1e9c6f932d2a98a2f1e47bd1665e26f2db9eb4
2023-07-14 10:29:55 -07:00
Schneider Victor-tulias 720d0cf4c4 Merge "Update TestProtocol.REQUEST_CLEAR_DATA to properly clear the workspace" into udc-qpr-dev 2023-06-30 16:54:30 +00:00
TreeHugger Robot c84ecc0f67 Merge "Removing ViewCaptureAnalysisRule" into udc-qpr-dev 2023-06-28 20:08:23 +00:00
Schneider Victor-tulias 67ca528591 Update TestProtocol.REQUEST_CLEAR_DATA to properly clear the workspace
Flag: not needed
Fixes: 287097473
Test: TaplTestsLauncher3
Change-Id: I980a68dff8b475ce8f7b86284663f697b7bc2b57
2023-06-28 10:37:44 -07:00
Vadim Tryshev 2ba42ef94d Removing ViewCaptureAnalysisRule
Bug: 286251603
Test: presubmit
Flag: N/A
Change-Id: I0123ed3892bbfd6d0e880141ace878b6204dbd81
2023-06-27 22:12:45 +00:00
Vinit Nayak 710b5ba162 Add logs to determine if grid positions incorrect
* Either positions are incorrect, or maybe we
need to clean-up existing shortcuts if they are in
incorrect position in the grid

Bug: 282963545
Change-Id: I5d32d130d0e05bde69eda9d73468eda49a4f2802
2023-06-23 15:42:53 -07:00
vadimt 95c1dc70b4 Saving view capture data before cleaning it in ViewCaptureRule
This makes it reliably available to FailureWatcher who saves the
 artifact afterwards.

Test: local, presubmit
Flag: N/A
Bug: 286251603
Change-Id: I11b4854684f6ba5c798096eac223760d76f004b1
2023-06-15 16:20:04 -07:00