Commit Graph

3766 Commits

Author SHA1 Message Date
Shamali Patwa 1f2dabfb4e Merge "Re-enable the testDragCustomShortcut test in pre-submits" into main 2024-04-25 21:09:21 +00:00
Treehugger Robot d1a01bd8a3 Merge "testDragToFolder is stable; promoting to presubmit" into main 2024-04-25 19:43:57 +00:00
Shamali P 0dce4a0704 Re-enable the testDragCustomShortcut test in pre-submits
In follow up need to align the code that looks for widets to work for
two pane picker in tablets.

Bug: 322820039
Flag: N/A
Test: Presubmit enabled for test
Change-Id: If8a3a7867bbafd5a08ebaef6ed354105762a8a23
2024-04-25 19:13:53 +00:00
Treehugger Robot 2bed168c4d Merge "Reapply "add more unit tests for WorkspaceItemProcessor"" into main 2024-04-25 18:48:07 +00:00
Daniel Akinola e91b4b52ee Merge "Revert "Force calculator to launch in fullscreen for taskbar tests"" into main 2024-04-25 17:56:47 +00:00
Sebastián Franco 307bafc511 Merge "Adding screenrecord to get more information about the test" into main 2024-04-25 17:48:49 +00:00
Charlie Anderson 9ac6f42610 Reapply "add more unit tests for WorkspaceItemProcessor"
Also, add more unit tests around Widgets.

This reverts commit d9ed5f301b.

Test: Added unit tests
Flag: N/A
Bug: 330906931
Bug: 294386159

Change-Id: I8de74bce8bddd06e5ce1399d26253cb936281bee
2024-04-25 12:35:14 -04:00
Daniel Akinola 56ccf74899 Revert "Force calculator to launch in fullscreen for taskbar tests"
This reverts commit 8771dfe3dd.

Reason for revert: was only a temporary fix while investigating issue, should be unnecessary after ag/27089675 is landed.

Change-Id: I5963dc77f31eb45c1cdd100788b045891de2d716
2024-04-25 15:49:06 +00:00
Vadim Tryshev b63fd9b7e1 testDragToFolder is stable; promoting to presubmit
Bug: 187761685, 233075289
Test: presubmit
Flag: N/A
Change-Id: I303ea378cef3e05dfc19ce10c0fc3698a66ecf4c
2024-04-24 15:19:05 -07:00
Himanshu Gupta 6fc5e7a010 Merge "Adding Tapl tests for User Installed App in PS." into main 2024-04-24 09:25:28 +00:00
Julie Pan f94f2c1b33 Merge "Remove mateuszc@google.com from tests/OWNERS" into main am: f6519bd225 am: d2a665cc7f
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/3041215

Change-Id: Ie2f658f4f67033c5e1de6327f6e53016d97ba132
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-23 22:37:48 +00:00
Julie Pan a9cf79324a Merge "Merge "Remove mateuszc@google.com from tests/shared/com/android/launcher3/testing/OWNERS" into main am: 06b1e6da76 am: f3d584f4f6" into main 2024-04-23 22:32:30 +00:00
Sebastián Franco 48d7c10a82 Merge "Make sure we keep the screen record even if the test succeeds" into main 2024-04-23 19:49:44 +00:00
Treehugger Robot 62a1a8a336 Merge "Move PreInstalled App List to UserCache." into main 2024-04-23 18:24:01 +00:00
Sunny Goyal edbe8e5ffc Merge "Fixing MainThreadInitializedObject" into main 2024-04-23 18:06:38 +00:00
Sebastian Franco ad15dd719e Make sure we keep the screen record even if the test succeeds
Bug: 322823478
Test: testEdu
Test: testDevicePressMenu
Flag: NA
Change-Id: Ia11d3cbc0a10e15d716b1845e3590bca2bd1ff76
2024-04-23 10:37:22 -07:00
Himanshu Gupta ae4631e6a3 Move PreInstalled App List to UserCache.
Bug: 333543006
Test: atest PrivateSpaceHeaderViewTest, AlphabeticalAppsListTest
Flag: NA
Change-Id: I84233c5a6406325d9e641b72ea8455911b46f65f
2024-04-23 15:28:01 +01:00
Himanshu Gupta 102b723d63 Adding Tapl tests for User Installed App in PS.
This test verifies that a user installed app
is shown above the sys apps divider, within the
Private Space container.

Bug: 322882655
Test: atest NexusLauncherTests:com.android.quickstep.TaplPrivateSpaceTest
Flag: NA
Change-Id: Id85105339ae45c263d9ef52a3bb55784587e887d
2024-04-23 15:22:43 +01:00
Sebastian Franco ea78903380 Adding screenrecord to get more information about the test
Test: testWorkspace
Flag: NA
Bug: 331261431
Change-Id: Ifeaa0fe287c2cbf0b9c1c468c494752fe7f35d37
2024-04-22 19:38:23 -07:00
Sunny Goyal 10fa016352 Fixing MainThreadInitializedObject
> Making SafeCloseable implementation mandatory, to prevent leaks during test and preview
> Removing getNoCreate method and defining executeIfCreated to avoid null pointer exceptions
> Fixing sandbox value leaking into main, by Checking sandbox against App context
> Converting sanbox to an interface instead a class

Bug: 335280439
Test: Presubmit
Flag: None
Change-Id: I951dcde871898e745ff6490a1c4f8fd1512888f5
2024-04-22 17:04:33 -07:00
dakinola 8771dfe3dd Force calculator to launch in fullscreen for taskbar tests
Taskbar tests are flaking when desktop windowing is enabled due to calculator app being launched in splitscreen unexpectedly during test setup (due to unexpected effect of DesktopModeLaunchParamsModifier on activity launch.) While looking into root cause, this temporary fix to address the test failures ensures that calculator app is always launched in fullscreen, by enforcing it with ActivityOptions.

Bug: 333446588
Bug: 333446588
Flag: None
Test: atest NexusLauncherTests:com.android.quickstep.TaplTestsTaskbar
Test: forrest build with CL (https://android-build.corp.google.com/builds/abtd/run/L47500030003265061)
Change-Id: If12e8490214aa1dd5de89ff8535495c2a0c1fe82
2024-04-22 21:42:09 +00:00
Treehugger Robot 9960f43a5c Merge "Adds new log constant to track overview select tooltip misalignment" into main 2024-04-22 20:24:28 +00:00
Federico Baron 9350e71447 Merge "Revert "Add screenrecord for simple reorder widgets test"" into main 2024-04-22 18:31:49 +00:00
Julie Pan d1d01edcdc Merge "Remove mateuszc@google.com from tests/shared/com/android/launcher3/testing/OWNERS" into main am: 06b1e6da76 am: f3d584f4f6
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/3041216

Change-Id: Ied5a54d6abe1abae8438ddf03bc50b19096c761e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-22 18:19:16 +00:00
Schneider Victor-tulias 77d3524b1b Merge "Remove debug tracing for b/332386996" into main 2024-04-22 18:01:57 +00:00
Treehugger Robot 1acba69818 Merge "Add TestActivity without any label for testing" into main 2024-04-22 17:23:03 +00:00
Federico Baron 0e9fce7046 Revert "Add screenrecord for simple reorder widgets test"
This reverts commit 8248279894.

Reason for revert: test stopped failing

Change-Id: I7993e38124530bdb0bdbb3447a449bd727b56d0a
2024-04-22 16:45:41 +00:00
Jordan Silva cbc8bf0443 Adds new log constant to track overview select tooltip misalignment
Bug: 332485341
Flag: N/A
Test: atest OverviewSelectTooltipImageTest
Change-Id: Ic1a9ad4e1e9e9b95774a4a1edac92ea79c75cec6
2024-04-22 17:39:31 +01:00
Treehugger Robot 774d05e970 Merge "Remove debug tracing for b/321775748" into main 2024-04-22 16:35:32 +00:00
Julie Pan f6519bd225 Merge "Remove mateuszc@google.com from tests/OWNERS" into main 2024-04-22 16:20:09 +00:00
Schneider Victor-tulias abf9f308a5 Remove debug tracing for b/332386996
Flag: N/A
Fixes: 332386996
Test: TaplTestsQuickstep
Change-Id: I0d0aa5d5654dbf391269333eb4808d36f5e645ed
2024-04-22 16:16:42 +00:00
Schneider Victor-tulias 3f8eea99e3 Remove debug tracing for b/321775748
Flag: N/A
Fixes: 321775748
Test: FallbackRecentsTest
Change-Id: I1f746bf43025e093e94e60f8a1561f4f6a0f9b22
2024-04-22 09:55:49 -04:00
Jordan Silva cbd111483e Add TestActivity without any label for testing
This change adds an unlabeled activity to test the overview select action. The test evaluates the overview modal task state to verify that the UI displays correctly.
Using an activity without a label prevents flakiness from AiAi, which sometimes shows the activity title as selected and sometimes does not.

Bug: 332750488
Flag: NA
Test: OverviewTaskSelectImageTest
Change-Id: I6b63f1410bc466ac6711b0ca3d609d8f7a31d8c1
2024-04-22 12:39:06 +01:00
Charlie Anderson 299e42cf8d Merge "Fix NPE for where intent.package is null but targetpkg is not." into main 2024-04-19 15:10:20 +00:00
Charlie Anderson ce255ff6fd Fix NPE for where intent.package is null but targetpkg is not.
- Also update WorkspaceItemProcessorTest with a new test and to use real intent instead of mock

Bug: 330250727
Test: unit tests
Flag: N/A
Change-Id: I77e17901f4754c301ca20b3c6f93bbe29bead59b
2024-04-18 17:48:27 -04:00
Brandon Dayauon 120838b04d Make settings cog animate back to original button
Provide the appropriate itemInfo so that launcherBackAnimation would play correctly.

bug:324569690
Test manual video: https://drive.google.com/file/d/1GfjL4PhdGOxs2KfDpieTNiFiKQ61aCgh/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space trunkfood

Change-Id: I1a9458643e932b279bf4ba4ea33e3dc0a2c121c2
2024-04-18 14:32:33 -07:00
Federico Baron 6188ec4157 Merge "Make hotseat column span responsive" into main 2024-04-16 17:17:55 +00:00
Brandon Dayauon 31e713ee4c Merge changes If93e3975,Ifed45f06 into main
* changes:
  Fix views being visible after closing private space.
  Set attach consumer after animation finished
2024-04-16 15:14:26 +00:00
fbaron e4b0b71faa Make hotseat column span responsive
Flag: NONE
Test: DeviceProfileDumpTest, DeviceProfileAlternativeDumpTest, HomeScreenImageTest
Bug: 325084912
Change-Id: Ifa9e8066662a1ab053f66b8800b739d813d2dab8
2024-04-16 06:19:16 +00:00
Winson Chung 240956e7d8 Merge "Use shared method for updating the runtime status flags for an item info" into main 2024-04-16 02:59:54 +00:00
Stefan Andonian 0d2cc9e87c Merge "Revert^2 "Remove Unused parts of LauncherPrefs causing cyclical dependency."" into main 2024-04-16 02:42:04 +00:00
Priyanka Advani 7d92102140 Merge "Revert^3 "Wait for LauncherModel loaded in waitForLauncherInitialized"" into main 2024-04-16 00:46:24 +00:00
Priyanka Advani 4e97c94559 Revert^3 "Wait for LauncherModel loaded in waitForLauncherInitialized"
This reverts commit 503ce966ef.

Reason for revert: Culprit for test breakages in b/334995023. Will be verifying through ABTD for confirmation and before submitting the revert.

Change-Id: Id8707cb2074b4f00ec332ebb14deb7d143ff1bbb
2024-04-15 22:18:31 +00:00
Schneider Victor-tulias 9d4fb2b5be Merge "Revert^2 "Wait for LauncherModel loaded in waitForLauncherInitialized"" into main 2024-04-15 19:30:38 +00:00
Stefan Andonian 1a626d2d05 Revert^2 "Remove Unused parts of LauncherPrefs causing cyclical dependency."
This reverts commit a80997d9eb.

Bug: 324670265
Test: Locally tested this, as well as ran it through post-submit via go/abdt with the fix.
Flag: NA
Reason for revert: Root-caused the issue with this, and will push the fix along with this revert.

Change-Id: I4bda53d94dfdb865883fef6ceec9dacd0b87f015
2024-04-15 18:28:25 +00:00
Anushree Ganjam 6642ea0d48 Merge "Add new class for SetPropRule and move outside ShellCommandRule." into main 2024-04-15 17:41:15 +00:00
Brandon Dayauon a271511240 Set attach consumer after animation finished
Its possible after the animation that attached view's alpha can still be stuck at 0 and never change.
This only happens when the view isn't in range to animate and after onBind() is already called.

Also added flag guarding to the animation as it seems to be forgotten since the big CL change moving
everything to privateProfileManager.

bug: 333506236
Test locally: https://screenshot.googleplex.com/8Kk6rLaczMPwr49 and https://screenshot.googleplex.com/9wXHeNuiCVFEMp6
manually: before https://drive.google.com/file/d/15hSqaUVjwE-lLp6IIv_mqwYbn_ITzR7s/view?usp=sharing
after: https://drive.google.com/file/d/15m7Al5H3vldFgIaQfFyulm1h92_Mgd0H/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.private_space_animation trunkfood

Change-Id: Ifed45f065b536bca5e8878b1bb95d16caf136ed6
2024-04-15 10:12:08 -07:00
Jagrut Desai 83fef2d60d Merge "Fixing TaplUninstallRemoveTest#uninstallWorkspaceIcon test" into main 2024-04-15 16:41:46 +00:00
Schneider Victor-tulias 503ce966ef Revert^2 "Wait for LauncherModel loaded in waitForLauncherInitialized"
This reverts commit b80c6c347a.

Reason for revert: The original change was not the cause for the test failures

Change-Id: Icfe0da43a96f5471076554c4dd25eae649bee81e
2024-04-15 15:58:19 +00:00
Owner Cleanup Bot 74836e9aee Remove mateuszc@google.com from tests/shared/com/android/launcher3/testing/OWNERS
This suggested change is automatically generated based on group
memberships and affiliations.
If this change is unnecessary or in error, vote CR -1 and the bot
will abandon it. Vote CR +1/2 to approve this change.

See the owner's recent activity for context:
https://android-review.googlesource.com/q/mateuszc@google.com

To report an issue, file a bug in the Infra>Codereview component.

Change-Id: Ib5072203e52bac83586b8c3de9a039a0ac5b272f
2024-04-14 17:35:48 +00:00