Commit Graph

13735 Commits

Author SHA1 Message Date
Schneider Victor-tulias 94a3642099 Add logging for adding pending icons to the workspace.
Added more logging to help track down b/168788486

Bug: 168788486

Test: manual
Change-Id: I309ad3abbedaeb538c97dd4929bedf6407fdfcf1
2021-04-22 13:09:22 -07:00
TreeHugger Robot 2e17bbae0d Merge "Fix cast exception when dropping widgets to a drop target" into sc-dev 2021-04-22 18:08:26 +00:00
Schneider Victor-tulias 5a6e10bba8 Merge "Complete gesture nav sandbox for for UXR." into sc-dev 2021-04-22 17:35:29 +00:00
Steven Ng 2d9d1b9937 Merge "Only update entries if there is a change in expand / collapse state" into sc-dev 2021-04-22 17:15:12 +00:00
Steven Ng cf93ef6cc9 Fix cast exception when dropping widgets to a drop target
When inflating a widget directly in the DragView, I've overridden
the layout param to FrameLayout.LayoutParam. Before drag complete,
we should restore the previous layout param.

Test: Drag a widget to a drop target. No crash is observed.
Bug: 186111130
Change-Id: Ifd33d57a886496ab31d4e741870b0ae18ca9ce4e
2021-04-22 17:45:16 +01:00
Steven Ng 582314e8e8 Only update entries if there is a change in expand / collapse state
Test: In all widgets tray, switch to work profile. Expands an app.
      Switch to personal tab and then switch back to work tab.
      The previously expanded app is collapsed with correct arrow.
Bug: 184199207
Change-Id: Iac601a04412cb8c5f163483c5dd79da35f1fd05c
2021-04-22 13:22:32 +01:00
TreeHugger Robot 6dcd0272f1 Merge "Using WindowContext for listening to configuration changes" into sc-dev 2021-04-22 10:57:05 +00:00
Sunny Goyal 35c7b19fa8 Using WindowContext for listening to configuration changes
Pre-S: Continue to use config-changed broadcast for configuration changes
and display-changed event for rotation changes
S+: Use WindowContext#componentCallbacks for config and rotation changes, and
continue to use display listener for frame-rate changes

Bug: 179308296
Test: Manual and presubmit
Change-Id: I533e69068b5fa6c052a02759ef309dd075ee6a4b
2021-04-22 00:23:02 -07:00
Shan Huang 5620c75c01 Updated launcher text shadow values.
Also update the way we compute shadow alpha so that it combines both text
alpha and shadow color alpha.

Test: Manually checked text appearances in launcher.
Bug: 185890335

Change-Id: I720a97bbaf21de86a5c446529109ce5b9ac5f6f7
2021-04-22 12:13:17 +08:00
Hyunyoung Song 3ee18bf510 Merge "Change spring effect on All Apps" into sc-dev 2021-04-21 20:54:24 +00:00
Alina Zaidi 1722e2f855 Merge "Fix some widget picker recommended widgets bugs." into sc-dev 2021-04-21 18:10:39 +00:00
Steven Ng 6f944f3624 Merge "Render RemoteViews in LauncherAppWidgetHostView" into sc-dev 2021-04-21 16:40:05 +00:00
Steven Ng e9a0ab33fa Merge "Use cellHeightPx to estimate recommended widgets' height" into sc-dev 2021-04-21 16:29:18 +00:00
Steven Ng e973d6f31f Render RemoteViews in LauncherAppWidgetHostView
Test: Pin a conversation widget from a notification. RemoteViews are
      rendered with the default size. Drag-n-drop from the pin widget
      dialog works fine.
Bug: 185934141

Change-Id: Idb76cce2807e55e7b42e2e044712519857beb202
2021-04-21 15:43:51 +01:00
Alina Zaidi 80732f89e7 Fix some widget picker recommended widgets bugs.
- Bind recommended widgets only when not in search mode. (b/183503774)
- Bind recommended widgets in onAttachedToWindow, Recommended widgets
are available in PopupDataProvider at this point. (b/185461866)

Bug: 183503774
Bug: 185461866
Test: tested manually
Change-Id: If24e5b2b3e69a695821b5f7d9f42ff4c89ae62fc
2021-04-21 15:26:01 +01:00
Steven Ng 260e98385e Use cellHeightPx to estimate recommended widgets' height
Test: Set grid to 2x2 and open the widgets picker in portrait. Able to
      scroll the recycler view.
Bug: 185915917
Change-Id: I02bb11a999fb1816de6e2410810c4ae6c1da137f
2021-04-21 14:43:30 +01:00
Hyunyoung Song 4fc2428474 Change spring effect on All Apps
Bug: 185942188
Test: Manual

Change-Id: Ic460d85e19074b7f2b2adf714b211591f0d23a08
2021-04-21 00:34:27 -07:00
TreeHugger Robot b9649edefe Merge "Fix flaky widget tapl tests" into sc-dev 2021-04-21 07:13:06 +00:00
Winson Chung ce9134c982 Merge changes I69baed7b,I38a1da16 into sc-dev
* changes:
  Logging config changes as well
  Reduce some logging from previous CL
2021-04-21 03:38:25 +00:00
Winson Chung dc0f3978e7 Logging config changes as well
Reduce some logging from previous CL

Bug: 185820525
Test: Presubmit
Change-Id: I69baed7b819b529db30a65cb39a80fb310d76243
2021-04-20 18:18:51 -07:00
Andy Wickham d12af6bda2 Merge "Adds a flag for Smartspace feedback." into sc-dev 2021-04-21 00:53:18 +00:00
TreeHugger Robot 7274d29c4c Merge "Add a feature flag for smartspace dismiss option." into sc-dev 2021-04-21 00:52:27 +00:00
Winson Chung 0bba6a79fc Reduce some logging from previous CL
Bug: 185820525
Test: Presubmit
Change-Id: I38a1da163eedf5f07bd507674ecb8661e8649d23
2021-04-20 15:42:43 -07:00
Steven Ng 8c8d99f966 Fix flaky widget tapl tests
Potential issues:
1. Widgets floating tips view is being shown
2. Header visible height is too small to be considered as a scroll
   gesture

Test: Run AddConfigWidgetTest, AddWidgetTest, BindWidgetTest &
      RequestPinItemTest
Bug: 185733371
Change-Id: Ic3e9188724dd920349ce8d8e8d98392b94b40642
2021-04-20 23:01:19 +01:00
Winson Chung 8e64bba9cf Add some logging for transposed mode in landscape
Bug: 185820525
Test: Presubmit
Change-Id: Id4cf605fd5c3277273025ac1a73f25add0608412
2021-04-20 20:38:04 +00:00
TreeHugger Robot 426bcc7715 Merge "Update TwoButtonNavbarTouchController logs" into sc-dev 2021-04-20 20:00:51 +00:00
TreeHugger Robot cdb4505020 Merge "Remove some noisy logs by setting DEBUG = false" into sc-dev 2021-04-20 19:58:51 +00:00
Schneider Victor-tulias 006cdeb641 Add a feature flag for smartspace dismiss option.
Test: manual
bug: 184179894
Change-Id: I568f7809f9a2407cf470d82c32a05956fcaaf807
2021-04-20 19:54:14 +00:00
Steven Ng e941bc7ff0 Merge "Inflate LauncherAppWidgetHostView directly in DragView" into sc-dev 2021-04-20 17:42:51 +00:00
Winson Chung f1f7b9aef9 Merge "Revert "Add logs to verify receiver is unregistered"" into sc-dev 2021-04-20 16:48:07 +00:00
Samuel Fufa 93573f0165 Merge "[Search][Keyboard] Update default allApps vertical transition inset" into sc-dev 2021-04-20 16:15:51 +00:00
TreeHugger Robot c61e393f85 Merge "Correct landscape mode color extraction rectangle" into sc-dev 2021-04-20 15:43:43 +00:00
Pierre Barbier de Reuille ca6f2475f1 Correct landscape mode color extraction rectangle
I had inverted the width and height of the screen,

Bug: 185887938
Test: Manual
Change-Id: I03889bf5e3f257414b90e992583307d61a960fe6
2021-04-20 14:59:22 +01:00
Alina Zaidi bfd56a6d59 Merge "Hide scroll bar if recycler view has no items." into sc-dev 2021-04-20 12:25:47 +00:00
Steven Ng b2c454ba15 Merge "Turn DragView into a FrameLayout" into sc-dev 2021-04-20 11:15:20 +00:00
Steven Ng 9ad5b60c6c Merge "Use availableHeightPx to calculate the max height for recommended widgets" into sc-dev 2021-04-20 10:33:32 +00:00
Alina Zaidi b89c991bab Merge "On exit search in widget picker, make recommended widgets table visible only if recommended widgets are available." into sc-dev 2021-04-20 09:54:29 +00:00
Alina Zaidi c839676fa0 Hide scroll bar if recycler view has no items.
Bug: 185873180
Test: Manually tested
Change-Id: Id0b21b264417aff19cfdcb46228bb497310ccc1b
2021-04-20 09:39:52 +01:00
Sunny Goyal 44ba9f2e14 Merge "Unifying icon loading methods" into sc-dev 2021-04-20 03:22:28 +00:00
Pinyao Ting a155f61f78 Merge "Additional debug logging to triage shortcut related issue." into sc-dev 2021-04-20 01:25:12 +00:00
Tony Wickham 8559ae324c Update TwoButtonNavbarTouchController logs
- Fix wrong bug number
- Log when we intercept and reinit to a state rather than in
  getTargetState() which is used to determine possible swipe
  directions too (which makes the logs confusing)

Test: run TaplTestsQuickstep#testOverviewActions
Bug: 177316094
Change-Id: Ibe5db6317c16c429c9c46bf237d3f8adc1458037
2021-04-19 17:40:47 -07:00
Andy Wickham 5a85912b92 Adds a flag for Smartspace feedback.
Test: Manual
Change-Id: I96dd8dad8bd2ab136960d0bebeac67b8bc00b583
2021-04-19 17:23:11 -07:00
Steven Ng 3242720ce7 Inflate LauncherAppWidgetHostView directly in DragView
Also removes AppWidgetHostViewDrawable

Bug: 183609936
Test: drag-n-drop icons, folders, widgets, shortcuts

Change-Id: I26d8b05b9f9171037f2459fa2389e7e02c8ca6dc
2021-04-20 00:26:07 +01:00
Sunny Goyal e36664d541 Turn DragView into a FrameLayout
Bug: 183609936
Test: drag-n-drop icons, folders, widgets, shortcuts
Change-Id: I030b36cd59ac6d0ced3263baca13108825ab2296
2021-04-20 00:19:06 +01:00
Steven Ng 315bef15e1 Merge "Apply color extraction when dragging" into sc-dev 2021-04-19 21:26:28 +00:00
Steven Ng 769a14ef34 Use availableHeightPx to calculate the max height for recommended widgets
heightPx doesn't take device orientation and system taskbar into account.

Bug: 185508758
Test: Open widgets tray, observe recommended widgets. Rotate the screen
      and observe recommended widgets.
Change-Id: I96f1817f96ba643e54e1d2599225254489091d03
2021-04-19 22:06:38 +01:00
Schneider Victor-tulias fb552936fd Complete gesture nav sandbox for for UXR.
- Removed All set screens altogether.
- Added "x" button to feedback view. This button now launches a dialog that allows the user to skip the tutorial.
- Added a progress tracker to the feedback view.
- Created a launch option to launch the back, home, then overview gesture tutorials in order.
- Added a button in the feedback view to progress through the tutorial.
- Updated tutorial animations to AnimatedVectorDrawables (with green accents).

Bug: 148542211

Test: manual
Change-Id: Icf3ec424141069895f97da74cd4ae881ff898d3f
2021-04-19 13:41:57 -07:00
Alina Zaidi 1869a9868c On exit search in widget picker, make recommended widgets table visible
only if recommended widgets are available.

This fixes missing scroll bar on exit search issue (b/183616305)

Bug: 183616305
Test: Manually tested
Change-Id: I3ced5fb2f833f3d34b7dfd376bb4b7c231bc28f6
2021-04-19 20:02:17 +01:00
Pinyao Ting 486ce88f18 Additional debug logging to triage shortcut related issue.
Bug: 185614138
Test: flash and verify logs shows up in bugreport
Change-Id: Ie7b45b5ffbd9ee2ed64f478647779e240f3255a7
2021-04-19 11:17:42 -07:00
Samuel Fufa 3722bb5620 [Search][Keyboard] Update default allApps vertical transition inset
Bug: 184721373
Test: Manual
Change-Id: I96c930a05055caa6ae1789c9d82810c099a0d133
2021-04-19 17:23:04 +00:00