Commit Graph

13735 Commits

Author SHA1 Message Date
Hilary Huo 7a5a96ea73 Merge "[settings-pixel-search] Flag guard slice logging." into sc-dev 2021-06-25 16:54:59 +00:00
Steven Ng 0d4e57d4f0 Merge "Extra logging related to widget removal upon restore" into sc-dev am: 408a73ea76
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15098572

Change-Id: I5bf17c3b4344b91fee64eab63bf013ea7ab94550
2021-06-25 16:30:53 +00:00
TreeHugger Robot 1491ec31c5 Merge "Update widget manipulation colors." into sc-dev 2021-06-25 15:18:45 +00:00
Alina Zaidi 0b320545f8 Compare maxSpanSize for WidgetsListContentEntries when updating visible
entries in widget picker.

This is so that widgets are rearranged according to maxSpanSize in
widget table

Bug: 191336852
Test: Manually rotated widget picker with one of the headers expanded
and checked that widgets in widget table adjust according to screen's
horizontal size.

Change-Id: I2406ca9eccd18f4bb32b396acaa188c37f0059ee
2021-06-25 13:46:03 +01:00
Steven Ng acd9d79932 Refine widgets removal logging
Test: N/A
Bug: 190565858
Change-Id: I7fb20eaf727db19787fa9b1fb36eeb5d1392e50c
2021-06-25 11:51:44 +01:00
Pinyao Ting bbb9a9c033 Extra logging related to widget removal upon restore
As observed in b/187799223, widgets are removed after restore. We cannot
identify the root cause from the bugreport. This CL includes more
logging in the hope of identifying the root cause.

Bug: 18779922
Bug: 190565858
Test: manual
Change-Id: Ibdc9876716028592d17beac4542e1d8c498f9e4c
(cherry picked from commit 655ac082c2)
2021-06-25 09:22:33 +00:00
Yogisha Dixit c0ac1dda74 Update widget manipulation colors.
Spec:
* Resize frame: https://docs.google.com/presentation/d/1UxdDh8EFhPbdRWRwzjbpgL-j02ew4Ew3eG3XBCeoYdo/edit#slide=id.OeO4S0j
* Drop target bar: https://docs.google.com/presentation/d/1UxdDh8EFhPbdRWRwzjbpgL-j02ew4Ew3eG3XBCeoYdo/edit#slide=id.vXfwHn8

Test: manual
Bug: 187910396
Change-Id: I6fd433796970c428841ee96e45ee4fca1ded3665
Merged-In: I6fd433796970c428841ee96e45ee4fca1ded3665
2021-06-25 08:43:29 +00:00
Hyunyoung Song 011f438c97 When KEYCODE_BACK is received, hide keyboard
Bug: 191845409
Bug: 190351740

Test: manual
Change-Id: I9e3a55f7eb81b2c2a668532ebb991cefbf248163
2021-06-25 01:28:27 -07:00
Hilary Huo b4538d1ef4 [settings-pixel-search] Flag guard slice logging.
Test: m
Bug: 191297465
Change-Id: I3f5f1ef5ad295e5d8ccedac00f290080653df5a3
2021-06-24 16:08:09 -07:00
Jonathan Miranda 7a273e2a8b resolve merge conflicts of a754e678a7 to sc-v2-dev
Move qsb according to spec.

Bug: 175329686
Test: visual test
      checked 5x5 and confirmed no visual change
      checked 4x5 and confirmed visual change
      - tested various display sizes to ensure no overlapping is caused


Change-Id: I5e00fcf57ffde597c6af08c6464ddfd7e8456bca
Merged-In: I95a80b484516f634fa13347534810c7a51cecc8d
2021-06-24 21:29:51 +00:00
Jonathan Miranda a754e678a7 Merge "Move qsb according to spec." into sc-dev 2021-06-24 21:14:11 +00:00
Steven Ng 3ff0ee1a95 Fix rounded corners for shortcut & generated preview shadow box
Test: Open the widgets picker and locate shortcuts. Rounded corners are
      rendered on the rectangular box of a shortcut
Fix: 191948061
Change-Id: I24e4dc4c4a9c9c7e875444db5294f6c33f50db85
2021-06-24 21:17:13 +01:00
Alina Zaidi e92c63f45b Remove scrim from navigation bar from full widget picker.
Bug: 191926325
Test: Manually tested
Change-Id: Idc5fded9e8227a6aa9cf58c9e2cce146dc52a2c6
2021-06-24 20:20:05 +01:00
TreeHugger Robot 55bdce183e Merge "Measure WidgetsBottomPicker again when the number of spans changes" into sc-dev am: 6604eb54bf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15095550

Change-Id: I5b5bf85f123ecc1423b74f52a7b33328e1bb4e6e
2021-06-24 19:13:32 +00:00
Jon Miranda 8bdb222a18 Move qsb according to spec.
Bug: 175329686
Test: visual test
      checked 5x5 and confirmed no visual change
      checked 4x5 and confirmed visual change
      - tested various display sizes to ensure no overlapping is caused

Change-Id: I95a80b484516f634fa13347534810c7a51cecc8d
Merged-In: I95a80b484516f634fa13347534810c7a51cecc8d
2021-06-24 18:51:46 +00:00
TreeHugger Robot 6604eb54bf Merge "Measure WidgetsBottomPicker again when the number of spans changes" into sc-dev 2021-06-24 18:43:32 +00:00
Jon Miranda 6a936e3ec4 Update colors for non-v31 devices.
Also renamed to popup color to popup shade to better differentiate
between the primary/secondary/tertirary popup colors.

Bug: 191496301
Test: Removed v31 colors to verify the non-v31 colors, that the shades are as expected
      Tested on wallpapaper with light text, again with dark mode
      Tested on wallpaper with dark text, and then again with dark mode

Change-Id: I3ec9ee7f85696ee48224740a1ec7f4abe42348ee
2021-06-24 11:07:52 -07:00
Steven Ng 53e8b46f66 Measure WidgetsBottomPicker again when the number of spans changes
Bug: In onMeasure, we calculate the number of spans that can be fit
horizontally. If the number of spans has changed, we re-organize
widgets shown in the table. However, after that, we didn't measure
WidgetsBottomPicker and its children again. As a result, the newly
added widget previews' dimensions are never measured.

Test: Long press clock app and then click widgets. Rotates the screen
      and observe widgets correctly shown.
Fix: 191644950
Change-Id: Iae94fba5b137807483e061d785b18d59defb013e
2021-06-24 18:16:05 +01:00
Jonathan Miranda dc01385cc2 Merge "Update popup colors. Add local color extraction behind a flag." into sc-dev am: bd51e6e3f3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15065087

Change-Id: I900c337c3fb3bd6296b95102ec55d4e6c7057e29
2021-06-23 23:10:11 +00:00
Jonathan Miranda bd51e6e3f3 Merge "Update popup colors. Add local color extraction behind a flag." into sc-dev 2021-06-23 22:51:20 +00:00
Hilary Huo cb4475f7d8 Merge "[settings-pixel-search] Add ww logging to track slice fetching timeout" into sc-dev am: 08843d8e37
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15068624

Change-Id: I58da46b9fc9fd83205c352996c78453885666397
2021-06-23 22:29:13 +00:00
Steven Ng be2dc65f08 Refine all apps tabs alignment & remove ripple effect from tabs
Test: Open all apps and observe the position of tabs alignment.
       Click a tab and observe the fade in color effect.
Fix: 191387242
Change-Id: Ie23a092268ce62eba29059eb5bd266a46ca652a5
2021-06-23 23:25:13 +01:00
Hilary Huo 08843d8e37 Merge "[settings-pixel-search] Add ww logging to track slice fetching timeout" into sc-dev 2021-06-23 22:18:00 +00:00
Jon Miranda 27de7d2643 Update popup colors. Add local color extraction behind a flag.
- Also updating folder backgrounds, lStar only works in ColorStateList.

Bug: 191496301
Test: test wallpaper with light text, in light mode
      test again in dark mode
      test wallpaper with dark text, in light mode
      test again in dark mode

Change-Id: I2d43d874e7e2fad6a9a0e039058beb58b204fa96
2021-06-23 14:18:25 -07:00
Steven Ng 1579854153 Merge "Use default spans as min spans if the min spans > default spans" into sc-dev am: fa9f70be03
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15081332

Change-Id: I64311aa17528c8c968a8cd2f032992c6e00225d7
2021-06-23 21:17:55 +00:00
Steven Ng f5555fcb8e Merge "Add null check before detach content view from dragView at onDropComplete" into sc-dev am: 5b786ca88d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15042822

Change-Id: Idc12dd2613200ce6e9901856b14c4ce0c5946fb6
2021-06-23 21:17:48 +00:00
Steven Ng fa9f70be03 Merge "Use default spans as min spans if the min spans > default spans" into sc-dev 2021-06-23 21:05:43 +00:00
Steven Ng 5b786ca88d Merge "Add null check before detach content view from dragView at onDropComplete" into sc-dev 2021-06-23 21:01:57 +00:00
Samuel Fufa 6c2c69cd97 Merge "Polish work for work profile" into sc-dev am: 1e70c235cf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15031833

Change-Id: Ie9cf60cd89c805c7341e2725259152215edea889
2021-06-23 19:00:41 +00:00
Samuel Fufa 1e70c235cf Merge "Polish work for work profile" into sc-dev 2021-06-23 18:58:29 +00:00
Jonathan Miranda 127e2605d5 Merge "Fix bug where icons in hotseat were clipped when display size is Small." into sc-dev am: 23415e214c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15068798

Change-Id: Ie2e85b1763f9061241df27e7b81acb3ff102b1d5
2021-06-23 18:36:53 +00:00
Hyunyoung Song 23ad64de64 Merge "Hide searchbox when header protection is on." into sc-dev am: 93068d1c39
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15058492

Change-Id: Ieffc6d68718a11249d21e29db28b26c86ef911e5
2021-06-23 18:36:41 +00:00
Jonathan Miranda 23415e214c Merge "Fix bug where icons in hotseat were clipped when display size is Small." into sc-dev 2021-06-23 18:27:19 +00:00
Hyunyoung Song 93068d1c39 Merge "Hide searchbox when header protection is on." into sc-dev 2021-06-23 18:15:27 +00:00
Hilary Huo e83189593a [settings-pixel-search] Add ww logging to track slice fetching timeout
Test: https://paste.googleplex.com/6310936320147456
Bug: 191297465
Change-Id: I0a4a65295e7290b55dccdb63830ff60c6838fbb2
2021-06-23 10:16:21 -07:00
Samuel Fufa ce820f51e2 Polish work for work profile
Bug: 191478900 Work profile toggle specs
Bug: 187761192 Fix issue where Installing app scrolling apps to top
Bug: 191121890	Fix issue where top of AllApps becomes empty when returning to AllApps
Bug: 191477329 String change for work profile paused state
Test: local
Change-Id: Idbaab333566b54afa3dc879f5bea98e1f77c44fc
2021-06-23 16:46:52 +00:00
Steven Ng 0571a370d1 Use default spans as min spans if the min spans > default spans
This is to match the behavior described in
AppWidgetProviderInfo#minResizeWidth/Height documentation.

Test: run LauncherAppWidgetProviderInfoTest
Bug: 191223844
Change-Id: I37c0c8bf5e4588919e5b30fab6d2fde7236e114b
2021-06-23 17:11:05 +01:00
Jon Miranda 0d284852d9 Fix bug where icons in hotseat were clipped when display size is Small.
Simplify calculations to ensure the hotseat sizes are always accurate.

Bug: 186556930
Test: changed display setting from small to largest on different grid
      sizes (5x5, 4x4, 4x5, 3x3, 2x2)

Change-Id: I97580c50a9d821577eb63335950d5695d9bf035d
2021-06-23 08:08:12 -07:00
Hyunyoung Song 7d3b25734a Hide searchbox when header protection is on.
Bug: 191726215
Test: manual
Change-Id: I086a05654faf718683ebe5dfbcf64b6bd6347ca8
2021-06-23 00:44:49 -07:00
Steven Ng 92335ed7bd Add null check before detach content view from dragView at onDropComplete
Test: Drop a conversation widget on a configuration button. No crash
      is observed.
Fix: 191762933
Change-Id: I483c6f4dbc9fc6c096383682284a4c854707f583
2021-06-22 23:26:05 +01:00
Jonathan Miranda 9bf19c1d7f Merge "Polish folder icon bugs." into sc-dev am: 835fab2305
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15046894

Change-Id: Id5684eeab5e56461eeeb60e23c37221afeb2b4dc
2021-06-22 22:22:56 +00:00
Jonathan Miranda 835fab2305 Merge "Polish folder icon bugs." into sc-dev 2021-06-22 22:00:17 +00:00
Brian Isganitis 1ce4353359 Enable widgets in launcher preview flag
Test: Widgets fully load in launcher preview with correct size and color
Fix: 185306338, 191499358
Change-Id: I2d02d7a1328ed9ef5d3dfbec090dc1f9908dd527
2021-06-22 14:58:22 -04:00
Brian Isganitis a905601cfd Merge "Use wallpaper colors for widgets in wallpaper change preview" into sc-v2-dev 2021-06-22 18:47:08 +00:00
Jon Miranda fa1e14c4b8 Polish folder icon bugs.
- Fix bug where folders are misaligned.
- Fix bug when closing on 2nd page of large folder.

Bug: 184822585
Test: drag folder originally in hotseat to workspace, vice versa
      test on grid where isScalable=true and isScalable=false

Change-Id: I08a79b8d280df3e3974baaa07e80db6bc4165e58
2021-06-22 11:12:47 -07:00
Cyrus Boadway db9d5cf3fd Merge "Suppress Splash Screen on widget reconfiguration activity start" into sc-dev am: 719be9a9e4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15062774

Change-Id: Ia0ffb706d5cc9f9d5adc169b8308445f0accba9a
2021-06-22 12:49:55 +00:00
Cyrus Boadway 719be9a9e4 Merge "Suppress Splash Screen on widget reconfiguration activity start" into sc-dev 2021-06-22 12:30:23 +00:00
Steven Ng 8a46c403e0 Merge "Update all apps & widget pickers personal / work tabs" into sc-dev am: cec6edf78e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15027782

Change-Id: Ia69538b6b15cb6ab6ce5fa9a2f4f42b2d0664d58
2021-06-22 10:47:31 +00:00
Steven Ng cec6edf78e Merge "Update all apps & widget pickers personal / work tabs" into sc-dev 2021-06-22 10:37:00 +00:00
Cyrus Boadway 263a00c738 Suppress Splash Screen on widget reconfiguration activity start
When a widget configuration activity is started, it's started from
the launcher. Under some circumstances the launcher's splash screen
would be shown, rather than the splash screen corresponding to the
tapped app.

To avoid confusion, we suppress the splash screen for configuration
starts.

Bug: 190153065
Test: manual
Change-Id: Ib18851f1bb50b64bc5d47b8aa5931490c969b54b
2021-06-22 09:22:33 +00:00