Commit Graph

13735 Commits

Author SHA1 Message Date
TreeHugger Robot a246eb4aa5 Merge "Add logging to help debug b/200572078." into sc-v2-dev 2021-09-30 07:01:41 +00:00
TreeHugger Robot 2e4a003f71 Merge "Remove the Share button option from Overview." into sc-v2-dev am: 70cc9ffe7c am: 8775a79741
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15935390

Change-Id: I27bfb9c63fb618abb0faaa116e44b9e95aa84b45
2021-09-30 04:38:22 +00:00
TreeHugger Robot 70cc9ffe7c Merge "Remove the Share button option from Overview." into sc-v2-dev 2021-09-30 04:11:47 +00:00
TreeHugger Robot d5b53bd6ac Merge "Allow icon add animations when user touches the screen." into sc-v2-dev am: 31a0b39daf am: 82bd8c7c57
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15846608

Change-Id: If3e802440ce7941c02f37f44b4fe33ed295fc39b
2021-09-30 02:23:00 +00:00
TreeHugger Robot 31a0b39daf Merge "Allow icon add animations when user touches the screen." into sc-v2-dev 2021-09-30 01:51:49 +00:00
Samuel Fufa 7444c5185f Merge "[Foldable] Apply max width to AllApps in unfolded state." into sc-v2-dev am: abb827b376 am: aab3edf950
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15882894

Change-Id: I3f8df26bbc49772faf8b166750fa8cc5ddbc16b5
2021-09-29 22:32:01 +00:00
Samuel Fufa abb827b376 Merge "[Foldable] Apply max width to AllApps in unfolded state." into sc-v2-dev 2021-09-29 22:07:42 +00:00
Alina Zaidi 1932f63691 Merge "Do not reorder recommended widgets in widget picker." into sc-v2-dev am: a4c1d0cfa4 am: 61d6aea926
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15921288

Change-Id: Ic7ffb40f4d15a5c421505abcb8c373afb6604477
2021-09-29 21:48:05 +00:00
Zak Cohen 71c527126b Overview - Remove Chips code
The proactive chips code has bit rotted and doesn't work properly anymore.
The product direction is not being pursued, so remove the code.

Bug: 201568600
Test: local
Change-Id: Ia00ceb027719c841bed665c1c50a132230bffe89
2021-09-29 14:43:27 -07:00
Zak Cohen 283ee7d74b Remove the Share button option from Overview.
It has never been enabled, and is not plan of record.

Bug: 201446691
Test: local and updated unit tests

Change-Id: I5ac6d40ba1dbcf28de4355cc51fff74cfb37ebc6
2021-09-29 14:43:27 -07:00
Pat Manning 05c2873979 Merge "Add TAPL tests for hiding the actions view when scrolling away from focused task in overview." into sc-v2-dev am: 429b8df180 am: 148b8bd2eb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15804385

Change-Id: I25bb02bde3dc3eeceb6a22d220a64da53b91ac96
2021-09-29 21:30:58 +00:00
Alina Zaidi a4c1d0cfa4 Merge "Do not reorder recommended widgets in widget picker." into sc-v2-dev 2021-09-29 21:23:23 +00:00
Pat Manning 429b8df180 Merge "Add TAPL tests for hiding the actions view when scrolling away from focused task in overview." into sc-v2-dev 2021-09-29 21:03:46 +00:00
Brian Isganitis 2e58c0262a Merge "Only set arrow color once when below icon." into sc-v2-dev am: 3fca6717ed am: 40817cc68e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15936545

Change-Id: I2bc83a5bac2bc190e1a28ebdcbab8bc8ef19116b
2021-09-29 20:09:27 +00:00
Brian Isganitis 3fca6717ed Merge "Only set arrow color once when below icon." into sc-v2-dev 2021-09-29 19:57:23 +00:00
Schneider Victor-tulias dccfe04a3a Improve all apps loading times.
Updated loadAllApps to load all required icons in a series of bulk sql queries. This reduces the cost of SQL lookups (up to two lookups per user, rather than one lookup per icon)

Bug: 195674813
Test: Added all icons to workspace, added duplicate icons, added icons for same component name from different users
Change-Id: Ifda8980386084999c53d7f881e8967be0d57d263
2021-09-29 12:37:40 -07:00
Brian Isganitis 285a1a7c9a Merge "Update arrow color after all notifications dismissed." into sc-v2-dev am: 3a91a6241f am: 52b9feb353
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15936544

Change-Id: Ie93b7aa71dbcd9545d2fc617101ed4a36db54742
2021-09-29 17:09:43 +00:00
Brian Isganitis 3a91a6241f Merge "Update arrow color after all notifications dismissed." into sc-v2-dev 2021-09-29 16:38:52 +00:00
Brian Isganitis 8b678206cf Only set arrow color once when below icon.
We were setting it again for the first child in any recursive call,
which could cause the color to be incorrect.

Test: Arrow always matches menu item below icon.
Fix: 201537864
Change-Id: I8f344bb7bdec4ebc51f8b8de118bec678d71e649
2021-09-29 12:30:50 -04:00
Brian Isganitis 1e34f65395 Update arrow color after all notifications dismissed.
assignMarginsAndBackgrounds updates determines the new arrow color, but
it doesn't actually update it. That is normally done in
updateArrowColor.

Test: Icon menu arrow color changes to content above it after notification
dots dismissed.
Fix: 201458705

Change-Id: I5ee40b420b03c29c197983af5968d4f2902bc59b
2021-09-29 16:29:16 +00:00
Alina Zaidi fc6837bb65 Do not reorder recommended widgets in widget picker.
This is to show them in ranking order sent by aiai.

Bug: b/201079509
Test: Added unit test in WidgetsTableUtilTest

Change-Id: I366ecaee8bc157aca185f633462d95fbd1dd180b
2021-09-29 15:52:47 +01:00
Steven Ng f79c48c0af Merge "Add a new string for widget configuration drop target" into sc-v2-dev am: d9f0c84f27 am: c14688087c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15934342

Change-Id: I86279a7c5301d0eec222563722c4e6cfaf194a65
2021-09-29 13:36:40 +00:00
Steven Ng d9f0c84f27 Merge "Add a new string for widget configuration drop target" into sc-v2-dev 2021-09-29 13:13:31 +00:00
Steven Ng 29f46c9628 Add a new string for widget configuration drop target
Test: manual. See screenshot in b/201286923
Fix: 201286923
Change-Id: I5be4f723523befe359b922273d11f57fb9f0b3fd
2021-09-29 12:15:07 +01:00
Alex Chau 46d1341ef2 Merge "Always let Hotseat touches follow through to Workspace if not intercepted" into sc-v2-dev am: 81f168ee7c am: 11fe0559ce
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15897179

Change-Id: Ifc93c6dad69eae7ec9a15b0c9ed015913b129cf0
2021-09-29 11:06:14 +00:00
Thales Lima 7a6752da51 launcher: create paddings for foldables
This creates a new padding file that bring some foldables up to spec
with VisD. For 2 panel layouts it now uses workspace margin instead of
cell layout padding.

Bug: 191879424
Fixes: 200035429
Test: checking paddings in HSV
Change-Id: I11b8e1afd76f535368d4c26e31630ce496171e13
2021-09-29 11:53:29 +01:00
Alex Chau 81f168ee7c Merge "Always let Hotseat touches follow through to Workspace if not intercepted" into sc-v2-dev 2021-09-29 10:45:56 +00:00
Pat Manning 35231f3041 Add TAPL tests for hiding the actions view when scrolling away from
focused task in overview.

Test: TaplTestsQuickstep.java
Bug: 197630182
Change-Id: Ie44a5bd99d7c9ffbc5405973c0ba1950cd90665c
2021-09-29 10:30:18 +00:00
Alex Chau 6ed6a6d874 Merge "Return mSynchronouslyBoundPages as getPagesToBindSynchronously between onInitialBindCompleteand finishBindingItems" into sc-v2-dev am: b830b2d999 am: 09f99a4d7d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15674917

Change-Id: I2f76f9ae0e2c24b5e0de696d6a46581301a09a09
2021-09-29 08:44:42 +00:00
Alex Chau b830b2d999 Merge "Return mSynchronouslyBoundPages as getPagesToBindSynchronously between onInitialBindCompleteand finishBindingItems" into sc-v2-dev 2021-09-29 08:25:49 +00:00
Zak Cohen 7cb98961ce Merge "Remove Content Push prototype." into sc-v2-dev am: c1359c448d am: a163c68ee2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15922695

Change-Id: I30a08ef27bee0d2252ceaaac5acbf6f10879ad13
2021-09-28 20:44:52 +00:00
Zak Cohen c1359c448d Merge "Remove Content Push prototype." into sc-v2-dev 2021-09-28 20:16:23 +00:00
Schneider Victor-tulias 0021338461 Add logging to help debug b/200572078.
Bug: 200572078
Test: ran launcher and checked logs
Change-Id: If59d850021df226d645aa6a72da2b5bb7ec63782
2021-09-28 12:02:51 -07:00
Alex Chau 21698c5799 Always let Hotseat touches follow through to Workspace if not intercepted
Fix: 200812841
Fix: 201306660
Test: Long press around QSB, hotseat, inbetween hotseat icons works
Test: Can scroll pages on top of hotseat and QSB
Test: Drag and drop still works in hotseat
Test: Can still press and long press on QSB
Change-Id: I3f6807be08ff2c55644e3bf8f6d05a3954a8ede6
2021-09-28 12:27:26 +00:00
TreeHugger Robot 0abaf45250 Merge "Moving activity tracker to Launcher process" into sc-v2-dev am: c77e3fde09 am: 93318f746f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15912383

Change-Id: I1cb8c49ab25dde0deb6417cac5ab582b9ba0d354
2021-09-27 20:47:26 +00:00
TreeHugger Robot c77e3fde09 Merge "Moving activity tracker to Launcher process" into sc-v2-dev 2021-09-27 20:10:02 +00:00
Brian Isganitis bea022197c Merge "Refactor arrow popups to allow easier code overriding and sharing." into sc-v2-dev am: 03be53443d am: 55626aedb4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15897839

Change-Id: Ic51602d41a025986dfdf5b502609d5d23bd31bea
2021-09-27 19:06:42 +00:00
Zak Cohen b48b84634f Remove Content Push prototype.
Bug: 201314561
Test: Build and run
Change-Id: I64f5ab40b349d68a50b0f49361f019456667b933
2021-09-27 11:57:50 -07:00
Brian Isganitis 03be53443d Merge "Refactor arrow popups to allow easier code overriding and sharing." into sc-v2-dev 2021-09-27 18:31:26 +00:00
vadimt 5ade8e890d Moving activity tracker to Launcher process
This will improve diagnostics for OOP tests,
like we now have a list of leaked activity classes.

Also some cleanups.

Bug: 187761685
Test: local runs
Change-Id: I8b5711ac727874fd826cfef9c742ea97048763e0
2021-09-27 17:36:14 +00:00
TreeHugger Robot 9ffe1a7b01 Merge "Fix getWidgetItemSizePx estimation" into sc-v2-dev am: ac81e8a92a am: 4bdc026863
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15897184

Change-Id: I40647fc8c45f10de132c6e2599dfbcab65d7908e
2021-09-27 16:38:13 +00:00
TreeHugger Robot ac81e8a92a Merge "Fix getWidgetItemSizePx estimation" into sc-v2-dev 2021-09-27 15:52:33 +00:00
Steven Ng 6d8deb32f6 Fix getWidgetItemSizePx estimation
The size returned by getWidgetItemSizePx is used by the widget picker
for the NavigableAppWidgetHostView. We should NOT deduct the padding
applied to NavigableAppWidgetHostView to this size.

If a launcher grid insets NavigableAppWidgetHostView, then we must
add the inset to the NavigableAppWidgetHostView width / height.

Test: Compare the size of widgets in preview and home screen using
      layout inspector. See screenshots in the bug
Fix: 200983939
Change-Id: I35022861b65f2624f69940cf3856d9c47f8dbbd9
2021-09-27 15:01:04 +01:00
TreeHugger Robot bd7cead303 Merge "Cleanup split screen offset in TaskViewSimulator" into sc-v2-dev am: d58e7b6fc4 am: 3a684ac265
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15910345

Change-Id: Iedec7b38faa175c0ca655fd5ef1d7e32aee3f2ed
2021-09-25 04:33:00 +00:00
Brian Isganitis a85ae69c72 Refactor arrow popups to allow easier code overriding and sharing.
Test: Existing menus work as intended.
Bug: 188222480
Change-Id: I7d19b06ce8bb7d765624c64c0042c4efd6faf348
2021-09-24 20:32:14 -04:00
Tony Wickham 2fb815b2fd Cleanup split screen offset in TaskViewSimulator
- Removed mRunningTargetWindowPosition and mSplitOffset, as they countered each other out anyway
- Removed PagedOrientationHandler#setLeashSplitOffset() since it's no longer used

Test: Swipe up from split and non split apps in both orientations on large and small devices, with and without home rotation enabled
Bug: 200817624
Change-Id: I78a80cbc718ee38a8933fa323798fb436710d59f
2021-09-24 15:37:30 -07:00
sfufa@google.com de0132939b [Foldable] Apply max width to AllApps in unfolded state.
Since we are applying the same iconWidth in AllApps as Workspace in unfolded state, this change restricts AllApps to span only the area required to display AllApps contents and not span full available width. Unfolded/phone behavior remains the same.

Bug: 199959857
Bug: 194259694
Test: visual
Change-Id: Ie5658d566f20e825e666ef17db79a87b07dc2936
2021-09-24 15:18:01 -07:00
Automerger Merge Worker 9daab56294 Merge "Merge "Consolidate isTablet logic across Launcher and SysUI" into sc-v2-dev am: cc1e94a982" into sc-v2-dev-plus-aosp am: 48390fa1da
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15898421

Change-Id: I97ee7e3d695c8212ce6064dccc9405a936cf6122
2021-09-24 17:36:13 +00:00
Tracy Zhou cc1e94a982 Merge "Consolidate isTablet logic across Launcher and SysUI" into sc-v2-dev 2021-09-24 17:16:41 +00:00
TreeHugger Robot 078cf20ae0 Merge "Correct the computation of the cell size." into sc-v2-dev am: bdddc5ab0c am: ab571d1ed0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15897178

Change-Id: I38ef570fe358e3bbccc3d3012829d1d955722f09
2021-09-24 16:44:25 +00:00