Commit Graph

13735 Commits

Author SHA1 Message Date
Jon Miranda 48d82e2c19 Merge "Clear all DragView in onSaveInstanceState" into sc-v2-dev am: 7ac2a71b94
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16425110

Change-Id: I60f6a9e8ae87bb011f9e7f4a7b11748415f044c1
2021-12-10 18:48:18 +00:00
Jon Miranda 7ac2a71b94 Merge "Clear all DragView in onSaveInstanceState" into sc-v2-dev 2021-12-10 18:36:15 +00:00
Alex Chau 9fee3fd379 Allow column size of search container to be configured
- Added numSearchContainerColumns in grid-option to control search container's width, defaults to numColumns if not specified

Bug: 210127246
Test: manual
Change-Id: I0c2594f0eeab8844dcff9468e603282a09fae0bd
2021-12-10 17:55:51 +00:00
Alex Chau d35c6f97fe Merge "Add split support for 3P launcher" into sc-v2-dev am: 42cbdee25c am: 809cef23a5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16416933

Change-Id: I6305941be879350ab192cf3be0fa0a4edf8ffe99
2021-12-10 10:25:32 +00:00
Alex Chau 809cef23a5 Merge "Add split support for 3P launcher" into sc-v2-dev am: 42cbdee25c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16416933

Change-Id: I7fa6dc108941f935a9f1987c23b9c8f2f49dad79
2021-12-10 10:10:55 +00:00
Vinit Nayak 2a93bc5b30 Add split support for 3P launcher
* Copied logic mostly from
Base/RecentsViewStateController
* There's one KI crash specific to 3P
(b/209694087)
* Swipe to home animation is TODO, but
then again it also seems incorrect for
full-screen app. 3P has many cosmetic issues
throughout.

Bug: 195607777
Test: Tested w/ Nova launcher with grid
and non-grid, able to invoke split screen with
same animations as 1P launcher

Change-Id: I35a1bc92a51caccac4214289e614000cd47bb503
2021-12-09 12:52:04 -08:00
Jon Miranda 14d6771aae Clear all DragView in onSaveInstanceState
Multiple users reports view getting stuck on screen. This CL
clears all DragView when user leaves launcher.

Root cause still undetermined, but happens enough that it warrants
a temp fix.

Bug: 162636845
Test: manual
Change-Id: I532b5274a1308c53f67c23c5c8ca07f2b7f9802c
2021-12-08 17:47:33 -08:00
TreeHugger Robot 2636a5d5b2 Merge "Add launcher grid spec for tablet" into sc-v2-dev am: b1ae1ca124 am: 287d976c91
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16371727

Change-Id: I609dbebde278dfb335a5a66c6bd71fcfa62a3102
2021-12-08 23:30:14 +00:00
TreeHugger Robot 287d976c91 Merge "Add launcher grid spec for tablet" into sc-v2-dev am: b1ae1ca124
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16371727

Change-Id: Id456a1dfa7e7f3578aa80cc281eb6680575c4cef
2021-12-08 23:14:44 +00:00
TreeHugger Robot b1ae1ca124 Merge "Add launcher grid spec for tablet" into sc-v2-dev 2021-12-08 22:49:00 +00:00
Alex Chau 1c883d861e Add launcher grid spec for tablet
- Introduced device_category to allow grids to be only enabled for certain device types. By default grids are enabled for all device types, so old OEM device_profiles aren't affected
  - Removed device_profiles_split.xml as a result and merged with device_profiles.xml
- Added deviceType in InvariantDeviceProfile to replace isSplitDisplay and centralize the logic
- Only has 6x5 grid with new default layout that works better for tablets

Bug: 198575341
Test: manual
Change-Id: I03f6727ce837ffeee6321b6d7c53942338d0cf30
2021-12-08 18:22:34 +00:00
Tony Wickham 35f3a45487 Merge changes I6cf84ec7,Iea599651,If3238286 into sc-v2-dev am: b5a051ca0b am: b05ad5dcbf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16407666

Change-Id: I6e97086358b20240c05ce06d3f2b600d9e139263
2021-12-08 18:13:17 +00:00
Tony Wickham b05ad5dcbf Merge changes I6cf84ec7,Iea599651,If3238286 into sc-v2-dev am: b5a051ca0b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16407666

Change-Id: Iffb14ab9d043a5802a92a76b2f388a62423c6625
2021-12-08 17:58:35 +00:00
Tony Wickham b5a051ca0b Merge changes I6cf84ec7,Iea599651,If3238286 into sc-v2-dev
* changes:
  Improve quick switch from home to taskbar
  Cleanup some taskbar/hotseat handoff issues
  Fix taskbar stash misalignment when going from app to overview
2021-12-08 17:42:54 +00:00
Alex Chau 129086560b Handle split select rotation am: 86ef5e924a am: bcf2060c5d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16405843

Change-Id: I1996ebcf1cb5c669d7394f4285a6b0f441aee9c0
2021-12-08 12:12:17 +00:00
Alex Chau bcf2060c5d Handle split select rotation am: 86ef5e924a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16405843

Change-Id: Ife26f26f92bd2f0a238ea19c9e9958d655e96083
2021-12-08 11:55:07 +00:00
Alex Chau 86ef5e924a Handle split select rotation
- Update floatingTaskView, apply splitsSelectTranslation and splitPrimaryScorllOffest when rotating while in split select
- Moved getSplitSelectTranslation to RecentsView
- When in portrait, treat STAGE_POSITION_BOTTOM_OR_RIGHT as STAGE_POSITION_TOP_OR_LEFT in split translation calculation
- Apply splitsSelectTranslation for portrait grid too

Fix: 201721153
Test: manual
Change-Id: I768a3b15de4d434674058b274c368798f5852917
2021-12-08 11:35:02 +00:00
Becky Qiu 9b2673cda4 [DO NOT MERGE] Remove one search flag and code from sc-v2. am: d0a9f1502b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16407148

Change-Id: I20a1bfac918e53367ab1af1203e0a94de02b1893
2021-12-08 07:25:57 +00:00
TreeHugger Robot 57b9c472dc Merge "[DO NOT MERGE] Remove one search flag and code from sc-v2." into sc-v2-dev 2021-12-08 06:57:28 +00:00
Brian Isganitis 1b5dd42e61 Merge "Adding support for logging wallpaper container info." into sc-v2-dev am: d3ebc4c692
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16335450

Change-Id: Ic26d48fe0190f8362acbd76170b649f5686a46e9
2021-12-08 06:14:10 +00:00
Brian Isganitis d3ebc4c692 Merge "Adding support for logging wallpaper container info." into sc-v2-dev 2021-12-08 05:48:30 +00:00
Brian Isganitis 79efba935f Adding support for logging wallpaper container info.
Test: https://paste.googleplex.com/5350571797118976 shows logging carousel size and index of wallpaper tapped. If the wallpaper is a live wallpaper, we also log its application info.
Bug: 188222480
Change-Id: I6dd7ac20af7afd675d8a886d5b838263680f773e
Merged-In: I6dd7ac20af7afd675d8a886d5b838263680f773e
2021-12-08 00:22:59 +00:00
Brian Isganitis cb1ef031de Merge "Adding support for logging wallpaper container info." 2021-12-08 00:22:04 +00:00
Tony Wickham b58230d15b Merge "Remove LauncherState.TASKBAR visible element" into sc-v2-dev am: 779879ce3d am: 562ca940e2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16405551

Change-Id: Ic703ea1b35ff2e0b8b5e1ea1a316251184fbec42
2021-12-07 21:15:32 +00:00
Tony Wickham 24675d36b7 Improve quick switch from home to taskbar
- Add LauncherState#isTaskbarAlignedWithHotseat() which defaults to !isTaskbarStashed(), but is always false for quick switch from home
- Replaced FLAG_TRANSITION_STATE_START_STASHED and FLAG_TRANSITION_STATE_COMMITTED_STASHED with FLAG_STATE_TRANSITION_RUNNING and a reference to mLauncherState. STATE_START is equivalent to TRANSITION_RUNNING changing to true, and STATE_COMMITTED is equivalent to TRANSITION_RUNNING changing to false. Then can get details from the state such as whether taskbar is stashed and icon alignment from mLauncherState

Test: quick switch from home, both with taskbar stashed in apps and not
Fixes: 194728611
Bug: 204657916
Change-Id: I6cf84ec73a4036e14cc7268667c6f62100884c27
2021-12-07 13:13:48 -08:00
Tony Wickham 562ca940e2 Merge "Remove LauncherState.TASKBAR visible element" into sc-v2-dev am: 779879ce3d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16405551

Change-Id: I876064e6ca079acf04ffdf17ee38060e270852a7
2021-12-07 20:56:27 +00:00
Tony Wickham 779879ce3d Merge "Remove LauncherState.TASKBAR visible element" into sc-v2-dev 2021-12-07 20:42:55 +00:00
Alex Chau 992db75dae Use percentage scaling for overview thumbnail size
- Limit overview to screen ratio to be at max 70%
- Tuned row spacing and page spacing
- Added 2 more test activities to testOverviewForTablet to avoid dismissing tasks at end of grid, as more grid tasks are now shown

Bug: 207350366
Test: manual
Change-Id: Id04871464bdb3ef2d6b046977b0ffd9bd51bc230
Merged-In: Id04871464bdb3ef2d6b046977b0ffd9bd51bc230
2021-12-07 14:50:40 +00:00
Alex Chau a5470710a3 Use percentage scaling for overview thumbnail size am: 4f7952ead4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16389092

Change-Id: I18751b12e2c7fa2b376545a95426594cbadffd07
2021-12-07 14:50:04 +00:00
Alex Chau 4f7952ead4 Use percentage scaling for overview thumbnail size
- Limit overview to screen ratio to be at max 70%
- Tuned row spacing and page spacing
- Added 2 more test activities to testOverviewForTablet to avoid dismissing tasks at end of grid, as more grid tasks are now shown

Bug: 207350366
Test: manual
Change-Id: Id04871464bdb3ef2d6b046977b0ffd9bd51bc230
2021-12-07 11:00:48 +00:00
Tony Wickham 7af54403a3 Remove LauncherState.TASKBAR visible element
It's no longer used, so removing to cleanup code and reduce confusion

Test: no functional change
Fixes: 209512651
Change-Id: Ibd671bde7190df976b5365331731a55a9abdbb35
2021-12-06 15:59:39 -08:00
Becky Qiu d0a9f1502b [DO NOT MERGE] Remove one search flag and code from sc-v2.
Bug: 209501163
Test: manual
Change-Id: Iee1c8276a1f81aa0f54e8a342cfdd3f01d7ab1b7
2021-12-06 15:22:04 -08:00
Jon Miranda 986a447ee2 Merge "Play return to icon animation if user swipes back to All Apps." into sc-v2-dev am: 52ee4ec4aa am: faedc9004c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16194658

Change-Id: If3e72442f3cd3b976d688ffef366a188683247fe
2021-12-06 19:03:41 +00:00
Brian Isganitis 111a5c5df5 Adding support for logging wallpaper container info.
Test: https://paste.googleplex.com/5350571797118976 shows logging carousel size and index of wallpaper tapped. If the wallpaper is a live wallpaper, we also log its application info.
Bug: 188222480
Change-Id: I6dd7ac20af7afd675d8a886d5b838263680f773e
2021-12-06 18:37:07 +00:00
Jon Miranda 52ee4ec4aa Merge "Play return to icon animation if user swipes back to All Apps." into sc-v2-dev 2021-12-06 18:17:52 +00:00
Alex Chau 5ec74a16f0 Merge "Add back screenshot button to Launcher3" into sc-v2-dev am: 5656154f1a am: abda7bc69c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16365185

Change-Id: I61b276bc55eb8486828e5ee9c19251065564d56e
2021-12-06 18:06:27 +00:00
Alex Chau 5656154f1a Merge "Add back screenshot button to Launcher3" into sc-v2-dev 2021-12-06 17:37:42 +00:00
TreeHugger Robot 88dc380611 Merge "Use getMeasuredWidth instead of getWidth in setSplitIconParams" into sc-v2-dev am: ad890ac5af am: 4e36642c01
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16388226

Change-Id: I53adc3f81e4de6296d7c2f8e76696f33c01e2508
2021-12-03 21:01:09 +00:00
TreeHugger Robot ad890ac5af Merge "Use getMeasuredWidth instead of getWidth in setSplitIconParams" into sc-v2-dev 2021-12-03 20:23:58 +00:00
TreeHugger Robot 694de39d05 Merge "Constraint Snackbar's width to 504dp" into sc-v2-dev am: 3013c7ecf5 am: c0f7659683
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16388221

Change-Id: I91594935a8e2823b7116fc649581be04160b8295
2021-12-03 19:52:18 +00:00
Alex Chau 4bdf8c1754 Use getMeasuredWidth instead of getWidth in setSplitIconParams
Fix: 208647202
Test: Enter overview with app pairs, rotate and rotate back, check the task icon
Change-Id: I14914258a2508cf3f399312f4c88574b27a5e9fa
2021-12-03 18:28:38 +00:00
Alex Chau dc73072797 Constraint Snackbar's width to 504dp
Fix: 209005185
Test: manual
Change-Id: I512ddb575a9fced4bf2608806aef875fe34304e6
2021-12-03 16:20:42 +00:00
Alex Chau eef3ed6628 Merge "Destroy activity/view references to avoid memory leak" into sc-v2-dev am: 683b4cd824 am: f1c38718d5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16365768

Change-Id: I0144c29e4ca9e0ea04d831f4473b4fd6ccf21a8f
2021-12-03 12:57:05 +00:00
Alex Chau 1bf0fe1b70 Add back screenshot button to Launcher3
- Also make spacing between buttons always 36dp
- Updated screenshot button image for Launcher3

Fix: 208384949
Test: Start overview in Launcher3WithQuickStep, test screenshot button is working
Change-Id: Ieb60ce134813202c1d14137fff0a131e1f5f8c96
2021-12-03 12:32:29 +00:00
Alex Chau 683b4cd824 Merge "Destroy activity/view references to avoid memory leak" into sc-v2-dev 2021-12-03 12:30:49 +00:00
Sunny Goyal 331e6e94f9 Merge "Updating icon badging logic" 2021-12-03 02:14:42 +00:00
Vinit Nayak 573fca80f6 Destroy activity/view references to avoid memory leak
Bug: 204891006
Change-Id: If60ac1716c30ebe68fb6e7457d71f542d3075422
2021-12-02 16:05:52 -08:00
TreeHugger Robot f30a999841 Merge "Add icons for staged split" into sc-v2-dev am: 7f54d5cde4 am: 0dc5a85eb5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16374164

Change-Id: I3103d1d423910686d049d72f399bfdf1eb0539ee
2021-12-02 23:36:33 +00:00
Alex Chau 2cbe70a386 Merge "Fix switch access for overview grid" into sc-v2-dev am: b31176c83b am: e5449f5468
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16346361

Change-Id: I9488154c6e53fa0ba111e2041619b5e49d9c81c8
2021-12-02 23:06:26 +00:00
TreeHugger Robot 7f54d5cde4 Merge "Add icons for staged split" into sc-v2-dev 2021-12-02 23:00:48 +00:00