Commit Graph

8965 Commits

Author SHA1 Message Date
TreeHugger Robot 98cf5545e5 Merge "Saving instance state so that widget cache is updated properly before rebind" into ub-launcher3-qt-dev 2019-06-12 18:15:22 +00:00
TreeHugger Robot 58dc1cfc61 Merge "Merge branch 'ub-launcher3-qt-r1-dev' into ub-launcher3-qt-dev" into ub-launcher3-qt-dev 2019-06-12 17:40:06 +00:00
Winson Chung 2fb6a4cfc9 Merge "Reset the overview sysui state when returning to the previous task" into ub-launcher3-qt-dev 2019-06-12 17:27:32 +00:00
vadimt 63a3846b56 Merge "Calling sendStateEventToTest() from a place guaranteed to be called" into ub-launcher3-qt-dev
am: c1fa3abd2e

Change-Id: I90802248680747645bc975e81fb4fe477f2db679
2019-06-11 17:31:17 -07:00
TreeHugger Robot c1fa3abd2e Merge "Calling sendStateEventToTest() from a place guaranteed to be called" into ub-launcher3-qt-dev 2019-06-12 00:12:08 +00:00
Winson Chung a36c8004ed Reset the overview sysui state when returning to the previous task
- Otherwise, it gets stuck until the next time launcher pauses/task launch

Bug: 135008910
Change-Id: Ia0696d764522e36a4064583cb82003c1e9c0cb7a
2019-06-11 16:53:01 -07:00
Winson Chung ee15e52258 Merge "Defer listening for notification changes until resume" into ub-launcher3-qt-dev
am: ca29259673

Change-Id: I135a79f492491c6c5c0bc449bc0c7faabbd8fd10
2019-06-11 15:01:50 -07:00
TreeHugger Robot ca29259673 Merge "Defer listening for notification changes until resume" into ub-launcher3-qt-dev 2019-06-11 21:43:02 +00:00
vadimt 8f9cf2f38f Calling sendStateEventToTest() from a place guaranteed to be called
See discussion in the bug

Bug: 133867119
Change-Id: Id162cfa3b0a0aafe17dd9b41e2c4b5d02c411830
2019-06-10 18:01:58 -07:00
Winson Chung 8758311c2a Defer listening for notification changes until resume
Bug: 134964922
Test: Take a systrace while swiping up, ensure there are no resource icon
      loads other than the icon for the current app while launcher is
      starting

Change-Id: I469a2089df02434918125b005cd795f5514ec389
2019-06-10 14:20:58 -07:00
Sunny Goyal 76ba0a328d Saving instance state so that widget cache is updated properly before rebind
List widgets use a static cache which is initialized as part of saveInstanceState.
Calling this ensures that no extra binder calls are made on rotation

Bug: 134707989
Change-Id: I8d4450134168bd412ba2911c57354a603868bc47
2019-06-10 12:00:10 -07:00
vadimt af6325138b More tracing for b/133009122
am: 34b2f03b30

Change-Id: I4487817d7b2905bf8837a35a2e13147c63ed1344
2019-06-10 11:55:05 -07:00
vadimt 34b2f03b30 More tracing for b/133009122
Bug: 133009122
Change-Id: I09a95b88ea55e1759151b2bcd5ede0c1efa38e7e
2019-06-10 11:26:37 -07:00
vadimt 1b0b3aa1ba More tracing for b/133009122
am: c25d975342

Change-Id: Iee85b5a93612867c8eabae37b0d6fa1a388a4084
2019-06-07 13:11:43 -07:00
vadimt c25d975342 More tracing for b/133009122
Bug: 133009122
Change-Id: Ic843c3147d8a7513b6e2b8732af18458eae10d63
2019-06-07 12:13:11 -07:00
Vadim Tryshev 9d14e5520e Merge "Freezing all apps updates during certain tests" into ub-launcher3-qt-r1-dev 2019-06-07 01:34:30 +00:00
vadimt 51d2cf913c Merge "Add tracing for b/134532571" into ub-launcher3-qt-dev
am: bfe171f9cb

Change-Id: I86539398e74beb527cbede66143ff1c61990cca8
2019-06-06 17:31:41 -07:00
TreeHugger Robot bfe171f9cb Merge "Add tracing for b/134532571" into ub-launcher3-qt-dev 2019-06-07 00:10:30 +00:00
vadimt 0f08db5eeb Add tracing for b/134532571
Bug: 134172603
Bug: 134532571
Change-Id: I75c8e0212a9b35d33842d5380fbe733b486be932
2019-06-06 17:00:57 -07:00
Sunny Goyal bbbfc62c63 Merge "Disable seamless rotation for 3 and 2 button mode" into ub-launcher3-qt-dev
am: 19f7c6fefb

Change-Id: Iec2636f14a157e9a9b5e9c47e1c258b9158dc942
2019-06-06 15:58:04 -07:00
Sunny Goyal 0b1cb75ee8 Disable seamless rotation for 3 and 2 button mode
Bug: 134095068
Change-Id: I8603e49a85b5524a02c9085485a180b022e3f91e
2019-06-06 15:35:45 -07:00
vadimt d4c90e12e9 Freezing all apps updates during certain tests
This CL adds a very low risk because most (but not all) changes affect
only Launcher behavior during the test.

This should fix a lab-only flake when all apps keeps changing while
the test is working with it.

Example: test figures out which icon to click, by the moment it clicks
there, there is another icon there, or the icon is under the search box,
and clicking opens IME.

Switching test devices to airplane mode didn't help. The earlier change
that prevents popup menu cancellation is not general enough.

Now the tests are given an API to explicitly freeze and unfreeze
all-apps, which should be a final solution.

Bug: 132900132
Bug: 133765434
Change-Id: I8b81cc9be004482beb6cdcdd05406e2d9b4c7629
2019-06-06 11:10:56 -07:00
Sunny Goyal 5db7cb9c2d Merge "Fixing wrong origin when launching new task from overview" into ub-launcher3-qt-dev
am: bfaabbea81

Change-Id: Ie0939ae8c5286631da3ef08ffaf0151bdc81c7e6
2019-06-05 19:54:59 -07:00
Sunny Goyal bfaabbea81 Merge "Fixing wrong origin when launching new task from overview" into ub-launcher3-qt-dev 2019-06-06 00:16:29 +00:00
Tony Wickham dd31cda247 Merge "Fade out scrim when swiping to home" into ub-launcher3-qt-dev
am: be1fde798c

Change-Id: I490a890b122a87a42e21b2dda30abb32c209a717
2019-06-05 15:36:30 -07:00
Tony Wickham be1fde798c Merge "Fade out scrim when swiping to home" into ub-launcher3-qt-dev 2019-06-05 22:27:49 +00:00
Sunny Goyal 90e9352ee1 Merge "Allowing tracing to be enabled using command line on all build flavors" into ub-launcher3-qt-dev
am: 0d6856a108

Change-Id: I8366486c5370ed34f2694b37be41f6fed7e66d54
2019-06-05 15:19:24 -07:00
Sunny Goyal b88d4a64fd Allowing tracing to be enabled using command line on all
build flavors

Change-Id: I5f8ee996bdcede2393eeb4aaa1b45fec7619d405
2019-06-05 14:09:51 -07:00
Sunny Goyal bda6b45341 Fixing wrong origin when launching new task from overview
> Also removing some unnecessary layout passes during launch animation

Bug: 133226418
Change-Id: I36fe69827853366deb7c56ca25f39e20c1a0b825
2019-06-05 12:25:28 -07:00
Zak Cohen 8d19146b7b Remove unused hints code.
This layout is handled by the provider of the hints now.

Bug: 132886768
Test: manual
Change-Id: Ifc0db2395a7503b1b03dcb796961ef6647c0413b
(cherry picked from commit f3231f417d)
2019-06-05 11:18:09 -07:00
Sunny Goyal 87c8a511cd resolve merge conflicts of f17eb616a8 to ub-launcher3-qt-r1-dev
Bug: None
Test: I solemnly swear I tested this conflict resolution.
Change-Id: I4e177dfb7ba3bde6eb53f63c2f2df273feef90ee
2019-06-05 10:44:02 -07:00
Tony ae087dc9b8 Fade out scrim when swiping to home
Bug: 134517106
Change-Id: Ica725e3a327c1c069e3859732ea6a878d361a3d8
2019-06-04 19:25:03 -07:00
vadimt 8474ab2b9d Merge "Fixing All Apps's getting stuck in a non-updating state" into ub-launcher3-qt-dev
am: 8789aa05a1

Change-Id: I583ea8c9e6920aa072fa29087c51ce817e6b9d63
2019-06-04 17:51:24 -07:00
TreeHugger Robot f17eb616a8 Merge "Some RecentsView layout fixes" into ub-launcher3-qt-dev 2019-06-04 21:34:19 +00:00
Sunny Goyal 1b52c7e5de Some RecentsView layout fixes
> Only creating task overlay for one view at a time
> Fixing setOverviewStateEnabled called twice when going
  between OVERVIEW and BACKGROUND state

Bug: 132815672
Bug: 122345781
Change-Id: I51ac5b0744af87194eca08e07fd2c75b8fa0d3e0
2019-06-04 14:17:30 -07:00
Perumaal Shanmugam 067bce7d8a Merge "Re-enable chips in qt-r1-dev" into ub-launcher3-qt-r1-dev 2019-06-04 17:29:10 +00:00
TreeHugger Robot 8789aa05a1 Merge "Fixing All Apps's getting stuck in a non-updating state" into ub-launcher3-qt-dev 2019-06-04 16:37:58 +00:00
vadimt 3ca5280186 Fixing All Apps's getting stuck in a non-updating state
Normally, if all apps is open, and an app installs/uninstalls/updates,
All Apps will immediately reflect this.

However, depending on something subtle in the intensity of the swipe
gesture that brought All Apps, all apps will freeze, and won't update.

This frozen state will go away after scrolling in all apps, iteration
with an icon and, generally, any tap interaction with All Apps.
Otherwise, it will stay until it's closed and opened again via a gesture
with a different pattern.

The reason is in the code that freezes All Apps updates during user
interactions with all apps.

For example, during scrolls. Or while the user holds an icon, expecting
to see a context menu; in this case an update would cause the menu to
not appear, which is somewhat annoying.

The motivation to add this code was to solve a category of lab-only
flakes when a context menu couldn't open because the lab device was busy
with post-flash activities.

The code incorrectly assumed that after ACTION_DOWN, we are guaranteed
to get either UP or CANCEL, which is wrong.

It's after *consumed* ACTION_DOWN that we'll get these events.

The fix still solves the user's and tests' problems that the code was
supposed to solve.

Bug: 134442147
Change-Id: I9db74a33ecf93b1dc6bc69df301f7f542dea2a40
2019-06-03 18:35:52 -07:00
Sunny Goyal 7241d7cfe5 Merge "Removing user locked change in LauncherAppState" into ub-launcher3-qt-dev
am: ce0c093133

Change-Id: Ib85ff9f162f4511726d270e9d1ab94734c04e054
2019-06-03 16:55:12 -07:00
TreeHugger Robot ce0c093133 Merge "Removing user locked change in LauncherAppState" into ub-launcher3-qt-dev 2019-06-03 23:44:58 +00:00
Sunny Goyal d17a951df8 Removing user locked change in LauncherAppState
The process will crash anyway when loading sharedPreference. So
we do not need any extra check to cause the same crash.

Bug: 134094839
Change-Id: Icfd4406ff601d6b9a75bd95ddcecb9869f7e7fa2
2019-06-03 23:19:02 +00:00
TreeHugger Robot 0f405d78d7 Merge "Remove unused hints code." into ub-launcher3-qt-r1-dev 2019-06-03 23:02:01 +00:00
Hyunyoung Song ed45267bf9 Merge "Add shape detection logic only for circle icons" into ub-launcher3-qt-dev 2019-06-03 22:34:02 +00:00
Zak Cohen f3231f417d Remove unused hints code.
This layout is handled by the provider of the hints now.

Test: manual
Change-Id: Ifc0db2395a7503b1b03dcb796961ef6647c0413b
2019-06-03 14:58:18 -07:00
Hyunyoung Song f69426c484 Add shape detection logic only for circle icons
b/119330044

Change-Id: I93042effa8417167d844f073275e8b941e861e60
2019-06-03 14:05:20 -07:00
Perumaal S 2461d61e14 Re-enable chips in qt-r1-dev
Fixes: 134164918
Change-Id: Ib5441a40ad8043afbe32d6c4c40808676cdcdb20
2019-06-03 10:21:47 -07:00
Adam Cohen acdde3d750 Fix issue where Workspace scrolling doesn't work
=> The WorkspaceTouchListener was relying on receiving TOUCH_DOWN in order to
   clear its state. This is not guaranteed; ie. when touches begin above
   children of the workspace (icons or widgets)

=> Any invocation of the Workspace long press menu would trigger this issue
   and it would persist until a touch went directly onto the Workspace in a
   location without any children.

Bug 132298752

Change-Id: Id8617baaa1ce59dc84758a7c82049329323b04cc
2019-06-01 17:16:59 -06:00
TreeHugger Robot 045dc86d9f Merge "Disable chips in qt_dev" into ub-launcher3-qt-dev 2019-05-31 22:12:40 +00:00
Perumaal S 464dda250b Disable chips in qt_dev
- Not for use in qt_r1_dev

Bug: 134164918
Change-Id: Ib49289060a39a1a5615e762a4e72b105ed166135
2019-05-31 21:28:46 +00:00
vadimt a8f77a6afd More debug tracing for switching to all apps not sending the final event
(to the test)

Bug: 134172603
Bug: 133867119
Change-Id: I00cf3a35daefa23d2e72a89d21e6ce37c8a9a46d
2019-05-31 13:34:24 -07:00