Commit Graph

19593 Commits

Author SHA1 Message Date
Vinit Nayak 77ce4c261e Merge "Update API for OneShotRemoteHandler" into main 2023-10-11 15:13:25 +00:00
Vinit Nayak c4f653c24c Merge "Null out context for all split controllers" into main 2023-10-11 15:12:24 +00:00
Alex Chau 4989f4f36d Revert "Revert "Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig flag""
This reverts commit 7b5472f986.

Reason for revert: aconfig/SetFlagsRule actually works with TAPL tests (http://ag/c/platform/packages/apps/Launcher3/+/24991890/comment/8303a3c6_030ae00b/)
Bug: 270397206

Change-Id: I7529a64c3197e4c2b4d5fb1e46fb29bdea1e52e9
2023-10-11 14:08:22 +00:00
Riddle Hsu 681f340d7d Finish recents animation for standalone recents on home
There was a check from RunningTask to avoid using transient-launch
when launching recents activity on a 3rd party home. But the info
may not be updated in time (from TaskStackChangeListener) if there
are several changes happen in a short time.

Then it may misjudge that home is still on top but the current top
is a normal app. Then the app will be paused unexpected because
setTransientLaunch() is not called.

Since FLAG_MOVED_TO_TOP is introduced, task reorder will also be
collected in transition, so the check of isHomeTask is longer needed.
But RecentsTransitionHandler still needs to cooperate with it about
how to animate the merging animation while recents animation is running.
To simplify it, just finish the recents animation when recents activity
is launched on top of home activity, i.e. consider it as a regular
launch because only the recents activity is on top and there are no
other apps need to keep visible for live-tile.

Note that setTransientLaunch() is still called for the case. However
its effect will be gone after the transition is finished.

This can also fix various issues when using a 3p launcher:
 - When auto rotation is enabled and put device in landscape:
    - Unable to enter recents from gesture mode
    - System bars are disappeared when pressing recents key
 - Jump-cut when pressing home key to leave recents on home.

Bug: 302703228
Bug: 294029838
Test: WindowInsetsBehaviorTests
Test: Rapidly click navigation bar while a regular app is on top.
      The app should not receive onPause.
Change-Id: I9ba9bdb3757bbdcb1cbb363b4fe6431860dac4da
2023-10-11 18:46:35 +08:00
Hyunyoung Song e0a25fbd51 Merge "Add CUSTOM_LPNH_THRESHOLDS feature flag to customize LPNH" into main 2023-10-11 07:54:26 +00:00
Tracy Zhou 9633e5b74c Merge "Fix phone mode task bar inset values not correctly initialized" into main 2023-10-11 05:32:09 +00:00
Vinit Nayak def3e9d7f4 Call split finish callback if split invocation fails
Bug: 295981634
Test: Splitting w/ Google TV widget no longer
keeps placeholder views on screen
Flag: ENABLE_SPLIT_WORKSPACE_TO_WORKSPACE

Change-Id: I1d4df9deb9aaaaeef3741a05130429d0091293e8
2023-10-10 21:01:35 -07:00
Vinit Nayak a439c912d8 Null out context for all split controllers
* Destroy context for AppPairsController and
SplitSelectDataHolder

Bug: 302551868
Change-Id: I5636ecf50d51ad383ac89a457697984bc8d907ca
2023-10-10 20:42:42 -07:00
Vadim Tryshev f782eaba73 Improving diagnostics from fallback recents tests when phone is not unlocked
Failing earlier so that we don't get strange messages from the middle of the test.

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I1e3c70623e6f907bcc6bd0486b6c75afecb610e3
2023-10-10 19:18:22 -07:00
Vinit Nayak e83b08ff6e Update API for OneShotRemoteHandler
* All no-ops except SplitSelectStateController

Bug: 295981634
Change-Id: Idabe80951ceb2b0a980f3179366d75fc064c69ec
2023-10-10 15:41:26 -07:00
Tracy Zhou de28c115b2 Fix phone mode task bar inset values not correctly initialized
We rely on contentHeightToReportToApps and tappableHeightToReportToApps (that ultimately call into DeviceProfile) of TaskbarStashController to initialize the insets. However, DeviceProfile only initializes those values when isTaskbarPresent is true. Rather than completely changing the initialization of DeviceProfile, we special case in TaskbarStashController that uses the bar height for inset

Bug: 274517647
Test: turn on FLAG_HIDE_NAVBAR_WINDOW and TASKBAR_NO_RECREATION, make sure the insets are correct in both 3 button and gesture nav mode
Change-Id: I164a6e2c9f9d24888155b45325ee8ce46ca2c39f
2023-10-10 13:02:16 -07:00
Bill Yi 7991a8ed41 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2023-10-10 19:29:49 +00:00
Sunny Goyal cd44740567 Moving onboarding prefs to use LauncherPrefs
Bug: 301661768
Test: Presubmit
Flag: N/A
Change-Id: Iec8a5e739f394a152d5ffc57b01e0449e94b4084
2023-10-10 11:47:33 -07:00
Jagrut Desai 3872759957 Merge "Stop Active Gesture Error Detection for Non Gestural Navigation Mode" into main 2023-10-10 17:32:47 +00:00
Schneider Victor-tulias bdae57c157 Fix janky Alt+Tab through overview animation
Flag: not needed
Fixes: 282172884
Test: used alt+tab in overview; also launched overview through keyboard quick switch view
Change-Id: I3d1e54cda317ee8f8d2b2d698480cd3ca01dfc85
2023-10-10 11:20:15 -04:00
Charlie Anderson 2934c460c4 Fix status bar flicker on adding widgets requiring configuration.
- Changes ProxyActivityStarter theme to draw transparent navigation and status bar

Test: locally
Flag: N/A
Bug: 202485497

Change-Id: I88d14099ec9b1f433fbcdc9184fe5af557bc180b
2023-10-10 11:00:05 -04:00
Alex Chau 09d8e2ca57 Merge "Revert "Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig flag"" into main 2023-10-10 12:26:21 +00:00
Alex Chau 7b5472f986 Revert "Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig flag"
This reverts commit 6f264a927b.

Reason for revert: Keeping old flag system so we can test in Tapl tests (b/283246928)
Bug: 270397206

Change-Id: I3e6364ebac8018facc3b22e510615735299a3dad
2023-10-10 10:38:04 +00:00
Tracy Zhou f14c534ec5 Merge "Set correct stashed task(nav) bar height with taskbar/navbar unification" into main 2023-10-10 05:08:02 +00:00
Federico Baron ca39bd99cc Merge "Add screenrecord to testOverviewActionsMenu_iconAppChipMenu" into main 2023-10-09 21:29:11 +00:00
Sebastian Franco 02a4fb41c7 Unifying constant app names used in Tests
Bug: 298234173
Test: No-op changes, all test should pass
Change-Id: I3cd4854b150d827393bff6eada7aa9a9201dadaa
2023-10-09 14:25:49 -07:00
Vadim Tryshev 6bc3f5e0e1 Merge "Introducing a method for execution an action on Launcher for teardown" into main 2023-10-09 21:22:47 +00:00
Tracy Zhou 5bd641e3f5 Merge "Fix task bar crashing in small screen with task bar / nav bar unification on" into main 2023-10-09 20:26:25 +00:00
Vadim Tryshev 39b4fad9b0 Introducing a method for execution an action on Launcher for teardown
If the test fails to initialize properly, tearDown is still called,
and we may have null Launcher activity.

We want to safely skip using that activity to avoid a NullPointerException
that would hide the original error message.

Bug: 304306290
Test: presubmit
Flag: N/A
Change-Id: I89774a92ede046fa3afadacc62df25f4f496f4e7
2023-10-09 11:29:42 -07:00
Andreas Agvard d25afb7eab DO NOT MERGE Temporary fix for race condition. am: 928e0521b2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24955345

Change-Id: Iae4f125b437f3fc4528851d48432757b1121f353
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-09 18:21:59 +00:00
Alex Chau 461b65fa4e Merge "Use mock TaskStackChangeListeners in RecentsModelTest" into main 2023-10-09 16:39:13 +00:00
Jagrut Desai 5cc3767e60 Stop Active Gesture Error Detection for Non Gestural Navigation Mode
Bug: 290266108
Bug: 294926731
Test: Presubmit
Flag: not needed
Change-Id: I111d60fbedbeb7e8b553cdeadc0e3f39a9a351b2
2023-10-09 09:34:30 -07:00
Vinit Nayak b95ee09a69 Merge "Dismiss split selection for workspace long-press" into main 2023-10-09 16:13:52 +00:00
Alex Chau a0c149fc8d Use mock TaskStackChangeListeners in RecentsModelTest
- Also unregistered TaskStackChangeListeners and TaskIconCache listeners in RecentsModel.close(), so clean-up will happen if it's in a SandboxContext

Bug: 303259446
Test: RecentsModelTest
Change-Id: I438a499be8e737de7df79b670ecfd26f0ee70662
2023-10-09 14:31:58 +01:00
Andreas Agvard 928e0521b2 DO NOT MERGE Temporary fix for race condition.
Bug: 303078360
Test: Manual

Change-Id: I7355e3b64424492b6fab4f416014d2a9a797973d
2023-10-07 22:55:17 +00:00
Vinit Nayak 4f850a42a0 Merge changes I9e56ddbe,I8767deea into main
* changes:
  Disallow taskbar long click when in split selection state
  Add method to determine if launcher is in split selection state
2023-10-07 00:20:24 +00:00
Vinit Nayak 01849e4c63 Merge "Null reference to activity as runnable back handler" into main 2023-10-07 00:15:54 +00:00
Jagrut Desai f56bfabaa4 Merge "Change Taskbar Window height logic for taskbar pinning." into main 2023-10-06 23:33:30 +00:00
Vinit Nayak d0fc718a0a Dismiss split selection for workspace long-press
Bug: 295426148
Test: Enter split contextual from homescreen,
long-press on empty space, split gets dismissed
Flag: ENABLE_SPLIT_WORKSPACE_TO_WORKSPACE

Change-Id: I3a893bea7b22645fe60c65c4c5ab8c2087d769da
2023-10-06 16:05:54 -07:00
Winson Chung 36a9c19487 Merge "Defer nav handle action until after the recents transition is complete" into main 2023-10-06 22:47:32 +00:00
fbaron 263644524e Add screenrecord to testOverviewActionsMenu_iconAppChipMenu
Bug: 303329286
Test: n/a
Flag: no flag
Change-Id: Iab1f9e38ef1d05d56b08f62a5b3b973e96cc6f60
2023-10-06 15:38:08 -07:00
Andy Wickham 9fbc52f02d Add CUSTOM_LPNH_THRESHOLDS feature flag to customize LPNH
When this flag is enabled, new Developer Options appear which
allow you to customize the slop and timeout to invoke LPNH.

The slop is defined as a multiplier to the default edge slop
(which I discovered while looking into this - it appears to
be intended for touches along the device edge and is 50%
larger than the default touch slop; currently used by Back).

Timeout is defined in milliseconds, defaulting to 400, at least
on my device.

Bug: 301680992
Bug: 300955321
Flag: CUSTOM_LPNH_THRESHOLDS - should be no-op with default off
Test: Manual with flag on and adjusting sliders, and flag off
Change-Id: Iabc7b3706f4fdd6f0392c858b81a856e375ffd51
2023-10-06 15:06:13 -07:00
Ats Jenk 186e60e94c Merge changes from topic "overview-to-desktop" into main
* changes:
  Account for freeform tasks being visible in overview
  Enable live tile for desktop
2023-10-06 22:05:06 +00:00
Vinit Nayak 114293fb56 Disallow taskbar long click when in split selection state
* This is specifically when contextual is initiated on home
screen and then user swipes up into overview.
* We no longer want to rely on LauncherStates for split specific
management

Bug: 295981634
Test: Start split on home, swipe up to overview, long press on
taskbar app icons, nothing happens
Flag: ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE

Change-Id: I9e56ddbe1f536be779d4848769a993724d5395da
2023-10-06 14:42:22 -07:00
Vinit Nayak 1525cd7269 Add method to determine if launcher is in split selection state
* Available for both launcher and taskbar via
ActivityContext

Bug: 295981634
Change-Id: I8767deea0b2432da3047209037874c966b83c3b3
2023-10-06 14:40:49 -07:00
Brian Isganitis 447b09057a Merge "Prevent NPE from changing all apps visibility in shared state." into main 2023-10-06 20:59:33 +00:00
Brian Isganitis f79785065b Merge "Have dragged search items return to All Apps icon if cancelled." into main 2023-10-06 20:44:06 +00:00
Schneider Victor-tulias 8265d04e0a Merge "Fix NullPointerException in OverviewInputConsumer" into main 2023-10-06 20:30:39 +00:00
Bill Yi 50f8bed76f Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I188b2bc905489318760cbe5869deef836d2e04b2
2023-10-06 13:16:06 -07:00
Vinit Nayak 4a926d3bfd Null reference to activity as runnable back handler
Bug: 302551868
Change-Id: Ia21c5696ef58c113a8d038cb0f8dfef413d991de
2023-10-06 11:15:14 -07:00
Brian Isganitis 96224ef755 Merge "Migrate Kotlin tests to use mockito-kotlin2." into main 2023-10-06 17:54:56 +00:00
Sunny Goyal b34296face Merge "Making AsyncClockEventDelegate a singleton" into main 2023-10-06 16:58:41 +00:00
Vinit Nayak 0f9d9a825f Merge "Null reference to split callback" into main 2023-10-06 14:21:18 +00:00
Tracy Zhou cfbf3ff695 Set correct stashed task(nav) bar height with taskbar/navbar unification
Again caused by DeviceProfile not initiating task bar stashed and unstashed height in folded state with unification code

Test: Make sure that task(nav) bar has the correct height in both folded and unfolded state
Bug: 274517647
Change-Id: I0d86cfccc6f096bc983f87c57fdfac9800fd4d41
2023-10-05 22:51:10 -07:00
Winson Chung 4f17c97d03 Defer nav handle action until after the recents transition is complete
Bug: 303078360
Test: Force delay in finishing recents transition and verify with bug steps
Change-Id: I2021cc291204261de56ef9c912d8b5935059c7fb
Signed-off-by: Winson Chung <winsonc@google.com>
2023-10-06 03:42:35 +00:00