Ats Jenk
c7c9d594a1
Directly use launcher activity interface
...
When desktop tasks become visible or hidden, we update a SysUI state
flag. This flag update gets processed in TouchInteractionService which
then calls DesktopVisibilityController to update launcher state based on
whether desktop tasks are visible or not.
We were getting a reference to the DesktopVisibilityController through
OverviewComponentObserver. This was causing issues when device was
unlocked with desktop tasks visible. And 3-button navigation was enabled.
In this scenario, we are immediately processing a SysUI flags update
that desktop tasks are visible again (they are hidden while device is
locked). When this update is processed, OverviewComponentObserver
returns the fallback launcher interface. And not the nexus launcher.
The fallback launcher interface does not contain the
DesktopVisibilityController. Since the fallback controller does not
return the visiblity controller, we skipped processing the update that
desktop tasks are visible. Which resulted in launcher remaining in a bad
state with home screen icons visible and desktop tasks on top.
Bug: 273594452
Test: enable 3-button nav and proto 2, move an app to desktop, lock
screen with desktop app visible, unlock screen, observe launcher icons
hidden
Test: enable gesture nav and proto 2, move and app to desktop and lock
screen with desktop app visible, unlock and observe launcher icons
hidden
Test: repeat the same steps with proto 1 enabled
Change-Id: Id52ac4cf2df151b2aee2070ee2eb14de3d74fead
2023-03-16 08:58:50 -07:00
Pat Manning
f0c7fa20ca
Revert "Stash taskbar on swipe to go home for 3p fallback launcher."
...
This reverts commit 9fdd7a1340 .
Reason for revert: testing for b/273809618
Change-Id: Icd0b862f1f5a5a9930a08774c339f21e740d2fa0
2023-03-16 15:53:53 +00:00
Nick Chameyev
6a9535e00c
[Unfold animation] Adjust animation parameters
...
Turns down the amount of translation/scale
of the animation to make it more subtle.
Bug: 271563317
Test: manual
Change-Id: I1cdd045cf4e045a9a238e71a6315d7d813e9f398
2023-03-16 15:32:07 +00:00
Hawkwood Glazier
c9509621aa
Merge "Update PluginManagerWrapper to match SysUI changes" into udc-dev am: 2fced82e24
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21989728
Change-Id: I9e4aa9f653ca44fd361896d922b86da511175c14
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-16 14:25:28 +00:00
Hawkwood Glazier
2fced82e24
Merge "Update PluginManagerWrapper to match SysUI changes" into udc-dev
2023-03-16 14:11:51 +00:00
Fengjiang Li
f35e05b650
Merge "[Predictive Back] Add extra bottom space in taskbar all apps to home" into udc-dev am: 751d1475be
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21991761
Change-Id: I99b6ce9de48142b924edd74ed1f465964da14553
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-16 01:26:23 +00:00
Fengjiang Li
751d1475be
Merge "[Predictive Back] Add extra bottom space in taskbar all apps to home" into udc-dev
2023-03-16 00:46:42 +00:00
Tony Wickham
0c6ccca22d
Restore proper nav buttons translation when taskbar is recreated
...
Since mTaskbarInAppDisplayProgressMultiProp is set by various states
that are hard to query in init() (e.g. state of all apps, -1, widgets,
etc.), we store the last mTaskbarInAppDisplayProgressMultiProp in the
TaskbarSharedState and restore those values in init().
Also updated some debug logs in the dump.
Test: manual: from home screen, swipe down to quick settings and toggle
Dark theme, ensure nav buttons don't translate; do the same but over
launcher all apps
Flag: none
Fixes: 267325761
Change-Id: Ib8e6778582ed39c674cd3c1e95312e673659f6a7
2023-03-16 00:06:22 +00:00
Hongwei Wang
0d22befcb8
VisD update for the PipAppIconOverlay 2/N
...
- Pass the up-to-dated app icon size from Launcher to WMShell
this is for non-auto-enter-pip cases
- For auto-enter-pip, use the DeviceProfile#allAppsIconSizePx directly
Video: http://recall/-/aaaaaabFQoRHlzixHdtY/ha3ebrRk0hAEyU8GSWBrYE
Bug: Bug: 271912318
Test: manual with 4x4 and 5x5 grid, see the video
Change-Id: Iaad26758a25c6cb3832a2da10e15c53e72de0ce5
2023-03-15 15:55:26 -07:00
Jeremy Sim
cd5297315e
Merge "Revert "Revert "Create TAPL test suite for splitscreen""" into tm-qpr-dev am: 7b286a4f68 am: 7f61f22560 am: c0d8b2dc0b
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22079982
Change-Id: I828347c738eb246df5b357d5b61fc93175e38670
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-15 22:36:25 +00:00
Jeremy Sim
c0d8b2dc0b
Merge "Revert "Revert "Create TAPL test suite for splitscreen""" into tm-qpr-dev am: 7b286a4f68 am: 7f61f22560
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22079982
Change-Id: Id25492e0212812d5489923fab9777c8d41f1bfe0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-15 22:19:59 +00:00
Jeremy Sim
7f61f22560
Merge "Revert "Revert "Create TAPL test suite for splitscreen""" into tm-qpr-dev am: 7b286a4f68
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22079982
Change-Id: I4b59606fe141dc2e08bbbc68f8fab42a35cec522
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-15 21:38:36 +00:00
TreeHugger Robot
152bc58d21
Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev
2023-03-15 21:24:12 +00:00
Jeremy Sim
7b286a4f68
Merge "Revert "Revert "Create TAPL test suite for splitscreen""" into tm-qpr-dev
2023-03-15 21:08:24 +00:00
Sunny Goyal
bed7d655ff
Merge "Enabling dynamic flag application" into udc-dev am: 910a2aafda
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22100676
Change-Id: Ia2dd201ef705aafef1cc4f00b5a64dc45ac0434e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-15 19:45:26 +00:00
Vinit Nayak
f72634410e
Merge "Add debug logging for touch handling for all tests" into tm-qpr-dev am: 2741c7befd am: ae4ca5610f am: 36b8937d6d
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22079210
Change-Id: Ia95734020c4b6ea01c7108c139cb0051d56b5a9f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-15 19:44:59 +00:00
Nick Chameyev
426882ff58
Merge "[Unfold animation] Restore clippings before clearing registered views" into tm-qpr-dev am: 6099f9d2d5 am: d2a6c54663 am: b6a97947d3
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22094942
Change-Id: I367220ac888862aeb5e4c0c0ab9176447a03153f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-15 19:43:46 +00:00
Sunny Goyal
910a2aafda
Merge "Enabling dynamic flag application" into udc-dev
2023-03-15 19:12:45 +00:00
Vinit Nayak
36b8937d6d
Merge "Add debug logging for touch handling for all tests" into tm-qpr-dev am: 2741c7befd am: ae4ca5610f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22079210
Change-Id: Icdfe8b24c417efbe3745e6fce46773c406f84032
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-15 18:43:30 +00:00
Nick Chameyev
b6a97947d3
Merge "[Unfold animation] Restore clippings before clearing registered views" into tm-qpr-dev am: 6099f9d2d5 am: d2a6c54663
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22094942
Change-Id: Ie0eedfa0cad36ccb896083890c099ecdf9d90182
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-15 18:42:59 +00:00
Vinit Nayak
ae4ca5610f
Merge "Add debug logging for touch handling for all tests" into tm-qpr-dev am: 2741c7befd
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22079210
Change-Id: Ic12a4e8855c34ba7e02fc3fc4701765f64b3fa50
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-15 18:05:19 +00:00
Nick Chameyev
d2a6c54663
Merge "[Unfold animation] Restore clippings before clearing registered views" into tm-qpr-dev am: 6099f9d2d5
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22094942
Change-Id: I84732f909aefdce0a4679b666c730d23844fde9b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-15 18:04:55 +00:00
Vinit Nayak
2741c7befd
Merge "Add debug logging for touch handling for all tests" into tm-qpr-dev
2023-03-15 17:29:24 +00:00
Fengjiang Li
11f873da0b
[Predictive Back] Add extra bottom space in taskbar all apps to home
...
Bug: 272797556
Test: manual
Change-Id: Ie84117d4211c382544c9ed8e1226bf70b2bd382d
2023-03-15 10:14:48 -07:00
Nick Chameyev
6099f9d2d5
Merge "[Unfold animation] Restore clippings before clearing registered views" into tm-qpr-dev
2023-03-15 17:07:39 +00:00
Sunny Goyal
ae1ce47770
Enabling dynamic flag application
...
Bug: 266854800
Test: Verified by changing flags using adb shell
Change-Id: I29a8b581c9edb21ed4a7204c33f0e5fe8eef51b9
2023-03-15 09:57:59 -07:00
Pat Manning
ecc3027c95
Add automirroring to kids mode back button.
...
Fix: 270629022
Test: manual.
Change-Id: I51957074c0278253a15e0efe9b2b2bcaa8105c4f
2023-03-15 16:03:00 +00:00
Pat Manning
0cc69a9814
Merge "Stash taskbar on swipe to go home for 3p fallback launcher." into tm-qpr-dev am: 7fadbd9e86 am: 388942103c am: 179e97bab2
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21916480
Change-Id: I56e50628cb0ac836a59a87a101dcafc13c62dba2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-15 15:19:58 +00:00
Pat Manning
179e97bab2
Merge "Stash taskbar on swipe to go home for 3p fallback launcher." into tm-qpr-dev am: 7fadbd9e86 am: 388942103c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21916480
Change-Id: I141cf3dd2a47392fa622656a316e72f440243266
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-15 14:41:14 +00:00
Pat Manning
388942103c
Merge "Stash taskbar on swipe to go home for 3p fallback launcher." into tm-qpr-dev am: 7fadbd9e86
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21916480
Change-Id: Ib1ed89d0435675229a8b82282310e04bbd60e953
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-15 14:05:44 +00:00
Pat Manning
7fadbd9e86
Merge "Stash taskbar on swipe to go home for 3p fallback launcher." into tm-qpr-dev
2023-03-15 13:34:18 +00:00
Mike Schneider
a79d460736
Add optional debug logging to on flag changes
...
FlagDebugUtils.formatFlagChange() utility to always write the set of
updated flags, with a list of actual changes applied. Examples:
[allow_gesture|device_dozing] +[device_dozing]
[] -[state_started]
Additionally, moved the appendFlag utility to the new FlagDebugUtils
Test: manually verifed the output in logcat
Bug: 261418621
Change-Id: Ie4f2cfcd4b34f0a816db7845e1df4331babed07a
2023-03-15 13:36:18 +01:00
Nick Chameyev
87eda343f9
[Unfold animation] Restore clippings before clearing registered views
...
When launcher rotates during the fold/unfold animation
we clear views registered for the animation but we don't
restore the original clipping options that might be set.
This causes lost of the original property values
as the map that stores original values will store
updated values (after the animation preparation).
Bug: 273554726
Test: manual
Change-Id: I9c44a7ce4867ba0c3d6d1dca728d7c4cd3b378db
2023-03-15 11:12:01 +00:00
Bill Yi
11aa16757e
Import translations. DO NOT MERGE ANYWHERE
...
Auto-generated-cl: translation import
Change-Id: Ie3f75adb5fcdf1dddb8ce29d311d67e25c7fbe0b
2023-03-15 01:25:40 -07:00
Jon Miranda
ed68653443
Merge "Fix taskbar spring when going from home to overview." into tm-qpr-dev am: 35d4b6d250 am: 732c9d864a am: 603dc3f798
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22074947
Change-Id: I95fdde3584340d3aac2bd03704c92b86bdd14554
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-15 01:43:24 +00:00
Jon Miranda
603dc3f798
Merge "Fix taskbar spring when going from home to overview." into tm-qpr-dev am: 35d4b6d250 am: 732c9d864a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22074947
Change-Id: If1800be8c33b73ad4507532e87f388096f8a0726
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-15 00:18:28 +00:00
Jon Miranda
732c9d864a
Merge "Fix taskbar spring when going from home to overview." into tm-qpr-dev am: 35d4b6d250
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22074947
Change-Id: Ie5f18f89742e4c5ccd7d54fbf04d6a1883ac5e5f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-14 23:33:05 +00:00
Jon Miranda
35d4b6d250
Merge "Fix taskbar spring when going from home to overview." into tm-qpr-dev
2023-03-14 22:40:39 +00:00
Jeremy Sim
da75737d63
Revert "Revert "Create TAPL test suite for splitscreen""
...
This reverts commit 313a44039f .
Merging will reenable the TAPL suite TaplTestsSplitscreen.java, which was failing on phones due to a function call that only works on tablets.
Fixed by conditionally running the function only on tablet devices.
Fixes: 271852893
Test: Ran tests locally on phone and tablet.
Change-Id: If3e692924ed9c5ee113872e4f8ff0652890d1280
2023-03-14 15:36:32 -07:00
Pat Manning
df96bb0ed8
Merge "Scale using workspace width for handheld device on swiping from home to overview." into tm-qpr-dev am: 105d72b6ea am: 285121bddf am: ef2e9c51e3
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21958125
Change-Id: I99d6cb87321761d7c835623517f8b535460b6a3b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-14 21:26:23 +00:00
Vinit Nayak
40595ac4c0
Add debug logging for touch handling for all tests
...
* This information comes up often enough in test failures, good
to have at the outset to rule out obvious issues.
Bug: 270214626
Change-Id: Iee70fffed7a742565f41d8bf5aa38cdabefca3b4
2023-03-14 14:10:33 -07:00
Pat Manning
ef2e9c51e3
Merge "Scale using workspace width for handheld device on swiping from home to overview." into tm-qpr-dev am: 105d72b6ea am: 285121bddf
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21958125
Change-Id: I0852334fd194b2c5478d1945814731dfb3ba09a8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-14 20:20:42 +00:00
Pat Manning
285121bddf
Merge "Scale using workspace width for handheld device on swiping from home to overview." into tm-qpr-dev am: 105d72b6ea
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21958125
Change-Id: I86a3c8d0cfb6b258031669d8fb9e6b15a1fb2733
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-14 19:43:43 +00:00
Pat Manning
105d72b6ea
Merge "Scale using workspace width for handheld device on swiping from home to overview." into tm-qpr-dev
2023-03-14 19:13:31 +00:00
Jeremy Sim
c5cdf7f7a1
Merge "Fix two issues with splitting from Taskbar" into tm-qpr-dev am: b439c837d8 am: 0389929e5f am: 0529dbe41f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21966877
Change-Id: I089badd99119ea3990e7078c8a0fcc0be5e9a903
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-14 19:04:55 +00:00
Brian Isganitis
458c3aef29
Merge "Log when FLAG_STASHED_IN_APP_AUTO changes." into tm-qpr-dev am: 201a8f5ea3 am: c9905fed66 am: 7654a32a29
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21778876
Change-Id: I38f524341bcada333de36563b6771e2831d0b2b0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-14 19:02:53 +00:00
Jeremy Sim
0529dbe41f
Merge "Fix two issues with splitting from Taskbar" into tm-qpr-dev am: b439c837d8 am: 0389929e5f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21966877
Change-Id: I89e1057e9d11c22e06e3dd1bd42851d83fee06f5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-14 18:23:40 +00:00
Brian Isganitis
7654a32a29
Merge "Log when FLAG_STASHED_IN_APP_AUTO changes." into tm-qpr-dev am: 201a8f5ea3 am: c9905fed66
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21778876
Change-Id: I56f40e88f58630b919fc1231fc1b230074c186bc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-14 18:22:53 +00:00
Jeremy Sim
0389929e5f
Merge "Fix two issues with splitting from Taskbar" into tm-qpr-dev am: b439c837d8
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21966877
Change-Id: I0aa5b2f2ee81d12fb3f7157fa8406f96f62eda39
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-03-14 18:06:34 +00:00
Jon Miranda
f262cf989e
Fix taskbar spring when going from home to overview.
...
Bug: 246660243
Test: go home -> overview
Change-Id: Id49d8f7457940ce28684c0259ed1f204b9026609
2023-03-14 11:04:16 -07:00