Commit Graph

11894 Commits

Author SHA1 Message Date
Tony Wickham c35c6b8863 Nullify mParallelRunningAnim after it ends to avoid updating it
Keeping the stale reference after the animation ends is dangerous because if we call end() on it, it will jump to the now-obsolete end value.

Test: atest NexusLauncherTests:com.android.launcher3.memory.MemoryTests#testAppLaunchFromWorkspace
Bug: 193440212
Change-Id: I8ca45db7ceec2d6e6a9c6e69a6e0359fd73a7d27
2021-07-27 22:06:00 -10:00
Tony Wickham a18b090472 Merge "Don't recreate touch controllers when ending gesture" into sc-v2-dev am: 42fe934768 am: c910a3a02f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15388699

Change-Id: I9dbb78faf2ffe30f7af06a461c6ce927fc0b4143
2021-07-27 17:41:44 +00:00
Tony Wickham 42fe934768 Merge "Don't recreate touch controllers when ending gesture" into sc-v2-dev 2021-07-27 17:05:58 +00:00
TreeHugger Robot 4eb88802cb Merge "Overview - leave modal state on orientation changes." into sc-v2-dev am: 07e74119ee am: 48d050eeb3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15379173

Change-Id: Ie78145a46f21e9657976235ac5684d27d5a5ef27
2021-07-27 08:37:32 +00:00
TreeHugger Robot 07e74119ee Merge "Overview - leave modal state on orientation changes." into sc-v2-dev 2021-07-27 08:01:10 +00:00
Lucas Dupin 89fe4d07fb Merge "Request early wake-up when zooming" into sc-v2-dev am: d9713b2665 am: fd0803fc84
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15388815

Change-Id: I2e1bb17c707635d16b2e07b1a4a2204412cee34c
2021-07-26 22:36:34 +00:00
Lucas Dupin d9713b2665 Merge "Request early wake-up when zooming" into sc-v2-dev 2021-07-26 22:09:01 +00:00
Tracy Zhou d790ea1d28 Merge "Reset current task and dequeue overview commands when recents animation is cancelled" into sc-dev am: 024749a1e0 am: 4ea4ed5d05
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15365516

Change-Id: I384267e7f71be0908ec48d82270684a0219cffc0
2021-07-26 21:53:40 +00:00
Tracy Zhou cd8e798097 Merge "Reset current task and dequeue overview commands when recents animation is cancelled" into sc-dev am: 024749a1e0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15365516

Change-Id: I1f6bad994a472a678c3e4d099ab25138eb0e0a6b
2021-07-26 21:38:54 +00:00
Tracy Zhou 024749a1e0 Merge "Reset current task and dequeue overview commands when recents animation is cancelled" into sc-dev 2021-07-26 21:17:38 +00:00
Hongwei Wang 0e4473329c Check PiP permission before entering auto pip
Video: http://recall/-/aaaaaabFQoRHlzixHdtY/c9raN4jiaNqbiV7DF4YTJ6
Bug: 194272108
Test: try auto-enter-pip with permission disabled
Change-Id: I2c6112a299866744255b3cfe5c108fadfb2715af
2021-07-26 14:16:43 -07:00
TreeHugger Robot 288196cf15 Merge "Only set property state after back button instantiated" into sc-v2-dev am: f7602976e2 am: 909f00873d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15391625

Change-Id: Ie788a1703004377e9fc15e16e893096d301e4a04
2021-07-26 21:14:06 +00:00
TreeHugger Robot f7602976e2 Merge "Only set property state after back button instantiated" into sc-v2-dev 2021-07-26 20:55:08 +00:00
zakcohen 5b144ea31f Overview - leave modal state on orientation changes.
Bug: 194424293
Test: Local

Change-Id: I913dd5cb85aa1c52d79a8876a78a677a586da9c7
2021-07-26 13:51:47 -07:00
Tony Wickham 0e9ecaeea8 Don't recreate touch controllers when ending gesture
Test: swipe up to overview from an app and swipe up to dismiss it during the transition
Bug: 189700453
Change-Id: I303696f90dbb236ea93e06d94a3c92d783850fa4
2021-07-26 10:40:56 -10:00
Tracy Zhou 94e798bac1 Reset current task and dequeue overview commands when recents animation is cancelled
Fixes: 193925362
Test: manual
Change-Id: I792be003e5aabf34324075829d5381cba591892b
2021-07-26 12:17:01 -07:00
Vinit Nayak 1b3078258f Only set property state after back button instantiated
Fixes: 194374924
Test: Repro steps don't cause crash
Change-Id: I5ece220469f420d59698a56816057e248306fd32
2021-07-26 11:50:02 -07:00
Lucas Dupin 4a7acaed37 Request early wake-up when zooming
This way we'll be less likely to jank on 120Hz devices.

Test: manual
Fixes: 194680560
Change-Id: Ieff93f234701649514f8905c20c19cef231c816b
2021-07-26 11:19:39 -07:00
Alex Chau 38dad54d80 Add overviewShowAsGrid to DeviceProfile am: 646f804627 am: 989e308fcb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15390570

Change-Id: I0aa8ebd55ae03a68f52ce12ef3169ed4a5033eb5
2021-07-26 13:35:16 +00:00
Alex Chau 5fd9d491b0 Tune Overview size according to VisD
- Removed modalTransformY as overview actions no longer need to move in modal view
- Moved row spacing and page spacing to DeviceProfile
- Added several tablet / orientation specific DeviceProfile params

Bug: 194194694
Test: Manual
Change-Id: Id5435e7f6fc1b6fb7c0e55e55fa240cf84c4d6da
2021-07-26 12:01:30 +01:00
Alex Chau 646f804627 Add overviewShowAsGrid to DeviceProfile
- Simplified a lot of dp.isTablet && FeatureFlags.ENABLE_OVERVIEW_GRID.get() usage

Bug: 194194694
Test: manual
Change-Id: Idfb0ad192048106bbe6f8e2a28fa5613b86e5208
2021-07-26 11:59:34 +01:00
Jerry Chang 8242c1c924 Merge "Reset divider bar visibility after long pressing on taskbar" into sc-v2-dev am: 27ee995528 am: 010e769133
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15366815

Change-Id: Ib147a10c422bc3132ae0ca63ce7a2a25ef66adf2
2021-07-26 01:43:18 +00:00
Jerry Chang 27ee995528 Merge "Reset divider bar visibility after long pressing on taskbar" into sc-v2-dev 2021-07-26 01:13:21 +00:00
Sunny Goyal 6f6e219d5b Merge "Fixing touch events ignored in some cases" into sc-dev am: e0e64b4851 am: e7f9f3ee7c am: 6c1f77dd85
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15362818

Change-Id: I296e9c1222be2a5827e05a6c3fa44d47a8c43807
2021-07-23 22:59:41 +00:00
Sunny Goyal e7f9f3ee7c Merge "Fixing touch events ignored in some cases" into sc-dev am: e0e64b4851
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15362818

Change-Id: Ia2e97076a790bcd3e6c5bcbae79231bd1815f64a
2021-07-23 22:48:48 +00:00
TreeHugger Robot 46c2d41c79 Merge "Hide taskbar on lockscreen" into sc-v2-dev am: 61eb1fe0ac am: bb8e304ee6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15264051

Change-Id: I667a07fc780f01908e5646f09fe3b8c5c43910ef
2021-07-23 19:36:19 +00:00
TreeHugger Robot 61eb1fe0ac Merge "Hide taskbar on lockscreen" into sc-v2-dev 2021-07-23 19:01:26 +00:00
Alex Chau d3122f41a5 Merge "Avoid seeing ClearAllButton for overview grid's snap position" into sc-v2-dev am: f4afdc4167 am: aa0d699722
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15359119

Change-Id: I5453ca3a176d92bcdf5c77b4e0c0a531a91a8c5b
2021-07-23 11:57:01 +00:00
Alex Chau f4afdc4167 Merge "Avoid seeing ClearAllButton for overview grid's snap position" into sc-v2-dev 2021-07-23 11:27:27 +00:00
Jerry Chang f5ef75fd4d Reset divider bar visibility after long pressing on taskbar
Fix: 194164662
Test: enter stage split, long pressing on taskbar and observe
      the divider bar is visible.

Change-Id: I935283dd75442c47d4f3e8421943eea8e0f3cd7f
2021-07-23 02:38:40 +00:00
Sunny Goyal 58e81e5da1 Fixing touch events ignored in some cases
Bug: 160218103
Test: Manual
Change-Id: Ifa71e742451acecd8979a6833a202c6189b4df52
2021-07-22 15:27:43 -07:00
Ben Lin 1dbd5be25e Merge "PIP: Implement auto-rotate with gesture nav for Shell transitions." into sc-v2-dev am: 1800f916ad am: 8e9e07f484
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15331679

Change-Id: I0c07af5a7158db94667d559556025282b2b9e869
2021-07-22 21:51:27 +00:00
TreeHugger Robot 7e7f595719 Merge "Animate SplitPlaceholderView when entering split from overview" into sc-v2-dev am: f2af895b20 am: 092efed8d7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15081296

Change-Id: I6091d6c30f9392cb15566ef6eab00c57505bf0ef
2021-07-22 21:51:11 +00:00
Ben Lin 1800f916ad Merge "PIP: Implement auto-rotate with gesture nav for Shell transitions." into sc-v2-dev 2021-07-22 21:25:11 +00:00
TreeHugger Robot f2af895b20 Merge "Animate SplitPlaceholderView when entering split from overview" into sc-v2-dev 2021-07-22 21:17:35 +00:00
Vinit Nayak 2f4b18bada Hide taskbar on lockscreen
Add new animated float to disable taskbar
background value when keyguard is visible.

Fixes: 191857724
Test: Tested w/ and w/o bouncer for gesture + 3 button
Tested w/ IME pw on lock screen.

Change-Id: I2e1696fd25f4c170bfb2bc0694ccd644e453b1fe
2021-07-22 13:14:51 -07:00
Vinit Nayak 7903758d08 Animate SplitPlaceholderView when entering split from overview
Bugs tracked in b/181704764

Bug: 181704764
Test: Tested on phone and large screen in multiple orientations

Change-Id: I07509006ae3d1f4425dc5119d0c8ed52b41a3bc2
2021-07-22 20:12:26 +00:00
Jason Chang 12a0357c31 Merge "Fix unable to swipe up to exit one-handed mode under 2 button navigation" into sc-dev am: 1b3f5d3883
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15311532

Change-Id: I6459733abb399137224fe9c24ac7cdc63282dd9e
2021-07-22 16:54:17 +00:00
Alex Chau 41e77de54e Avoid seeing ClearAllButton for overview grid's snap position
- This is a follow-up of http://ag/15220572
- When determining if task's snap position is too close to ClearAllButton, avoid positions that will see part of ClearAllButton

Bug: 192254835
Test: manual
Change-Id: I09425075ff0c24835ac3c4e79856aef7985476b2
2021-07-22 16:14:15 +01:00
TreeHugger Robot 908a1ef10d Merge "Add null check for recents scaling during quick switch." into sc-v2-dev am: d32a472e5c am: 125ea48ce5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15358270

Change-Id: Ifd729f96f9f291a91901dfca33f51e54cf0bb72b
2021-07-22 11:04:10 +00:00
TreeHugger Robot d32a472e5c Merge "Add null check for recents scaling during quick switch." into sc-v2-dev 2021-07-22 10:28:50 +00:00
Jason Chang f4a1256c06 Merge "Fix unable to swipe up to exit one-handed mode under 2 button navigation" into sc-dev am: 1b3f5d3883 am: 0476be4a35
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15311532

Change-Id: Ideff92e3380a41b21aa307b3ab8ce4d28a3221c8
2021-07-22 10:24:20 +00:00
Jason Chang 1b3f5d3883 Merge "Fix unable to swipe up to exit one-handed mode under 2 button navigation" into sc-dev 2021-07-22 09:43:13 +00:00
Pat Manning b442aee4c4 Add null check for recents scaling during quick switch.
Test: manual - FallbackRecentsTest.goToOverviewFromHome and
StartLauncherViaGestureTests.testStressPressHome were previously failing
due to null mActivity in AbsSwipeUpHandler#getScaleProgressDueToScroll.
Bug: 192470757
Change-Id: I562171c22ad3c89e64b4dc853a266c8b8b78402c
2021-07-22 08:52:28 +00:00
TreeHugger Robot dae4d9f324 Merge "Scale recents during quick switch for large screens." into sc-v2-dev am: eb894b577a am: 07b974c8ad
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15337882

Change-Id: If6103f7dffc06002498dfbccf94b52746d824566
2021-07-21 21:47:02 +00:00
TreeHugger Robot eb894b577a Merge "Scale recents during quick switch for large screens." into sc-v2-dev 2021-07-21 21:35:12 +00:00
TreeHugger Robot 82a387fdf9 Merge "Reland "Move focused task to front when attaching RecentsView"" into sc-v2-dev am: 246b450f16 am: c42c711476
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15311704

Change-Id: I8cc1279039de4c8caf9ae09749512b518d9d9593
2021-07-21 20:35:44 +00:00
Brian Isganitis 0ce2954d2b Support overriding All Apps EDU animation on drag am: ec4a56a311 am: 419b61df54
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15349065

Change-Id: Ided55e5c6e6a14ec2dee8e1776f3973f48d757e4
2021-07-21 20:26:26 +00:00
Brian Isganitis a9b1814d42 Support overriding All Apps EDU animation on drag am: ec4a56a311
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15349065

Change-Id: Ie0caf9308989d8f3ba0b23ffb68b0157c5d2c22e
2021-07-21 20:15:33 +00:00
TreeHugger Robot 246b450f16 Merge "Reland "Move focused task to front when attaching RecentsView"" into sc-v2-dev 2021-07-21 20:08:41 +00:00