Commit Graph

4553 Commits

Author SHA1 Message Date
Tony Wickham a3daee40f3 Merge "Update kotlin formatting for TaskbarInsetsController" into main 2024-01-08 19:10:24 +00:00
Brandon Dayauon 4f673d2517 Merge "Increase predicted app row by 4dp to be same as SEARCH_RESULT_APP_ROW" into main 2024-01-08 18:00:05 +00:00
Brandon Dayauon 3dd0f12cad Increase predicted app row by 4dp to be same as SEARCH_RESULT_APP_ROW
Verified that there should be no jumping going on in the top app row between A-Z list and Toast.

bug: 312781931
Test: manual -video:
https://drive.google.com/file/d/11GX-5mVr5BoZY29IyX5FvrIA_yT57MOJ/view?usp=sharing
Flag: None

Change-Id: I5c35c04eb500f52780b0b77c542e0a861346a3fd
2024-01-05 17:09:23 -08:00
Tony Wickham 79f5536524 Update kotlin formatting for TaskbarInsetsController
Flag: none
Test: none
Bug: none
Change-Id: I2f83ce8bbbe89ac3fcee6f6b3c1100f387ddf76e
2024-01-06 00:42:08 +00:00
Jagrut Desai 21f3d770a0 Merge "Taskbar Pinning Animation Improvements" into main 2024-01-05 23:21:57 +00:00
Tony Wickham 8424eed91a Merge "Fix onIsStashedChanged() not called in 3 button mode" into main 2024-01-05 22:18:18 +00:00
Liran Binyamin fdc5c72aa1 Merge "Add a test for stashed bubble bar" into main 2024-01-05 21:19:19 +00:00
Jagrut Desai a3d3c06967 Taskbar Pinning Animation Improvements
Test: Manual
Bug: 312178646
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED

Change-Id: I708127be8301a61994168f780474c75be726815d
2024-01-05 12:12:12 -08:00
Tony Wickham 438e6c90af Fix onIsStashedChanged() not called in 3 button mode
Calling this ensures we update touchableRegion accordingly.

Since this will also start the stashed handle region sampling,
which we don't need for 3 button mode, also adjust logic to
check that the StashedHandleView is actually visible.

Flag: None
Test: Lock screen, run `adb shell cmd uimode night yes`, unlock
Test: Lock screen, rotate, unlock
  In both cases, verify touchableRegion is accurate
Fixes: 315393203
Change-Id: I951af6b97cad0ee0f362dc22f3996cfd9286a21e
2024-01-05 19:19:57 +00:00
Liran Binyamin 40c1b93aee Add a test for stashed bubble bar
This change introduces a new test protocol event for unstashing the bubble bar.

It's not possible to do this via a UI event because the stashed handle is only visible when an app is in the foreground, but in that state none of the elements in TaskbarDragLayer are visible to accessbility.

Flag: LEGACY persist.wm.debug.bubble_bar DISABLED
Bug: 273994695
Test: atest PlatformScenarioTests:android.platform.test.scenario.sysui.bubble.BubbleBarTest
Change-Id: I4581bf95b07691429966ecbd573232047f820b69
2024-01-05 08:49:27 -05:00
Sunny Goyal 1a8f804195 Merge "Removing ENABLE_CACHED_WIDGET since we now have always listenign widget" into main 2024-01-05 00:02:54 +00:00
Johannes Gallmann 852a70f994 Merge "Hide app icon during predictive back to home" into main 2024-01-04 19:39:05 +00:00
Tony Wickham 97e6c9c214 Merge "Fix KI in test and re-enable for postsubmit." into main 2024-01-04 17:50:35 +00:00
Sunny Goyal 4df719a1e6 Removing ENABLE_CACHED_WIDGET since we now have always listenign widget
> Also using PendingWidgetView for deferred widget view

Bug: 270395008
Flag: LEGACY ENABLE_CACHED_WIDGET enabled
Test: Exising widgets tests pass.
      Verified UI by forcefully rendering deferred widget

Change-Id: Id34f89d778f9f993c1b7ad13f66e57fda9843417
2024-01-04 09:26:10 -08:00
Jordan Silva 873d49937c Merge "Add ESCAPE key to dismiss Overview" into main 2024-01-04 14:12:28 +00:00
Jordan Silva 9878a7206e Add ESCAPE key to dismiss Overview
This CL adds the functionality of escape key to Overview. It dismisses Overview when the esc key is pressed.
When Overview is showing a Modal Task, it will return to Overview state instead of the Normal state.

Fix: 315283507
Flag: N/A
Test: TaplTestsQuickstep
Change-Id: I02e02f623d9a4aad1c2d6188fdea4e3fc4f96d64
2024-01-04 09:08:44 -03:00
Vinit Nayak e4b5ab6523 Merge "Null out launcher reference to prevent leak" into main 2024-01-04 00:59:28 +00:00
Tony Wickham c5d4e4dcf5 Fix KI in test and re-enable for postsubmit.
- The taskbar stashing logic with hardware keyboards was different
  between tests and user experience; aligned the test to be the
  same.
- There is still a previous test failure that only occurred in
  post submit, so also add ScreenRecord to diagnose it
- Once that is resolved, can promote the test to PRESUBMIT.

Test: testQuickSwitchToPreviousAppForTablet
Flag: NA
Fixes: 318544733
Bug: 314873201
Change-Id: Ia813eb0294d759c40d90cec7a8e9a7e0aea2d917
2024-01-03 23:27:18 +00:00
Vinit Nayak e363a611d2 Null out launcher reference to prevent leak
Bug: 314806687
Flag: None
Test: Enabled flag and played with taskbar/home transitions,
seemed fine

Change-Id: I86ab417eccf1fd6255195025890a1b93bf5d3bb4
2024-01-03 15:08:47 -08:00
Tracy Zhou e1c3332532 Merge "Correct contextual button width, height and touch area" into main 2024-01-03 21:11:24 +00:00
Helen Cheuk df20ea0ed4 Merge "Update BubbleTextView height to match parent so focus outline drawn could be fully displayed" into main 2024-01-03 18:38:29 +00:00
Jagrut Desai 39e4b611b5 Merge "Refactor TaskbarDividerPopup Open/close animation" into main 2024-01-03 17:00:52 +00:00
Johannes Gallmann 436b9939e3 Hide app icon during predictive back to home
Bug: 311337169
Flag: ACONFIG com.android.systemui.predictive_back_qs_dialog_anim DEVELOPMENT
Test: Manual, i.e. testing predictive back to home on device and verifying visually that app icon behaves correctly
Change-Id: I91491d91d004d81f4abc67c361c8824eba8dfdcd
2024-01-03 16:45:16 +01:00
helencheuk 2174b0ad2e Update BubbleTextView height to match parent so focus outline drawn could be fully displayed
Design doc: go/launcher-focus-outline
Before: BubbleTextView height is larger than its parent, outline is cropped
https://screenshot.googleplex.com/dYXjWAHS4VzPQdJ
After: BubbleTextView has the same height as its parent Prediction Row, outline is fully shown
https://screenshot.googleplex.com/3eMxPwxiHs9JTTq

Bug: 310953377
Test: Manual
Flag: ACONFIG com.android.launcher3.enable_focus_outline Development
Change-Id: I7bfa4da3b67b4a4abc4dfe9df560dda8d7e9b1bd
2024-01-03 12:14:25 +00:00
Tracy Zhou 650000f68f Correct contextual button width, height and touch area
Side note: this is unrelated to NearestTouchFrame

Bug: 313371759
Bug: 230395757
Test: https://screenshot.googleplex.com/6mF4ZPSob6z55Nh
Change-Id: I7e5217bef4b2cfb6d14d62d107e75b1267ffd2f4
2024-01-02 23:05:53 -08:00
Tracy Zhou 9742e603b5 Merge "Adjust the layout of nav buttons in 3 button mode with task bar / nav bar unification" into main 2024-01-03 00:12:56 +00:00
Jagrut Desai 25cb918a37 Refactor TaskbarDividerPopup Open/close animation
Test: Manual
Bug: 315848479
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED
Change-Id: I3c43bd718cef24ec334f7f4884167ecb2ce0cfd5
2024-01-02 15:25:42 -08:00
Tracy Zhou 5ad10ff6f6 Adjust the layout of nav buttons in 3 button mode with task bar / nav bar unification
In nav bar, we assign layout weight 0.25:0.5:1(for home but the content width of home is set to 80dp):0.5:0.25 with a LinearLayout. Since we use a FrameLayout for taskbar (to support both folded and unfolded task bar), in this change we are matching the layout by manually calculating the width of each section (since we are already manipulating like so in different layoutters)

Bug: 230395757
Test: https://screenshot.googleplex.com/3P6vDrgb6geqTUm
Change-Id: I6ba201477621f173e42c5211fcc68b24e3022122
2024-01-02 14:34:51 -08:00
Hyunyoung Song 0c2204dcbe Merge "Fixing UserHandle for AppTarget Event from Launcher." into main 2024-01-02 18:22:18 +00:00
Yunfan Chen 2c385bec7b Merge "Do not recreate taskbar due to unestimated bounds" into main 2023-12-28 11:09:16 +00:00
Jeremy Sim 227d3b79f3 Merge "Ignore taskbar launch request if app(s) are already running" into main 2023-12-21 07:00:27 +00:00
Yunfan Chen f00adbeb68 Do not recreate taskbar due to unestimated bounds
The change around configuration and display cutout to support flexible
display setup is making the received display info is not calculated as
the hard-coded way in taskbar. It will cause the taskbar recreated when
the device reaches a given rotation for the first time.

The recreation is not necessary as it is only a hint of taskbar's
estimation doesn't match the result. Block the recreation in that case
to avoid user visible animation issue.

Bug: 302387383
Test: Rotate a device with movable cutout and no recreation happens
Flag: ACONFIG com.android.window.flags.allows_screen_size_decoupled_from_status_bar_and_cutout TRUNKFOOD
Flag: ACONFIG com.android.window.flags.movable_cutout_configuration DEVELOPMENT
Change-Id: I1aa6add57ec49a49cc7473bfaada6d9212c1fc4b
2023-12-21 14:35:20 +09:00
Jeremy Sim 9a7b6f972b Ignore taskbar launch request if app(s) are already running
This CL fixes several issues:
- When launching an app pair on top of the exact same app pair, Overview no longer enters a broken state
- When launching another app quickly after launching an app pair, splitscreen no longer breaks

Fixes: 315190686
Test: Launch app pair and then launch same app pair again from Taskbar -- Overview does not break
Flag: ACONFIG com.android.wm.shell.enable_app_pairs DEVELOPMENT
Change-Id: I0d474dd89359e1a10a881c5cf8deee64754219c3
2023-12-21 10:13:20 +09:00
Shamali Patwa 716f982d44 Merge "Add long click listener to the widget picker activity" into main 2023-12-20 22:39:57 +00:00
Brian Isganitis 4227a72c94 Merge "Have meta key toggle Taskbar All Apps in freeform mode." into main 2023-12-20 21:00:01 +00:00
Pat Manning d842f5e573 Merge "Hide taskbar icons for IME when virtual keyboard is present." into main 2023-12-20 20:11:43 +00:00
Brian Isganitis 588b78e174 Have meta key toggle Taskbar All Apps in freeform mode.
Test: Manual
Fix: 315245851
Flag: NA
Change-Id: Ie72f2f48ed21e85fc3b3f707cfd91023ebe79a7c
2023-12-20 19:42:19 +00:00
Pat Manning 559434af5a Hide taskbar icons for IME when virtual keyboard is present.
Unless hardware keyboard is attached and taskbar is pinned.

Fix: 316270741
Bug: 255818649
Test: Manual. Using combinations of transient taskbar, virtual and hardware keyboards.
Flag: NONE
Change-Id: I1fae1655fc16b9fa951510cf834d2a33cb8956d8
2023-12-20 18:55:09 +00:00
Schneider Victor-tulias a7519cd0c6 Merge "Focus the first task in KQS when it is not currently running" into main 2023-12-20 14:58:18 +00:00
Shamali P 790d599d2a Add long click listener to the widget picker activity
The listener allows us to drag and drop widgets outside the launcher.

Bug: 315209740
Test: atest Launcher3Tests
Flag: NA

Change-Id: Iafc6e8903ea4f32540df30152b35d9eb7e98c6d6
2023-12-20 14:30:44 +00:00
Tony Wickham 054d953a0d Merge "Log app launches via taskbar drag and drop" into main 2023-12-19 16:17:21 +00:00
Schneider Victor-tulias 4044669a90 Focus the first task in KQS when it is not currently running
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 316004088
Test: TaplTestsKeyboardQuickSwitch
Change-Id: I8a91ca0dd32c6fc2352d285934a2c4f79ba1bb13
2023-12-19 10:48:40 -05:00
Himanshu Gupta ce2b013d31 Merge "Adding methods to access LauncherApps APIs." into main 2023-12-19 11:27:09 +00:00
Jeremy Sim 34aa1c5366 Merge "Fixes two bugs with findLastActiveTasksAndRunCallback()" into main 2023-12-19 02:08:54 +00:00
Tony Wickham 1a8cf0a9f6 Log app launches via taskbar drag and drop
- This also goes through the app predictions pipeline to update
  hotseat predictions

Fixes: 316940471
Test: Drag apps to split screen, ensure taskbar predictions update
      (also verify by logging AppPredictor#notifyAppTargetEvent)
Flag: None
Change-Id: I844414ecb56b4e36a2c94d913c1fb37abf056593
2023-12-18 23:30:59 +00:00
Himanshu Gupta 6c25654e84 Adding methods to access LauncherApps APIs.
These methods are added to ApiWrapper class
so that Launcher can acess these APIs.

Bug: 308054233
Test: Presubmit
Flag: ACONFIG com.android.launcher3.Flags.private_space_sys_apps_separation DEVELOPMENT
Change-Id: Ic2e64b38cc8b0d262d3f6e9614e2b3fceb9d82a0
2023-12-18 19:47:13 +00:00
Himanshu Gupta 314afce4f9 Fixing UserHandle for AppTarget Event from Launcher.
Currently, every non-foreground user AppTarget Event
is assigned the first userhandle present in the list
of UserProfiles cached with Launcher.
This causes issues when more than one profile is
present, as then appevents from either profiles are
indistinguishable.
This chane fixes that, based upon the recent fixes to
make Launcher and ItemInfo user profile aware.

Bug: 314124511
Test: Manual by clicking diff app targets
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space TEAMFOOD
Change-Id: I188c828eeeff9b617ddf9a75bccea9b9ab38e506
2023-12-18 19:10:23 +00:00
Liran Binyamin ca516b0249 Merge "Make BubbleBarView initially hidden" into main 2023-12-18 14:23:57 +00:00
Jeremy Sim 42a44d7984 Fixes two bugs with findLastActiveTasksAndRunCallback()
This CL changes findLastActiveTasksAndRunCallback to return a fixed array rather than an ArrayList.

1) This fixes a (minor) crash with app pairs, where we performed get(0) on an empty array when no running tasks were found.
2) This also fixes a live bug where app pairs would launch apps in the wrong order if app 1 was not found in running tasks, but app 2 was.

The function should be more robust now, preserving the indexing of the input keys.

Fixes: 316053131
Test: Clear all tasks from Overview, launch an app pair, launch succeeds
Flag: ACONFIG com.android.wm.shell.enable_app_pairs DEVELOPMENT
Change-Id: I51d8ba823a2ec57e9ecfeede956e0afce1d653f4
2023-12-18 11:39:33 +09:00
William Leshner c43435c063 Merge "Handle widget taps in WidgetPickerActivity." into main 2023-12-15 23:20:23 +00:00