Commit Graph

7784 Commits

Author SHA1 Message Date
TreeHugger Robot 971a476cb7 Merge "WallpaperManagerCompat: correct build version check" into ub-launcher3-edmonton 2018-04-18 19:01:48 +00:00
TreeHugger Robot 58253eaac8 Merge "Introducing Clear-all button on Overview" into ub-launcher3-edmonton 2018-04-18 18:56:28 +00:00
Jon Miranda 596d7f135d WallpaperManagerCompat: correct build version check
WallpaperManagerCompatVOMR1 is targeting API 27 (O MR1), but the
api guard is checking, if we are running API 26 (O) or above.

Correct the check to prevent using unavailable Wallpaper APIs.

Change-Id: I83cceee8eb61b2d74e647d473d7d560d00be14d3
(cherry picked from commit Iaf510bb79010e640db04adbbc2ee44de9abd6913)
Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
2018-04-18 11:45:13 -07:00
Vadim Tryshev 6d2321cb7d Introducing Clear-all button on Overview
It’s an initial implementation, i.e. no fancy effects.
It shares a parent (LauncherRecentsViewContainer) with RecentsView.
The button is centered in clear_all_button_container, which gets
positioned programmatically to the right of the last task. (RTL polish
will be a separate CL as well).

Bug: 72222505
Change-Id: Ia912908a93a30c2f51450ccf0f97c7495e7916d5
Test: Manual
2018-04-18 11:33:21 -07:00
Tony Wickham 5c3706c22a Merge "Make sure notification listener stays unbound on reboot when badging disabled" into ub-launcher3-edmonton 2018-04-18 17:12:06 +00:00
Tracy Zhou b67e35337b Reset PIP position when canceling swipe up
onStop() is a confirmed signal of user leaving Launcher. In most use
cases, we use onUserLeaveHint() to move PIP. However, in some cases,
onUserLeaveHint() does not get triggered. It's still a good signal for
those use cases because it happens sooner than onStop() and is not
interrupted by focus change. In order to address cases that
onUserLeaveHint() is not triggered (e.g. cancelling swipe up), onStop()
pushes PIP to the right position. In other cases, we simply set it
twice, which does not hurt.

Change-Id: Ia206590d10d673b16196bbab927a24aaae3ba46b
Fixes: 77648293
Test: manual test
2018-04-17 23:45:47 -07:00
Tony 7aa922c912 Make sure notification listener stays unbound on reboot when badging disabled
We were requesting unbind in onCreate(), but the NotificationListenerService
documentation for requestUnbind() clearly states "The service should wait for the
{@link #onListenerConnected()} event before performing this operation. I know it's
tempting, but you must wait." I was tempted, and I did not wait. :(

The fact that the notification listener was binding even though the setting was off
was not only inefficient, but also had at least one user-visible bug: because
secure settings are set per user, the global badging setting actually only applies
canShowBadge = false for user 0; other users such as work profile still show badges.

Repro steps:
1. Have a work profile
2. Get a notification on work profile app and normal app
3. Turn off global badging setting ("Allow notification dots" from home settings)
4. Reboot the device

In this case, we get onCreate, call requestUnbind() which is ignored since we aren't
bound, then get onBind() and onListenerConnected() etc. Thus the work profile app has
a notification dot and other apps don't.

Bug: 71545493
Change-Id: I7f7dc219b25c28257f8b98fba7e362b99d3cba45
2018-04-17 18:54:10 -07:00
Sunny Goyal ed7a6937cb Unifying and maintaining the text-alpha and text visibility property
Bug: 76228194
Change-Id: I70be5f9fd22c53864a9a0308f256baa7dc1f3ab7
2018-04-17 20:08:10 +00:00
Sunny Goyal de967a2355 Disabling alpha layer on some views
Change-Id: Ide1d5951ea80080f8fea8f32a76487b646b4f958
(cherry picked from commit 2020b20cd9)
2018-04-17 20:01:31 +00:00
Vadim Tryshev a2adac6a91 Removing accessibility description from page indicators
The current page is announced upon switching to it.
Is should be done this way for all future page implementations with
indicators.

Bug: 77827828
Change-Id: I8ba3bd9d068954df51d6de45da79133ede12c96d
Test: Manual
Merged-In: I8f2f163a261dd7098939674d39e014236fc66d5d
2018-04-17 19:52:18 +00:00
Sunny Goyal 3483c52e6b Waiting until onResume before creating the wallpaper-open animation.
Bug: 77853906
Change-Id: I5126855492da59c9dbfef0ce2a97f94662a6522b
2018-04-16 13:01:57 -07:00
TreeHugger Robot 4107c4310a Merge "a11y: disabling accessibility scrolling of the home screen" into ub-launcher3-master 2018-04-13 18:37:57 +00:00
Tony Wickham 00f9712cdd Merge "Ignore null notifications" into ub-launcher3-master 2018-04-13 18:12:05 +00:00
Tony Wickham a6f5869d8f Ignore null notifications
There seems to be an edge case where we can get a null notification in
onNotificationRemoved(); there's nothing actionable about that, so just
ignore it to prevent NPE. Also add null check to onNotificationPosted()
for good measure.

Bug: 69140873
Change-Id: I3586bf435d05aee38b99dffd3d01315b433e8476
2018-04-13 10:57:09 -07:00
Tony Wickham 035a20dee1 Merge "Don't show back button when discovery bounce is playing" into ub-launcher3-master 2018-04-13 17:27:37 +00:00
Tony Wickham df1eb8bb86 Don't show back button when discovery bounce is playing
Bug: 74766552
Change-Id: Ib3b514f4a2bfaa8593b82cd5acb16f02dd09dcc7
2018-04-12 17:26:18 -07:00
Sunny Goyal d754dcd5d9 Only skip the animation, if we are going to the same state
Bug: 77487950
Change-Id: I2d3e376094b0fb0d3120ab6c4d6569f52ab8273f
2018-04-12 14:17:06 -07:00
Sunny Goyal 2998e43256 Merge "Listen for cases where touch controllers change, and update them" into ub-launcher3-master 2018-04-12 00:37:22 +00:00
Tony Wickham a006830f0a Listen for cases where touch controllers change, and update them
Otherwise we'd be stuck using the old touch controllers until DragLayer
is setup again (e.g. launcher is killed).

Bug: 77921826
Change-Id: I8aac6fc453839902cb2d99279a6bd1549ee17d79
2018-04-11 17:25:40 -07:00
Sunny Goyal 7eff40ff2d Several app transition fixes:
> If launcher already started, creating the state transition only after threshold crossed, so that previous animations are not cancelled
> Not posting animaiton callbacks at the front of the queue, as that sometimes causes it get executed before onNewIntent
> Farking the activity as forceInvisible while launching an opaque app, so that quickly pressing home/back runs the reverse animation
> Not running state animations when force-invisible is true

Bug: 77830325
Bug: 77898806
Change-Id: I50a7e915ca35fd6aeb284c8f321ecca74396fe98
2018-04-11 17:08:31 -07:00
TreeHugger Robot e9f31c1014 Merge "Using correct window bounds in multi-window for fallback activity" into ub-launcher3-master 2018-04-11 23:59:16 +00:00
Sunny Goyal 3477804c72 Using correct window bounds in multi-window for fallback activity
Also fixing a bug where insets were not updated when recreating deviceprofile

Bug: 77875376
Change-Id: I7806cf949da415ef171ccf2f4ab3e8f2b7606220
2018-04-11 16:43:18 -07:00
Winson Chung 2cb5bddd1c Merge "Reload the task list when multiwindow mode changes" into ub-launcher3-master 2018-04-11 23:32:29 +00:00
Vadim Tryshev 52b2b43c56 a11y: disabling accessibility scrolling of the home screen
Bug: 77914605
Test: Manual
Change-Id: I5dcfe7479d7239b1f66bd2e805a1aa8978f5ca5b
2018-04-11 13:43:36 -07:00
Winson Chung 1a77c3dce1 Reload the task list when multiwindow mode changes
Bug: 73097187
Change-Id: I05d8635f78451600cbb8a9c03515e60d3c32e1ae
2018-04-11 13:26:21 -07:00
Vadim Tryshev eeaa8ee6c2 a11y: disabling animation for task list swipes
Bug: 77632611
Test: Manual
Change-Id: Ibbfba5f3219d63a5604544eea33422ee91f54c01
2018-04-11 12:23:42 -07:00
Sunny Goyal 82d2074cd2 Merge "Do not reset the previous state animation, if it is a part of the new state animaiton" into ub-launcher3-master 2018-04-10 03:02:02 +00:00
Tony Wickham 97b658f289 Merge "Can now swipe away to dismiss second task" into ub-launcher3-master 2018-04-10 00:13:05 +00:00
Sunny Goyal b35f50cf55 Do not reset the previous state animation, if it is a part of the new state animaiton
Change-Id: Ic433db8cd2b0701923185d0a2db2a4361567437f
2018-04-09 16:31:12 -07:00
Matthew Ng f0f00b30b8 Check for eng build as a debug build
Test: compile with eng lunch and see if you get debug settings
Change-Id: If94c4d49b5fb12cd46d51197e0a60ea6d0b0a01e
2018-04-09 16:20:42 -07:00
Tony Wickham 52c7b8c6ac Can now swipe away to dismiss second task
Previously we only allowed dragging the forefront task. Now you can
swipe up to dismiss the second task as well, but can't drag it down to
launch.

Also cleaned up page-scroll-while-dismissing logic to ensure it works
correctly in RTL and for new cases with dismissing adjacent pages.

Bug: 73187449
Change-Id: I1fe873c4cf1380b951dd3b2e396ab401ca1f7470
2018-04-09 16:04:21 -07:00
TreeHugger Robot a4e8763d11 Merge "Updating the card size logic" into ub-launcher3-master 2018-04-09 17:20:31 +00:00
Tony Wickham 9ae484b95d Merge "Log dismissing or launching recent tasks" into ub-launcher3-master 2018-04-06 22:55:50 +00:00
Tony Wickham 3541ac10a1 Merge "When dragging past first or last state, don't reinit target" into ub-launcher3-master 2018-04-06 22:51:06 +00:00
Tony Wickham 9bd862e588 Log dismissing or launching recent tasks
We now pass the log action (e.g. SWIPE or FLING) to the pending
animation, so that the end listener can log appropriately. This
is used when swiping down or up on a task, for example.

Bug: 73783784
Change-Id: I5c2eee24e8b23cf4af68d503d3435a6d8088dd8a
2018-04-06 15:41:39 -07:00
Tony Wickham 6270a0ea18 When dragging past first or last state, don't reinit target
Example bug:
1. Swipe up to overview and let go
2. Swipe all the way to the top of the screen, past where all apps stops
3. Swipe down

Before this change, you get reset in NORMAL state instead of OVERVIEW.

By ensuring that getTargetState() checks the drag direction before
returning a new state, we guarantee we only re-init in the case that the
state is actually changing. Otherwise it's possible to change the state
to one that is impossible, such as NORMAL when swiping up from ALL APPS.

Change-Id: I19913dded9c94228d06289780b6400e99403f378
2018-04-06 14:32:18 -07:00
Sunny Goyal d792a77234 Updating the card size logic
In full screen always follow the device aspect ratio
In multi-window, follow the 1:1 split window size
Rotate the screen shot only in full-screen mode

Bug: 70289009
Change-Id: Id5095565634d4d7920fefa929b28276db80bda5f
2018-04-06 11:29:32 -07:00
Jonathan Miranda 80be805996 Merge "Fix bug where BTV text alpha stays 0 when PopupContainer closed w/o animation." into ub-launcher3-master 2018-04-06 16:30:43 +00:00
Mario Bertschler d39148afb0 Adding FLAG_ICON_BADGED and check flag in DragView.getBadge.
Bug: 77634973
Change-Id: I0e398bea7aa86246616e37bbd76f0936facb83ba
2018-04-06 08:15:28 +02:00
Jon Miranda 0fd7c6c9da Fix bug where BTV text alpha stays 0 when PopupContainer closed w/o animation.
Bug: 77565147
Change-Id: I71501c7a65369386efcb7b1a36f19b117e119ed9
2018-04-05 15:23:41 -07:00
Sunny Goyal ca90706994 Merge "Simplifying fallback recents animation" into ub-launcher3-master 2018-04-05 21:31:14 +00:00
Sunny Goyal 9054843a1f Simplifying fallback recents animation
Instead of using WindowTransformSwipeHandler, keeping the launcher UI in place and
just animating the window

Change-Id: I4defce3a9745407523de651aeb28a37867567507
2018-04-05 13:51:21 -07:00
Tony Wickham c51493d281 Don't let touches go through popup when notification is present
Bug: 76139059
Change-Id: I7d39fbeb60e871eeadedb8a3ee1ef81dc4e2f47e
2018-04-05 12:07:08 -07:00
TreeHugger Robot 5c7e6c258e Merge "Close options popup when rebinding launcher." into ub-launcher3-master 2018-04-05 18:47:54 +00:00
Jon Miranda fcb7e19f67 Close options popup when rebinding launcher.
Bug: 77582012
Change-Id: I6707ca526c8c934f56b227288d2cbea7139ac41d
2018-04-05 11:32:41 -07:00
TreeHugger Robot f54a8f345b Merge "Avoid duplicate accessibility announcement upon switching to -1st page" into ub-launcher3-master 2018-04-05 18:02:25 +00:00
Vadim Tryshev 2c430b34cb Avoid duplicate accessibility announcement upon switching to -1st page
Since -1st window already has accessible description, no need to
announce "Page X of Y" for it.

Bug: 74210311
Test: Manual
Change-Id: I5cbfd763778b5f7049be732a750df4501b5419e0
2018-04-05 10:53:08 -07:00
TreeHugger Robot e976ca950b Merge "Fix animations home" into ub-launcher3-master 2018-04-04 22:02:14 +00:00
Tony Wickham 81839b86b2 Merge "Change overview animation to scale instead of translationX" into ub-launcher3-master 2018-04-04 21:40:15 +00:00
Winson Chung 9800e730a2 Fix animations home
- To prevent surface thrashing, we no longer hide the home activity before
  starting the transition home. This prevents the launcher from being added
  to the remote animation target list, which means that we default to
  skipping the launcher animation. As a workaround, we special case the
  flow and force the animation to run when starting the recents animation.

Bug: 74405472
Test: Go home from an app, ensure there is an animation.
Change-Id: Ifd2b39444fdeab323ee79a368b580a6264c3e5b9
2018-04-04 14:36:40 -07:00