ab1dc752e8
Make sure the hotseat icons are always visible in phone mode
...
With task bar in unfolded state, we animate from app to home by morphing the task bar into the hotseat. In the folded state, the visibility of the hotseat should never be affected by the task bar state.
Fixes: 309477352
Test: Swipe up from app in folded state with task bar / nav bar unification flag on, make sure that the transition is smooth and the hotseat is always visible. Also make sure unfolded state works as usual.
Change-Id: I1064a0c03e8f7539f8ea4d0322f58be9dff8513e
2023-11-11 07:46:30 +00:00
2d545b5c45
[automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: a2f83ad671 -s ours am: f20eeaa820 -s ours
...
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25332226
Change-Id: Ie463a7d7ddefd59c07b37b9b89d7efa9da4f86cf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-11-11 04:57:09 +00:00
f20eeaa820
[automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: a2f83ad671 -s ours
...
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25332226
Change-Id: I7087bdcb6e8b5606e2a01e46859f9ed3406d07c8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-11-11 04:28:54 +00:00
aecbc650fc
Merge "Disabling strict activity leak check more aggressively than in ag/25340909" into main
2023-11-11 02:26:06 +00:00
4c2bf22c8d
Merge "Demoting a couple of presubmit blocker tests" into main
2023-11-11 00:53:21 +00:00
94cb915d38
Disabling strict activity leak check more aggressively than in ag/25340909
...
That CL wasn't sufficient, still seeing:
https://android-build.corp.google.com/test_investigate/?blocking=warning&invocationId=I37300010216048087&status=none&testResultId=TR78329041431354974
Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I36979a8929ccb996b81e8d41ec75b9713258c1c3
2023-11-10 16:41:42 -08:00
dcead30d1e
Merge "Disabling strict activity leak check" into main
2023-11-11 00:35:33 +00:00
761b735728
Demoting a couple of presubmit blocker tests
...
Bug: 310242894
Test: presubmit
Flag: N/A
Change-Id: Ifd4dd430dbb645b5ab066742dd3ec861de3dfffa
2023-11-10 15:14:04 -08:00
7df94cca65
Disabling strict activity leak check
...
Started seeing presubmit blockers like:
https://android-build.corp.google.com/test_investigate/?invocationId=I51800010216065294&testResultId=TR60829041305611993
Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: Ic88f67e54d2dec4b244784abd2a15fbdfdf9e711
2023-11-10 15:04:46 -08:00
c3909d970b
Merge "[Tiger] Re-adding PlatinumTest annotation" into main
2023-11-10 21:56:12 +00:00
0edcdb2943
Merge "Import translations. DO NOT MERGE ANYWHERE" into main
2023-11-10 21:15:38 +00:00
72cef203b2
Merge "Import translations. DO NOT MERGE ANYWHERE" into main
2023-11-10 21:15:38 +00:00
1f8ff66235
Making killing setup wizard a permanent solution
...
It will be killed only in presubmit. In postsubmit, we want to be a true
e2e test exposed to all actual problems, including setup wizard that
doesn't go away.
Bug: 309471958
Test: presubmit
Flag: N/A
Change-Id: I2e877eade060e75e277eb3603d90b659207b5a47
2023-11-10 12:20:45 -08:00
1d3035e024
Prevent widgets from entering split
...
Bug: 296502210
Test: Manual
Flag: ACONFIG com.android.wm.shell.enable_split_contextual DEVELOPMENT
Change-Id: I1a166f6ca0fe5fd2fa1d29b97b8856e52985e0c1
2023-11-10 12:17:12 -08:00
d315ffcb8f
Merge "Increasing wait time for Launcher restart after enabling test provider" into main
2023-11-10 19:58:20 +00:00
a333756f0c
Increasing wait time for Launcher restart after enabling test provider
...
Of the the logcats indicates that Launcher gets killed eventually, but
it takes 17 sec, while the test waits for the Launcher restart to
compete in 10 sec.
Perhaps restart take longer than usual because the system is still busy
killing setup wizard.
Bug: 308489613
Test: presubmit
Flag: N/A
Change-Id: Idd576cacc300bce071bb40743209b4a111f18473
2023-11-10 10:31:14 -08:00
da5baa981a
Merge "Fix focus nav of AllApps when Searching." into main
2023-11-10 18:20:01 +00:00
dc165fcf90
Fix RTL issue with TaskbarDividerPopupMenu
...
Test: Presubmit, Manual
Bug: 310217447
Flag: LEGACY ENABLE_TASKBAR_PINNING TEAMFOOD
Change-Id: I00a9088274ee6716250da7f6c79caf6820955803
2023-11-10 09:50:25 -08:00
1ab8da20f5
Fix RTL issue with all apps meta icon
...
Test: Presubmit, Manual
Bug: 309453796
Flag: NONE
Change-Id: I5d8bda2c48a0815d7005a0727f67f871f75d4f0f
2023-11-10 09:44:51 -08:00
e7cb65009e
Fix focus nav of AllApps when Searching.
...
- Do not focus the Icon in Small Icon Result Rows
- Use FocusIndicatorHelper when focusing search result icons
Flag: NONE
Bug: 296844600
Fix: 310173226
Test: Test: TaplKeyboardFocusTest
Change-Id: Icfc82ae41ffc8ef7c7ad42950f98f3d2dc805795
2023-11-10 16:48:21 +00:00
9bb62ee9c1
[Tiger] Re-adding PlatinumTest annotation
...
This undoes ag/24559527 as this test is no longer flaky.
Actual PlatinumTest presubmit restoration is done in cl/581071347
Bug: b/293944634
Flag: N/A
Test: Test only change
Change-Id: I605f8911fa3a3658c49642efee8d6166545ae89b
2023-11-10 01:37:15 +00:00
edf4826a63
Import translations. DO NOT MERGE ANYWHERE
...
Auto-generated-cl: translation import
Change-Id: I6a7c7c137d375c77c1660371634aa0aa8ccc003f
2023-11-09 16:39:37 -08:00
a2f83ad671
Import translations. DO NOT MERGE ANYWHERE
...
Auto-generated-cl: translation import
Change-Id: I3bcae008c01d30b84a9c1edb9fbd73c7bb832d47
2023-11-09 16:38:38 -08:00
4dec607fec
Import translations. DO NOT MERGE ANYWHERE
...
Auto-generated-cl: translation import
Change-Id: Idf14fea5b132a4871252134e07263e7dd51feccd
2023-11-09 16:38:08 -08:00
90dd098c85
Migrate ENABLE_TASKBAR_PINNING to aconfig flag
...
Test: Manual, Presubmit
Bug: 265437087
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED
Change-Id: I4800230c04feceefa2398e189c493c8c4a7b2fe5
2023-11-09 23:20:03 +00:00
af4f41b9dc
Merge "Hide overlay if the overlay was shown when Meta key is tapped." into main
2023-11-09 22:14:41 +00:00
8f7986abae
Responsive grid cleanup
...
This CL renames some of the variables to keep it consistent across the code. It removes workarounds that were made to facilitate easy code reviews without breaking the tests.
It is a cleanup of the responsive grid feature.
Bug: 299889733
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: CalculatedAllAppsSpecTest
Test: CalculatedFolderSpecTest
Test: CalculatedHotseatSpecTest
Test: CalculatedWorkspaceSpecTest
Test: AllAppsSpecsTest
Test: FolderSpecTest
Test: HotseatSpecsTest
Test: WorkspaceSpecsTest
Change-Id: I198fadfbcfc0d1b32a62a3076949b42ee1fbcf33
2023-11-09 22:06:03 +00:00
f30a048141
Merge "Create privateSpaceAnimation Flag" into main
2023-11-09 20:43:34 +00:00
767d484b27
Merge "Resize icon and text size for AllApps when it doesn't fit the cell" into main
2023-11-09 20:24:38 +00:00
d66d114944
Merge "Make enableTaskbarNoRecreate() depend on ENABLE_TASKBAR_PINNING and ENABLE_TASKBAR_NAVBAR_UNIFICATION" into main
2023-11-09 18:47:59 +00:00
f7f607109b
Create privateSpaceAnimation Flag
...
bug: 299294792
Test: Presubmit
Flag: ACONFIG com.android.launcher3.private_space_animation DEVELOPMENT
Change-Id: I8a5bd4f436e98a69d82cff1eb3efcf6b2c616a34
2023-11-09 10:24:37 -08:00
b2cb1f87b7
Merge "Folder preview work badge theming fix" into main
2023-11-09 17:35:48 +00:00
583e48d915
Merge "Adding insets to prevent back gesture from triggering status bar" into main
2023-11-09 16:44:05 +00:00
8e1e2a5155
Merge "Use instrumentation arg to prevent unnecessary delays in unit tests" into main
2023-11-09 16:03:20 +00:00
b5d08b246e
Use instrumentation arg to prevent unnecessary delays in unit tests
...
Bug: 308792359
Flag: NA
Test: presubmits passing
Change-Id: Ib38db86057998fcf859a44fa190e6cc4d82263dd
2023-11-09 12:07:18 +00:00
100b77e667
Merge "Translucent apps are kept in Recents while in the foreground" into main
2023-11-09 11:30:29 +00:00
99349f0819
[automerger skipped] [DO NOT MERGE] Change the LPNH flag to read from server flag "ENABLE_LONG_PRESS_NAV_HANDLE_MPR". am: 75183ceed5 am: 0b780abf31 -s ours
...
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25303662
Change-Id: I28e653e4f65a2bca925196e93c169f29bc46727a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-11-09 07:52:44 +00:00
0b780abf31
[DO NOT MERGE] Change the LPNH flag to read from server flag "ENABLE_LONG_PRESS_NAV_HANDLE_MPR". am: 75183ceed5
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25303662
Change-Id: I9ef5d303c1c0ed30a02e56e039699de44307201c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-11-09 07:10:52 +00:00
6c2681049c
Merge "Update PipContentOverlay usage" into main
2023-11-09 03:41:43 +00:00
572b5b09fd
Merge "Allowing ACTION_CANCEL events to come from device 0" into main
2023-11-09 01:42:16 +00:00
fd13b2c650
Merge "Demoting a couple of flaking tests from presubmit" into main
2023-11-09 01:40:36 +00:00
a3f581d733
Merge "Diagnosing when Launcher is in invalid state" into main
2023-11-09 01:40:03 +00:00
b736982bab
Hide overlay if the overlay was shown when Meta key is tapped.
...
Before fix : https://b.corp.google.com/issues/300492676#comment13
When Meta key is tapped in -1 screen, the toggleAllAppsFromIntent is called and
AllApps Drawer is shown in home screen. But the user is still in -1 screen.
After fix: https://b.corp.google.com/issues/300492676#comment15
When meta key is tapped in -1 screen, we hide -1 screen and transition
to 0 screen and then show AllAppsDrawer.
Bug: 300492676
Test: Manual, https://b.corp.google.com/issues/300492676#comment15
Flag: NA
Change-Id: I1234e4defdd0b53be35271b9f7567b0719eec7ac
2023-11-08 17:08:57 -08:00
75183ceed5
[DO NOT MERGE] Change the LPNH flag to read from server flag "ENABLE_LONG_PRESS_NAV_HANDLE_MPR".
...
Flag: ENABLE_LONG_PRESS_NAV_HANDLE_MPR
Test: Manual
Bug: 309689303
Change-Id: Ib695b3d6ac3f40ee53b6b64bb6b121e7b34d4b07
2023-11-08 23:43:49 +00:00
640e65888c
Adding insets to prevent back gesture from triggering status bar
...
Flag: NONE
Test: Built locally verified back gesture doesn't trigger status bar
Bug: 279252552
Change-Id: I3ad325b1937b5f26278354bc8cef0c94066eed25
2023-11-08 14:53:15 -08:00
f2d7be1cec
Make enableTaskbarNoRecreate() depend on ENABLE_TASKBAR_PINNING and ENABLE_TASKBAR_NAVBAR_UNIFICATION
...
We want to turn on the flag when either of the dependent features is on
Bug: 299193589
Test: N/A
Change-Id: I7b48ff2be0cf9da3b6bc00d75370fa585ce4140d
2023-11-08 14:52:58 -08:00
913f6f6767
Remove TaplTestsQuickstep tests from PlatinumTest Part2
...
Test: Presubmit
Bug: 303256981
Flag: NONE
Change-Id: If6b6ff6a495da8d079ad4080bfe373f368904ae0
2023-11-08 22:47:38 +00:00
7030216f48
Refactor/clean up Overview Actions buttons
...
Since the number of Overview actions is growing, this patch factors out the button hiding logic so it's not all handled in OverviewActionsView.
Also, since splitscreen can now be carried out on Taskbar targets, the split button is no longer ever disabled (only hidden), so removed unused code for that.
Bug: 274835596
Test: Manual
Flag: NA
Change-Id: Icacdee6d0e6071ccb400dfc25a84572e7e9ce772
2023-11-08 13:43:19 -08:00
7a1beb559f
Allowing ACTION_CANCEL events to come from device 0
...
Tests assert that input events come to Launcher only from tests, which
sets deviceId to 0. This way, we spot when a cable touches a lab device
and breaks the tests, in which case deviceId will be != -1.
But CANCEL event, which is programmatic, now can legitimately come from
device 0.
Bug: 308489875
Test: presubmit
Flag: N/A
Change-Id: I84ee9ed8e008043f83e82d57b17b64a10677ee8d
2023-11-08 13:20:57 -08:00
1e360c1a92
Folder preview work badge theming fix
...
Currently the preview apps in a folder icon have the work badge with theming even when themed icons is off
Fix: 306665193
Test: Verify that folder with work icons has non-themed work badge when themed icons is off
Flag: NONE
Change-Id: I78ca7cb2361f6e590742fa64c88397d1ea80be68
2023-11-08 12:30:58 -08:00
Tracy Zhou
Bill Yi
Vadim Tryshev
Kevin Lim
Vinit Nayak
Pat Manning
Jagrut Desai
Anushree Ganjam
Jordan Silva
Brandon Dayauon
Federico Baron
Randy Pfohl
Uwais Ashraf
Andreas Agvard
Chris Li
Jeremy Sim