Commit Graph

76729 Commits

Author SHA1 Message Date
Treehugger Robot fb133bdb69 Merge "Allow DeviceProfile tests to run on TreeHugger Robolectric device" into main 2024-06-04 12:28:42 +00:00
Uwais Ashraf 801563328a Allow DeviceProfile tests to run on TreeHugger Robolectric device
Bug: 325088842
Test: Presubmit passes
Flag: EXEMPT test-only
Change-Id: Id2856b2016b2e1ba467c7b8e830631f5253d6b8c
2024-06-04 11:03:34 +00:00
Jordan Silva 11afae1bc9 Adding logs to monitor OverviewCommandHelper
This CL adds some logs to help analyzing why recents button with 3 button navigation sometimes don't open Overview.

Bug: 337954957
Test: NONE
Flag: EXEMPT Adding logs to debug issue
Change-Id: I44a799319eca667b04d4e78a38ade796fc3b69fb
2024-06-04 11:16:01 +01:00
Bill Yi b748c8e6ee Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I7d47742f878876e358fec1130708bae36149f801
2024-06-03 18:20:44 -07:00
Bill Yi 4ff619a610 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I4e0f4e61a5e6957bd6d52ede541d1dfe0523ab74
2024-06-03 18:20:15 -07:00
Fengjiang Li 0ebe6524f5 Merge "Animate -1 to recents" into main 2024-06-04 01:08:48 +00:00
Liam, Lee Pong Lam e48009919d [Launcher3] Hide keyboard when fastscroller scrolling down and keyboard
shown

Implement keyboard hiding logic: Hide keyboard when scrolling down (y > mLastY) unless already requested (mRequestedHideKeyboard). Track hide request state to prevent redundant calls.

New added logic: Only hide keyobard while dragging the scrollbar

result video: https://photos.app.goo.gl/e4dYUUiUN3BujNUz9

Bug: 333967597
Flag: EXEMPT bugfix
Test: Manual
Change-Id: Id672763c69cbb37aeb7a1fd3f17eb168de9f49b4
2024-06-04 00:43:30 +00:00
Liam Lee Pong Lam 61ac47e675 Merge "Revert "[Launcher3] Hide keyboard when fastscroller scrolling down and keyboard"" into main 2024-06-04 00:25:19 +00:00
Tony Wickham be10c0b10c Add flag for Recents in Taskbar
Flag: com.android.launcher3.enable_recents_in_taskbar
Test: none
Bug: 315354060
Change-Id: I5b757558ab8e5905b4142146901b68f55d0c7ef8
2024-06-03 21:12:46 +00:00
Schneider Victor-tulias 38b9e1438e Merge "Clean up unused debug logs for b/319168409" into main 2024-06-03 20:31:42 +00:00
Uwais Ashraf 000aaf649b Merge "Revert flaky FolderNameProviderTest" into main 2024-06-03 20:27:50 +00:00
Fengjiang Li 018074351c Animate -1 to recents
Fix: 343770316
Test: manual - record a video
Flag: com.android.launcher3.use_activity_overlay
Change-Id: I74346f060ea93dbc8fc0a1c3290d4996d89ec062
2024-06-03 12:59:48 -07:00
Liran Binyamin ba732a77a1 Merge "Fix bubble bar and handle visibility on first bubble" into main 2024-06-03 19:49:26 +00:00
Shamali Patwa 54d8924415 Merge changes from topic "image-previews-wrap" into main
* changes:
  Adjust previews in a row to align with each other and remove whitespace.
  Move item animator to its own class and use it only for full sheet
  Measure recommendation children using the provided available height
2024-06-03 19:47:22 +00:00
Anton Vayvod ee38224910 Guard Flags references with a check for running on Android V.
Otherwise, Launcher3 next build crashes on non-V devices.

Bug: NONE Trivial cleanup.
Test: manual
Flag: NONE The change deals with flags

Change-Id: I9d9335ea1cb0f299aa5af8095ff1ea2f98c23542
2024-06-03 19:04:41 +00:00
Liam Lee Pong Lam ee5867e980 Revert "[Launcher3] Hide keyboard when fastscroller scrolling down and keyboard"
This reverts commit 883a79db71.

Reason for revert: Revert this change because it caused other bug b/343285163

Change-Id: I1fdb21cc4a5cdcf2c22e9b1927753b290626289c
2024-06-03 19:00:14 +00:00
Ats Jenk 1507a2c59e Merge "Fix bubble position when dragged to dismiss view" into main 2024-06-03 18:30:59 +00:00
Brandon Dayauon f839b1121d Merge "Create a bug fix flag for the FloatingMaskView." into main 2024-06-03 18:18:05 +00:00
Shamali P 7a183e4051 Adjust previews in a row to align with each other and remove whitespace.
- Introduces a WidgetTableRow that identifies preview height for all of
its children while keeping them aligned with minimum whitespace
- The fullSheet's move / change animations can conflict with the resize
so, we wait for them before performing resize of the row.

Bug: 335715046
Test: Manual
Flag: NONE BUGFIX
Change-Id: Id843430c7adfc228c219ba54d504baddba792df0
2024-06-03 18:07:30 +00:00
Shamali P 01d1c31ec7 Move item animator to its own class and use it only for full sheet
Bug: 335715046
Test: Manual
Flag: NONE BUGFIX
Change-Id: I6977e9854edcee385f5b7075f62dd1d8ff8dfdce
2024-06-03 18:07:21 +00:00
Shamali P 93ee47f729 Measure recommendation children using the provided available height
We always want to measure the pages based on the provided height.

Bug: 335715046
Test: Manual
Flag: NONE BUGFIX
Change-Id: I9de2ed1e0d4cc37d24435b9077e60bf5f0456091
2024-06-03 18:07:11 +00:00
Liran Binyamin 273f9ec487 Fix bubble bar and handle visibility on first bubble
When the animation of the first bubble is suppressed, immediately
stash or show the bubble bar to make sure it has been initialized
correctly.

Also we no longer automatically update the bubble bar visibility
based on its alpha value, since we're managing alpha and visibility
ourselves.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 343505267
Fixes: 343502240
Test: manually verified state for the following scenarios for the first bubble
       - in app when keyboard is open
       - in app -> open shade
       - in app -> lock device
       - on home -> open shade
       - on home -> lock device
       - in overview -> open shade
Test: manually sanity tested to make sure animations for more bubbles still work
Test: manual
       - Open test bubble app
       - Open keyboard and send a bubble
       - The bubble should animate using a HUN since the keyboard is open
       - Swipe back to hide the keyboard
       - Observe that the bubble bar no longer shows to stash into the handle
Change-Id: I754a5a9c8e961af0cdd5ccadf83d3081d4414c7e
2024-06-03 13:27:48 -04:00
Jagrut Desai 38478e74f9 Make Taskbar Divider PopUp Menu Width Dynamic
Test: Manual
Bug: 327647761
Flag: com.android.launcher3.enable_taskbar_pinning
Change-Id: Ib5c13324afee46b45b2c71e3af86c15a6384a278
2024-06-03 10:26:41 -07:00
Schneider Victor-tulias 43592a83c8 Clean up unused debug logs for b/319168409
Flag: NONE removing debug logs
Fixes: 319168409
Test: TaplDragTest#testDragAppIcon
Change-Id: I73208b042248df04281d52eaf3ed6832abbfc144
2024-06-03 12:05:40 -04:00
Uwais Ashraf 050ff39fe2 Revert flaky FolderNameProviderTest
Bug: 325088328
Test: Presubmit passes
Flag: EXEMPT test-only
Change-Id: I22c0bfdea32f552ffdb5dacc34038f7b1c668762
2024-06-03 15:35:13 +00:00
Brandon Dayauon 6b65956a5c Merge "Make PrivateSpaceSettingsButton instead of having just the imageView." into main 2024-06-03 15:02:59 +00:00
Alex Chau 5e102e4994 Handle uiMode changes in QuickstepLauncher
- Added uiMode in handled configChanges for QuickstepLauncher, NexusLauncherActivity and RecentsActivity
- This avoids Launcher from being recreated when swithching from an app in driving mode (e.g. Maps), which causes massive jank
- Launcher layout is affected when driving mode changes, so a recreation is ujnnecessary
- Light/dark mode changes still causes Launcher to create as expected

Fix: 339747262
Test: Swtich from driving mode app to another or home in 1p and 3p laucnher
Test: Switch light/dark mode and Launcher is updated correctly
Flag: EXEMPT bugfix
Change-Id: I3d52f0625b580a5b5a1ddbbb487c271a4bb0152b
2024-06-03 12:24:30 +01:00
Riddle Hsu 684ee34fe7 Send source rect hint to Shell via stopSwipePipToHome
Launcher has calculated it, so shell side can use it directly to
avoid inconsistency.

Bug: 331315278
Test: Assume the target app support auto-pip and it doesn't draw
      under display cutout.
      E.g. LAYOUT_IN_DISPLAY_CUTOUT_MODE_SHORT_EDGES
      Enter PiP from 90 degrees to home with 0 degrees.
      The left side of pip should not flicker.
Change-Id: Id09efc8a30eeef14a031d9db2ab1e00b6f3034bc
2024-06-03 11:04:51 +08:00
Hongwei Wang 282cdebd0c Crop the center when no source rect hint
When there is no source rect hint, forge a crop that matches the given
aspect ratio and centered, therefore we can use a consolidated animation
path and fix the issue with the round corner, which was inproperly
scaled in the past.

Flag: NONE bug fix
Bug: 298409662
Test: Test the overlay in both gesture and button navigation mode,\
      with both YouTube and Google Maps,\
      in both folded and unfolded mode.
Change-Id: I8ae48b999159a51eda2ff41c49cdb3c4e1541176
2024-06-02 19:36:38 -07:00
Jeremy Sim 9715761427 Merge "Add logging for actions view" into main 2024-06-01 00:40:22 +00:00
Jeremy Sim bcaceda41a Merge "Save app pair with 50-50 snap target if snap position is SNAP_TO_NONE" into main 2024-06-01 00:39:00 +00:00
Shamali Patwa b28d9b58bd Merge "Fix test failure in post submit" into main 2024-06-01 00:12:12 +00:00
Brandon Dayauon 6f1ca642ee Merge "Rename add* to update* and call setQuietMode() itself" into main 2024-06-01 00:09:52 +00:00
Brandon Dayauon 582790c56a Merge "Fading PS container on hide." into main 2024-06-01 00:07:34 +00:00
Brandon Dayauon 736527a127 Make PrivateSpaceSettingsButton instead of having just the imageView.
This way we can keep the click listener in this PrivateSpaceSettingsButton.java class.
- Moved itemInfo creation to PrivateSpaceSettingsButton and created a test class

bug: 341053089
Test: manually - presubmit video: https://drive.google.com/file/d/1_TCGrILvwmMpxbgIcbOcpB2AxeBJbyNf/view?usp=sharing
Flag: Aconfig com.android.launcher3.enable_private_space Nextfood
Change-Id: I79cd319274f4445dd00bc257be81728360d09684
2024-05-31 17:05:13 -07:00
Jeremy Sim 2d107d8d4d Add logging for actions view
Bug: 340935208
Test: N/A
Flag: EXEMPT bugfix
Change-Id: Idb1ed848f01fc8378ae54f89ecf37cd14300ed79
2024-05-31 23:03:43 +00:00
Shamali Patwa 7c3e2ff946 Merge "Don't apply color filter on header icons if animations are disabled." into main 2024-05-31 22:00:35 +00:00
Shamali Patwa 8e7613e4c7 Fix test failure in post submit
Bug: 343937933
Change-Id: Ie989e4ce4f098a225873d13de9c6913933e5628e
Test: Unit test fix
Flag: None test fix
2024-05-31 21:59:41 +00:00
Isak Lilja 29322e82fe Save app pair with 50-50 snap target if snap position is SNAP_TO_NONE
It was not possible to save an app pair if free snap mode was enabled
and the snap position was SNAP_TO_NONE. Just default to 50-50 split if
the current divider snap position is SNAP_TO_NONE.

Cherrypicked from isak.lilja@sony.com's CL at https://partner-android-review.git.corp.google.com/c/platform/packages/apps/Launcher3/+/2835425.

Bug: 343219704
Test: N/A
Flag: EXEMPT bugfix
Change-Id: I62347ac13440f714a493366ac66e893578a2d8d9
2024-05-31 21:52:15 +00:00
Andrew Cole 967dd54595 First Unit Tests for Utilities.java
Writing some initial unit tests for Utilities.java to get others started so they can easily add to the party.

Bug: 297950111
Test: Self
Flag: TEST_ONLY
Change-Id: I3323e6483790e2c2fbbd5c8db0281802abf0749b
2024-05-31 14:50:48 -07:00
Ats Jenk af5a393f88 Fix bubble position when dragged to dismiss view
When moving a bubble to dismiss view, use the drag translation x methods
to set the translation x values.
When bubble is moved to the dismiss view, the container will animate
back to the initial position. And we need to account for this while
bubble is in the dismiss view.

Bug: 339659499
Flag: com.android.wm.shell.enable_bubble_bar
Test: manual, drag bubble to other side and then to dismiss view,
  observe that bar moves back to original side and bubble is at the
  center of the dismiss view
Change-Id: I4c6e1be2dcd1180d985ceafccfc0f18466549347
2024-05-31 14:21:40 -07:00
Kevin Lim 9e496d61f8 Merge "[IconCache] Override persistent log method for when BaseIconCache retreived empty ApplicationInfo or default app icon" into main 2024-05-31 20:56:21 +00:00
Jagrut Desai 98eac2c1b2 Merge "Removing TWO_NEXUS_LAUNCHER_ACTIVITY_WHILE_UNLOCKING" into main 2024-05-31 20:40:54 +00:00
Federico Baron 4aa92bec7f Merge "Revert "Add screenrecord for testAllAppsFromHome()"" into main 2024-05-31 20:13:52 +00:00
Federico Baron 48c2b2b509 Merge "Add screenrecord/demote TwoPanelWokrspaceTest" into main 2024-05-31 20:13:22 +00:00
Federico Baron 4e9adbae11 Merge "Add screenrecord for testDragAppIcon" into main 2024-05-31 20:13:05 +00:00
Treehugger Robot b805620a91 [automerger skipped] Merge "Cancel manual animation if LauncherState changes during drag." into 24D1-dev am: 85e9c6f1a2 -s ours
am skip reason: Merged-In I6364dbde8aea67f5d1c525edf57ed7eb26096cf9 with SHA-1 22dee942b5 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27249862

Change-Id: Ibfe7ada5ccadbcc86a0acc61fa3ee2e950a648f2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-31 19:35:52 +00:00
Andy Wickham 5e98ba57be [automerger skipped] Cancel manual animation if LauncherState changes during drag. am: 649903838e -s ours
am skip reason: Merged-In I6364dbde8aea67f5d1c525edf57ed7eb26096cf9 with SHA-1 22dee942b5 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27249862

Change-Id: I762325e36ffde2bd90452de69b35b8f303c1ded1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-31 19:35:45 +00:00
Treehugger Robot 85e9c6f1a2 Merge "Cancel manual animation if LauncherState changes during drag." into 24D1-dev 2024-05-31 19:27:25 +00:00
Brian Isganitis 8aad11912d Merge "Only stash for IME when in-app and in overview." into main 2024-05-31 19:25:31 +00:00