Commit Graph

76729 Commits

Author SHA1 Message Date
Cole Faust 47e6c241e6 Merge "Baseline NewApi issues" into main 2024-01-12 04:49:23 +00:00
Android Build Coastguard Worker e21a821c3d Snap for 11303174 from 6cdb1de48d to 24Q2-release
Change-Id: Ic2f8f0dfc48ab422364852b49979d138ab675cdb
2024-01-12 02:50:44 +00:00
Android Build Coastguard Worker 73fe6ac6f4 Snap for 11302939 from 480448b059 to 24Q2-release
Change-Id: I42e39aaeba0927967ef15ba709c1c9c0f46ab324
2024-01-12 01:28:57 +00:00
Bill Yi 11766a67bb Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I4e130d40326ad2b4580d7449c5c9229dc83cefc9
2024-01-11 17:26:25 -08:00
Vadim Tryshev 6cdb1de48d Merge "Making testAllAppsFromHome platinum" into main 2024-01-12 01:25:48 +00:00
Bill Yi 2a7d9f3927 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I2f4edf2f617b9c7c5fc2fe36b84144b7e620f5cb
2024-01-11 17:25:27 -08:00
Bill Yi 2f863664af Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Iecc8364731c1fd3bd540875601599642a36a1e96
2024-01-11 17:25:02 -08:00
Tracy Zhou 78c548a829 Remove taskbar window from WindowManager in TaskbarManager.destroy()
When task bar crashes (from anything), task bar window is not cleaned up properly. This is because destroyExistingTaskbar() only removes the root layout from the window when we are no longer rendering task bar (one use case of that is folding the device). We need to clean it up in onDestroy() also.

Fixes: 319105323
Test: adb shell am crash com.android.systemui and make sure there is only one task bar window
Change-Id: Ia9c808e903422707bf4c270b2631fc913dde65d9
2024-01-11 16:13:06 -08:00
Tony Wickham 480448b059 Merge "Temporary workaround for taskbar hiding in Desktop" into main 2024-01-11 23:21:42 +00:00
Holly Jiuyu Sun de4ac178b9 Merge "Implement Install Apps button in Private Space." into main 2024-01-11 23:18:46 +00:00
Jagrut Desai 3fc1e3a45d Fix TaskbarDividerPopupView vertrical Arrow offset
Test: Manual
Bug: 310673489
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning TEAMFOOD
Change-Id: I6c6af315cb058c8da599af8120a6a903ab247006
2024-01-11 14:00:37 -08:00
Vadim Tryshev bfbc121e5d Merge "Waiting for Normal state when closing search result by touching outside" into main 2024-01-11 21:43:19 +00:00
Vadim Tryshev d586d054a2 Merge "Waiting for Normal state after pressing meta key in AllApps" into main 2024-01-11 21:43:06 +00:00
fbaron ae39c0f9de Don't reset search in two pane sheet
Fix: 319150904
Test: Verify on device that search doesn't reset
Flag: NONE
Change-Id: I7ecb20ef67416e5393d600821ac96b2f7e80c4d2
2024-01-11 13:37:45 -08:00
Charlie Anderson 3e53925c88 Merge "Change FIRST_LOAD_AFTER_RESTORE_KEY to be nonRestorableItem" into main 2024-01-11 21:08:18 +00:00
Vadim Tryshev 5674552a5d Using a standard way to go to Overview in DWB Toast test
Standardizing reduces maintenance.

Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I0f59262a9f34c29a97c496f0f61c44ab1af56d04
2024-01-11 12:46:47 -08:00
Vadim Tryshev 65b735beeb Merge "Waiting for Normal state when closing Overview by touching outside of first task" into main 2024-01-11 19:40:57 +00:00
Jagrut Desai 80cc62173e Adding Taskbar Pinning Analytics again.
Test: Presubmit
Bug: 265436916
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning TEAMFOOD
Change-Id: I742dccccc7648bb7ec8bf94d5f5f55430a5543ab
2024-01-11 11:33:02 -08:00
Vadim Tryshev 04947de324 Merge "Re-promoting testDragToFolder to postsubmit" into main 2024-01-11 19:21:43 +00:00
Sergey Pinkevich 19265a47bd Merge "Place app icons in correct place in RTL for Seascape mode" into main 2024-01-11 13:31:04 +00:00
Anna Zhuravleva 29a3139815 Add shortcut to install an app to Private space
Introduce long-press shortcut to install a copy
of the main user app to private space.

Test: manual, installed apps in different stores
and tried shortcut
https://screenshot.googleplex.com/6oAVamTytiYmvPC.png
Bug: 316118005
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space_install_shortcut DEVELOPMENT

Change-Id: I702cd2a27388e3cc6e9e126308d5479836ba6655
2024-01-11 12:40:28 +00:00
Johannes Gallmann 9e91335473 Disable back gesture in Launcher after reboot
It needs to be ensured that `updateDisallowBack` is called at startup after views are created.

Bug: 318786031
Flag: NONE
Test: Manual, i.e. verifying that back gesture is disabled after rebooting the device
Change-Id: I32812101c0e159f5cba41ab419f86de760449906
2024-01-11 12:23:22 +00:00
Riddle Hsu 1438af66f8 Merge "Fix leakage of GestureExclusionListener" into main 2024-01-11 05:54:05 +00:00
Vadim Tryshev a705fdf74f Waiting for Normal state when closing search result by touching outside
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I2e90105057de44fff96d6d0fd740f963465be57e
2024-01-10 18:57:13 -08:00
Android Build Coastguard Worker 33809eb270 Snap for 11297328 from cb9f5744ae to 24Q2-release
Change-Id: I4ba57ecbd7c0fc18504bf17137c11c3c8c70290a
2024-01-11 00:23:26 +00:00
Uwais Ashraf 361aa882cc Merge "Update the device twoPanelId specs to use the default spec when it is not defined" into main 2024-01-11 00:19:29 +00:00
Holly Sun 97b1bba413 Implement Install Apps button in Private Space.
UX mock: https://www.figma.com/file/K6bIIcG882EiJNjxvSWsFT/V%E2%80%A2-Private-Space?node-id=7246%3A83750&mode=dev
UX icon spec: https://www.figma.com/file/K6bIIcG882EiJNjxvSWsFT/V%E2%80%A2-Private-Space?type=design&node-id=19979-224329&mode=design&t=50SDFdomAtonNU4V-0

Video: https://drive.google.com/file/d/1VtTzxR46dLiaozOo6sOHADv1qTcBOwDP/view?usp=sharing
Screenshot:
https://screenshot.googleplex.com/3ShcUozVrkGMHbc
https://screenshot.googleplex.com/3F4c3yzJ7RUpma7

Reason to use PrivateSpaceInstallAppButtonInfo: reuse `VIEW_TYPE_ICON`, which needs an AppInfo.

Bug: 308064949
Test: manual
Flag: ACONFIG com.android.launcher3.private_space_app_installer_button development
Change-Id: I3fb27fae8324d4b276816b17f9b0a2d9b6f33ed2
2024-01-10 14:28:33 -08:00
Cole Faust c778a67f8b Baseline NewApi issues
NewApi is a lint check that you don't call framework methods that were
introduced in versions later than your min_sdk_version. We want to
make this an error, so we're baselineing all existing issues.

This cl was generated automatically, by taking all the NewApi issues
from the reference baselines, and all the non-NewApi issues from the
existing checked in baselines.

Bug: 268261262
Test: Presubmits
Change-Id: Ibfbf5af12819d43dabd4b6c0eb12a4d0e8258f30
2024-01-10 12:30:39 -08:00
Sunny Goyal cb9f5744ae Merge "Moving widget inflation logic to a separate class" into main 2024-01-10 20:03:15 +00:00
Tony Wickham 4e7411c54c Temporary workaround for taskbar hiding in Desktop
Taskbar still hides during the transition, but then reappears
after settling.

Flag: LEGACY ENABLE_HOME_TRANSITION_LISTENER enabled
Bug: 314207404
Test: manual
Change-Id: Ie3d29b3d40e513f39cb34176baa781c9f2853e57
2024-01-10 19:59:25 +00:00
Oriol Prieto Gasco 2916945dbf Set aconfig container to "system"
Bug: 312769710
Flag: NA
Test: TH
Change-Id: I7fbb8e31629b7aa90fbdf2b029932c111cce8d42
2024-01-10 19:52:57 +00:00
Sergey Pinkevich f595fc3164 Place app icons in correct place in RTL for Seascape mode
The goal for this CL is to show icons for split apps (similar to Landscape mode). The aligning (perfect pixel, aligned to the task bounds) can be done in a separate task

Bug: 317072320
Flag: NONE
Test: manually

Old behavior: https://drive.google.com/file/d/11UQyEB-EhKYu1eisjAW_MnhV-drrT38E/view?usp=sharing (icons are missing in RTL mode)

New behavior: https://drive.google.com/file/d/1GrZe6J8zBIoHtP7DzgZnpJiyz2XWujLf/view?usp=sharing

Change-Id: I2fe7defd1c668326ab0e0114a4cd9793e66d6175
2024-01-10 19:50:49 +00:00
Tracy Zhou e19c572ac2 Merge "Hook up luma sampling state change from CommandQueue" into main 2024-01-10 19:33:24 +00:00
Vinit Nayak 9efb2fb0a0 Sync split dismiss anim scrim fadee timing with taskbar to home anim duration
* We sync the scrim fade with the taskbar animation duration
to avoid any flickers fortaskbar icons disappearing before hotseat
icons show up.
* Layer wise taskbarIcons > scrim > hotseat
as taskbarIcons are translating into place, the frame where they fade out
the scrim should also fade out so they get seamlessly replaced by hotseat icons
* In our case the scrim was staying on too long so the scrim would show before
the hotseat, making it look like a flicker.
* Now we fade away the scrim sooner

Bug: 318747712
Test: Flicker no longer occurs
Flag: None
Change-Id: I779af1826ee55bfcbced3e972f14f5f299e9aaeb
2024-01-10 11:18:26 -08:00
Sunny Goyal 31e27ed934 Moving widget inflation logic to a separate class
This allows us to reuse this logic at other places

Bug: 318539160
Test: atest TaplBinderTests
Flag: None
Change-Id: I2e19aad207efb3a99bb3b70ba71c076699dba2bc
2024-01-10 10:41:44 -08:00
Jordan Silva d29f0644f2 Update the device twoPanelId specs to use the default spec when it is not defined
In some situations, DeviceProfile is recreated with an invalid InvariantDeviceProfile leading to a crash, because it tries to use an non existent responsive grid spec. To prevent the crash, we are update the responsive grid two panel specs to use the default spec when two panel spec is not defined.

Bug: 317993862
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: NexusLauncherImageTests
Test: DeviceProfileDumpTest
Test: DeviceProfileAlternativeDisplaysDumpTest
Change-Id: I8b8095745787ad47b006892452a54942f981713e
2024-01-10 15:11:26 -03:00
Vadim Tryshev 0a1c916f78 Merge "Waiting for Overview state when closing SelectModeButtons via Esc" into main 2024-01-10 18:02:08 +00:00
Schneider Victor-tulias 7b019ef700 Update the KQS app launch animation to match the spec exactly
Updated the KQS to look exactly like the default app launch animation, in the opposite direction:
- animation interpolator
- task corner radius
- task margin
- animation duration

Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 313606549
Fixes: 313607264
Test: launched tasks from KQS from home and launched app
Change-Id: I3f49f9430b2148680816d904aced93d14f366123
2024-01-10 15:34:00 +00:00
Johannes Gallmann f263e9d307 Fix TaplTestsQuickstep.testPressback failure (2)
Since anim is empty in the predictiveBack case, the animationEnd listener needs to be added to rectFSpringAnim instead

Bug: 318675970
Flag: ACONFIG com.android.systemui.predictive_back_system_animations STAGING
Test: TaplTestsQuickstep
Change-Id: Ibb3fd44c56b9d5370362f994762554eff02edbe6
2024-01-10 14:20:38 +00:00
Uwais Ashraf ae710a2f30 Merge "Add logging for overview over home bug" into main 2024-01-10 14:19:56 +00:00
Johannes Gallmann 376cde95d0 Align window clipping logic of back-to-home to cross-task-back
Bug: 315461656
Flag: ACONFIG com.android.systemui.predictive_back_system_animations STAGING
Test: Manual, i.e. visually verifying back to home behaviour on Felix
Change-Id: I075c38fc58c56108128fdf895c62b2f626da36ad
2024-01-10 14:18:39 +00:00
Helen Cheuk 78745df2b4 Merge "Fix wrong translation for swiping up split task" into main 2024-01-10 13:11:05 +00:00
helencheuk 06ddebb34f Fix wrong translation for swiping up split task
The wrong calculation is caused by using half size mTaskRect in Split task to calculate the translation X to middle
It should use the fullTaskSize instead of half size. This change refactors the code to store the full size so it does not need to re-calculate many times

Bug: 312371505
Test: Manual, swiping up split task diagonally from right side many times, test the case when mSplitBounds is not null in addAppToOverviewAnim
Test: Tested swipe up to overview for split task/single task in Phone, Tablet and Unfolded phone, with the flag on and off
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Change-Id: Id2b008a7d9597271e077a125f3195b27196797d7
2024-01-10 11:40:58 +00:00
Riddle Hsu 96d7f9c2d7 Fix leakage of GestureExclusionListener
So the unregister/register are paired when launcher activity
is relaunched:

Launcher#onDestroy
 > mSplitWithKeyboardShortcutController.onDestroy()
+ > RecentsAnimationDeviceState#destroy
+  > unregisterExclusionListener

Launcher#onCreate
 > setupViews
  > new SplitWithKeyboardShortcutController
   > new RecentsAnimationDeviceState
    > onDisplayInfoChanged
     > registerExclusionListener

Bug: 319133753
Test: Toggle screen resolution many times and check the amount
      of DisplayContent#mSystemGestureExclusionListeners.
Change-Id: I2fb84415db71aaa14e653fea2592d6b9b5adad59
2024-01-10 17:59:28 +08:00
Tracy Zhou cf5407dfc6 Hook up luma sampling state change from CommandQueue
Currently when swiping up from some apps (maps), the stashed task bar color changes. Instead, sampling should be disabled during the transition (with a signal from the frameworks).

Bug: 230395757
Test: Swipe up from maps. Make sure the bar color doesn't change during transition
 to overview
Change-Id: Ifc30f4067a0e4d134b422d152f5b5caee0a77a33
2024-01-09 21:56:58 -08:00
Vadim Tryshev f2a31282da Merge "Waiting for Normal state when swiping from a popup to home" into main 2024-01-10 04:11:41 +00:00
Fengjiang Li ad3915e7dd Merge "Adding support for skipping animation cancel on reapply" into main 2024-01-10 02:28:19 +00:00
Android Build Coastguard Worker 1a9b770b75 Snap for 11292102 from 225bf58643 to 24Q2-release
Change-Id: I1c216bcf0ebc054bf6ebdf9978c341dd9977f6b6
2024-01-10 00:21:16 +00:00
Vadim Tryshev 07f4f9b9fd Merge "Waiting for Normal state when closing Overview by touch" into main 2024-01-10 00:16:04 +00:00
Vadim Tryshev 702324860d Waiting for Normal state after pressing meta key in AllApps
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I005183095833d7b0b8f9fa444af98932d3414ee4
2024-01-09 15:55:38 -08:00