The animation ReorderPreviewAnimation handles two animations, one when
the mode is MODE_HINT and the other MODE_PREVIEW. The animation is
basically the same but MODE_PREVIEW ocilates to finalDelta and back
to initDelta. MODE_HINT stays in finalDelta. When finish, we have to
go back to the initial position.
This behaviour is currently done using logic, making sure the view stays
in finalDelta no matter the value of the animation, the bug is in this
logic. I think is better to do this with the current animation API by
setting setRepeatCount to 0 on the HINT case and reverting the animation
when finish so it goes back to the initial position.
This seems to have been there for a long time, at least since the
creating of git_main, but it became more aparent now. In a follow up cl
I will move this class to it's own file and into kotlin to help if there
are issues here again.
Fix: 294473336
Test: manual testing
Flag: NA
Change-Id: I4ac5de3ce8a8170944a072c6ce41c65d0963a780
Arrow can become detached from the bubble bar background. This can
happen when bubble bar is pinned to the left and the right-most bubble
is selected. When the selected, right-most bubble is removed by drag and
dismiss, the view is removed and bubble bar background is immediately
updated. But we try to animate the arrow to the new selected position.
Before starting to animate arrow position, check if arrow position is
greater than bubble bar width. If it is, the arrow is detached and we
should not try to animate it to the new position. Just move it.
Flag: LEGACY persist.wm.debug.bubble_bar DEVELOPMENT
Bug: 273310265
Test: switch to RTL language, have 3 bubbles in bar, expand and select
the right-most bubble, then dismiss it via drag, observe arrow jumps
to new position and does not become detached from background
Test: switch to LTR language, try the same, 3 bubbles and dismiss the
left-most bubble, observe arrow jumps the same and does not become
detached
Test: select other bubbles, observe arrow position animates to the new
position
Change-Id: I399db3c3e32b65b9125262bba0a0c32e45865bba
This is required in some cases, when we do not want
the Launcher (ProxyActivityStarter) Activity to come
in recents.
Bug: 320664417
Flag: ACONFIG com.android.launcher3.private_space_app_installer_button TEAMFOOD
Test: Manual build and flash.
Change-Id: I94d9dfab19f8a2410fa82adc0c0c22a3ac238a0b
Fix bubble bar collapse and expand animations when bubble bar is pinned
to the left.
When system language is set to an RTL language, bubble bar gets pinned
to the left edge of the screen.
Bubble bar should expand to the right and collapse to the left. Bubbles
in the bubble bar should be ordered from right to left. The most recent
bubble should be at the right in the bubble bar.
Known issue:
- when the most recent bubble is removed, the arrow animates to a new
position, but the background is not animated, resulting in arrow
getting detached from the container. Will be fixed by animating the
background.
Flag: LEGACY persist.wm.debug.bubble_bar DEVELOPMENT
Bug: 273310265
Test: with LTR language set as the system language
- expand bubble bar with 1 bubble
- expand bubble bar with multiple bubbles
- select second bubble, observe after collapse it is set as first
- dismiss a bubble from bubble bar by dragging
Test: with RTL language set as the system language
- expand bubble bar with 1 bubble
- expand bubble bar with multiple bubbles
- select second bubble, observe after collapse it is set as first
- dismiss a bubble from bubble bar by dragging
Change-Id: Ic46a5b1a6e45ad225ba509a61147cc6a8cdd0397
Touch targets have to meet a minimum of 48 dp to meet accessibility
requirements. The Done button in the gesture navigation tutorial menu
was previously too small.
Flag: LEGACY ENABLE_NEW_GESTURE_NAV_TUTORIAL ENABLED
Fixes: 319752098
Test: Opened the gesture tutorial menu in smaller and larger screens.
Change-Id: I7d9b856ad4829e4ffe26a7df00f42e5e4fcf1b2e
* Archiving test for promise icons use a broadcast receiver.
* Due to recent class identifier change, manifest entry for the receiver was invalidated. This cl attempts to fix the breakage.
Test: atest TaplPromiseIconUiTest.java
Bug: 319240622
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: I061278d6cc3f49c579575a1af49ffe53770fd790
This patch modifies PackageUpdatedTask.execute() to also remove app pairs when their member apps are uninstalled.
Fixes: 316050282
Test: Install App A, create an app pair containing App A, uninstall App A.
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I8487a2dfcfc6d29bd55e88003d1950078c6e2e31
When the user selects an app pair as a split target, the split instructions view will now bounce up and down to prompt the user to select something else.
Fixes: 315529271
Test: Manual
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I1ff194449db2263b266404f42a75ebc35ee6077c
- It's not currently being used at all, and with the taskbar/navbar
unification we will likely not need it going forward as well
Fixes: 318651465
Test: Builds
Change-Id: I909c0165468e8da9c3ca2df4ba98da9dcc43eb53
When home screen rotation is enabled, instead of updating taskbar height (assuming that folded task bar is always on the bottom of screen display), we should update taskbar width instead.
Bug: 313371759
Test: try out both folded and unfolded 3-button and gesture nav modes, enable home rotation, make sure all the nav buttons are functional and visible when they should be.
Change-Id: I16f53d9e9c3cd0229fc50b73613b032a96322b97
This CL does the following:
- Creates a dir for multivalentTests
- Creates symlinks for the dir to keep Android Studio happy
- Moves many files to the multivalentTests dir
- Adjusts gradle and soong build files to use the new dir as part of
their source sets.
Test: ./gradlew :NexusLauncher:testGoogleWithQuickstepDebugUnitTest
Test: atest Launcher3RoboTests
Fix: 316553886
Bug: 316553889
Flag: NA
Change-Id: Iae28fd0c0191b3ecf9bd2950800875950cca2622
Vinit Nayak
Sebastian Franco
Ats Jenk
Tracy Zhou
Brandon Dayauon
Himanshu Gupta
Jakob Schneider
Mady Mellor
Vadim Tryshev
Android Build Coastguard Worker
Saumya Prakash
Winson Chung
Jagrut Desai
Federico Baron
Sunny Goyal
Anushree Ganjam
Rohit Goyal
Luca Zuccarini
Sam Cackett
Jeremy Sim
Tony Wickham
Uwais Ashraf