Commit Graph

76729 Commits

Author SHA1 Message Date
Shamali Patwa a80e199798 Merge "Keep rounded corners while scrolling in right pane & fix scrollbar size." into main 2024-04-19 22:43:39 +00:00
Stefan Andonian f22011a51c Merge "Use ItemInfo with correct position when adding to Workspace via Accessibility." into main 2024-04-19 21:13:11 +00:00
Shamali Patwa 4ee10f33ee Merge "Use same margins for widgets bottom sheet as all apps." into main 2024-04-19 21:08:24 +00:00
Eghosa Ewansiha-Vlachavas 0c338f3055 Merge "Check RecentsView is not null before use in AbsSwipeUpHandler" into main 2024-04-19 20:25:21 +00:00
Anushree Ganjam 093ef5fa30 Merge "When AllAppsSearchBarController's mInput edit text focus is false, we should hidekeyboard." into main 2024-04-19 19:59:44 +00:00
Schneider Victor-tulias ec39107105 Update KQS to better support desktop tasks
While we wait for a way to display a sreenshot of the desktop statically, using a placeholder solution.

Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 335632286
Test: TaplTestKeyboardQuickSwitch
Change-Id: I2525ab89eb3a5a902e7ab55367187d87aada1f10
2024-04-19 14:53:20 -04:00
Sebastián Franco 87fbc2e02e Revert^4 "Removing all restored backups except one so we don't have old backups"
To prevent the error I introduce the method restorePreviousState().

This reverts commit 1234090589.

Reason for revert: Fixing presubmit breaks

Bug: 325285743
Flag:  ACONFIG narrow_grid_restore disabled
Test: BackupAndRestoreDBSelectionTest
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:ad46eb75f4c239321b1e8f03062dd7599cdc9495)
Merged-In: I63666c29eb91dada4243af019ab0538c40bc0f78
Change-Id: I63666c29eb91dada4243af019ab0538c40bc0f78
2024-04-19 18:27:07 +00:00
Eghosa Ewansiha-Vlachavas 47e0a61f29 Check RecentsView is not null before use in AbsSwipeUpHandler
Prevents NullPointerException

Flag: NONE
Test: Presubmit
Fixes: 335485976
Change-Id: Ia91f95dc4839c9d4c00c7aeed6cc9cebdafa33ee
2024-04-19 18:18:51 +00:00
Vinit Nayak c0a1fbe872 Merge "Revert^2 "Launch split tasks at beginning of animation instead of the end"" into main 2024-04-19 17:00:37 +00:00
Stefan Andonian 86d3c8814b Use ItemInfo with correct position when adding to Workspace via Accessibility.
Bug: 332651703
Flag: NA
Test: Verified that the issue isn't reproducible with the fix. The issue
was 100% reproducible before.
Change-Id: I01207396e19b4f7d14d6a147e5e5fb98bae9ea99

Change-Id: I81aad9758ee33b8acc2d6a1242e54f2a47124374
2024-04-19 16:22:39 +00:00
Fengjiang Li 7d80f801b1 Merge "[Predictive Back] AbstractSlideInView#mViewToAnimateInSwipeToDismiss can be private" into main 2024-04-19 16:22:30 +00:00
Treehugger Robot d8a6db2c90 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev am: a692409e5b -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27022990

Change-Id: I40b4ccea42b0653f2b86044dec63abc7c40b665e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-19 16:16:32 +00:00
Bill Yi 99c7b2d991 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: ea696564d5 -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27022990

Change-Id: Ie6a92980cb5248e207ad2b3f28bdff16955ec06e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-19 16:16:27 +00:00
Bill Yi 5f71ca9d0f [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 46a33d45c0 -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27021532

Change-Id: I85ccb22d67a3a94ca79166cc7f9d39b4165324b2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-19 16:16:20 +00:00
Treehugger Robot a692409e5b Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev 2024-04-19 16:00:28 +00:00
Charlie Anderson 299e42cf8d Merge "Fix NPE for where intent.package is null but targetpkg is not." into main 2024-04-19 15:10:20 +00:00
mpodolian 73b07e2024 Updated pointer to match visual specification.
Updated bubble bar view pointer to have rounded tip.

Test: BubbleBarViewAnimatorTest
Fixes: 333546362
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Change-Id: I7875426b06a330bc355a833c51849335f831317e
2024-04-19 15:32:26 +01:00
Brandon Dayauon 715059a1e3 Merge "Make settings cog animate back to original button" into main 2024-04-19 10:07:36 +00:00
Luca Zuccarini 62535f1fab Merge "Settle without jumping at the end of the home transition." into main 2024-04-19 09:50:38 +00:00
Bill Yi ea696564d5 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I69611a4fef3c988a5639cb21110f608d38d07897
2024-04-18 23:15:13 -07:00
Bill Yi a42f37d97e Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ife6c71dc43953d4bb17e9913334aeb3e6d55d9a8
2024-04-18 23:14:45 -07:00
Bill Yi 46a33d45c0 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I6f2f4284cf13655c06901f962e97de9c74a88bfe
2024-04-18 23:13:46 -07:00
Bill Yi 84d1a232f1 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I7331cf03b59ebe8617870299f491f76d4f25ae4c
2024-04-18 23:13:19 -07:00
Brandon Dayauon 24db282ed4 Merge changes Ied2efcf6,I07579635 into main
* changes:
  Polish workFAB with updated spec.
  Fix workFAB alignment.
2024-04-19 00:59:19 +00:00
Vinit Nayak a6bf5a0014 Revert^2 "Launch split tasks at beginning of animation instead of the end"
This reverts commit fb092a9a6c.

Reason for revert: b/333937249

Change-Id: I77bd6c0d2fbe2f2dad074e8e0e741b50d4d7c204
2024-04-19 00:18:16 +00:00
Brandon Dayauon 7760a4c262 Merge "Private space header to support RTL" into main 2024-04-18 23:19:35 +00:00
Anushree Ganjam d169cb3667 When AllAppsSearchBarController's mInput edit text focus is false, we should hidekeyboard.
The searchEditText has focusableInTouchMode = true, See https://source.corp.google.com/h/googleplex-android/platform/superproject/main/+/main:vendor/unbundled_google/packages/NexusLauncher/res/layout/typeahead_search_input.xml;l=47;drc=199723c3c6db539cce4c03b5b612015fe040b202

See https://developer.android.com/reference/android/view/View#attr_android:focusableInTouchMode which says "Boolean that controls whether a view can take focus while in touch mode. If this is true for a view, that view can gain focus when clicked on, and can keep focus if another view is clicked on that doesn't have this attribute set to true."

So when external keyboard is connected and we come out of all apps in touch mode, the edit text still has focus in touch mode and continues to keep focus even though clearFocus() is called. So we hide the keyboard so that input connection is not established with edit text anymore.

Before: https://b.corp.google.com/issues/317742889#comment22

After: https://b.corp.google.com/issues/317742889#comment23

Bug: 317742889
Flag: NA
Test: Manual
Change-Id: Ib297b4cdf376d41e244d2b798a101e4255de5108
2024-04-18 15:32:48 -07:00
Shamali P 5f7eb1f2ee Keep rounded corners while scrolling in right pane & fix scrollbar size.
[demo](http://screencast/api/gif/NDU4MTQ5ODE3Mzc4NDA2NHxhYmUzMDcxNy04MA/image)

Bug: 333734241
Test: screencast
Flag: N/A
Change-Id: Ifb522ca2c0a1092bf41c630e336b19c81d504c26
2024-04-18 22:32:30 +00:00
Shamali Patwa 1b8fcf4371 Merge "Revert "When getting a widget provider by name, check all categories"" into main 2024-04-18 22:14:29 +00:00
Charlie Anderson ce255ff6fd Fix NPE for where intent.package is null but targetpkg is not.
- Also update WorkspaceItemProcessorTest with a new test and to use real intent instead of mock

Bug: 330250727
Test: unit tests
Flag: N/A
Change-Id: I77e17901f4754c301ca20b3c6f93bbe29bead59b
2024-04-18 17:48:27 -04:00
Brandon Dayauon 20a6ffd04b Merge "Fix install apps button" into main 2024-04-18 21:42:59 +00:00
Brandon Dayauon baf5f6ec3d Polish workFAB with updated spec.
Updating the workFAB to the new spec: https://docs.google.com/presentation/d/1tTODboxGqJ3ypEyYnr0-bUpSXcvX1cl6Sj8y0Nut5hU/edit?resourcekey=0-9GT8EJG43kTT4aKPWVWRig#slide=id.g2c8f3ae8e02_0_0
Have the background endPadding to be 4 and icon have an endMargin of 12 and the text endMargin of 16.
So that when the text is disappeared, the space between the icon and the right bound is 16dp to spec.

bug:332761814
Test manually:
after LTR expanded:https://drive.google.com/file/d/1NZQW0CF9VFZBoM3673LFiUknqW2nf4r8/view?usp=sharing
after LTR collapsed: https://drive.google.com/file/d/1NRpdTuYQntSs5-yeRL1fJIJy2ETDOYLM/view?usp=sharing
after RTL collapsed: https://drive.google.com/file/d/1NE51MIsS5Fk0DwAuzCehEQzTa42OGj_o/view?usp=sharing
after RTL expanded: https://drive.google.com/file/d/1NPgiPfzw3DOa_xbB_TtlwK-G1Y5WCi53/view?usp=sharing
Flag:None

Change-Id: Ied2efcf6b1bd19c191d80e47bae4f8f6e3794803
2024-04-18 14:40:42 -07:00
Brandon Dayauon 4e68d3992d Fix workFAB alignment.
The calculation to find how much the FAB should shift is outdated as using the
method from deviceProfile#getAllAppsIconStartMargin() gives a better value.

bug:332761814
Test manually:
after LTR expanded:https://drive.google.com/file/d/1NZQW0CF9VFZBoM3673LFiUknqW2nf4r8/view?usp=sharing
after LTR collapsed: https://drive.google.com/file/d/1NRpdTuYQntSs5-yeRL1fJIJy2ETDOYLM/view?usp=sharing
after RTL collapsed: https://drive.google.com/file/d/1NE51MIsS5Fk0DwAuzCehEQzTa42OGj_o/view?usp=sharing
after RTL expanded: https://drive.google.com/file/d/1NPgiPfzw3DOa_xbB_TtlwK-G1Y5WCi53/view?usp=sharing
Flag:None

Change-Id: I07579635d6176553d27497cb73b81799648fb014
2024-04-18 14:40:41 -07:00
Brandon Dayauon 120838b04d Make settings cog animate back to original button
Provide the appropriate itemInfo so that launcherBackAnimation would play correctly.

bug:324569690
Test manual video: https://drive.google.com/file/d/1GfjL4PhdGOxs2KfDpieTNiFiKQ61aCgh/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space trunkfood

Change-Id: I1a9458643e932b279bf4ba4ea33e3dc0a2c121c2
2024-04-18 14:32:33 -07:00
Fengjiang Li aa64c04ed8 [Predictive Back] AbstractSlideInView#mViewToAnimateInSwipeToDismiss can be private
Bug: 335467443
Test: presubmit
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TRUNKFOOD
Change-Id: Ibf4b6f04d829daa6a109724c927bf466c25160d5
2024-04-18 13:37:34 -07:00
Liran Binyamin 4d91e16589 Merge "Give bubble team owners on launcher bubble dirs" into main 2024-04-18 18:45:54 +00:00
Shamali Patwa 7e5ed568b9 Revert "When getting a widget provider by name, check all categories"
This reverts commit 1f69351310.

Reason for revert: Testing odd behavior between google app and pixel weather and duplicate items issue

Change-Id: If181aa3e86969e8821b7e1cc765c3801f04489d2
2024-04-18 18:16:38 +00:00
Liran Binyamin a87abece5a Handle taps on the animating bubble
Make the animating bubble touchable and expand the bubble bar when tapping on it.

Demo: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/c4wBVtrT5YIgxL5kVuuoDU

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605846
Test: atest BubbleBarViewAnimatorTest
Change-Id: I09281c2ebc9921750ada42dfc27e95d1ad0bd83b
2024-04-18 13:52:22 -04:00
Sunny Goyal b895788424 Merge "Using applicationId instead of packageName for xml substitution for increased compatibility" into main 2024-04-18 17:30:31 +00:00
Brandon Dayauon fe791d11aa Fix install apps button
- Setting the button's user via iteminfo to the privateprofile user
doesn't let the user to go into the play store. This was initially done so that
we can check the itemInfo to see if item is private space instead of just checking
if the item has a decorationInfo for collapse animation.
- The itemInfo change is reverted and we can check that case by checking with instanceOf PrivateSpaceInstallAppButtonInfo

bug:335600922
Test manually video: https://drive.google.com/file/d/1N2zOHvPmBptBaBf8SCqjBAM6UhV0lQBI/view?usp=sharing
Flag: ACONFIG com.android.launcher3.enable_private_space TRUNKFOOD

Change-Id: I09f22c9df5b4f9408eea6995eafea83e30c93a0d
2024-04-18 16:59:49 +00:00
Shamali P 50bf021b02 Use same margins for widgets bottom sheet as all apps.
* Per UX discussion with jane and david, the full width looks too large
for the app info -> long press -> widgets bottom sheet.
* Earlier during POR, we decided to match them all, but after trying it out, we think smaller is better for the app specific bottom sheet.

* http://screencast/cast/NTg1Njk1MDUxOTU5NTAwOHxiMDU0YWJhMi04MQ
* http://screencast/cast/NjU0NjQyODgwMDI3MDMzNnw4NDNhMGVjMy0yMg


Bug: 328812171
Test: screencast
Flag: N/A
Change-Id: I9b0a996f80bac2639bcadf85480468ac886c7093
2024-04-18 16:58:39 +00:00
Brandon Dayauon cf0ae01a51 Private space header to support RTL
bug:335658774
Test manually:
before: https://drive.google.com/file/d/1N8kFl28OhCJ7kTTo8VK74x-Mvaqi8GJ4/view?usp=sharing
after:https://drive.google.com/file/d/1N6AyVXcOSA48NveklIeqypueu7WLfP0V/view?usp=sharing
Flag: ACONFIG com.android.launcher3.enable_private_space TRUNKFOOD

Change-Id: I1c80e33f84251d42cd5821735457548de41db40d
2024-04-18 09:50:39 -07:00
Liran Binyamin b8ae441c10 Give bubble team owners on launcher bubble dirs
Flag: N/A
Test: treehugger
Bug: none
Change-Id: Ic5f69f34a1561ffb5a879a88b1532754e4b38f42
2024-04-18 12:18:21 -04:00
Liran Binyamin a7d2658d96 Merge "Update new bubble animation" into main 2024-04-18 15:51:39 +00:00
Mykola Podolian 3291b85e5e Merge "Update bubble bar to match visual spec" into main 2024-04-18 15:09:34 +00:00
Eghosa Ewansiha-Vlachavas f6ea0a3a2b Merge "Gate new desktop task menu button with device config check" into main 2024-04-18 15:02:52 +00:00
Eghosa Ewansiha-Vlachavas e885e54d90 Gate new desktop task menu button with device config check
Desktop windowing is enabled only when the desktop windowing flag is
enabled and the device is supported through setting a device config
flag. Add this device config check to the desktop task menu button so it
does not appear if the device is not compatible.

Flag: NONE
Fixes: 335178869
Test: atest -c NexusLauncherTests:com.android.quickstep.DesktopSystemShortcutTest
Change-Id: Ia2559c1ff57bb7921867e69a47d868c03eae57e7
2024-04-18 11:47:55 +00:00
mpodolian d25c65f9f2 Update bubble bar to match visual spec
Made bubble bar icon size adjustable and listen to the task bar
icon size changes. Additionally fixes an issue where the pointer arrow
could be misplaced.

Test: BubbleBarViewAnimatorTest.kt
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 295027436
Fixes: 334781761
Change-Id: Ie4ceee84cc00baa0186a3d5b431080c8495c7285
2024-04-18 10:00:42 +01:00
Sunny Goyal 29586169aa Using applicationId instead of packageName for xml substitution for increased compatibility
Bug: 335280439
Test: Presubmit
Flag: None
Change-Id: Ic0932224b964bfb57571adfc27ffdfd1ab716b45
2024-04-17 23:24:17 -07:00
Sunny Goyal a82ce1feda Merge "Making moving getDisplayType to DisplayController so that it can be accessed without IDP" into main 2024-04-18 05:51:58 +00:00