Commit Graph

76729 Commits

Author SHA1 Message Date
Vinit Nayak 33b4935234 Prevent passing in GroupedTaskView when not animating split launch am: 8082401a83
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23910406

Change-Id: I5cba930c740bac29dd12c615510c76130d52938a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-06 04:43:45 +00:00
Fengjiang Li 53bd1c059a Merge changes from topic "preinflate-allapps-rv" into udc-qpr-dev am: 1e3d799fe3 am: 1eb81c658a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23714667

Change-Id: If4d644f0aafd40daffe8d92df9448a23f0607e0c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-06 01:22:35 +00:00
Vinit Nayak 8082401a83 Prevent passing in GroupedTaskView when not animating split launch
* With ag/23320818 we started always passing in GroupedTaskView,
which gets used downstream to mean that we are launching an app
from tapping on it in overview
* This caused a bug in the case where we quickswitched to the last
task. Now we pass in null for GroupedTaskView like before

Test: Prior bug (b/274540670) doesn't occur, nor do repro steps
for this one
Fixes: 289163668
Flag: None

Change-Id: I82dd8f26bfc286fefc0995822786cf3980da41d0
2023-07-05 18:21:59 -07:00
Jeremy Sim 923c996b97 Merge "Remove flag ENABLE_LAUNCH_FROM_STAGED_APP" into udc-qpr-dev am: 66ec0f6a28 am: 5aab73311a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23848181

Change-Id: Ic2009f133ea2933453bf0d4048861960dcc3877e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-06 01:18:17 +00:00
Jeremy Sim ec565bcff5 Merge "Add logcat logs for splitscreen launch failures" into udc-qpr-dev am: 3137f65dcc am: 86cf2ea3c8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23784840

Change-Id: Ie6c1d12d76fe7acb41beddc7b8667eab8c70aa37
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-06 01:04:16 +00:00
Liran Binyamin 820cbaad4d Ensure overflow isn't selected when bar is collapsed am: 16b05e251b am: 3c81efd136
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23900933

Change-Id: If381ac2bfaaea5a905901abc013c8ac700cb1955
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-06 00:28:19 +00:00
Vinit Nayak f6f192853d Cleanup WorkProfileTest logs
Fixes: 243688989
Change-Id: Ic3f143062c1a1383d1e79959dae59c45743547e9
2023-07-05 16:27:11 -07:00
Fengjiang Li 1eb81c658a Merge changes from topic "preinflate-allapps-rv" into udc-qpr-dev am: 1e3d799fe3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23714667

Change-Id: I8f3cfc5a95c39cf5d0bded35fbb094cd5f18dc4d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-05 23:21:21 +00:00
Fengjiang Li 1e3d799fe3 Merge changes from topic "preinflate-allapps-rv" into udc-qpr-dev
* changes:
  Pre-inflate BubbleTextViews into Launcher/TaskBar All Apps RV
  Fix calculation of all apps recyclerview pool size of app icons
2023-07-05 22:44:55 +00:00
Jeremy Sim 5aab73311a Merge "Remove flag ENABLE_LAUNCH_FROM_STAGED_APP" into udc-qpr-dev am: 66ec0f6a28
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23848181

Change-Id: Ie893a904846f1f8387c358ae1d1dac565eee6abe
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-05 22:16:00 +00:00
Jeremy Sim 86cf2ea3c8 Merge "Add logcat logs for splitscreen launch failures" into udc-qpr-dev am: 3137f65dcc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23784840

Change-Id: I490a99f184fdb3d6432b93ea36ac79c0e8a51c66
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-05 22:15:20 +00:00
Liran Binyamin c06c7ff6fa Update the bubble bar offset on Home
This is an initial change that positions the bubble bar aligning it
with the center of the hotseat icons. We still need to center it
with the taskbar when in overview.

This change also fixes the touch issues where sometimes the hotseat
icons don't respond to taps. The fix is twofold:

1. Make sure that taskbar insets are always updated when
   BubbleStashController#setBubblesShowingOnHome is called.
2. Update the touchable region in TaskbarInsetsController to account
   for the Y translation of the bubble bar bounds when the bubble
   bar is visible.

Demo: https://screenshot.googleplex.com/6NRyu2CR7Bjs32x

Bug: 286247080
Test: Manual on a physical device
Change-Id: I00daff8341e4d8f5d141b5e0220726f6c03b437c
2023-07-05 17:29:52 -04:00
Jeremy Sim 66ec0f6a28 Merge "Remove flag ENABLE_LAUNCH_FROM_STAGED_APP" into udc-qpr-dev 2023-07-05 21:22:22 +00:00
Jeremy Sim 3137f65dcc Merge "Add logcat logs for splitscreen launch failures" into udc-qpr-dev 2023-07-05 21:22:12 +00:00
patmanning 2c1860e8c6 Sends user home when stashed taskbar handle is clicked.
TAPL, see: go/tapl-taskbar-hover-states

Fix: 249852605
Test: TaplTestsTransientTaskbar
Flag: ENABLE_CURSOR_HOVER_STATES
Change-Id: If3c31b9b43a7361bc4e1a97395486249a44ad0f6
2023-07-05 22:18:01 +01:00
Fengjiang Li 1519c168da Pre-inflate BubbleTextViews into Launcher/TaskBar All Apps RV
This CL ensures no inflation of BubbleTextView happens while binding applications, and reduces jank on slow device.

1. Let active/inactive all apps RVs share the same AllAppsRecyclerViewPool
2. Use worker thread to pre-inflate BubbleTextViews and add them to shared view pool on main thread

Bug: 287523421
Test: See before/after screenshot/video/trace attached in bug
Change-Id: I00213407be2c7c2d329997552785d0aa56c4d057
2023-07-05 13:07:26 -07:00
Fengjiang Li 1acda93e26 Fix calculation of all apps recyclerview pool size of app icons
grid.numShownAllAppsColumns is the column size of all apps, whereas mNumAppsPerRow is the column size of workspace, we should use the former one to calculate num of all apps icons

Bug: 287523421
Flag: N/A
Test: Open all apps from launcher and taskbar and scroll it, Expect scorlling works without jank.
Change-Id: Ife488e5853c84f6cc94e1e9e7edae67844275439
2023-07-05 13:07:18 -07:00
Liran Binyamin 3c81efd136 Ensure overflow isn't selected when bar is collapsed am: 16b05e251b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23900933

Change-Id: I19c19e06e387ce56a78d10b8251edf8449ceb989
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-05 19:15:12 +00:00
Liran Binyamin 16b05e251b Ensure overflow isn't selected when bar is collapsed
After the bubble bar collapsing animation completes, and reordering
is finished, if the bubble overflow is selected, update the selected
bubble to be the first bubble. This ensures that the overflow
is not selected the next time the bubble bar is expanded.

This is done through a callback from the BubbleBarView to the
BubbleBarController with the key of the first bubble. Ideally the view
would just notify that the selected bubble needs to be updated, but
the controller doesn't hold ordering info.

Fixes: 289280431
Test: manual
       - Add 2 bubbles to the bubble bar
       - Expand the bubble bar. The first bubble A should be selected
       - Select the second bubble B
       - Select the overflow
       - Tap on the overflow again to collapse the bubble bar
       - Tap on the bubble bar to expand it
       - Observe that bubble B is first and selected
Change-Id: I0f9c2d628cfaf3a80da55ff634284687425e949a
2023-07-05 12:20:46 -04:00
Android Build Coastguard Worker f4dadca234 Snap for 10430798 from 323958007d to udc-qpr1-release
Change-Id: Idffc99bcdeed02b82b07d6d555d713f6fa88ffae
2023-07-03 23:19:04 +00:00
Tracy Zhou 32e8934f61 Add initial trackpad tapl tests am: 323958007d am: b3f8477b94
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23744485

Change-Id: Id4d47e95cbac52a14d00ee8fd06a9e23991986c1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-03 21:10:07 +00:00
Tracy Zhou b3f8477b94 Add initial trackpad tapl tests am: 323958007d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23744485

Change-Id: I76bf5d89ac5b141aad398ff62b3483535a0d6fc3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-03 20:28:39 +00:00
Tracy Zhou 323958007d Add initial trackpad tapl tests
- go home

Bug: 281732733
Test: presubmit
Change-Id: I538d63bde2bf427a02c2bc355eab71546d667bf9
2023-07-03 10:50:54 -07:00
Android Build Coastguard Worker 9fb82f6215 Snap for 10423847 from 491b0f9028 to udc-qpr1-release
Change-Id: I25ca668880f74090c616c44cc8d970f123e5eddf
2023-07-01 23:18:49 +00:00
Android Build Coastguard Worker 325e8a6323 Snap for 10421851 from 957d46ae52 to udc-qpr1-release
Change-Id: I3384302ef703ee13cf14262bc509c65f2307dfc2
2023-07-01 01:24:08 +00:00
Jagrut Desai 96a8d9f9c3 Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f am: d4b4e95bea am: 491b0f9028 am: 491eb03668
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422

Change-Id: I3c4527df86763aca1354945d6f7adedd76cad56c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-01 01:17:57 +00:00
Jagrut Desai fb1755102e Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f am: 982dacc7ef am: 4fc44d56a9 am: ca6ef7e29a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422

Change-Id: Ib1c333bf8391d93e4638417b0c6bd25ec709ff15
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-01 01:17:14 +00:00
Jagrut Desai 8173e89af0 Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f am: d4b4e95bea am: 62dd220b69 am: 9f3a115ab0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422

Change-Id: I426c472efbbc08b0089604ba06abeee02d7e89d4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-01 01:16:05 +00:00
Jagrut Desai 491eb03668 Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f am: d4b4e95bea am: 491b0f9028
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422

Change-Id: I1f51078eb6167d5dde01df2918abd8abdd3a8a45
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-01 00:34:51 +00:00
Jagrut Desai ca6ef7e29a Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f am: 982dacc7ef am: 4fc44d56a9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422

Change-Id: I18c2abbb984f1ef9c8c649d554116d522e2340a4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-01 00:30:44 +00:00
Jagrut Desai 9f3a115ab0 Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f am: d4b4e95bea am: 62dd220b69
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422

Change-Id: I616ad6bb87381eca5b452ddadd460d35f4b71414
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-01 00:29:18 +00:00
Jagrut Desai bd15977020 Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f am: efba64d65f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422

Change-Id: Ida48ee884afccf26a6e5ef44c4af1f2f93cbbf8b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 23:48:45 +00:00
Jagrut Desai 4fc44d56a9 Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f am: 982dacc7ef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422

Change-Id: I686be2553533fbec2b6c45af460fa482580bb500
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 23:47:47 +00:00
Jagrut Desai 491b0f9028 Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f am: d4b4e95bea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422

Change-Id: I9d438b3edda25a7407d30d702013b385b3fd9195
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 23:47:37 +00:00
Jagrut Desai 62dd220b69 Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f am: d4b4e95bea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422

Change-Id: I2c06c2637c4d7fefab71ea87af677b210cd2829c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 23:45:46 +00:00
Jagrut Desai 2b01cb4bd4 Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f am: e88a949a17
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422

Change-Id: I0db039662d4a1d25104d7373e8c22affbdbea74c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 23:45:15 +00:00
Android Build Coastguard Worker 479b6e75c0 Merge cherrypicks of ['googleplex-android-review.googlesource.com/23852178', 'googleplex-android-review.googlesource.com/23845422'] into udc-release.
Change-Id: Id2f13f18793e0a6b6c00368be8cf2de6cf329092
2023-06-30 23:27:52 +00:00
Jagrut Desai 7cc6f65011 Taskbar All Apps Shortcut Menu Acccessibility Focus
Bug: 280657266
Test: manual
Flag: not needed
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:53d953ccd24cd378418d9bd8c9964589fb1af44a)
Merged-In: I2426636067ce3635b8b24b9f5d093dad7d9ddf4c
Change-Id: I2426636067ce3635b8b24b9f5d093dad7d9ddf4c
2023-06-30 23:26:29 +00:00
Jon Miranda df537ccdb7 Cleans up bad state when transient taskbar shows on home.
Bug: 279514548
Test: open transparent activity on top of launcher
      unstash taskbar
      go home
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:3bad3ebaad529a8be587b9c0eae61faf87ea8505)
Merged-In: I13ab79b334e1f8feda441a82cc4d035c0142f513
Change-Id: I13ab79b334e1f8feda441a82cc4d035c0142f513
2023-06-30 23:26:22 +00:00
Jagrut Desai 982dacc7ef Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422

Change-Id: I5c4b401023efb9cd5fcdbff50819dc95ad6cc4c2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 23:06:12 +00:00
Jagrut Desai efba64d65f Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422

Change-Id: I782a431defdc72b8a73d8a862dd6443e06d3330c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 23:05:36 +00:00
Jagrut Desai e88a949a17 Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422

Change-Id: Iee33ca78be02118b1e6471d9d558c82d05a786aa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 23:05:16 +00:00
Jagrut Desai d4b4e95bea Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422

Change-Id: I33a1ec0e54a662878f981bd599abb3f1d5c6f105
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 23:05:06 +00:00
Jagrut Desai fa2a81844f Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev 2023-06-30 22:29:20 +00:00
Holly Sun 1a9a98005d [a11y] Fix crash when using talkback to add to home screen.
1. Fix a crash from http://cs/android-internal/packages/apps/Launcher3/src/com/android/launcher3/Launcher.java;l=1928;rcl=d677caa75de74f1c3a88367cad67ae405fd2903d. It can also be `ITEM_TYPE_SEARCH_ACTION`. Remove the `itemType` check and just use the `PendingAddItemInfo` class type.
2. Override `startConfigActivity` in `PinShortcutRequestActivityInfo`, so that `Launcher#onActivityResult` can be triggered properly from `Launcher#processShortcutFromDrop` (http://cs/android-internal/packages/apps/Launcher3/src/com/android/launcher3/Launcher.java;l=1939;rcl=d677caa75de74f1c3a88367cad67ae405fd2903d )
3. Then we call to `Launcher#completeAdd` -> `completeAddShortcut`. The original `info` passed to `processShortcutFromDrop` doesn’t have a `componentName` (new code), so remove the component non-null check from `completeAddShortcut`.

Bug: 287166186
Bug: 287167527
Bug: 287166771
Test: manual
Flag: N/A
Change-Id: Id3e1444de188f2d2af760f58e3d9814a2b7abd88
Merged-In: Id3e1444de188f2d2af760f58e3d9814a2b7abd88
(cherry picked from commit 35b9960b63)
2023-06-30 20:49:33 +00:00
Treehugger Robot dcde9874ed Merge "Cleans up bad state when transient taskbar shows on home." into udc-dev am: 2c3c1e46c0 am: 4de15620c2 am: 957d46ae52 am: 5e23c3025d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23852178

Change-Id: I60c2124c049641a94f62b4e37d581336dafff9be
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 20:17:34 +00:00
Treehugger Robot bc1c56aa17 Merge "Cleans up bad state when transient taskbar shows on home." into udc-dev am: 2c3c1e46c0 am: 4264a7d135 am: c44ae73e4f am: e2529cecff
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23852178

Change-Id: I5fbbcc0b719bb4264684c005017e7861764310cf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 20:16:56 +00:00
Treehugger Robot 85b657c704 Merge "Cleans up bad state when transient taskbar shows on home." into udc-dev am: 2c3c1e46c0 am: 4de15620c2 am: 120c78d24f am: dd262b4617
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23852178

Change-Id: I197545b22bb294048915c5bcee8ce6bcceaf6d51
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 20:15:38 +00:00
Treehugger Robot 5e23c3025d Merge "Cleans up bad state when transient taskbar shows on home." into udc-dev am: 2c3c1e46c0 am: 4de15620c2 am: 957d46ae52
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23852178

Change-Id: I61abe7d28129799ee0e39c289c5fa29b92d95e77
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 19:53:19 +00:00
Treehugger Robot e2529cecff Merge "Cleans up bad state when transient taskbar shows on home." into udc-dev am: 2c3c1e46c0 am: 4264a7d135 am: c44ae73e4f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23852178

Change-Id: Ia6526b05a6ab2f57cc44ffa3979c7a8c2a2697fb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 19:30:34 +00:00