Commit Graph

76729 Commits

Author SHA1 Message Date
Treehugger Robot 6c7fdd42cc Merge "Clean up RECEIVE_UNFOLD_EVENTS_FROM_SYSUI flag" into udc-qpr-dev am: a5f24d709e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24501121

Change-Id: Ieb275c6a69efc1e061fd38a284b9218f61b18433
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-23 17:43:52 +00:00
Tracy Zhou 5eae18306c Merge "Init nav mode in TaskbarActivityContext between fold/unfold" into udc-qpr-dev am: b038bac666
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24493282

Change-Id: I3bfd26f70ba8b7b968c3a5fa610a59f458fd07b8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-23 17:42:00 +00:00
Treehugger Robot 7e1c5d0b74 Merge "Correctly ignoring apps_view" into udc-qpr-dev 2023-08-23 17:41:19 +00:00
Treehugger Robot bed2e59967 Merge "Ignoring FloatingTaskThumbnailView:id/thumbnail" into udc-qpr-dev 2023-08-23 17:41:01 +00:00
Pat Manning d0f729d13c Do not clip scaled Launcher icons on hover.
Include change for setting the hover state flag programatically, as FastBitmapDrawable does not currently support DeviceConfig flags.

Fix: 243191650
Test: FastBitmapDrawableTest. Screenshot tests in another cl.
Flag: ENABLE_CURSOR_HOVER_STATES
Change-Id: I0eb796ae62e571a3287132bfcb99c4fca1e2fbe4
2023-08-23 08:45:43 +00:00
Liran Binyamin 90d3a422f8 Cap the width of the bubble bar when collapsed
When the bubble bar is collapsed we now show at most 2 bubbles.

Fixes: 295020145
Test: Manual
      - Add 1 bubble to the bubble bar
      - Collapse bubble bar
      -- Observe that only that bubble is visible
      - Expand the bubble bar
      -- Observe that both that bubble and the overflow are visible
      - Add another bubble
      -- Observe that 2 bubbles are visible when collapsed
      - Add another bubble
      -- Observe that only the first 2 bubbles are visible when collapsed
Change-Id: I5f534f53eefe9a920b8b3258813d67d021c5f2a8
2023-08-23 07:40:56 +00:00
Liran Binyamin 5e7ca0c0b3 Merge "Handle touches on the bubble bar in Overview" into udc-qpr-dev 2023-08-23 07:13:16 +00:00
Fengjiang Li d18fcad565 Re-enable ALL_APPS_GONE_VISIBILITY and ENABLE_ALL_APPS_RV_PREINFLATION
Re-submit ag/24499161 with ag/24517009 to ensure tests are still passing

Flags: ENABLE_ALL_APPS_RV_PREINFLATION ALL_APPS_GONE_VISIBILITY
Test: Tested in bug bash
Bug: 288161355 291651514
Change-Id: I562d39f5edef46240700669b26d6e8fb27cbb77a
2023-08-22 18:20:52 -07:00
Vadim Tryshev bb3e61f313 Ignoring FloatingTaskThumbnailView:id/thumbnail
Bug: 286251603
Test: presubmit
Flag: N/A
Change-Id: I7e1f31c24e6b3f7cfc996d2117a8cd4e3482c01b
2023-08-22 17:44:22 -07:00
Android Build Coastguard Worker 5b7871e1c6 Snap for 10697761 from 2c9a2f2353 to udc-qpr1-release
Change-Id: I1f2a8da043a38ae60601a26c20ec333a0affac5c
2023-08-22 23:18:51 +00:00
Treehugger Robot 7c183e2987 Merge "Taskbar: use ENABLE_HIDE_IME_CAPTION_BAR" into udc-qpr-dev 2023-08-22 22:05:32 +00:00
Mady Mellor c62e37305d Set a view id for the bubble dismiss view (launcher)
There is a flake in the drag to dismiss bubble test, I think it's
because sometimes it misses the dismiss target since the test drags
the bubble to the bottom of the screen instead of the target location.

In attempt to fix this I'm setting an ID on the dismiss target to
look up where it is on screen and drag the bubble to it directly.

Test: treehugger
Bug: 296933279
Change-Id: I7949aa0131020651214e9ebaa834dda8fc25971a
2023-08-22 20:56:27 +00:00
Sunny Goyal 52a7f05681 Adding support for clearing overview suggestion state when overview is disabled
Bug: 297037290
Test: Presubmit
Flag: N/A
Change-Id: I38f7fd38564c7c529cbd9aa5acead08b181b1b92
2023-08-22 13:46:29 -07:00
Brian Isganitis 42907f022e Introduce TAPL APIs for Taskbar QSB and search results.
Includes support for interacting with app search results for Taskbar All
Apps.

Design doc: go/toasty-taskbar-tapl

Test: Compiles
Bug: 295366997
Flag: not needed
Change-Id: I07cb8a96a0aba2668ffc647ca2a6b8c1137157ca
2023-08-22 16:04:45 -04:00
Sebastián Franco 2c9a2f2353 Merge "Remove odd screen ids when isTwoPanels is true" into udc-qpr-dev 2023-08-22 20:02:29 +00:00
Treehugger Robot a7eed17af3 Merge "Revert "Prevent some leaks from leaking to the next test"" into udc-qpr-dev 2023-08-22 20:00:54 +00:00
Vadim Tryshev 65daa2da8d Properly marking TaplTestsSplitscreen with test annotations
Without such annotations, the test may not run

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I597ca8a8f176c1f5ee39e4fa7a7c3ac938b53b7f
2023-08-22 12:09:16 -07:00
Fengjiang Li 053c11a344 Merge "Revert "Turn on ENABLE_ALL_APPS_RV_PREINFLATION and ALL_APPS_GONE_VISIBILITY for udc-qpr branch"" into udc-qpr-dev 2023-08-22 18:49:10 +00:00
Fengjiang Li df7cb761aa Revert "Turn on ENABLE_ALL_APPS_RV_PREINFLATION and ALL_APPS_GONE_VISIBILITY for udc-qpr branch"
This reverts commit e302fb8cd9.

Reason for revert: WellbeingTests#testPauseAppFromAllApps is failing b/297040371

Change-Id: I92f885abff4bb1e3058eebcd23bf23875e5f84cf
2023-08-22 18:42:38 +00:00
Vadim Tryshev 84f51ec03e Revert "Prevent some leaks from leaking to the next test"
This reverts commit d17a270b31.

Reason for revert: Perhaps, caused failures like: Launcher internal state didn't switch to Home, https://android-build.corp.google.com/test_investigate/?invocationId=I32700010190010056&testResultId=TR70828881289196802

Change-Id: I1c7afb75785aac6b02f451b9d5b74de7833abfed
2023-08-22 18:30:48 +00:00
Vadim Tryshev 798e892051 Correctly ignoring apps_view
Note already existing DRAG_LAYER + "SearchContainerView:id/apps_view",

Bug: 296927267
Test: presubmit
Flag: N/A
Change-Id: Ib65dab08a4dd25db4297390cc796405a0c7e148b
2023-08-22 17:37:29 +00:00
Randy Pfohl f18305ac08 Merge changes I3394267d,Idf9ef20e into udc-qpr-dev
* changes:
  Adding some logging to track test failure in post submit
  enable testWidgets for postsubmit for long term debugging
2023-08-22 17:14:40 +00:00
Luca Zuccarini 8837e66a7e Avoid sending an IME close request if the IME is already closed.
Bug: 277738379
Fix: 296986528
Flag: N/A
Test: manual
Change-Id: I0a3419f17ee569020c9de673b9507337661bd002
2023-08-22 16:47:55 +00:00
helencheuk a66a121bec Add test to long press icon on home screen
Fix: 292083404
Test: TaplTestsLauncher3#testLaunchHomeScreenMenuItem
Change-Id: I301ac719aeda744e8b8dca9a405208625eff89e7
2023-08-22 16:33:06 +00:00
Vinit Nayak 0989216160 Merge "Null out Activity in split controller" into udc-qpr-dev 2023-08-22 16:21:45 +00:00
Adrian Roos f45ebad9be Taskbar: use ENABLE_HIDE_IME_CAPTION_BAR
With ENABLE_HIDE_IME_CAPTION_BAR, we no longer need to update the navigation bar override. This was already applied for the navigation bar, but not the task bar. Mirrors the NavigationBar.java change in
I8793db69fb846046300d5a56b3b0060138ef4cd5.

Bug: 289748734
Change-Id: I86079cb6670a2ae3b6fa883694f8af81df212408
Test: presubmit
2023-08-22 16:07:37 +00:00
Fengjiang Li 2474a8c1fb Merge "Turn on ENABLE_ALL_APPS_RV_PREINFLATION and ALL_APPS_GONE_VISIBILITY for udc-qpr branch" into udc-qpr-dev 2023-08-22 15:09:20 +00:00
Liran Binyamin 80f20a2183 Handle touches on the bubble bar in Overview
If the bubble bar is visible and we're in Overview, set the touchable region
of the Taskbar to include the bubble bar bounds.

Fixes: 290197298
Test: Manual
      - Add multiple bubbles to the bubble bar
      - Go to Overview
      - Tap on the bubble bar
      -- Observe that the bubble bar expands
      - Tap on different bubbles
      -- Observe that the bubble bar updates correctly
      - Tap outside the bubble bar
      -- Observe that the bubble bar collapses
      - Tap outside of the bubble bar again
      -- Observe that the launcher state changed and we are in Home
Change-Id: I722778ee41b50ebca57431bb303da89104d25090
2023-08-22 09:13:15 -04:00
Pat Manning c7087e8f9f Do not consume hover events not coming from cursor for a11y.
Fix: 283041221
Test: TaplTestsTransientTaskbar
Flag: ENABLE_CURSOR_HOVER_STATES
Change-Id: I95e9ded6873173ea001c82d6319716a2d48b3bad
2023-08-22 09:17:04 +00:00
Treehugger Robot a5f24d709e Merge "Clean up RECEIVE_UNFOLD_EVENTS_FROM_SYSUI flag" into udc-qpr-dev 2023-08-22 09:09:51 +00:00
Tracy Zhou b038bac666 Merge "Init nav mode in TaskbarActivityContext between fold/unfold" into udc-qpr-dev 2023-08-22 06:48:01 +00:00
Sunny Goyal 5442cbc300 Clean up RECEIVE_UNFOLD_EVENTS_FROM_SYSUI flag
Bug: b/270397209
Test: Presubmit
Flag: RECEIVE_UNFOLD_EVENTS_FROM_SYSUI
Change-Id: I4f87777fd27b5489557742b58e25dc5488b7d32b
2023-08-22 04:31:09 +00:00
Android Build Coastguard Worker 5e0122d13a Merge cherrypicks of ['googleplex-android-review.googlesource.com/23447960', 'googleplex-android-review.googlesource.com/24314473', 'googleplex-android-review.googlesource.com/24224609'] into udc-release.
Change-Id: I2f33858065e7f76bc8964949e323eb411700aa04
2023-08-22 02:19:47 +00:00
Luca Zuccarini b38e61a339 Animate depth from the right value on Taskbar All Apps launches.
`MyDepthController` in `QuickstepTransitionLauncher` assumes that we
want the background to always animate the same way, matching the rest
state of the workspace (depth == 0). However, in Taskbar All Apps the
background is visible, and depth != 0. We now initialize the one-off
`DepthController` for launches to take into account the latest depth set
by the top level `DepthController`, so there is no jumpcut at the
beginning of the animation.

Note that in my opinion we should use the same `DepthController` for all
cases, rather than having this one-off. I'm looking into the feasibility
of that change, but for now this fixes the issue at hand.

Fix: 292959100
Flag: N/A
Test: manual, see videos in the bug

(cherry picked from commit 627d67549f)
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:3e91646d123abbe58ccc0544746145ce5024b923)
Merged-In: Id90e8e728cc3e2ccf7d92148fbb0d6ff3e6fd6ca
Change-Id: Id90e8e728cc3e2ccf7d92148fbb0d6ff3e6fd6ca
2023-08-22 02:15:08 +00:00
Alex Chau c02dabfb59 Fix return condition in getWorkspacePageTranslationProvider
- When EDIT_MODE was introduced, it added a wrong condition to make it always return DEFAULT_PAGE_TRANSLATION_PROVIDER

Bug: 294228521
Test: manual
(cherry picked from commit c325c686c7)
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:4bfc0ee720e4ee80035c7ef59cf2d8d095cf9d72)
Merged-In: If970949c8ab55bc67f98f987a7654ec2db89cdfb
Change-Id: If970949c8ab55bc67f98f987a7654ec2db89cdfb
2023-08-22 02:14:58 +00:00
Nick Chameyev 14b4f9edcc [Unfold animation] Do not preemptively start the animation if it has run already
Currently if we open an app, unfold the device and then go to home
screen we will start the unfold animation preemptively in Launcher
because Launcher activity will receive updated configuration change
(where isTablet = true) only after going back to home screen, not
when unfolding the device.

This causes a problem because SystemUI won't send the unfold animation
events after going back home as the animation has already run, so we
end up with wrongly started animation in Launcher.

This CL fixes the issues by checking if SystemUI has finished the
animation (or if it is currently running) to avoid preemptive animation
start in this case. This is done by subscribing to the original
unfold transition progress provider which emits progress events
sent through IPC from SystemUI.

Bug: 285150685
Bug: 293131586
Test: open an app on folded screen, unfold, go to home screen =>
  check that icons are not squished
Test: fold/unfold when launcher is open
(cherry picked from commit 6d756970e7)
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:2e53f5ef97a02d25f508774e82985e24dc2f4d2d)
Merged-In: Ic437ff4d19cbd5764635f3007d99880622150f5b
Change-Id: Ic437ff4d19cbd5764635f3007d99880622150f5b
2023-08-22 02:14:49 +00:00
Vinit Nayak b620af4612 Null out Activity in split controller
Bug: 295225524
Change-Id: I59aaed3fca07d611088cec0a4bfafc658a151bb2
2023-08-21 23:40:51 +00:00
Treehugger Robot 0bf390490a Merge "Pass extras Bundle in onRecentsAnimationStart" into main 2023-08-21 23:25:16 +00:00
Android Build Coastguard Worker 335a1f24ed Snap for 10690357 from 4dc9893028 to udc-qpr1-release
Change-Id: Ia81aa6f0cbe1e931424c0b31b28b627f084e577b
2023-08-21 23:19:05 +00:00
Treehugger Robot eabb5bbe7e Merge "Prevent some leaks from leaking to the next test" into udc-qpr-dev am: 1e709c2a95 am: c5c3c2590b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24487871

Change-Id: I72f0de405cddcc29100a0d696b2def2f55a19521
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 22:55:56 +00:00
Treehugger Robot 15f1370c45 Merge "Add null check for mRecentsView when recents animation is canceled" into udc-qpr-dev am: 2a1df8879f am: 0dbd72188b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24499166

Change-Id: I1ebeef38e8001379a7d0b4b1c4a9ae8bc4cf9698
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 22:53:41 +00:00
Stefan Andonian bd3a62fe30 Merge "Move WallpaperColorHints RPC calls to a background thread." into udc-qpr-dev am: 0487d8ee9b am: 28c69acdfe
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24087102

Change-Id: I66833830e2e20dcb23ed9abd80b72bec8cefe378
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 22:53:18 +00:00
Kevin Lim 2fea004ac9 Merge "[Tiger] Add screen record to debug flaky test" into udc-qpr-dev am: c7aeced342 am: a73c072f39
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24486156

Change-Id: I46a6e0ff77046cee60d8e38e068ea993f1a576d2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 22:51:59 +00:00
Treehugger Robot c5c3c2590b Merge "Prevent some leaks from leaking to the next test" into udc-qpr-dev am: 1e709c2a95
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24487871

Change-Id: I4a227c9f2060835efb7aaaa1ff4ad96576345e2d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 22:47:36 +00:00
Tracy Zhou d9d17ce133 Init nav mode in TaskbarActivityContext between fold/unfold
In RotationButtonController, we show the floating rotation button either when the bar is visible, or when the device is in gesture nav mode, even in an immersive app. The issue here is that mNavMode is not correctly initialized after the device is unfolded.

Fixes: 272164624
Test: Open townhall. Fold and then unfold. Tilt the device and make sure the floating rotation button shows.
Change-Id: I09025132fdca5c764e66d9ac21f29b853741d257
2023-08-21 22:38:13 +00:00
Treehugger Robot 1e709c2a95 Merge "Prevent some leaks from leaking to the next test" into udc-qpr-dev 2023-08-21 22:23:21 +00:00
Treehugger Robot 0dbd72188b Merge "Add null check for mRecentsView when recents animation is canceled" into udc-qpr-dev am: 2a1df8879f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24499166

Change-Id: I47fae5b187a2bb2a50e0ff78ce9672cdd50ba6b3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 22:14:42 +00:00
Stefan Andonian 28c69acdfe Merge "Move WallpaperColorHints RPC calls to a background thread." into udc-qpr-dev am: 0487d8ee9b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24087102

Change-Id: I2e1652b293d3fb49017d2062e08c2d2352f339d5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 22:14:05 +00:00
Kevin Lim a73c072f39 Merge "[Tiger] Add screen record to debug flaky test" into udc-qpr-dev am: c7aeced342
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24486156

Change-Id: I6ba70bbfa9c4f0b21f8d76ac33db54818ef5b0ed
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 22:13:18 +00:00
Treehugger Robot 2a1df8879f Merge "Add null check for mRecentsView when recents animation is canceled" into udc-qpr-dev 2023-08-21 21:50:54 +00:00