Commit Graph

19452 Commits

Author SHA1 Message Date
Riddle Hsu 77a6164f7a Merge "Reduce no-op IPC when swiping up" into udc-dev 2023-03-31 05:11:54 +00:00
Tracy Zhou f3e9f870bd Fix task bar unstashing and stashing when triggering back gesture using the trackpad
Need to defer starting recents animation. Instead of starting at touch down, will defer to passing initial slop. For the back gesture, launcher gesture nav will cancel the motion events from the input monitor passing the initial slop since it's not detected as a swipe up gesture.

Fixes: 276390218
Test: 3-finger horizontal swipe to go back, and make sure the task bar stay stashed through the transition
Change-Id: I03376c4d9696a9e5679b74e36ec142efa882981b
2023-03-30 21:04:13 -07:00
Jerry Chang 8102dc0802 Merge "Fix wrong surface positioning when animating a split pair to home" into udc-dev am: d571e89311
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22330129

Change-Id: Ifbb18b727f58a2c7a4669cb155e3bdf171f74b7f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-31 03:06:11 +00:00
TreeHugger Robot 552fe5ec52 Merge "Don't stash immediately when drag was canceled" into tm-qpr-dev am: d9dd75d2cc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22316250

Change-Id: I5f1189de25670ff70fe5bc4b39ed4cbc41a676cf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-31 01:23:49 +00:00
Jerry Chang d571e89311 Merge "Fix wrong surface positioning when animating a split pair to home" into udc-dev 2023-03-31 01:12:57 +00:00
Jagrut Desai 6eded0ec4a Merge "Taskbar System Action with Broadcast Receiver." into tm-qpr-dev am: d1d0fb8607 am: 99e6efe6f3 am: 3aaae66d37
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22242613

Change-Id: Ic59efbe40854d67a44665135fb79c7fc8b858c51
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-31 01:09:44 +00:00
Jon Miranda ebd8ef2598 Merge "Align taskbar so that it does not overlap with nav buttons." into tm-qpr-dev am: e008411f00 am: eb1bc63ffa am: 258b331c49
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22315699

Change-Id: Iad69fab6e06886c1153eae9b3b2fd745abae346f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-31 00:40:35 +00:00
TreeHugger Robot d9dd75d2cc Merge "Don't stash immediately when drag was canceled" into tm-qpr-dev 2023-03-31 00:08:44 +00:00
Schneider Victor-tulias c8234e92f3 Merge "Add the gesture nav tutorial menu page" into tm-qpr-dev am: 1db2fcbd19 am: cafab1d7cc am: 6468ce77b8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22119029

Change-Id: I1be767700e832b604c36143390e1a8a327425e70
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-30 23:03:34 +00:00
Schneider Victor-tulias 1f63b6f605 Merge "Fix TwoPanelWorkspaceTests" into tm-qpr-dev am: 90259a6db4 am: d8e5795131 am: f8f602d76c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22185922

Change-Id: Iea577dd3fed651294523559be95174154b23d86b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-30 23:03:27 +00:00
Evan Rosky 8869bb5f40 Improve transition logging
Adding debug-names to remote transitions so that
they can be identified across processes

Bug: 276349701
Test: existing tests since this doesn't change logic
Change-Id: I41400feeb2dd91971f8c750613085c80af309aea
2023-03-30 15:28:43 -07:00
Vinit Nayak ecca8eacbc Default to using SplitSelectSource drawable if TaskView icon drawable is null
* Alternative solution could be to set
onTaskViewVisibilityChanged(true) for the taskView that is about
to be dismissed so it loads it's taskIcon/thumbnail back from the cache
* However, that does still leave us open to race conditions (even though
we can be reasonably confident the icon is probably in the cache)
* Also made other changes to allow already public fields on some classes
to be mockable for unit testing

Fixes: 275267738
Test: Tested with fullscreen task at end of overview,
GroupedTaskView at end of overview,
Initiating split from home,
Initiating split from overview actions,
Initiating split from overview app icon

Change-Id: Ic9059c93c07b90f61c9f418d5d36d6ba201ff96a
2023-03-30 15:26:57 -07:00
Sebastian Franco 7fcb30d2c7 Correctly disposing of LauncherUnlockAnimationController
In SystemUiProxy we don't need to check for null before calling
setLauncherUnlockAnimationController becase that function is already
checkingh fo nulls, so it was preventing the variable from getting
cleaned.

Fix: 275418590
Test: flake should dissapear or be reduced
Change-Id: I8cf5dad57678493167354e137a18e37b37f3e58b
2023-03-30 21:39:46 +00:00
Arthur Hung e3225379e7 Merge "Handling statusbar color when back navigation (2/2)" into udc-dev am: b5c44b60c0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21551120

Change-Id: I8daacc9212c5a2cfc795483ebf513cd8df53a4e9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-30 20:43:29 +00:00
TreeHugger Robot c8c63de840 Merge "Don't stash immediately when drag was canceled" into udc-dev am: 2514a15a85
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22323212

Change-Id: I0637bee615c8f5856abed553c78d9842da7ddc1f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-30 19:59:15 +00:00
Sunny Goyal cea33520d7 Merge "Revert "Simplifying some page indicator dots attributes so that it can"" into udc-dev am: 1fc1cd002f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22339626

Change-Id: Ia8c8fa656ae5f25e3b29cf9c296d2f2b428878ee
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-30 19:59:07 +00:00
Jagrut Desai 3aaae66d37 Merge "Taskbar System Action with Broadcast Receiver." into tm-qpr-dev am: d1d0fb8607 am: 99e6efe6f3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22242613

Change-Id: I2cd41ac48e58ac04f4600f6d63b5915fc260c48f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-30 18:40:46 +00:00
Jon Miranda 258b331c49 Merge "Align taskbar so that it does not overlap with nav buttons." into tm-qpr-dev am: e008411f00 am: eb1bc63ffa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22315699

Change-Id: I41ea7b65f0ffaaa7c2fae79d349763b6841204f8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-30 18:39:44 +00:00
Schneider Victor-tulias 6468ce77b8 Merge "Add the gesture nav tutorial menu page" into tm-qpr-dev am: 1db2fcbd19 am: cafab1d7cc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22119029

Change-Id: Id6121e8c572666f182e0b2d0ca250c636236f19f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-30 17:28:13 +00:00
Schneider Victor-tulias f8f602d76c Merge "Fix TwoPanelWorkspaceTests" into tm-qpr-dev am: 90259a6db4 am: d8e5795131
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22185922

Change-Id: Ic5d6ce2a870f19c960baab3af8abfb1faee248f1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-30 17:16:22 +00:00
Jagrut Desai 99e6efe6f3 Merge "Taskbar System Action with Broadcast Receiver." into tm-qpr-dev am: d1d0fb8607
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22242613

Change-Id: I34aa4182c74483c6dd94adb119bda9a30a8240aa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-30 17:06:00 +00:00
Jon Miranda eb1bc63ffa Merge "Align taskbar so that it does not overlap with nav buttons." into tm-qpr-dev am: e008411f00
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22315699

Change-Id: I72655d251013fddd9736963cc68e842c58941569
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-30 17:05:45 +00:00
Schneider Victor-tulias cafab1d7cc Merge "Add the gesture nav tutorial menu page" into tm-qpr-dev am: 1db2fcbd19
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22119029

Change-Id: Ie1f24b78ea9f49a1089e15331cadc35af0073490
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-30 16:47:18 +00:00
Schneider Victor-tulias d8e5795131 Merge "Fix TwoPanelWorkspaceTests" into tm-qpr-dev am: 90259a6db4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22185922

Change-Id: I916c0e191cb2e335b9e393ea76c34cff39778481
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-30 16:47:04 +00:00
Riddle Hsu b1ca1b777f Reduce no-op IPC when swiping up
In SplitScreenController#onGoingToRecentsLegacy, it also ignores:
if (ENABLE_SHELL_TRANSITIONS) return null;

This avoids a latency from the 2-way IPC before calling
RecentsAnimationListener#onRecentsAnimationStart.

Bug: 275508603
Test: Swipe-up
Change-Id: If1aa847bd92b2a16812a5181b4476d9a35619a76
2023-03-30 15:49:40 +00:00
Arthur Hung b5c44b60c0 Merge "Handling statusbar color when back navigation (2/2)" into udc-dev 2023-03-30 11:23:03 +00:00
TreeHugger Robot cba5d7b5c5 Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev 2023-03-30 08:58:51 +00:00
Jagrut Desai d1d0fb8607 Merge "Taskbar System Action with Broadcast Receiver." into tm-qpr-dev 2023-03-29 23:26:26 +00:00
Tony Wickham 52f046e027 Don't stash immediately when drag was canceled
Instead, keep the taskbar open for the normal timeout.

Test: Drag an app from taskbar and drop back in taskbar, ensure taskbar
stays open until 5 second timeout; Drag an app from taskbar and drop
into split screen, ensure taskbar stashes immediately
Flag: ENABLE_TRANSIENT_TASKBAR true
Fixes: 275019813

Change-Id: I06ca0eccbfe313dbae8f6d96c7c09bb659f6a27b
Merged-In: I06ca0eccbfe313dbae8f6d96c7c09bb659f6a27b
2023-03-29 23:10:11 +00:00
Jon Miranda e008411f00 Merge "Align taskbar so that it does not overlap with nav buttons." into tm-qpr-dev 2023-03-29 23:04:43 +00:00
TreeHugger Robot 2514a15a85 Merge "Don't stash immediately when drag was canceled" into udc-dev 2023-03-29 23:04:38 +00:00
TreeHugger Robot 495c7819ef Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2023-03-29 22:22:16 +00:00
Sunny Goyal 1fc1cd002f Merge "Revert "Simplifying some page indicator dots attributes so that it can"" into udc-dev 2023-03-29 21:22:10 +00:00
Jon Miranda 156ff34f35 Align taskbar so that it does not overlap with nav buttons.
Fixes: 275510698
Bug: 259712417
Test: View device where taskbar should be start aligned
      Update Display size to make everything bigger
      Observe that taskbar icons never overlap nav buttons
Flag: ENABLE_TRANSIENT_TASKBAR true

Change-Id: I246374518f21c4b92d3e02e5582c929a471d9305
2023-03-29 21:04:03 +00:00
Sunny Goyal 0263a679f2 Revert "Simplifying some page indicator dots attributes so that it can"
This reverts commit a5ead45967.

Reason for revert: b/274169859

Change-Id: Id214694ae4f61cd70796c6f7e932c1fdef82d746
2023-03-29 19:11:03 +00:00
Schneider Victor-tulias 1db2fcbd19 Merge "Add the gesture nav tutorial menu page" into tm-qpr-dev 2023-03-29 18:54:22 +00:00
Brian Isganitis d43d7c3702 Clean up device profile change listeners for AllApps.
Test: https://b.corp.google.com/issues/260177372#comment1
Bug: 260177372
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:d17261029af89ef03b860686d1d3c6651e7c8e13)
Merged-In: Ic7417980e8280bf2fcb110e5de74ea2ae59d9b74
Change-Id: Ic7417980e8280bf2fcb110e5de74ea2ae59d9b74
2023-03-29 18:46:47 +00:00
Brian Isganitis d17261029a Clean up device profile change listeners for AllApps.
Test: https://b.corp.google.com/issues/260177372#comment1
Bug: 260177372
Change-Id: Ic7417980e8280bf2fcb110e5de74ea2ae59d9b74
2023-03-29 14:18:14 -04:00
Jagrut Desai d2140ba498 Taskbar System Action with Broadcast Receiver.
Test: Manual
Bug: 265618836
Change-Id: I734402ef277a09cf5e41aa63f8be09375706c17a
2023-03-29 10:37:45 -07:00
Schneider Victor-tulias 90259a6db4 Merge "Fix TwoPanelWorkspaceTests" into tm-qpr-dev 2023-03-29 17:03:59 +00:00
Jerry Chang 7e51edd808 Fix wrong surface positioning when animating a split pair to home
Use the screen based position instead of parent-relative position to
make sure the surface was placing at the expected position while
animation apps to home.

Bug: 273685456
Test: http://recall/-/fLARJNt42LVxc3tt86SneW/c2pLS6FwyEMweiLiWqqzPa
Change-Id: Iea79e6d2b9ab591fe18c5ac7a0d89bb90a461145
2023-03-29 07:21:33 +00:00
Bill Yi 4a7f7025b7 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Idd3d822debe118ff239dbbcac121170df81769f0
2023-03-28 20:05:36 -07:00
Bill Yi 5f5627ec20 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ie923f09baaaa91bce6f664b48a6690b928166b53
2023-03-28 20:05:00 -07:00
Saumya Prakash d462e39f76 Merge "Add extra error checking for Home Gesture Tutorial" into tm-qpr-dev am: eed10f31f7 am: 95c9996088 am: c63702b6b4 am: 23bb93bef6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22296252

Change-Id: I8dca9f84c2693fa7ae37cf312c9fee4d7fb5e416
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-29 00:08:12 +00:00
Randy Pfohl 9db6955726 Merge "checking if outline provider is null to handle rare NPE" into tm-qpr-dev am: 40f065d1fd am: a402713eb2 am: 5c588c95b4 am: 8ce0ab7a5e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21995352

Change-Id: Ie5054c1d6948039eb71b20e56dfdc9bd0eae0a51
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-29 00:06:53 +00:00
Saumya Prakash 23bb93bef6 Merge "Add extra error checking for Home Gesture Tutorial" into tm-qpr-dev am: eed10f31f7 am: 95c9996088 am: c63702b6b4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22296252

Change-Id: I34ada65ab45855627b51f4d8b2687efbb83b1875
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-28 23:30:02 +00:00
Randy Pfohl 8ce0ab7a5e Merge "checking if outline provider is null to handle rare NPE" into tm-qpr-dev am: 40f065d1fd am: a402713eb2 am: 5c588c95b4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21995352

Change-Id: Ief20fe7f56f78bd80346c8f9c2848e519382c658
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-28 23:29:51 +00:00
Saumya Prakash c63702b6b4 Merge "Add extra error checking for Home Gesture Tutorial" into tm-qpr-dev am: eed10f31f7 am: 95c9996088
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22296252

Change-Id: I7afe22edddb59609ec9bf9ac736f4facf4fe630c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-28 22:58:57 +00:00
Randy Pfohl 5c588c95b4 Merge "checking if outline provider is null to handle rare NPE" into tm-qpr-dev am: 40f065d1fd am: a402713eb2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21995352

Change-Id: I7f20393c364b09d13e2c7027ddf85ac6552e62f2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-28 22:58:47 +00:00
Saumya Prakash 95c9996088 Merge "Add extra error checking for Home Gesture Tutorial" into tm-qpr-dev am: eed10f31f7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22296252

Change-Id: I0222aa84ca570dd7aa97880fee3d54877c990660
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-28 22:45:21 +00:00